Android/packages_apps_Settings
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix the Protocol buffer best practice warnings problem

Browse Source 
- Add prefix for the items of the SessionType enums.

Fixes: 287363023
Test: atest SpaActivityTest SpaLogDataTest MetricsDataModelTest
Change-Id: Ifde0b61a05b1257edaca54325a72dad333e43e3c
This commit is contained in:
Sunny Shao
2023-07-18 16:36:14 +08:00
parent facadb94c1
commit 4d00821093
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/com/android/settings/spa/core/instrumentation/SpaLogProvider.kt
View File

@@ -72,10 +72,10 @@ class SpaLogData(val id: String, val event: LogEvent,
} }
val sessionSource = extraData.getString(LOG_DATA_SESSION_NAME) val sessionSource = extraData.getString(LOG_DATA_SESSION_NAME)
return when(sessionSource) { return when(sessionSource) {
SESSION_BROWSE -> SettingsEnums.BROWSE SESSION_BROWSE -> SettingsEnums.SESSION_BROWSE
SESSION_SEARCH -> SettingsEnums.SEARCH SESSION_SEARCH -> SettingsEnums.SESSION_SEARCH
SESSION_SLICE -> SettingsEnums.SLICE_TYPE SESSION_SLICE -> SettingsEnums.SESSION_SLICE_TYPE
SESSION_EXTERNAL -> SettingsEnums.EXTERNAL SESSION_EXTERNAL -> SettingsEnums.SESSION_EXTERNAL
else -> SettingsEnums.SESSION_UNKNOWN else -> SettingsEnums.SESSION_UNKNOWN
} }
} }

4
tests/spa_unit/src/com/android/settings/spa/core/instrumentation/SpaLogDataTest.kt
View File

@@ -53,7 +53,7 @@ class SpaLogDataTest {
bundle.putString(LOG_DATA_SESSION_NAME, SESSION_BROWSE) bundle.putString(LOG_DATA_SESSION_NAME, SESSION_BROWSE)
val spaLogData = SpaLogData(TEST_PID, LogEvent.PAGE_ENTER, bundle, dataModel) val spaLogData = SpaLogData(TEST_PID, LogEvent.PAGE_ENTER, bundle, dataModel)
assertThat(spaLogData.getSessionType()).isEqualTo(SettingsEnums.BROWSE) assertThat(spaLogData.getSessionType()).isEqualTo(SettingsEnums.SESSION_BROWSE)
} }
@Test @Test
@@ -61,7 +61,7 @@ class SpaLogDataTest {
bundle.putString(LOG_DATA_SESSION_NAME, SESSION_SEARCH) bundle.putString(LOG_DATA_SESSION_NAME, SESSION_SEARCH)
val spaLogData = SpaLogData(TEST_PID, LogEvent.PAGE_ENTER, bundle, dataModel) val spaLogData = SpaLogData(TEST_PID, LogEvent.PAGE_ENTER, bundle, dataModel)
assertThat(spaLogData.getSessionType()).isEqualTo(SettingsEnums.SEARCH) assertThat(spaLogData.getSessionType()).isEqualTo(SettingsEnums.SESSION_SEARCH)
} }
@Test @Test