Modify Settings homepage layout
- Add BottomNavigationView which has two tabs - Remove BottomSheet in layout files Change-Id: I493290fa9dee0566c73c5c9d7fbba10b71b4e2b4 Fixes: 113266753 Test: visual
This commit is contained in:
@@ -29,22 +29,6 @@
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
message="Avoid using hardcoded color"
|
||||
category="Correctness"
|
||||
priority="4"
|
||||
summary="Using hardcoded color"
|
||||
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.
This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
|
||||
errorLine1=" app:barPredictionColor="@color/material_empty_color_light""
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/layout/battery_history_chart.xml"
|
||||
line="38"
|
||||
column="9"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
@@ -2425,7 +2409,7 @@
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/values-en-rXC/strings.xml"
|
||||
line="2559"
|
||||
line="2524"
|
||||
column="168"/>
|
||||
</issue>
|
||||
|
||||
@@ -2441,7 +2425,7 @@
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/values-en-rAU/strings.xml"
|
||||
line="2560"
|
||||
line="2525"
|
||||
column="64"/>
|
||||
</issue>
|
||||
|
||||
@@ -2457,7 +2441,7 @@
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/values-en-rCA/strings.xml"
|
||||
line="2560"
|
||||
line="2525"
|
||||
column="64"/>
|
||||
</issue>
|
||||
|
||||
@@ -2473,7 +2457,7 @@
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/values-en-rGB/strings.xml"
|
||||
line="2560"
|
||||
line="2525"
|
||||
column="64"/>
|
||||
</issue>
|
||||
|
||||
@@ -2489,7 +2473,7 @@
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/values-en-rIN/strings.xml"
|
||||
line="2560"
|
||||
line="2525"
|
||||
column="64"/>
|
||||
</issue>
|
||||
|
||||
@@ -2505,7 +2489,7 @@
|
||||
errorLine2=" ~~~~~~~~~~~~~~~~~~~">
|
||||
<location
|
||||
file="res/values/strings.xml"
|
||||
line="5898"
|
||||
line="5865"
|
||||
column="36"/>
|
||||
</issue>
|
||||
|
||||
@@ -2701,6 +2685,22 @@
|
||||
column="49"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
message="Avoid using hardcoded color"
|
||||
category="Correctness"
|
||||
priority="4"
|
||||
summary="Using hardcoded color"
|
||||
explanation="Hardcoded color values are bad because theme changes cannot be uniformly applied.Instead use the theme specific colors such as `?android:attr/textColorPrimary` in attributes.
This ensures that a theme change from a light to a dark theme can be uniformlyapplied across the app."
|
||||
errorLine1=" <item name="android:navigationBarDividerColor">#1f000000</item>"
|
||||
errorLine2=" ^">
|
||||
<location
|
||||
file="res/values/themes.xml"
|
||||
line="175"
|
||||
column="56"/>
|
||||
</issue>
|
||||
|
||||
<issue
|
||||
id="HardCodedColor"
|
||||
severity="Error"
|
||||
|
||||
Reference in New Issue
Block a user