From 38f872fa1fb6e43a15459e59fd43b558ff979115 Mon Sep 17 00:00:00 2001 From: jackqdyulei Date: Wed, 3 Oct 2018 16:34:57 -0700 Subject: [PATCH] Fix the complie error of network migration 1. Fix the error in import part 2. Remove broken code and add TODO Future CL will fix TODO and add tests Bug: 114749736 Test: Build Change-Id: I4fda0708959e299015ecb10ac17c9c2dadc6f852 --- res/values/config.xml | 7 +- res/values/strings.xml | 27 +- res/xml/cdma_options.xml | 31 +- res/xml/gsm_umts_options.xml | 33 +- res/xml/network_setting_fragment.xml | 8 +- .../AdvancedOptionsPreference.java | 16 +- .../settings/mobilenetwork/CdmaOptions.java | 17 +- .../CdmaSubscriptionListPreference.java | 12 +- .../CdmaSystemSelectListPreference.java | 13 +- .../settings/mobilenetwork/CellInfoUtil.java | 29 ++ .../mobilenetwork/DataUsagePreference.java | 3 +- .../mobilenetwork/GsmUmtsOptions.java | 39 +-- .../mobilenetwork/MobileDataPreference.java | 30 +- .../mobilenetwork/MobileNetworkFragment.java | 320 +++++++++++------- .../mobilenetwork/MobileNetworkUtils.java | 173 ++++++++++ .../mobilenetwork/NetworkOperators.java | 12 +- .../mobilenetwork/NetworkScanHelper.java | 1 - .../NetworkSelectListPreference.java | 47 +-- .../mobilenetwork/NetworkSelectSettings.java | 8 +- .../mobilenetwork/RoamingDialogFragment.java | 26 +- 20 files changed, 565 insertions(+), 287 deletions(-) create mode 100644 src/com/android/settings/mobilenetwork/MobileNetworkUtils.java diff --git a/res/values/config.xml b/res/values/config.xml index 0129768d60c..8e60505ccc0 100755 --- a/res/values/config.xml +++ b/res/values/config.xml @@ -137,7 +137,12 @@ true - + false + + false + + diff --git a/res/values/strings.xml b/res/values/strings.xml index 0060202f5cb..41d024d1f68 100644 --- a/res/values/strings.xml +++ b/res/values/strings.xml @@ -10186,23 +10186,10 @@ - - Disconnected - - Connected - - Connecting\u2026 - - Couldn’t connect - Available networks Searching\u2026 - - No networks found. - - Couldn\u2019t find networks. Try again. Registering on %s\u2026 @@ -10215,8 +10202,6 @@ Automatically select network - - Choose network Carrier settings @@ -10259,4 +10244,16 @@ Change between RUIM/SIM and NV subscription + + + Advanced + + Automatic registration\u2026 + + Allow data roaming? + + Check with your network provider for pricing. + + + Unavailable when connected to %1$s diff --git a/res/xml/cdma_options.xml b/res/xml/cdma_options.xml index f6ef97a7508..046d16f4739 100644 --- a/res/xml/cdma_options.xml +++ b/res/xml/cdma_options.xml @@ -1,22 +1,23 @@ - - - - @@ -46,9 +47,7 @@ - + diff --git a/res/xml/gsm_umts_options.xml b/res/xml/gsm_umts_options.xml index 81b2debb83c..6ca9ad602ee 100644 --- a/res/xml/gsm_umts_options.xml +++ b/res/xml/gsm_umts_options.xml @@ -1,22 +1,23 @@ - - @@ -26,7 +27,7 @@ android:title="@string/select_automatically" android:persistent="false"/> - @@ -35,7 +36,7 @@ android:key="button_choose_network_key" android:title="@string/choose_network_title" android:fragment="com.android.phone.NetworkSelectSetting" /> - + @@ -43,7 +44,7 @@ android:key="category_gsm_apn_key" android:layout="@layout/preference_category_no_label"> - @@ -52,9 +53,7 @@ - + diff --git a/res/xml/network_setting_fragment.xml b/res/xml/network_setting_fragment.xml index d334861929e..b1b78547c4a 100644 --- a/res/xml/network_setting_fragment.xml +++ b/res/xml/network_setting_fragment.xml @@ -20,23 +20,23 @@ android:title="@string/cdma_lte_data_service"> - - - -