diff --git a/AndroidManifest.xml b/AndroidManifest.xml index 0634ff11a30..1caebbb2263 100644 --- a/AndroidManifest.xml +++ b/AndroidManifest.xml @@ -139,7 +139,11 @@ android:label="@string/network_settings_title" android:theme="@style/Theme.Settings.Home" android:launchMode="singleTask"> - + + + + + diff --git a/src/com/android/settings/network/telephony/MobileDataDialogFragment.java b/src/com/android/settings/network/telephony/MobileDataDialogFragment.java index be2da048828..276d1fbe613 100644 --- a/src/com/android/settings/network/telephony/MobileDataDialogFragment.java +++ b/src/com/android/settings/network/telephony/MobileDataDialogFragment.java @@ -17,6 +17,7 @@ package com.android.settings.network.telephony; import android.app.Dialog; +import android.app.settings.SettingsEnums; import android.content.Context; import android.content.DialogInterface; import android.os.Bundle; @@ -109,8 +110,7 @@ public class MobileDataDialogFragment extends InstrumentedDialogFragment impleme @Override public int getMetricsCategory() { - //TODO(b/114749736): add metric id for this fragment - return 0; + return SettingsEnums.MOBILE_DATA_DIALOG; } @Override diff --git a/src/com/android/settings/network/telephony/MobileNetworkSettings.java b/src/com/android/settings/network/telephony/MobileNetworkSettings.java index 623b6de9920..6e5dece5a01 100644 --- a/src/com/android/settings/network/telephony/MobileNetworkSettings.java +++ b/src/com/android/settings/network/telephony/MobileNetworkSettings.java @@ -196,7 +196,6 @@ public class MobileNetworkSettings extends RestrictedDashboardFragment { } } - //TODO(b/114749736): update search provider public static final Indexable.SearchIndexProvider SEARCH_INDEX_DATA_PROVIDER = new BaseSearchIndexProvider() { @Override diff --git a/src/com/android/settings/network/telephony/PreferredNetworkModePreferenceController.java b/src/com/android/settings/network/telephony/PreferredNetworkModePreferenceController.java index f60f927a32e..0326f42d8c6 100644 --- a/src/com/android/settings/network/telephony/PreferredNetworkModePreferenceController.java +++ b/src/com/android/settings/network/telephony/PreferredNetworkModePreferenceController.java @@ -116,8 +116,6 @@ public class PreferredNetworkModePreferenceController extends BasePreferenceCont } private int getPreferredNetworkModeSummaryResId(int NetworkMode) { - //TODO(b/114749736): refactor it to "Preferred network mode: ", instead of building - // string for each type... switch (NetworkMode) { case TelephonyManager.NETWORK_MODE_TDSCDMA_GSM_WCDMA: return R.string.preferred_network_mode_tdscdma_gsm_wcdma_summary; diff --git a/src/com/android/settings/network/telephony/RoamingDialogFragment.java b/src/com/android/settings/network/telephony/RoamingDialogFragment.java index 4c82686081a..c349c1a47fa 100644 --- a/src/com/android/settings/network/telephony/RoamingDialogFragment.java +++ b/src/com/android/settings/network/telephony/RoamingDialogFragment.java @@ -17,6 +17,7 @@ package com.android.settings.network.telephony; import android.app.AlertDialog; import android.app.Dialog; +import android.app.settings.SettingsEnums; import android.content.Context; import android.content.DialogInterface; import android.content.DialogInterface.OnClickListener; @@ -78,8 +79,7 @@ public class RoamingDialogFragment extends InstrumentedDialogFragment implements @Override public int getMetricsCategory() { - //TODO(b/114749736): add category for roaming dialog - return 0; + return SettingsEnums.MOBILE_ROAMING_DIALOG; } @Override