From 227affaf29a55ed874e90eb2cdfb849080e4bd68 Mon Sep 17 00:00:00 2001 From: Evan Laird Date: Wed, 22 Mar 2017 11:36:18 -0400 Subject: [PATCH] Cleanup to screensaver settings for O Reworked the way screensaver settings are laid out for O. Instead of using the options menu and dialogs to navigate screensaver options, there are now two rows: one row for the screensaver choice and optionally its own settings, and one row for the "when to show" setting. And now there's a nice obvious button you can press to preview your choices. Test: 'export ROBOTEST_FILTER="RadioButtonListFragmentTest";\ mmm -j20 packages/apps/Settings/tests/robotests' Bug: 35031991 Change-Id: Ie7d2055fb45f6dfe72e34cb9598d9a25f7bee75a --- res/layout/dream_info_row.xml | 94 ----- res/layout/dream_start_button.xml | 38 ++ res/values/arrays.xml | 14 + res/values/styles.xml | 2 + res/xml/display_settings.xml | 2 +- res/xml/dream_fragment_overview.xml | 41 ++ src/com/android/settings/DreamSettings.java | 364 ------------------ .../core/gateway/SettingsGateway.java | 2 +- .../ScreenSaverPreferenceController.java | 2 +- .../settings/dream/CurrentDreamPicker.java | 117 ++++++ .../CurrentDreamPreferenceController.java | 79 ++++ .../android/settings/dream/DreamSettings.java | 147 +++++++ .../dream/StartNowPreferenceController.java | 66 ++++ .../settings/dream/WhenToDreamPicker.java | 115 ++++++ .../WhenToDreamPreferenceController.java | 52 +++ .../search/SearchIndexableResources.java | 2 + .../dream/CurrentDreamPickerTest.java | 91 +++++ .../CurrentDreamPreferenceControllerTest.java | 111 ++++++ .../settings/dream/DreamSettingsTest.java | 113 ++++++ .../StartNowPreferenceControllerTest.java | 94 +++++ .../settings/dream/WhenToDreamPickerTest.java | 108 ++++++ .../WhenToDreamPreferenceControllerTest.java | 70 ++++ 22 files changed, 1263 insertions(+), 461 deletions(-) delete mode 100644 res/layout/dream_info_row.xml create mode 100644 res/layout/dream_start_button.xml create mode 100644 res/xml/dream_fragment_overview.xml delete mode 100644 src/com/android/settings/DreamSettings.java create mode 100644 src/com/android/settings/dream/CurrentDreamPicker.java create mode 100644 src/com/android/settings/dream/CurrentDreamPreferenceController.java create mode 100644 src/com/android/settings/dream/DreamSettings.java create mode 100644 src/com/android/settings/dream/StartNowPreferenceController.java create mode 100644 src/com/android/settings/dream/WhenToDreamPicker.java create mode 100644 src/com/android/settings/dream/WhenToDreamPreferenceController.java create mode 100644 tests/robotests/src/com/android/settings/dream/CurrentDreamPickerTest.java create mode 100644 tests/robotests/src/com/android/settings/dream/CurrentDreamPreferenceControllerTest.java create mode 100644 tests/robotests/src/com/android/settings/dream/DreamSettingsTest.java create mode 100644 tests/robotests/src/com/android/settings/dream/StartNowPreferenceControllerTest.java create mode 100644 tests/robotests/src/com/android/settings/dream/WhenToDreamPickerTest.java create mode 100644 tests/robotests/src/com/android/settings/dream/WhenToDreamPreferenceControllerTest.java diff --git a/res/layout/dream_info_row.xml b/res/layout/dream_info_row.xml deleted file mode 100644 index fd70ad543ff..00000000000 --- a/res/layout/dream_info_row.xml +++ /dev/null @@ -1,94 +0,0 @@ - - - - - - - - - - - - - - - - - - - - - - - - diff --git a/res/layout/dream_start_button.xml b/res/layout/dream_start_button.xml new file mode 100644 index 00000000000..7d5e0c92618 --- /dev/null +++ b/res/layout/dream_start_button.xml @@ -0,0 +1,38 @@ + + + + + +