Commit Graph

5 Commits

Author SHA1 Message Date
Bruno Martins
9f648b7046 Revert "lineage-sdk self-removing prefs: move reap from onBindViewHolder to onAttached"
This reverts commit 027b615325.

While it served its original purpose, this was causing bad side-effects
when using our constraints (verified at least with requiresConfig and
requiresAction). Moving the reap to onAttached was rendering self-removing
prefs useless because if the view isn't loaded yet, the preference
(which also doesn't yet exists) can't really be hidden.

Change-Id: Ic61fe4b9979412d89c55ea1543c494e69bf6eab7
2017-12-06 12:31:48 +00:00
Sam Mortimer
027b615325 lineage-sdk self-removing prefs: move reap from onBindViewHolder to onAttached
*) Eliminates visibility of the pref removal. You could previously
   see vertical movement of text during initial display of replaced
   prefs.

*) In addition, when reaping, use setVisible(false) instead of
   removePreference.  Otherwise, array out of bounds index exceptions
   occur in frameworks pref support libraries (as a result of moving
   from onBindViewHolder to onAttached).

Change-Id: I1a0045552572a590f89715f8d94156eddaaec469
2017-11-09 14:42:55 +00:00
Sam Mortimer
3c54d58691 lineage-sdk: Support requiresConfig integers and add requiresConfigMask
*) Add support for integer requiresConfig resources (previously supported
   only strings and bools).  Preference is removed if the int is 0.

*) Add a new attribute requiresConfigMask that takes a string decimal int.
   If requiresConfig is an integer then the pref is removed if
   (requiresConfig resource value & requiresConfigMask value) == 0.
   If requiresConfig is not an integer type then requiresConfigMask
   is ignored.

*) Code clean-up for the rest of checking requiresConfig.

Change-Id: Ic2622809c02a94d9cecf6f59ed6e689fdb835458
2017-10-24 22:52:07 -07:00
Sam Mortimer
542742b751 lineage-sdk: rebrand step 2: update file contents
Change-Id: I9881acc57cdc0aeea2b296aac12a8af932d30aea
2017-10-06 09:40:24 -07:00
Sam Mortimer
5ede05bdca lineage-sdk: rebrand step 1: update paths
Change-Id: I4c2135d03d730a313a0638d0f857afa48fb220d3
2017-09-22 17:19:40 -07:00