Replaces the need for:
32e67e6020
*) frameworks/support are now built with gradle and are included as prebuilts.
*) API level 26 (8.0) introduced PreferenceDataStorage which can be used
to implement what we need without touching the support library.
Change-Id: Ide3417019ccf8bde5dca3b2aec3d2075e7c8b597
This reverts commit 027b615325.
While it served its original purpose, this was causing bad side-effects
when using our constraints (verified at least with requiresConfig and
requiresAction). Moving the reap to onAttached was rendering self-removing
prefs useless because if the view isn't loaded yet, the preference
(which also doesn't yet exists) can't really be hidden.
Change-Id: Ic61fe4b9979412d89c55ea1543c494e69bf6eab7
*) Eliminates visibility of the pref removal. You could previously
see vertical movement of text during initial display of replaced
prefs.
*) In addition, when reaping, use setVisible(false) instead of
removePreference. Otherwise, array out of bounds index exceptions
occur in frameworks pref support libraries (as a result of moving
from onBindViewHolder to onAttached).
Change-Id: I1a0045552572a590f89715f8d94156eddaaec469
