From d787f127814f03449a5ba8abe116dbfa1b3f2e86 Mon Sep 17 00:00:00 2001 From: Luca Stefani Date: Mon, 3 Jan 2022 13:22:33 +0100 Subject: [PATCH] settings: Use proper locking Change-Id: I0f2c30cb0bb324602738800a8ff81359fa484223 --- sdk/src/java/lineageos/providers/LineageSettings.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/src/java/lineageos/providers/LineageSettings.java b/sdk/src/java/lineageos/providers/LineageSettings.java index ecd4039a..b3123e69 100644 --- a/sdk/src/java/lineageos/providers/LineageSettings.java +++ b/sdk/src/java/lineageos/providers/LineageSettings.java @@ -261,7 +261,7 @@ public final class LineageSettings { long newValuesVersion = SystemProperties.getLong(mVersionSystemProperty, 0); // Our own user's settings data uses a client-side cache - synchronized (this) { + synchronized (NameValueCache.this) { if (mValuesVersion != newValuesVersion) { if (LOCAL_LOGV || false) { Log.v(TAG, "invalidate [" + mUri.getLastPathSegment() + "]: current " @@ -298,7 +298,7 @@ public final class LineageSettings { String value = b.getPairValue(); // Don't update our cache for reads of other users' data if (isSelf) { - synchronized (this) { + synchronized (NameValueCache.this) { mValues.put(name, value); } } else { @@ -328,7 +328,7 @@ public final class LineageSettings { } String value = c.moveToNext() ? c.getString(0) : null; - synchronized (this) { + synchronized (NameValueCache.this) { mValues.put(name, value); } if (LOCAL_LOGV) {