From 981cdd2b8ee0e620c3e87f34862bba293a3a930b Mon Sep 17 00:00:00 2001 From: Pranav Vashi Date: Sat, 26 Nov 2022 22:05:47 +0530 Subject: [PATCH] Properly set default value for switch pref Signed-off-by: Pranav Vashi --- .../lineageos/preference/SelfRemovingSwitchPreference.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/LineagePreferenceLib/java/lineageos/preference/SelfRemovingSwitchPreference.java b/packages/LineagePreferenceLib/java/lineageos/preference/SelfRemovingSwitchPreference.java index 4666b62a..4071825b 100644 --- a/packages/LineagePreferenceLib/java/lineageos/preference/SelfRemovingSwitchPreference.java +++ b/packages/LineagePreferenceLib/java/lineageos/preference/SelfRemovingSwitchPreference.java @@ -66,10 +66,8 @@ public abstract class SelfRemovingSwitchPreference extends SwitchPreferenceCompa protected void onSetInitialValue(boolean restorePersistedValue, Object defaultValue) { final boolean checked; if (!restorePersistedValue || !isPersisted()) { - if (defaultValue == null) { - return; - } - checked = getBoolean(getKey(), (boolean) defaultValue); + boolean defValue = defaultValue == null ? false : (boolean) defaultValue; + checked = getBoolean(getKey(), defValue); if (shouldPersist()) { persistBoolean(checked); }