Files
frameworks_base/core/proto
Bernie Innocenti fa499f9259 Add NS_R_INTERNAL_ERROR item into NsRcode
Bug: 119862317
Test: ./out/host/linux-x86/bin/statsd_testdrive 116

Merged-In: I023ff5dc0ae2efe45f81494929640c9b96821a0d
Merged-In: I0cf28032f8079c64253ed3f90fcf9d4705a5b492
(cherry picked from commit 83ef1697e3)

Change-Id: I106f73e8b0251bc7a64c68dfb450269ac7cd4feb
2019-07-25 21:57:44 +00:00
..
2019-01-28 17:30:05 -08:00
2019-05-01 18:04:24 +00:00

Conventions for the protos in this directory:

  1. As in the rest of Android, use 4 spaces to indent instead of 2.

  2. For protos based on Java files, use the same package as the Java file. For example, com.android.server.thing instead of com.android.server.thing.proto.

  3. If the proto describes the top level output of dumpsys, it should contain Dump. This makes it easy to understand that the proto is the dumpsys output of a certain service, not the data structure of that service, e.g. WindowManagerServiceDumpProto vs WindowManagerServiceProto.

    • Inner messages whose containing messages have the Proto suffix do not need to have a Proto suffix. E.g:
message FooProto {
    message Bar {
        ...
    }
}
 vs
message FooProto {
    message BarProto {
        ...
    }
}
  1. If the proto represents the structure of an object, it should have Proto as its suffix. Please also include the full package path of the original object as a comment to the proto message.

  2. Include units in the field names. For example, screen_time_ms vs screen_time, or file_size_bytes or file_size_mebibytes vs file_size.

  3. Leave field numbers 50,000 - 100,000 reserved for OEMs.