1da49dc9b4
Deny write access to /data/resource-cache for UIDs other than root and system. While this is already handled by SELinux rules, add an additional layer of security to explicitly prevent malicious apps from messing with the system's idmap files. Test: make idmap2_tests Change-Id: Id986633558d5d02452276f05f64337a8700f148a
98 lines
3.6 KiB
C++
98 lines
3.6 KiB
C++
/*
|
|
* Copyright (C) 2018 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
#include <dirent.h>
|
|
#include <set>
|
|
#include <string>
|
|
|
|
#include "gmock/gmock.h"
|
|
#include "gtest/gtest.h"
|
|
|
|
#include "android-base/macros.h"
|
|
#include "android-base/stringprintf.h"
|
|
#include "private/android_filesystem_config.h"
|
|
|
|
#include "idmap2/FileUtils.h"
|
|
|
|
#include "TestHelpers.h"
|
|
|
|
using ::testing::NotNull;
|
|
|
|
namespace android::idmap2::utils {
|
|
|
|
TEST(FileUtilsTests, FindFilesFindEverythingNonRecursive) {
|
|
const auto& root = GetTestDataPath();
|
|
auto v = utils::FindFiles(root, false,
|
|
[](unsigned char type ATTRIBUTE_UNUSED,
|
|
const std::string& path ATTRIBUTE_UNUSED) -> bool { return true; });
|
|
ASSERT_THAT(v, NotNull());
|
|
ASSERT_EQ(v->size(), 6U);
|
|
ASSERT_EQ(std::set<std::string>(v->begin(), v->end()),
|
|
std::set<std::string>({root + "/.", root + "/..", root + "/overlay", root + "/target",
|
|
root + "/system-overlay", root + "/system-overlay-invalid"}));
|
|
}
|
|
|
|
TEST(FileUtilsTests, FindFilesFindApkFilesRecursive) {
|
|
const auto& root = GetTestDataPath();
|
|
auto v = utils::FindFiles(root, true, [](unsigned char type, const std::string& path) -> bool {
|
|
return type == DT_REG && path.size() > 4 && path.compare(path.size() - 4, 4, ".apk") == 0;
|
|
});
|
|
ASSERT_THAT(v, NotNull());
|
|
ASSERT_EQ(v->size(), 6U);
|
|
ASSERT_EQ(std::set<std::string>(v->begin(), v->end()),
|
|
std::set<std::string>({root + "/target/target.apk", root + "/overlay/overlay.apk",
|
|
root + "/overlay/overlay-static-1.apk",
|
|
root + "/overlay/overlay-static-2.apk",
|
|
root + "/system-overlay/system-overlay.apk",
|
|
root + "/system-overlay-invalid/system-overlay-invalid.apk"}));
|
|
}
|
|
|
|
TEST(FileUtilsTests, ReadFile) {
|
|
int pipefd[2];
|
|
ASSERT_EQ(pipe(pipefd), 0);
|
|
|
|
ASSERT_EQ(write(pipefd[1], "foobar", 6), 6);
|
|
close(pipefd[1]);
|
|
|
|
auto data = ReadFile(pipefd[0]);
|
|
ASSERT_THAT(data, NotNull());
|
|
ASSERT_EQ(*data, "foobar");
|
|
close(pipefd[0]);
|
|
}
|
|
|
|
#ifdef __ANDROID__
|
|
TEST(FileUtilsTests, UidHasWriteAccessToPath) {
|
|
constexpr const char* tmp_path = "/data/local/tmp/test@idmap";
|
|
const std::string cache_path(base::StringPrintf("%s/test@idmap", kIdmapCacheDir));
|
|
const std::string sneaky_cache_path(base::StringPrintf("/data/../%s/test@idmap", kIdmapCacheDir));
|
|
|
|
ASSERT_TRUE(UidHasWriteAccessToPath(AID_ROOT, tmp_path));
|
|
ASSERT_TRUE(UidHasWriteAccessToPath(AID_ROOT, cache_path));
|
|
ASSERT_TRUE(UidHasWriteAccessToPath(AID_ROOT, sneaky_cache_path));
|
|
|
|
ASSERT_TRUE(UidHasWriteAccessToPath(AID_SYSTEM, tmp_path));
|
|
ASSERT_TRUE(UidHasWriteAccessToPath(AID_SYSTEM, cache_path));
|
|
ASSERT_TRUE(UidHasWriteAccessToPath(AID_SYSTEM, sneaky_cache_path));
|
|
|
|
constexpr const uid_t AID_SOME_APP = AID_SYSTEM + 1;
|
|
ASSERT_TRUE(UidHasWriteAccessToPath(AID_SOME_APP, tmp_path));
|
|
ASSERT_FALSE(UidHasWriteAccessToPath(AID_SOME_APP, cache_path));
|
|
ASSERT_FALSE(UidHasWriteAccessToPath(AID_SOME_APP, sneaky_cache_path));
|
|
}
|
|
#endif
|
|
|
|
} // namespace android::idmap2::utils
|