Files
frameworks_base/cmds
Dichen Zhang 23c04c6f62 Fix command injection on screencap
There is a potential injection by using screencap in case of user handled parameters.
"dumpstate" command launches "screencap", when "-p" is argument is set. At that moment, content of "-o" parameter generates a path with ".png" extension to define "screencap" argument.
"dumpstate" is often run as a service with "root" privileged such as defined in "dumpstate.rc". For instance "bugreportz" call "ctl.start" property with "dumpstatez".
Launching "dumpstate" with "-p" option and a user input as "-o" would result in a root command execution. SE Linux might protect part of this attack.

Cherry-pick from ag/10651695 with fix ag/10700515

Bug: 123230379
Test: please see commands #4 and #5
Change-Id: Icd88cdf4af153e07addb4449cdb117b1a3c881d3
2020-03-25 17:05:43 -07:00
..
2018-05-04 23:17:00 -07:00
2018-05-14 16:47:02 -07:00
2019-06-04 06:05:31 +00:00
2019-02-26 13:22:24 -08:00