- Task#numberFullscreen was only used in one location where we needed to figure-out if the task has occluding activities. Just use the hierarchy to figure that out vs. keeping track of a variable that adds confusion. - ActivityRecord#sendingToBottom was used to prevent focus and orientation changes from activity moved to the bottom, however since we are traversing the hierarchy from top-to-bottom we should process activities on-top first vs the onces that have already moved to the bottom. - ActivityRecord#remove is no longer needed as the object won't be connected to the hierarchy when it is removed. Test: They pass! Bug: 80414790 Bug: 35699615 Change-Id: I23f6501a65bf745dc0fb819c30543cd21241fa91
Conventions for the protos in this directory:
-
As in the rest of Android, use 4 spaces to indent instead of 2.
-
For protos based on Java files, use the same package as the Java file. For example,
com.android.server.thinginstead ofcom.android.server.thing.proto. -
If the proto describes the top level output of dumpsys, it should contain
Dump. This makes it easy to understand that the proto is the dumpsys output of a certain service, not the data structure of that service, e.g.WindowManagerServiceDumpProtovsWindowManagerServiceProto.- Inner messages whose containing messages have the
Protosuffix do not need to have aProtosuffix. E.g:
- Inner messages whose containing messages have the
message FooProto {
message Bar {
...
}
}
vs
message FooProto {
message BarProto {
...
}
}
-
If the proto represents the structure of an object, it should have
Protoas its suffix. Please also include the full package path of the original object as a comment to the proto message. -
Include units in the field names. For example,
screen_time_msvsscreen_time, orfile_size_bytesorfile_size_mebibytesvsfile_size. -
Leave field numbers 50,000 - 100,000 reserved for OEMs.