2. Expose Dest values in IIncidentReportArgs.h Please see bug for detail descriptions. Bug: 67869340 Test: unit tested and on-device test. Ran command: $ out/host/linux-x86/bin/incident-section-gen incidentd to test various of privacy taggings. Change-Id: I12af3d7da4c7c72bd63598893fe2c1f70b09baa4
271 lines
9.9 KiB
C++
271 lines
9.9 KiB
C++
// Copyright (C) 2017 The Android Open Source Project
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#define LOG_TAG "incidentd"
|
|
|
|
#include "FdBuffer.h"
|
|
#include "PrivacyBuffer.h"
|
|
|
|
#include <android-base/file.h>
|
|
#include <android-base/test_utils.h>
|
|
#include <android/os/IncidentReportArgs.h>
|
|
#include <gmock/gmock.h>
|
|
#include <gtest/gtest.h>
|
|
#include <string.h>
|
|
|
|
using namespace android;
|
|
using namespace android::base;
|
|
using namespace android::os;
|
|
using namespace std;
|
|
using ::testing::StrEq;
|
|
using ::testing::Test;
|
|
using ::testing::internal::CaptureStdout;
|
|
using ::testing::internal::GetCapturedStdout;
|
|
|
|
const uint8_t OTHER_TYPE = 1;
|
|
const uint8_t STRING_TYPE = 9;
|
|
const uint8_t MESSAGE_TYPE = 11;
|
|
const string STRING_FIELD_0 = "\x02\viamtestdata";
|
|
const string VARINT_FIELD_1 = "\x08\x96\x01"; // 150
|
|
const string STRING_FIELD_2 = "\x12\vwhatthefuck";
|
|
const string FIX64_FIELD_3 = "\x19\xff\xff\xff\xff\xff\xff\xff\xff"; // -1
|
|
const string FIX32_FIELD_4 = "\x25\xff\xff\xff\xff"; // -1
|
|
const string MESSAGE_FIELD_5 = "\x2a\x10" + VARINT_FIELD_1 + STRING_FIELD_2;
|
|
|
|
|
|
class PrivacyBufferTest : public Test {
|
|
public:
|
|
virtual ~PrivacyBufferTest() {
|
|
// Delete in reverse order of construction, to be consistent with
|
|
// regular allocation/deallocation.
|
|
while (!privacies.empty()) {
|
|
delete privacies.back();
|
|
privacies.pop_back();
|
|
}
|
|
}
|
|
|
|
virtual void SetUp() override {
|
|
ASSERT_NE(tf.fd, -1);
|
|
}
|
|
|
|
void writeToFdBuffer(string str) {
|
|
ASSERT_TRUE(WriteStringToFile(str, tf.path));
|
|
ASSERT_EQ(NO_ERROR, buffer.read(tf.fd, 10000));
|
|
ASSERT_EQ(str.size(), buffer.size());
|
|
}
|
|
|
|
void assertBuffer(PrivacyBuffer& buf, string expected) {
|
|
ASSERT_EQ(buf.size(), expected.size());
|
|
CaptureStdout();
|
|
ASSERT_EQ(buf.flush(STDOUT_FILENO), NO_ERROR);
|
|
ASSERT_THAT(GetCapturedStdout(), StrEq(expected));
|
|
}
|
|
|
|
void assertStrip(uint8_t dest, string expected, Privacy* policy) {
|
|
PrivacySpec spec(dest);
|
|
EncodedBuffer::iterator bufData = buffer.data();
|
|
PrivacyBuffer privacyBuf(policy, bufData);
|
|
ASSERT_EQ(privacyBuf.strip(spec), NO_ERROR);
|
|
assertBuffer(privacyBuf, expected);
|
|
}
|
|
|
|
void assertStripByFields(uint8_t dest, string expected, int size, Privacy* privacy, ...) {
|
|
Privacy* list[size+1];
|
|
list[0] = privacy;
|
|
va_list args;
|
|
va_start(args, privacy);
|
|
for (int i=1; i<size; i++) {
|
|
Privacy* p = va_arg(args, Privacy*);
|
|
list[i] = p;
|
|
}
|
|
va_end(args);
|
|
list[size] = NULL;
|
|
assertStrip(dest, expected, create_message_privacy(300, list));
|
|
}
|
|
|
|
Privacy* create_privacy(uint32_t field_id, uint8_t type, uint8_t dest) {
|
|
Privacy* p = new_uninit_privacy();
|
|
p->field_id = field_id;
|
|
p->type = type;
|
|
p->children = NULL;
|
|
p->dest = dest;
|
|
p->patterns = NULL;
|
|
return p;
|
|
}
|
|
|
|
Privacy* create_message_privacy(uint32_t field_id, Privacy** children) {
|
|
Privacy* p = new_uninit_privacy();
|
|
p->field_id = field_id;
|
|
p->type = MESSAGE_TYPE;
|
|
p->children = children;
|
|
p->dest = DEST_DEFAULT_VALUE;
|
|
p->patterns = NULL;
|
|
return p;
|
|
}
|
|
|
|
FdBuffer buffer;
|
|
private:
|
|
TemporaryFile tf;
|
|
// Littering this code with unique_ptr (or similar) is ugly, so we just
|
|
// mass-free everything after the test completes.
|
|
std::vector<Privacy *> privacies;
|
|
|
|
Privacy *new_uninit_privacy() {
|
|
Privacy* p = new Privacy;
|
|
privacies.push_back(p);
|
|
return p;
|
|
}
|
|
};
|
|
|
|
TEST_F(PrivacyBufferTest, NullPolicy) {
|
|
writeToFdBuffer(STRING_FIELD_0);
|
|
assertStrip(DEST_EXPLICIT, STRING_FIELD_0, NULL);
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripUnsetField) {
|
|
writeToFdBuffer(STRING_FIELD_0);
|
|
assertStripByFields(DEST_AUTOMATIC, "", 1, create_privacy(0, STRING_TYPE, DEST_UNSET));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripVarintField) {
|
|
writeToFdBuffer(VARINT_FIELD_1);
|
|
assertStripByFields(DEST_EXPLICIT, "", 1, create_privacy(1, OTHER_TYPE, DEST_LOCAL));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripLengthDelimitedField_String) {
|
|
writeToFdBuffer(STRING_FIELD_2);
|
|
assertStripByFields(DEST_EXPLICIT, "", 1, create_privacy(2, STRING_TYPE, DEST_LOCAL));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripFixed64Field) {
|
|
writeToFdBuffer(FIX64_FIELD_3);
|
|
assertStripByFields(DEST_EXPLICIT, "", 1, create_privacy(3, OTHER_TYPE, DEST_LOCAL));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripFixed32Field) {
|
|
writeToFdBuffer(FIX32_FIELD_4);
|
|
assertStripByFields(DEST_EXPLICIT, "", 1, create_privacy(4, OTHER_TYPE, DEST_LOCAL));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripLengthDelimitedField_Message) {
|
|
writeToFdBuffer(MESSAGE_FIELD_5);
|
|
assertStripByFields(DEST_EXPLICIT, "", 1, create_privacy(5, MESSAGE_TYPE, DEST_LOCAL));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, NoStripVarintField) {
|
|
writeToFdBuffer(VARINT_FIELD_1);
|
|
assertStripByFields(DEST_EXPLICIT, VARINT_FIELD_1, 1, create_privacy(1, OTHER_TYPE, DEST_AUTOMATIC));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, NoStripLengthDelimitedField_String) {
|
|
writeToFdBuffer(STRING_FIELD_2);
|
|
assertStripByFields(DEST_EXPLICIT, STRING_FIELD_2, 1, create_privacy(2, STRING_TYPE, DEST_AUTOMATIC));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, NoStripFixed64Field) {
|
|
writeToFdBuffer(FIX64_FIELD_3);
|
|
assertStripByFields(DEST_EXPLICIT, FIX64_FIELD_3, 1, create_privacy(3, OTHER_TYPE, DEST_AUTOMATIC));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, NoStripFixed32Field) {
|
|
writeToFdBuffer(FIX32_FIELD_4);
|
|
assertStripByFields(DEST_EXPLICIT, FIX32_FIELD_4, 1, create_privacy(4, OTHER_TYPE, DEST_AUTOMATIC));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, NoStripLengthDelimitedField_Message) {
|
|
writeToFdBuffer(MESSAGE_FIELD_5);
|
|
assertStripByFields(DEST_EXPLICIT, MESSAGE_FIELD_5, 1, create_privacy(5, MESSAGE_TYPE, DEST_AUTOMATIC));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripVarintAndString) {
|
|
writeToFdBuffer(STRING_FIELD_0 + VARINT_FIELD_1 + STRING_FIELD_2
|
|
+ FIX64_FIELD_3 + FIX32_FIELD_4);
|
|
string expected = STRING_FIELD_0 + FIX64_FIELD_3 + FIX32_FIELD_4;
|
|
assertStripByFields(DEST_EXPLICIT, expected, 2,
|
|
create_privacy(1, OTHER_TYPE, DEST_LOCAL), create_privacy(2, STRING_TYPE, DEST_LOCAL));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripVarintAndFixed64) {
|
|
writeToFdBuffer(STRING_FIELD_0 + VARINT_FIELD_1 + STRING_FIELD_2
|
|
+ FIX64_FIELD_3 + FIX32_FIELD_4);
|
|
string expected = STRING_FIELD_0 + STRING_FIELD_2 + FIX32_FIELD_4;
|
|
assertStripByFields(DEST_EXPLICIT, expected, 2,
|
|
create_privacy(1, OTHER_TYPE, DEST_LOCAL), create_privacy(3, OTHER_TYPE, DEST_LOCAL));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripVarintInNestedMessage) {
|
|
writeToFdBuffer(STRING_FIELD_0 + MESSAGE_FIELD_5);
|
|
Privacy* list[] = { create_privacy(1, OTHER_TYPE, DEST_LOCAL), NULL };
|
|
string expected = STRING_FIELD_0 + "\x2a\xd" + STRING_FIELD_2;
|
|
assertStripByFields(DEST_EXPLICIT, expected, 1, create_message_privacy(5, list));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, StripFix64AndVarintInNestedMessage) {
|
|
writeToFdBuffer(STRING_FIELD_0 + FIX64_FIELD_3 + MESSAGE_FIELD_5);
|
|
Privacy* list[] = { create_privacy(1, OTHER_TYPE, DEST_LOCAL), NULL };
|
|
string expected = STRING_FIELD_0 + "\x2a\xd" + STRING_FIELD_2;
|
|
assertStripByFields(DEST_EXPLICIT, expected, 2, create_privacy(3, OTHER_TYPE, DEST_LOCAL), create_message_privacy(5, list));
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, ClearAndStrip) {
|
|
string data = STRING_FIELD_0 + VARINT_FIELD_1;
|
|
writeToFdBuffer(data);
|
|
Privacy* list[] = { create_privacy(1, OTHER_TYPE, DEST_LOCAL), NULL };
|
|
EncodedBuffer::iterator bufData = buffer.data();
|
|
PrivacyBuffer privacyBuf(create_message_privacy(300, list), bufData);
|
|
PrivacySpec spec1(DEST_EXPLICIT), spec2(DEST_LOCAL);
|
|
|
|
ASSERT_EQ(privacyBuf.strip(spec1), NO_ERROR);
|
|
assertBuffer(privacyBuf, STRING_FIELD_0);
|
|
ASSERT_EQ(privacyBuf.strip(spec2), NO_ERROR);
|
|
assertBuffer(privacyBuf, data);
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, BadDataInFdBuffer) {
|
|
writeToFdBuffer("iambaddata");
|
|
Privacy* list[] = { create_privacy(4, OTHER_TYPE, DEST_AUTOMATIC), NULL };
|
|
EncodedBuffer::iterator bufData = buffer.data();
|
|
PrivacyBuffer privacyBuf(create_message_privacy(300, list), bufData);
|
|
PrivacySpec spec;
|
|
ASSERT_EQ(privacyBuf.strip(spec), BAD_VALUE);
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, BadDataInNestedMessage) {
|
|
writeToFdBuffer(STRING_FIELD_0 + MESSAGE_FIELD_5 + "aoeoe");
|
|
Privacy* list[] = { create_privacy(1, OTHER_TYPE, DEST_LOCAL), NULL };
|
|
Privacy* field5[] = { create_message_privacy(5, list), NULL };
|
|
EncodedBuffer::iterator bufData = buffer.data();
|
|
PrivacyBuffer privacyBuf(create_message_privacy(300, field5), bufData);
|
|
PrivacySpec spec;
|
|
ASSERT_EQ(privacyBuf.strip(spec), BAD_VALUE);
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, SelfRecursionMessage) {
|
|
string input = "\x2a\"" + VARINT_FIELD_1 + STRING_FIELD_2 + MESSAGE_FIELD_5;
|
|
writeToFdBuffer(input);
|
|
Privacy* field5 = create_message_privacy(5, NULL);
|
|
Privacy* list[] = { create_privacy(1, OTHER_TYPE, DEST_LOCAL), field5, NULL };
|
|
field5->children = list;
|
|
string expected = "\x2a\x1c" + STRING_FIELD_2 + "\x2a\xd" + STRING_FIELD_2;
|
|
assertStrip(DEST_EXPLICIT, expected, field5);
|
|
}
|
|
|
|
TEST_F(PrivacyBufferTest, AutoMessage) {
|
|
writeToFdBuffer(STRING_FIELD_2 + MESSAGE_FIELD_5);
|
|
Privacy* list[] = { create_privacy(1, OTHER_TYPE, DEST_LOCAL), NULL };
|
|
Privacy* autoMsg = create_privacy(5, MESSAGE_TYPE, DEST_AUTOMATIC);
|
|
autoMsg->children = list;
|
|
string expected = "\x2a\xd" + STRING_FIELD_2;
|
|
assertStripByFields(DEST_AUTOMATIC, expected, 1, autoMsg);
|
|
} |