628946a6ef
In this case:
1. Privileged system app FOO is overlain by an installed update,
2. FOO was replaced during an OTA,
3. The new in-system FOO introduced new privileged permission requests
that had not been requested by the original FOO,
4. the update version of FOO still had a higher version code than
the new FOO on the system disk, and
5. the update version of FOO had been requesting these same (newly-
added-to-system-apk) permissions all along;
then the newly-added privileged permission requests were incorrectly being
refused. FOO should be able to use any privileged permission used by the
APK sited on the system disk; but instead, it was only being granted the
permissions used by the *original* version of FOO, even though the system
FOO now attempted to use them.
Still with me?
The fix is to (a) properly track privileged-install state when processing
known-to-be-hidden system packages, and (b) to tie the semantics of the
permission grant more explicitly to that evaluated state, rather than
using the prior (rather fragile) fixed-up privilege calculation applied
to the overlain apk's parse records.
Bug 11271490
Change-Id: Id8a45d667e52f3b5d18109e3620d5865f85bb9c9
65 lines
1.9 KiB
Java
65 lines
1.9 KiB
Java
/*
|
|
* Copyright (C) 2011 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.server.pm;
|
|
|
|
import android.content.pm.ApplicationInfo;
|
|
import android.content.pm.PackageParser;
|
|
|
|
import java.io.File;
|
|
|
|
/**
|
|
* Settings data for a particular package we know about.
|
|
*/
|
|
final class PackageSetting extends PackageSettingBase {
|
|
int appId;
|
|
PackageParser.Package pkg;
|
|
SharedUserSetting sharedUser;
|
|
|
|
PackageSetting(String name, String realName, File codePath, File resourcePath,
|
|
String nativeLibraryPathString, int pVersionCode, int pkgFlags) {
|
|
super(name, realName, codePath, resourcePath, nativeLibraryPathString, pVersionCode,
|
|
pkgFlags);
|
|
}
|
|
|
|
/**
|
|
* New instance of PackageSetting replicating the original settings.
|
|
* Note that it keeps the same PackageParser.Package instance.
|
|
*/
|
|
PackageSetting(PackageSetting orig) {
|
|
super(orig);
|
|
|
|
appId = orig.appId;
|
|
pkg = orig.pkg;
|
|
sharedUser = orig.sharedUser;
|
|
}
|
|
|
|
@Override
|
|
public String toString() {
|
|
return "PackageSetting{"
|
|
+ Integer.toHexString(System.identityHashCode(this))
|
|
+ " " + name + "/" + appId + "}";
|
|
}
|
|
|
|
public int[] getGids() {
|
|
return sharedUser != null ? sharedUser.gids : gids;
|
|
}
|
|
|
|
public boolean isPrivileged() {
|
|
return (pkgFlags & ApplicationInfo.FLAG_PRIVILEGED) != 0;
|
|
}
|
|
}
|