Files
frameworks_base/core/java/android/os
Nick Kralevich cb1dddad27 Don't set sehash when calling restoreconRecursive
restorecon_recursive updates the SELinux label of the files in the
filesystem, and then attempts to write the xattr "security.sehash" as an
optimization for future restorecons. Writing security.* extended
attributes requires CAP_SYS_ADMIN, which system_server doesn't have (and
shouldn't have).

Suppress the computation and writing of the hash value. It's not
needed.

This bug has been around for a long time, but due to the fix for
bug 62302954, the error message is being generated more frequently
now.

TODO: It would be better if the default for restorecon was to suppress
the hash computation, since otherwise it encourages programs to be
overprivileged with CAP_SYS_ADMIN. I'll plan on doing that in a followup
commit.

Bugs where this error message has been called out:
Bug: 129766333
Bug: 129271240
Bug: 128700692
Bug: 129925723

Test: install an APK and ensure that no "SELinux:  setxattr failed"
    error messages are generated.
Change-Id: I83f4f225e4e73453daea42dbcabf0f8a06d320d6
2019-04-04 16:11:37 -07:00
..
2019-02-13 16:02:03 +00:00
2019-03-13 11:49:42 +00:00
2017-11-16 22:58:45 -07:00
2019-01-14 22:36:09 +00:00
2019-01-14 22:36:09 +00:00
2017-06-28 16:49:12 -07:00
2017-11-21 10:17:14 -08:00