8a6def0247
Currently, DumpRenderTree2 asigns the following result codes
{PASS, FAIL_RESULT_DIFFERS, FAIL_NO_EXPECTED_RESULT, FAIL_TIMED_OUT,
FAIL_CRASHED}
This is not strictly correct, as a test may fail for any of three
reasons - crashing, timing out, or the the result not being as
expected. Therefore, it's possible for a test to fail even if the
result is as expected.
This patch updates AbstractResult to handle each of the three reasons
for failure separately. We then test all three to determine if the
test has passed.
This allows us to correctly report whether or not the result differs
from expected for a failing test.
Change-Id: I7adcfe72c4dd0bd3de2e1b868d9807be6eb5bddf
126 lines
2.8 KiB
Java
126 lines
2.8 KiB
Java
/*
|
|
* Copyright (C) 2010 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.dumprendertree2;
|
|
|
|
import android.os.Bundle;
|
|
import android.os.Message;
|
|
import android.webkit.WebView;
|
|
|
|
/**
|
|
* A dummy class representing test that crashed.
|
|
*
|
|
* TODO: All the methods regarding expected results need implementing.
|
|
*/
|
|
public class CrashedDummyResult extends AbstractResult {
|
|
String mRelativePath;
|
|
|
|
public CrashedDummyResult(String relativePath) {
|
|
mRelativePath = relativePath;
|
|
}
|
|
|
|
@Override
|
|
public byte[] getActualImageResult() {
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
public String getActualTextResult() {
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
public Bundle getBundle() {
|
|
/** TODO: */
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
public String getDiffAsHtml() {
|
|
/** TODO: Probably show at least expected results */
|
|
return "Ooops, I crashed...";
|
|
}
|
|
|
|
@Override
|
|
public String getRelativePath() {
|
|
return mRelativePath;
|
|
}
|
|
|
|
@Override
|
|
public ResultCode getResultCode() {
|
|
return ResultCode.NO_ACTUAL_RESULT;
|
|
}
|
|
|
|
@Override
|
|
public boolean didCrash() {
|
|
return true;
|
|
}
|
|
|
|
@Override
|
|
public boolean didTimeOut() {
|
|
return false;
|
|
}
|
|
|
|
@Override
|
|
public void setDidTimeOut() {
|
|
/** This method is not applicable for this type of result */
|
|
assert false;
|
|
}
|
|
|
|
@Override
|
|
public TestType getType() {
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
public void obtainActualResults(WebView webview, Message resultObtainedMsg) {
|
|
/** This method is not applicable for this type of result */
|
|
assert false;
|
|
}
|
|
|
|
@Override
|
|
public void setExpectedImageResult(byte[] expectedResult) {
|
|
/** TODO */
|
|
}
|
|
|
|
@Override
|
|
public void setExpectedTextResult(String expectedResult) {
|
|
/** TODO */
|
|
}
|
|
|
|
@Override
|
|
public String getExpectedImageResultPath() {
|
|
/** TODO */
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
public String getExpectedTextResultPath() {
|
|
/** TODO */
|
|
return null;
|
|
}
|
|
|
|
@Override
|
|
public void setExpectedImageResultPath(String relativePath) {
|
|
/** TODO */
|
|
}
|
|
|
|
@Override
|
|
public void setExpectedTextResultPath(String relativePath) {
|
|
/** TODO */
|
|
}
|
|
}
|