In FeatureConnection, we never cleaned up the ImsFeatureStatusCallback
after it was destroyed, leaving zombie FeatureConnections around.
Bug: 156893040
Test: atest FrameworksTelephonyTests
Change-Id: Idcf8b558c3807a3f9f5094afee532e76ea6f02cb
Looks like somewhere along the line this was partially overwritten by
another change. This makes the toString value consistent and stops the
MNC field from running into the country ISO code.
Test: compilation (trivial)
Change-Id: Ifdc00d340ae8ce31c224decebdd6c7aa4230bdb7
Bug: 8675309
PowerManager does not rely on TelephonyManager#notifyUserActivity
to complete successfully since it is a oneway notification. If it
fails, due to telephony not being alive, do not throw a
RemoteException.
Bug: 156203930
Test: manual
Change-Id: I4c788fef5a887c45dbc3a20b7c8af40beed8d00a
NetworkTypeController (or DcTracker in aosp/master) will set lte
display type to LTE_CA when current ServiceState fulfills one of the
following conditions:
- getDataNetworkType return NETWORK_TYPE_LTE_CA
- isUsingCarrierAggregation return true
NetworkRegistrationInfo#getAccessNetworkTechnology() always returns LTE
when data rat is LTE CA. So the first condition will never get
fulfilled.
isUsingCarrierAggregation flag will only get updated when
ServiceStateTracker calls RatRatcheter.ratchet without location change.
This makes isUsingCarrierAggregation flag not always reliable to
determine if carrier aggregation is on.
The CL fix the issue by changing ServiceState#isUsingCarrierAggregation
to return true when ServiceState#getCellBandwidths return more than one.
The same condition is already used by RatRatcheter when set
isUsingCarrierAggregation flag in RatRatcheter#ratchet.
Bug: 154060784
Test: atest com.android.internal.telephony.ServiceStateTest
Test: atest android.telephony.cts.ServiceStateTest
Change-Id: Ie6c07cb58d2a40eeb10e8f0131c98212ba463517
These were previously being suppressed by doclava but with this change,
all failures are fixed and the suppression logic has been removed.
To fix the issues, there were a few possible changes made:
- broken reference to a public API (such as incorrect parameters): fixed
- unnecessary @link inside an @see tag: fixed
- @see referring to an @hide or @SystemApi: reference removed
- broken references to inner class constructors
- worked around by fully qualifying the constructor
Bug: 6963924
Test: make doc-comment-check-docs
Exempt-From-Owner-Approval: cherry-picked from master
Change-Id: Ifbdce2de96cdffa560bd90f549fa7184d1f9af85
Merged-In: Ifbdce2de96cdffa560bd90f549fa7184d1f9af85
(cherry picked from commit e0624c7a40)
Use PropertyInvalidatedCache to avoid redundant calls to
SubscriptionController getSlotIndex and getPhoneId.
Bug: 151953109
Test: Verified cache operated correctly when phone process is killed.
Test: atest SubscriptionControllerTest
Test: atest android.telephony.cts.SubscriptionManagerTest
Change-Id: I70552537af44f3e05b156cd190ebb28f0d940bf6
Create a genericized class to use for SubscriptionManager caching calls
in order to avoid duplicating logic that fetches values from ISub.
Bug: 151953109
Test: atest android.telephony.cts.SubscriptionManagerTest
Merged-In: I6682ded8aec8cb3e50521584c177df6d5dae8c49
Change-Id: I6682ded8aec8cb3e50521584c177df6d5dae8c49
Use PropertyInvalidatedCache to avoid redundant
calls to SubscriptionController.getDefaultSmsSubscriptionId.
Bug: 151953109
Test: Verified cache operated correctly when phone process is killed.
Test: atest SubscriptionControllerTest
Test: atest android.telephony.cts.SubscriptionManagerTest
Merged-In: Iadb6a42b256013021903f75ed72bb5f046bfa2cc
Change-Id: Iadb6a42b256013021903f75ed72bb5f046bfa2cc
It was removed from boot-image-profile when we tried to expose them
for mainlining. Now it's @hide again, so we should add it back
into boot-image-profile otherwise it will break appss.
Bug: 153825725
Test: build
Change-Id: I7dcce69d3d2b3b2601f98817a4ee4467f7efb47a
Use PropertyInvalidatedCache to avoid redundant
calls to SubscriptionController.getActiveDataSubscriptionId.
Bug: 151953109
Test: Verified cache operated correctly when phone process is killed.
Test: atest SubscriptionControllerTest
Test: atest android.telephony.cts.SubscriptionManagerTest
Merged-In: I45d1abf15e4b105c966d4a786a4dc33aa67b20aa
Change-Id: I45d1abf15e4b105c966d4a786a4dc33aa67b20aa
When notifying the framework of an incoming call, a lock is held
in both the MmTelFeature and MmTelFeatureConnection. This can cause
a deadlock if the MmTelFeatureConnection is also processing an
event, such as sending/acknowleging an SMS message.
Remove the lock around the listener methods to the framework, since
it is not needed.
Bug: 155083563
Test: atest CtsTelephonyTestCases:ImsServiceTest FrameworksTelephonyTests
Change-Id: I39f7192c6f79e215ef989797870f5f501197cd08
Use PropertyInvalidatedCache to avoid redundant
calls to SubscriptionController.getDefaultDataSubscriptionId
Bug: 151953109
Test: Verified cache operated correctly when phone process is killed.
Test: atest SubscriptionControllerTest
Test: atest android.telephony.cts.SubscriptionManagerTest
Merged-In: Ifbd380a9281d7bc9c3a9b35c5e93207acabf8d15
Change-Id: Ifbd380a9281d7bc9c3a9b35c5e93207acabf8d15
The Global Cell-ID is constructed from other
fields in each CellIdentity.
Currently, it is not stored during parceling.
Thus, after a CellId is parceled and unparceled
this value is being lost.
Do a quick fix to update the global Cell ID during
unparceling. A longer-term fix is to resolve the
layering violations that create the situation where
the global Cell ID is defined in the base class
but manipulated in the derived classes.
Fixes a broken unit test.
Bug: 154955167
Test: atest ServiceStateTrackerTest#testRatRatchet
Change-Id: I5c58322ebcec8886405e25e09754c7f154187efe
replace java doc links from @see {@link ...} to @see #...}
Bug: 154439721
Test: Building the project
Change-Id: I5ffdb3c56a01a6454d2d640898c1d7e24b63ae40
Use PropertyInvalidatedCache to avoid redundant
calls to SubscriptionController.getDefaultSubscriptionId
Bug: 151953109
Test: Flashed build and verified that the phone booted
and executed the cache
Merged-In: I69b178b42a49b1eda6c2e72ce21d93906ff9d281
Change-Id: I69b178b42a49b1eda6c2e72ce21d93906ff9d281
Fixed the toString and made overrideNetworkTypeToString
public for debugging purposes.
Fix: 154229268
Test: Manual
Change-Id: I5c886de22543188032df172810b987cff964577b
Make CellIdentity.MNC_MIN_LENGTH and CellIdentity.MNC_MAX_LENGTH
hidden public to support IccRecords changes.
Bug: 152518548
Test: make
Change-Id: Ic253a6bbbf07e4ce62a7ea25ca67dff54e2c67c8
For IWLAN, MTU is not negotiated as part of the RA. The interface
MTU is still necessary here to ensure full backward compatibility.
To workaround this, we set legacy mtu field with the larger value
of mtu v4 and mtu v6.
Fix: 153470573
Test: FrameworkTelephonyTests
Change-Id: I0671618817a295cc4e9c75df17501de338dbe155
Remove the dependency on this interface until it is intended
to be public.
Fixes: 153908410
Test: atest CtsTelephonyTestCases
Change-Id: Iad82b7d06738468861bd49164fbb4b4dafb8c014
