We should only re-use a cached 'allow' decision if the decision ...
- is for the same host
- is for an error which is at least as severe as the current error
Bug: 5409251
Change-Id: Id8516f58c8d23de44e80539ffeaf945be3d2914a
- Fix a comment in BrowserFrame.certificate()
- Simplify SslCertLookupTable by not storing 'deny' decisions.
We only need to store 'allow' decisions, as we don't re-use 'deny' decisions.
No change in behaviour.
Bug: 5409251
Change-Id: I447cd1966fbb6c2dea8088b2e4c4e2de22405cb9
- Use assert rather than junit.framework.Assert
- Add some comments
- There's no need for checkSslPrefTable() to call handleSslErrorResponse() as
we'll never update the table. Instead call
LoadListener.handleSslErrorResponse() directly.
No functional change.
Bug: 5409251
Change-Id: I0c6cdae43fa966f86f4a6c43b74c2f2a01f60319
https://android-git.corp.google.com/g/#/c/133348 changed BrowserFrame to
construct the SslError using only the host. This was done so that we match on
just the host component of the URL when re-using previous decisions in case of
an SSL error. It also means that the browser displays only the host when it
shows the SSL error dialog.
This change fixes BrowserFrame to pass the full URL to SslError. We modify
SslCertLookupTable to keep the existing behaviour regarding matching on only the
host component. There's no need to change Browser to continue displaying only
the host as I think this change was an unintentional side-effect.
Also remove dead code-path in BrowserFrame.reportSslCertError(). This
method is used only with the Chromium HTTP stack. This code was added
in https://android-git.corp.google.com/g/#/c/121023.
No functional change.
Bug: 5410252
Change-Id: Ief2dbf4558095fb6fa7ab0caac7d37fa4f640b66
Directly update the layers transform and position.
This makes updates faster and less dependent on other webkit work.
bug:5218173
Change-Id: I5f784ef64eda1be3cee406aa23702e5378c8de9e
bug: 5385775
Check mWebViewCore has been destroyed
Remove mWebTextView from WebView when WebView is destroyed
Clear WebTextView's handler when it is removed from WebView
Change-Id: I9c62292d693109e692c341e3e4dba3e04af81fe4
Multiple focusable windows cause undesired behavior around selection
modes. TextView isn't sure how to behave when it loses window focus
with regard to selection handles and action modes need to be focusable
for WebView find on page since it uses an EditText as a custom view.
For now:
* Use a layered window decor for overlay action mode when there is no
action bar requested. This eliminates an extra window and avoids the
issue described for full-screen UIs.
* Disable WebView's find-on-page mode when the action mode's UI will
not be focusable. This only affects WebViews in floating windows.
Also remove the "Text Selection" title for WebView's selection mode at
UX's request, as it is inconsistent with TextView's selection mode and
the string does not fit on phones in portrait even on wide
devices. This now uses the same mechanism used in TextView to decide
whether to use title text.
Change-Id: I80caeecea9b47728cf26bb0a388153ca0bdeafe1
This makes sure that the page's SSL certificate is cleared when the page load
starts.
Follows on from https://android-git.corp.google.com/g/#/c/138147.
Bug: 5287216
Change-Id: I40f74a72dc495c48d7167b7b70a845a8481feb85
Note that this is an incomplete fix, as we do not clear the responses for
connections currently in use, as they maintain their own cache. See
http:/b/5324235.
Bug: 5287216
Change-Id: I18f6638efeff0bee1e7ffed606be1444d683bebd
* changes:
Always update the WebView's SSL certificate, regardless of whether a WebViewClient has been set
Remove superfluous synchronized modifier on SslCertLookupTable.getInstance()
This looks like a copy-paste error from other CallbackProxy methods which call
back to the WebViewClient or WebChromeClient, rather than the WebView.
Also remove '@hide' annotations. These are superfluous as the class is not
public.
Bug: 5287216
Change-Id: If97c4d769cf82563b9c182ba09fc742fbb7e08e9
- Update the description
- Use Throwable rather than RuntimeException
- Log as a warning rather than an error
Bug: 5313494
Change-Id: If13ce2088e7080122db14e5e0565f64e6d6f4320
If restored scale and text wrap scale are set to 0 (meaning the previous
scale wasn't saved), set them to overview and reading level scale
respectively.
Bug: 5230909
Change-Id: If7724e9a0cd948c88d0a001728266a3282083bdc
Bug: 5321358
Destroy does run with this. Ideally we should get rid of the need
to run this on the UI thread at all. GL destroy should instead
take place when the view is detached or something like that.
Cherry picked from master
Change-Id: I693ce83cd607186173d8cf58485c5df28004e52c
nativeSetIsScrolling has other side effects. Just pause picture
updating when WebView loses focus.
Change-Id: I917851c806f35a91a12a25c7457712123669384f
Make sure that the native component of WebView has been initialized
before any native-level optimization involving window focus occurs.
Change-Id: I24ca5fe21657aeb1a1faf5bc36fba5ea11064f86
This prevents animations and other live page content from consuming
too many resources while the user is interacting with a popup window.
Bug 5300522
Change-Id: I40fb6d16d56b540c431172052a1ae7fead7109be
Variable is not needed, and removing unneeded check
Also throwing an exception if sContext gets set to null.
Change-Id: Ic61ba4c88a162eb730e166f0e9f477e809b51f42
