Commit Graph

12924 Commits

Author SHA1 Message Date
Mathew Inwood
cd82f9adff Merge "Restore some greylist entries." into qt-dev
am: f4535c8d51

Change-Id: I3851fed60bedab9748f2d6d53f342f2605ecf78b
2019-06-28 13:18:30 -07:00
Mathew Inwood
a5531fa161 Restore some greylist entries.
In Q, these APIs were either:
- removed from the greylist entirely without good reason
- Moved to the restricted greylist without any public alternative
  information added

So they are being moved back to the greylist for Q.

Test: Treehugger
Bug: 136102585
Change-Id: Ie3dd15c8e17d530d853473a013717e6175383080
2019-06-28 09:23:06 +00:00
Felix
de67a21c84 Merge "PhoneWindowManager/KeyEvent: Camera key as WakeKey" am: dec76b8a40
am: 1841f6af1d

Change-Id: I6771fdd3408461fb8343006a05d15c260d0fb256
2019-06-26 00:27:32 -07:00
Winson Chung
26ccc92307 Merge "Catch all exceptions in onFrameDraw" into qt-dev
am: cff24b878d

Change-Id: I485cc8af4e6180adebb31235b43191e467b393bc
2019-06-25 15:36:26 -07:00
Winson Chung
cff24b878d Merge "Catch all exceptions in onFrameDraw" into qt-dev 2019-06-25 22:07:44 +00:00
Jorim Jaggi
b0bb2f778f Catch all exceptions in onFrameDraw
... as throwing an exception in there somehow will mess up the
hwui task queue.

Test: Have a crashy app, swipe up while the app is crashing
Fixes: 134583193
Change-Id: Ie3ba5f991759f807b154f55f9fc816e7efe2fdfe
2019-06-25 15:37:53 +02:00
Felix
2deb9b54d9 PhoneWindowManager/KeyEvent: Camera key as WakeKey
As discussed in https://r.android.com/973723

This makes any camera key event wake up the device.
Handling of the camera key apart from waking up the device might follow
in a later commit.

Signed-off-by: Felix <google@ix5.org>
Change-Id: I44dbc3f9ac465f664b6d740cb6a056b7f6e118fb
2019-06-25 06:41:12 +02:00
Robert Carr
641d4f27e3 Merge "ViewRootImpl: Ensure layout when configuration changes." into qt-dev
am: 6397ab05f9

Change-Id: I023b06dc785cbf22783a426060aef55714a457d8
2019-06-21 17:32:54 -07:00
Robert Carr
437c0e4c15 ViewRootImpl: Ensure layout when configuration changes.
When the configuration changes between landscape and reverse
landscape, the app will not receive onConfigurationChanged as
orientation is not part of the public portion of the configuration.
However, when the ViewRootImpl receives such a configuration back from
relayout, it will force a layout of the client views
(see updatedConfiguration in performTraversals), this is because
Configuration#equals compares the non public part of the configuration
as well. This CL changes MSG_REPORT_RESIZED to handle the configuration
changing the same way performTraversals does, so that the app consistently
receives a configuration change.

Bug: 134643273
Test: Manual
Change-Id: If016bcd9a5b8d2a7efc5e1ab3c82a88a608caf8b
2019-06-18 16:12:29 -07:00
lumark
cf48a8e828 Merge "Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable." into qt-dev
am: b7abebde5b

Change-Id: I2224102556d110021150ddb6eea90bb0be2c2f36
2019-06-18 05:32:30 -07:00
TreeHugger Robot
b7abebde5b Merge "Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable." into qt-dev 2019-06-18 12:27:15 +00:00
lumark
ca442d5d9f Make InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED testable.
Annotates InputMethodSystemProperty#MULTI_CLIENT_IME_ENABLED as @TestApi
to let cts can verify if multi-client IME enabled.

Bug: 135217809
Test: build and passes
Change-Id: Id7b4dceb2dbfaf3d7ed1084957dd14b04cad0cdf
2019-06-17 16:09:42 +08:00
Tim Murray
9adc27c042 Merge "Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"" into qt-dev
am: 2ea2a58d97

Change-Id: I89fe6d0159d74709578515329c0725fc75aa93bc
2019-06-14 13:24:06 -07:00
Tim Murray
2ea2a58d97 Merge "Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"" into qt-dev 2019-06-14 19:50:20 +00:00
Tim Murray
4f6b8ec056 Revert "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows"
This reverts commit c18c6da441.

Reason for revert: major memory increase

Change-Id: Iffb9cd14343cd678849e487bfa163b5f23608ffd
Test: presubmit
Bug: 134695730
2019-06-14 17:16:17 +00:00
Qasid Ahmad Sadiq
5e2254948d Merge "AccessibilityNodeIdManager should hold onto weak references of Views." into qt-dev
am: c0d808a274

Change-Id: I44bfdb8beebafd5e1a8ea91da9f30a876b0ddf27
2019-06-10 22:27:47 -07:00
Qasid Ahmad Sadiq
2e6efdefa6 AccessibilityNodeIdManager should hold onto weak references of Views.
... as opposed to strong references.
In case the calls between register and unregister aren't matched, we don't want to be leaking views.
I haven't seen any real eveidence of there being leaks, just a report. But this is preventative.

Created a "WeakSparseArray", which wraps SparseArray, and passes in a kind of WeakReference that has an id.
The references become unreachable, we use the id to remove the the entry from the SparseArray.

Test: Used the device for a bit with talkback on. CTSAccessibility*
Change-Id: I8d11727428f56fc06007232ae341d1409a11991f
Fix: 134506015
2019-06-10 19:47:34 -07:00
Tony Mak
5db125ccb8 Merge "Fix an issue that clicking on a smart action chip on keyguard ... failed to launch app resolver when there are more than one app handlers." into qt-dev
am: 78a48f5512

Change-Id: Ibd5f497a614e21b7d70972c51a56c820a5eb7c8a
2019-06-06 02:39:34 -07:00
Tony Mak
82e60027f4 Fix an issue that clicking on a smart action chip on keyguard ...
failed to launch app resolver when there are more than one app handlers.

What happened:
1. TextClassifier constructs an implicit intent to fulfill a task
like opening a link, making a phone call, etc.
2. TextClassifier calls resolveActivity against the implicit intent to
resolve the intent. The resolve component name will be used to create
an explicit intent. In this case, the intent is resolved to the
app resolver activity.
3. wouldLaunchResolverActivity in SysUI returns false for an explicit
intent with component name android/ResolverActivity.
4. SysUI does not trigger the "start the activity after the keyguard
is gone" logic because wouldLaunchResolverActivity returns false.
5. When user clicks on the action on keyguard, ResolveActivity.onStop
is triggered because it is shown (and thus moved to the background)
under the keyguard. So, finish() is called in onStop, and thus the bug.

IMHO, wouldLaunchResolverActivity should not return false
for an explicit intent with component name android/ResolverActivity.
But since we are late at this point, the safest option is to not setting
component name when the intent is resolved to package "android". Note that
this is what we are doing for P, so it should be pretty safe.

Test: 1. Install two browsers. Send myself a link. Tap on the Open Link
chip on keyguard. App resolver is shown.
2. atest frameworks/base/core/tests/coretests/src/android/view/textclassifier/

BUG: 129220155

Change-Id: I6d4d67c2233a2fec950887ea274825bf1cbc1ae2
2019-06-05 12:52:22 +01:00
Adrian Roos
1fb1edbe8a Merge "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows" into qt-dev
am: 952bcb8ffe

Change-Id: Ia6e018776df9fcfcd3e0ce00b18341d1cbc7c8c6
2019-06-03 16:02:28 -07:00
TreeHugger Robot
952bcb8ffe Merge "RootViewImpl: Fix measure size hint for WRAP_CONTENT windows" into qt-dev 2019-06-03 22:52:59 +00:00
Chavi Weingarten
71df88b5b0 Merge "Only updateBoundsSurface when surface size has changed." into qt-dev
am: fd979ca3d2

Change-Id: I4fc1da4bd8f3dd74f873a1955c8ef350e0d00c36
2019-06-03 09:18:02 -07:00
Chavi Weingarten
fd979ca3d2 Merge "Only updateBoundsSurface when surface size has changed." into qt-dev 2019-06-03 16:08:42 +00:00
Riddle Hsu
789d90fc0e Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev
am: 3bc96f9113

Change-Id: I8215c828fadc888d59b10ad85088b2edf17378df
2019-06-03 03:19:21 -07:00
TreeHugger Robot
3bc96f9113 Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev 2019-06-03 10:13:18 +00:00
chaviw
c0a8c4edbd Only updateBoundsSurface when surface size has changed.
Currently, updateBoundsSurface was getting called when the surface
changed, not just when the size changed. This meant it could be calling
setWindowCrop and deferTransaction when no size had changed. If size
hadn't changed, there was a high possibility that no new frames would be
submitted by the client, causing the deferTransaction to wait forever.

Since the deferTransaction was still waiting, SurfaceFlinger would wake
up every vsync to check if it should call doTransaction for the deferred
transaction. This caused 60Hz composition even when frames were rendered
slower.

Fixes: 132110524
Test: SF doesn't compose 30fps app at 60Hz
Change-Id: Icf3a99b34c288575438bfcd05e9077ea7919b4ca
2019-06-01 00:12:09 +00:00
Adrian Roos
c18c6da441 RootViewImpl: Fix measure size hint for WRAP_CONTENT windows
Fixes an issue where we would measure WRAP_CONTENT windows inconsistently
in the measure passes before and after relayoutWindow.

Fixes: 119839070
Bug: 73813813
Change-Id: I376e416d648f31a0dedecd6a70b476c3bf82b8b0
Test: Install test case app from 119839070, verify dialog is correctly laid out.
2019-05-31 14:26:35 +02:00
Siarhei Vishniakou
d447030e71 Merge "Close windows on ACTION_UP when touched outside" into qt-dev
am: 89ebf3f674

Change-Id: I845e4979cb3e7cc32775b9ac8083ee0802d6a390
2019-05-29 15:00:30 -07:00
TreeHugger Robot
89ebf3f674 Merge "Close windows on ACTION_UP when touched outside" into qt-dev 2019-05-29 21:51:22 +00:00
Abodunrinwa Toki
aeb8a3b154 Merge "Convert TextClassifierEvent to SelectionEvent for logging in the default TC." into qt-dev
am: a578ecce46

Change-Id: Icadad2e0afaa3355b260f95d011f0dd577115439
2019-05-23 12:55:31 -07:00
Abodunrinwa Toki
a578ecce46 Merge "Convert TextClassifierEvent to SelectionEvent for logging in the default TC." into qt-dev 2019-05-23 19:35:24 +00:00
Abodunrinwa Toki
5258633e2d Convert TextClassifierEvent to SelectionEvent
for logging in the default TC.

TCEvents for selection and links are not currently being written to
default TC logs. This changelist writes these events as SelEvents.

Bug: 131228248
Test: atest android.view.textclassifier.TextClassifierEventTest
Change-Id: I191f2f9281eab1b8a427ef21717fff283a304a22
2019-05-23 13:37:59 +01:00
Derek Sollenberger
a538b561fb Merge "Fix fading edge effect from impacting neighboring pixels" into qt-dev
am: 9fdd35e9aa

Change-Id: Ia759b9218ee6dbb6b6fa4aea69526de0d7facd84
2019-05-22 16:10:05 -07:00
TreeHugger Robot
9fdd35e9aa Merge "Fix fading edge effect from impacting neighboring pixels" into qt-dev 2019-05-22 21:32:59 +00:00
Felipe Leme
3e325a2b28 Merge "Make sure view.setAutofilled() is called when autofilled by augmented-autofill only." into qt-dev
am: 64f0871ef7

Change-Id: Ibf704b524efae59fc43efebe13442b7e9253d0e3
2019-05-22 14:14:06 -07:00
TreeHugger Robot
64f0871ef7 Merge "Make sure view.setAutofilled() is called when autofilled by augmented-autofill only." into qt-dev 2019-05-22 16:22:22 +00:00
Qasid Sadiq
a266cfe552 Merge "Send subtree changed AccessibilityEvent for all alpha changes." into qt-dev
am: 37f6ad6529

Change-Id: Ibfbe949d01cfba35a75a714df48f3c7b4597b41e
2019-05-21 23:26:04 -07:00
Felipe Leme
a16741cd5d Merge "Fixed javadoc for View.setContentCaptureSession()." into qt-dev
am: a4630da2c1

Change-Id: I62e5743a0d006aa00b320aab2b7afc01d0e277b5
2019-05-21 22:18:28 -07:00
Qasid Sadiq
37f6ad6529 Merge "Send subtree changed AccessibilityEvent for all alpha changes." into qt-dev 2019-05-21 20:03:15 +00:00
TreeHugger Robot
a4630da2c1 Merge "Fixed javadoc for View.setContentCaptureSession()." into qt-dev 2019-05-21 17:38:41 +00:00
Mark Renouf
c60f56d8ff Merge "Adds setCornerRadius to ActivityView & SurfaceView" into qt-dev
am: b46293f8f6

Change-Id: If481fa20f4b005c059bae835a431f84fc2da44f4
2019-05-20 10:30:39 -07:00
Abodunrinwa Toki
006efcaa64 Merge "Report AUTO_SELECTION as a smart selection event." into qt-dev
am: 2cb08912a7

Change-Id: Ic2a39f88e8f5ab2b2286915c887163d87c4297fe
2019-05-20 09:42:27 -07:00
TreeHugger Robot
b46293f8f6 Merge "Adds setCornerRadius to ActivityView & SurfaceView" into qt-dev 2019-05-20 16:30:20 +00:00
Abodunrinwa Toki
2cb08912a7 Merge "Report AUTO_SELECTION as a smart selection event." into qt-dev 2019-05-20 16:09:43 +00:00
yj81.kwon
b2f088409b Merge "[wm]: Fixed TaskPositioner leak" into qt-dev
am: 050d6df74c

Change-Id: Ife9c5d5da6fae4d40183a6a56a71165001bf6674
2019-05-20 04:54:49 -07:00
TreeHugger Robot
050d6df74c Merge "[wm]: Fixed TaskPositioner leak" into qt-dev 2019-05-19 23:12:25 +00:00
Qasid Ahmad Sadiq
6205820579 Send subtree changed AccessibilityEvent for all alpha changes.
Changes to view.mtransformationInfo.mAlpha outside of View.java weren't triggering subtree AccessibilityEvents.
This is a problem, because that property helps determine a views visibility in accessibility, and AccessibilityServices wouldn't be informed of this change in visibility.
This results in UIs with certain animations not being accessible at all.

This seems like an oversight to begin with, so it's a pretty low risk change.

Test: Tested the reported instance of this bug in Permission Manager, CTSAccessibility*
Change-Id: I02526e5659cf95f1373811008e74954a73addd21
Fix: 127589394
2019-05-17 21:13:17 +00:00
Derek Sollenberger
9d25cc242f Fix fading edge effect from impacting neighboring pixels
Bug: 132354626
Bug: 129117085
Test: skia unit tests and test cases described in the bug
Change-Id: Ieaa7c831dd6298ac0565e6f1837b1c1dbd4545da
(cherry picked from commit ac33a48751)
2019-05-17 17:59:57 +00:00
yj81.kwon
19585ffabf [wm]: Fixed TaskPositioner leak
If application process handles motion events late, it requests to start
moving task after MotionEvent.ACTION_UP is already fired. In that case,
system will wait for event that is not comming and cannot end drag state.
It's expected that the system finishes moving task when system receives
ACTION_UP by transfering touch focus. In a problem case, ACTION_UP event
is already sent to the application process before transfering touch focus.

If application receives ACTION_UP event after requesting moving task,
notify the system of finishing previous request.

Test: Quickly try to resize freeform windowing app repeatedly.
Test: atest WmTests:TaskPositioningControllerTests
Bug: 129507487

Change-Id: Ifa457ddc55524cae6da455e770472781a7805282
(cherry picked from commit 9a1cd7b5063229da536a1281916ae15ec9246d1a)
2019-05-16 16:42:10 -07:00
Adam He
851c703681 Merge "Metrics for content capture." into qt-dev
am: 815979d5df

Change-Id: I0abb01fbef13917a9bcb494f72afa4879e46e1c8
2019-05-16 13:29:40 -07:00