Commit Graph

10142 Commits

Author SHA1 Message Date
TreeHugger Robot
6d81ed4c34 Merge "Do not restore same autofill id twice" 2017-06-20 19:15:34 +00:00
TreeHugger Robot
8446a3005f Merge "Add support for ACTION_OUTSIDE to Dialog" 2017-06-20 18:08:10 +00:00
Philip P. Moltmann
cb79781356 Do not restore same autofill id twice
View's are restored based on their id. The autofill id is part of the
id's state. Unfortunately the ids of the view are not neccessary
unique. In this case two views would store state of for the same id.
Also two views would be restored frome the same state. This causes
duplicate autofill ids which is not allowed. Hence make sure that for a
single state, the autofill id is only restored once.

Change-Id: I8d950486cb21d9f6afe6d0f5f668799305ae73e7
Fixes: 62658714
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases
2017-06-20 10:08:21 -07:00
Jonathan Solnit
30f4c97aaa Merge "Check for keyguard occlusion on camera lift" into oc-dr1-dev am: e07567cc0b
am: 9a0894b930

Change-Id: I1e4a944ff83e46978cc4d15175347d0a44019ae5
2017-06-20 16:36:49 +00:00
Jonathan Solnit
e07567cc0b Merge "Check for keyguard occlusion on camera lift" into oc-dr1-dev 2017-06-20 16:24:28 +00:00
Michael Wright
ddec8fb43c Add support for ACTION_OUTSIDE to Dialog
Historically, Dialogs expected to be fullscreen in order to know when to
close.  By adding support for ACTION_OUTSIDE, they can now close when
the user touches outside of them without actually having to be
fullscreen

Bug: 62373955
Test: cts-tradefed run commandAndExit cts-dev \
      -m CtsAutoFillServiceTestCases -t \
      android.autofillservice.cts.LoginActivityTest#testSaveGoesAwayWhenTouchingOutside
Change-Id: I9cd2afc093ee6f252aaf6c23c029059584879004
2017-06-20 14:15:48 +00:00
Siarhei Vishniakou
3998a5ccc6 Merge "Revive DeadZone" into oc-dev am: b278424fa6 am: 305fe47d65
am: d5c0ef9467

Change-Id: Iec82102d862097ef3242da9103996afe94f0909c
2017-06-20 00:11:45 +00:00
Siarhei Vishniakou
305fe47d65 Merge "Revive DeadZone" into oc-dev
am: b278424fa6

Change-Id: I5a06302eaad1e955aaea6ae8d2785c0b12e53cc4
2017-06-19 23:59:46 +00:00
Wale Ogunwale
510fb72803 Merge "Added back removed ctor from DisplayEventReceiver" into oc-dev am: 113918f309 am: f4dc128aa2
am: c8f7cb6be7

Change-Id: I8355dfd4c6c3adb2fd34a01fb4a9b828f735788f
2017-06-19 23:57:42 +00:00
Siarhei Vishniakou
b278424fa6 Merge "Revive DeadZone" into oc-dev 2017-06-19 23:48:00 +00:00
Wale Ogunwale
f4dc128aa2 Merge "Added back removed ctor from DisplayEventReceiver" into oc-dev
am: 113918f309

Change-Id: I655721c29b22da375742628a9e7b8b3075b2dd27
2017-06-19 23:27:57 +00:00
TreeHugger Robot
113918f309 Merge "Added back removed ctor from DisplayEventReceiver" into oc-dev 2017-06-19 23:16:18 +00:00
Vladislav Kaznacheev
b9faebca98 Merge "Do not update currently open tooltip." into oc-dev am: 139dbe5c1c am: 3fd4215760
am: 6063096518

Change-Id: I5e7b6742544a5db4266e95be0ce01830ea62cd92
2017-06-19 21:37:31 +00:00
Vladislav Kaznacheev
6063096518 Merge "Do not update currently open tooltip." into oc-dev am: 139dbe5c1c
am: 3fd4215760

Change-Id: I4b9674e73830462bbe9288ebfa1bbac89af860b3
2017-06-19 21:24:11 +00:00
Vladislav Kaznacheev
2102c3211c Merge "Do not update currently open tooltip." into oc-dev
am: 139dbe5c1c

Change-Id: Ia3fc1f16e71a4a12a0a84704b7ca7a9d2ec33514
2017-06-19 21:12:45 +00:00
Siarhei Vishniakou
6ad0e39f33 Revive DeadZone
Override dispatchTouchEvent for the root FrameLayout
of NavigationBar to process ACTION_OUTSIDE MotionEvents
and dispatch directly to DeadZone to keep track of the
most recent outside tap.
Clarified documentation of ACTION_OUTSIDE behaviour.

Bug: 37552674
Test: open IME, tap any key, then quickly tap on top half
of the home button. The home button tap is ignored
and device does not go to homescreen.

Change-Id: Icb5cf6c76959f3514b8b94c09e38cc5434f31b23
2017-06-19 14:06:21 -07:00
TreeHugger Robot
139dbe5c1c Merge "Do not update currently open tooltip." into oc-dev 2017-06-19 21:01:47 +00:00
Wale Ogunwale
71f3099c53 Added back removed ctor from DisplayEventReceiver
...because some app can't help but access hidden APIs...

Test: builds
Change-Id: Ia1d4a71b46a53b44e3ebe5844e446009785a90ac
Fixes: 62719884
2017-06-19 13:53:32 -07:00
Yohei Yukawa
0998425067 Merge "Merge "Introduce HapticFeedbackConstants.TEXT_HANDLE_MOVE" into oc-dr1-dev am: 280acdb88b" into oc-dr1-dev-plus-aosp
am: ffc014dfcc

Change-Id: I6aebfd5c56c9ab0f4b61eb837e90cc26f7e016fb
2017-06-19 20:16:39 +00:00
TreeHugger Robot
280acdb88b Merge "Introduce HapticFeedbackConstants.TEXT_HANDLE_MOVE" into oc-dr1-dev 2017-06-19 19:44:52 +00:00
Felipe Leme
7ee79d25e5 Merge "Revert "Trim text from autofillvalue when checking for empty."" into oc-dev am: 215ebb941d am: 1581ceb1fb
am: ffd13036d1

Change-Id: I568601e36d5658560dff9a13bdaf5cb93982cacb
2017-06-17 01:29:13 +00:00
Phil Weaver
be16a207b4 Merge "Merge "Separate a11y and autofill view ids" into oc-dev am: c91290a6e9 am: 8b2816faa3" into oc-dr1-dev-plus-aosp
am: e9bd6e72fc

Change-Id: I534fb195d21490663e299c39d4a64b63856d7935
2017-06-17 01:26:53 +00:00
Casey Burkhardt
4f152ddd8f Merge "Resolve 3 inconsistencies in accessibility button API - Unify logic for detecting availability of the accessibility button - Ensure the initial visibility state is propagated to A11yMS - Ensure services only receive availability callbacks for changes" into oc-dev am: 4ab690a50d am: 8097485c28
am: 8cc3fee95c

Change-Id: Iae4767d6d764f272c3c867276483f7f8522259fe
2017-06-17 01:20:37 +00:00
Felipe Leme
ffd13036d1 Merge "Revert "Trim text from autofillvalue when checking for empty."" into oc-dev am: 215ebb941d
am: 1581ceb1fb

Change-Id: Ia8931bffb2a19993b598fcf6ecf9f09ab5157614
2017-06-17 01:09:38 +00:00
Phil Weaver
09e5b54fd5 Merge "Separate a11y and autofill view ids" into oc-dev am: c91290a6e9
am: 8b2816faa3

Change-Id: I567471d68e6ad5b60fcf33eda47e5d99bdb49f2b
2017-06-17 01:05:36 +00:00
Felipe Leme
730924cd65 Merge "Revert "Trim text from autofillvalue when checking for empty."" into oc-dev
am: 215ebb941d

Change-Id: I058b5fd135e4165214116055ccdc04e9d99955b0
2017-06-17 01:04:08 +00:00
Casey Burkhardt
8cc3fee95c Merge "Resolve 3 inconsistencies in accessibility button API - Unify logic for detecting availability of the accessibility button - Ensure the initial visibility state is propagated to A11yMS - Ensure services only receive availability callbacks for changes" into oc-dev am: 4ab690a50d
am: 8097485c28

Change-Id: I0c21a256e612fd2ecfb2dce6c4d28e3c33e075e2
2017-06-17 01:02:57 +00:00
Phil Weaver
0da21f56e4 Merge "Separate a11y and autofill view ids" into oc-dev
am: c91290a6e9

Change-Id: Iec71a9ae34f963ef1f0ce7f6bd09b5af5bbba6e6
2017-06-17 00:59:04 +00:00
TreeHugger Robot
215ebb941d Merge "Revert "Trim text from autofillvalue when checking for empty."" into oc-dev 2017-06-17 00:53:04 +00:00
Casey Burkhardt
5f485cab2b Merge "Resolve 3 inconsistencies in accessibility button API - Unify logic for detecting availability of the accessibility button - Ensure the initial visibility state is propagated to A11yMS - Ensure services only receive availability callbacks for changes" into oc-dev
am: 4ab690a50d

Change-Id: Ia86c49759f9dac2c40b5c28609ab283efb41cd02
2017-06-17 00:52:47 +00:00
Phil Weaver
c91290a6e9 Merge "Separate a11y and autofill view ids" into oc-dev 2017-06-17 00:46:05 +00:00
Casey Burkhardt
4ab690a50d Merge "Resolve 3 inconsistencies in accessibility button API - Unify logic for detecting availability of the accessibility button - Ensure the initial visibility state is propagated to A11yMS - Ensure services only receive availability callbacks for changes" into oc-dev 2017-06-17 00:41:06 +00:00
Bryce Lee
cda05758dc Merge "Create native Surface object on updateWindow for legacy apps." into oc-dev am: 1e1c5d7b77 am: 14d9e3a529
am: d44baa3b7d

Change-Id: I048fb1820809ae04b6acbbf5285459ff17db3ce1
2017-06-17 00:36:24 +00:00
Felipe Leme
5ae4e8dc9d Merge "Trim text from autofillvalue when checking for empty." into oc-dev am: b3b13ff62c am: 1c03d3fcef
am: 9ccb3a86ae

Change-Id: I5a6101d80376a0fd60bd6c49fe6a12f8ec9df12e
2017-06-16 23:56:12 +00:00
Bryce Lee
14d9e3a529 Merge "Create native Surface object on updateWindow for legacy apps." into oc-dev
am: 1e1c5d7b77

Change-Id: I2f402ea2a6003e5306a7bbcf1d7b8d640672d460
2017-06-16 23:24:34 +00:00
Bryce Lee
1e1c5d7b77 Merge "Create native Surface object on updateWindow for legacy apps." into oc-dev 2017-06-16 23:15:10 +00:00
Felipe Leme
9ccb3a86ae Merge "Trim text from autofillvalue when checking for empty." into oc-dev am: b3b13ff62c
am: 1c03d3fcef

Change-Id: I8f94db3b3b129caca53f3cb0ed0b16b2a4951648
2017-06-16 23:06:47 +00:00
Felipe Leme
2de4d6bce4 Merge "Trim text from autofillvalue when checking for empty." into oc-dev
am: b3b13ff62c

Change-Id: I5a96a3f2613aeaad1f3d146b5ce6a208b1180851
2017-06-16 23:00:14 +00:00
Felipe Leme
313cf3fb93 Revert "Trim text from autofillvalue when checking for empty."
This reverts commit c5d4e068f2.

Change-Id: I4027cf0f91ebb9032c21efad7025118891188bc6
2017-06-16 22:57:58 +00:00
Phil Weaver
846cda9397 Separate a11y and autofill view ids
Autofill seems to need IDs to be preserved across things
like configuration changes, while accessibility will not
function without views with unique ids. Separating out the
two types of IDs. We can re-combine them once it's clear
that both demands can be satisfied.

Bug: 62301218
Test: Run a11y and autofill CTS, and verify that the play
store app functions with TalkBack after a screen rotation.

Change-Id: I17a99de2874768fc0ade3aa354130dd1f6b4cd7e
2017-06-16 14:36:36 -07:00
Bryce Lee
02949f1415 Create native Surface object on updateWindow for legacy apps.
There are some apps that use the Surface object itself to indicate
changes. As a result, recycling the existing Surface object for
updates can lead to such apps ignoring events such as size changes.

This changelist restores the original behavior for legacy apps, where
the underlying native Surface object is recreated during updates.

Fixes: 62108743
Test: go/wm-smoke
Test: Open affected application, observe expansion to fullscreen when
      nav bar disappears. Rotate to other orientation and observe
      expansion to fullscreen.

Change-Id: I874602b6b8686c6ecb05cf7b1a04ec4b700ad3f9
2017-06-16 14:00:40 -07:00
Rob Carr
44be0d78b3 Merge "Merge "ViewRootImpl: More null checks for performTraversals." into oc-dev am: 6f87503ed8 am: c52b16c97d" into oc-dr1-dev-plus-aosp
am: ffb8035798

Change-Id: Ia47a2b128545b22e9dcbdd7273a2f71b07efa27b
2017-06-16 20:48:19 +00:00
Felipe Leme
c5d4e068f2 Trim text from autofillvalue when checking for empty.
Test: VirtualContainerActivityTest#testSaveDialogNotShownWhenBackIsPressed
Fixes: 62667931

Change-Id: I7e673eedd39fff7af89c694d0bfc5a495f14ea26
2017-06-16 13:41:37 -07:00
Rob Carr
37110b09af Merge "ViewRootImpl: More null checks for performTraversals." into oc-dev am: 6f87503ed8
am: c52b16c97d

Change-Id: I6343246eaffc1943d8748490acf51e682b1c5bee
2017-06-16 20:26:29 +00:00
Jonathan Solnit
6e8d70991c Check for keyguard occlusion on camera lift
Instead of just checking if the keyguard is locked, check that it's showing and
not occluded. Also add more logging.

Bug: 62386862
Test: Attempted lift gesture from the following states:
1. Locked
2. Suspended
3. Incoming phone call while locked
4. In phone call while locked
Change-Id: I55e75c695c9f1349ca16791a25029bf33477d7b7
2017-06-16 13:26:08 -07:00
Rob Carr
995f5240c9 Merge "ViewRootImpl: More null checks for performTraversals." into oc-dev
am: 6f87503ed8

Change-Id: I3c951fd2572abbada566494b5954697be098865d
2017-06-16 20:12:17 +00:00
Phil Weaver
149d958bd3 Merge "Stop rounded corners from confusing magnification" into oc-dr1-dev am: 9da5ee9e29
am: 364eb7bbb1

Change-Id: I267bdffd8599daf91dcc6c8a8b707fe3b756eee7
2017-06-16 19:59:02 +00:00
Rob Carr
6f87503ed8 Merge "ViewRootImpl: More null checks for performTraversals." into oc-dev 2017-06-16 19:55:12 +00:00
Phil Weaver
9da5ee9e29 Merge "Stop rounded corners from confusing magnification" into oc-dr1-dev 2017-06-16 19:34:18 +00:00
Vladislav Kaznacheev
dd469d171d Do not update currently open tooltip.
Currently if View.setTooltipText is called while
the tooltip is being shown for that view, it will
update the displayed text. The tooltip then will
resize to wrap around the new text, but not change
its position. This looks confusing if the new text
is significantly shorter or longer.

Removing this functionality until proper
re-positioning is implemented.

Bug: 38491655
Test: android.view.cts.TooltipTest passes
Change-Id: I79689288185888854b992b89e19fe381d3ac50e4
2017-06-16 11:31:23 -07:00