Fabrice Di Meglio
7c8b0e3532
am 9b3858be: am 88bb40b2: am 4253abbc: Merge "Fix bug #7274075 Non-functional CheckedTextView on Nexus 7 Jelly Bean 4.1.1" into jb-mr1-dev
...
* commit '9b3858be43cb08131af2c9e12d8db4bc0837ce4d':
Fix bug #7274075 Non-functional CheckedTextView on Nexus 7 Jelly Bean 4.1.1
2012-10-02 16:23:59 -07:00
Fabrice Di Meglio
9b3858be43
am 88bb40b2: am 4253abbc: Merge "Fix bug #7274075 Non-functional CheckedTextView on Nexus 7 Jelly Bean 4.1.1" into jb-mr1-dev
...
* commit '88bb40b2cb7c330c43a9b5b4f424ee567918152a':
Fix bug #7274075 Non-functional CheckedTextView on Nexus 7 Jelly Bean 4.1.1
2012-10-02 16:22:02 -07:00
Fabrice Di Meglio
88bb40b2cb
am 4253abbc: Merge "Fix bug #7274075 Non-functional CheckedTextView on Nexus 7 Jelly Bean 4.1.1" into jb-mr1-dev
...
* commit '4253abbcfa3165ad7d06c4de97cd780c4e96f94a':
Fix bug #7274075 Non-functional CheckedTextView on Nexus 7 Jelly Bean 4.1.1
2012-10-02 16:19:36 -07:00
Fabrice Di Meglio
5bb4e29aba
Fix bug #7274075 Non-functional CheckedTextView on Nexus 7 Jelly Bean 4.1.1
...
This regression has been introduced by this Change: Ia846de16bbc54f0729608259aa4b530da9404245
- in CHOICE_MODE_SINGLE you need to clear the checked states before doing anything
- rename variables for better readability too
Change-Id: I89b4390e5ebb192ca280fea2c06f991b537a2870
2012-10-02 15:53:00 -07:00
Adam Powell
5c68e4003b
am e9234dd1: am 075bb6b3: Merge "DO NOT MERGE - Revert fixes for ImageView/MeasureSpec/RelativeLayout" into jb-mr1-dev
...
* commit 'e9234dd1edc8988f41f1cb947e4df6e245d37cd1':
DO NOT MERGE - Revert fixes for ImageView/MeasureSpec/RelativeLayout
2012-10-01 16:00:11 -07:00
Adam Powell
e9234dd1ed
am 075bb6b3: Merge "DO NOT MERGE - Revert fixes for ImageView/MeasureSpec/RelativeLayout" into jb-mr1-dev
...
* commit '075bb6b3dfb9e58aa44c3b8588ab233a832956a3':
DO NOT MERGE - Revert fixes for ImageView/MeasureSpec/RelativeLayout
2012-10-01 15:56:58 -07:00
Adam Powell
946d05b95f
DO NOT MERGE - Revert fixes for ImageView/MeasureSpec/RelativeLayout
...
MeasureSpec.makeMeasureSpec has a bug where a negative or very large
size parameter will cause the resulting MeasureSpec value to
overflow. RelativeLayout partially relies on this when measuring
children with mode UNSPECIFIED; a default value of -1 in a local
variable ends up being passed to makeMeasureSpec, overflowing a mode
value to create a measurespec that is very large in size, with AT_MOST
as the mode. The correct behavior is for RelativeLayout to propagate
the UNSPECIFIED mode.
Unfortunately a number of custom view implementations in apps rely on
the buggy behavior as they do not implement their own onMeasure
method. This makes them fall back to View's default onMeasure
implementation, which accepts the spec's size unconditionally for
AT_MOST or EXACTLY modes, but falls back on
getSuggestedMinimum[Width|Height] for UNSPECIFIED. If the view had no
background drawable with dimensions and no minWidth field set, this
fix for RelativeLayout causes some views to measure with a size of 0
rather than a size of the 30-bit version of 0xFF...
Revert these fixes in the interests of compatibility. The next version
will conditionally use the new behavior if targetSdk > JB-MR1.
This also required reverting a fix for ImageView's adjustViewBounds
functionality, as it cannot be implemented reliably if this
RelativeLayout fix is not also in place.
Revert "Fix UNSPECIFIED measurement in RelativeLayout"
This reverts commit 132a742b94 .
Revert "Fix adjustViewBounds handling for ImageView"
This reverts commit d5edc77217 .
2012-10-01 15:06:46 -07:00
Fabrice Di Meglio
b788c84251
am 5fb54dad: am b67dff06: am a004f28a: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit '5fb54dada2d76266668deada1ea3d048304c5841':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-10-01 14:00:52 -07:00
Fabrice Di Meglio
5fb54dada2
am b67dff06: am a004f28a: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit 'b67dff065cfea410fba26fef758ac103ac8c9930':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-10-01 13:45:10 -07:00
Fabrice Di Meglio
b67dff065c
am a004f28a: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit 'a004f28aa4909add9d3b1070d437adafd6386c94':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-10-01 13:43:00 -07:00
Adam Powell
2831c963b4
am 5f260236: am 135ce20c: am fb42be77: Merge "Fix UNSPECIFIED measurement in RelativeLayout" into jb-mr1-dev
...
* commit '5f260236ed99a7e76ed1c65bd6e6dcf3b694e7d9':
Fix UNSPECIFIED measurement in RelativeLayout
2012-10-01 11:17:19 -07:00
Fabrice Di Meglio
51e1f8c2a0
am e05c1726: am 3332a701: am 10c84edc: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit 'e05c17263827fa26e63f83a82cb024af6b62900c':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-10-01 11:16:47 -07:00
Fabrice Di Meglio
639d09b466
am 840ea01f: am 93cea34a: am f2e5cf48: Merge "Fix bug #6427629 Clean up layout direction APIs" into jb-mr1-dev
...
* commit '840ea01fcbafe5d6b3fc8d90dcb5d99a65fa0113':
Fix bug #6427629 Clean up layout direction APIs
2012-10-01 11:16:35 -07:00
Adam Powell
5f260236ed
am 135ce20c: am fb42be77: Merge "Fix UNSPECIFIED measurement in RelativeLayout" into jb-mr1-dev
...
* commit '135ce20c12ef869028aa7d0182960f92840b7cfc':
Fix UNSPECIFIED measurement in RelativeLayout
2012-10-01 10:16:03 -07:00
Fabrice Di Meglio
e05c172638
am 3332a701: am 10c84edc: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit '3332a701e1cd6453089d7b0c6501c7f37cb69327':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-10-01 10:14:47 -07:00
Fabrice Di Meglio
840ea01fcb
am 93cea34a: am f2e5cf48: Merge "Fix bug #6427629 Clean up layout direction APIs" into jb-mr1-dev
...
* commit '93cea34a7f7834f42f921402415f7797b677e442':
Fix bug #6427629 Clean up layout direction APIs
2012-10-01 10:14:31 -07:00
Fabrice Di Meglio
b023a587ad
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
...
- add CheckedTextViewStyle with "viewStart" as default text alignment
- fix some typos
Change-Id: Ia8161c48faf579c89ba5ed49a436e4269178b8c1
2012-09-30 16:20:52 -07:00
Adam Powell
135ce20c12
am fb42be77: Merge "Fix UNSPECIFIED measurement in RelativeLayout" into jb-mr1-dev
...
* commit 'fb42be77ea88470c71f2ad1e03bff7fdc3721465':
Fix UNSPECIFIED measurement in RelativeLayout
2012-09-30 14:27:03 -07:00
Adam Powell
fb42be77ea
Merge "Fix UNSPECIFIED measurement in RelativeLayout" into jb-mr1-dev
2012-09-30 14:24:53 -07:00
Adam Powell
132a742b94
Fix UNSPECIFIED measurement in RelativeLayout
...
Explicitly handle UNSPECIFIED MeasureSpec mode.
Bug 7258418
Change-Id: Idc7b4f0a4a92505379eb5479a84665f7908fcb83
2012-09-30 12:42:46 -07:00
Fabrice Di Meglio
3332a701e1
am 10c84edc: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit '10c84edcfa674f13d798f4de65f95c76269c6191':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-09-30 11:37:00 -07:00
Fabrice Di Meglio
10c84edcfa
Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
2012-09-30 11:33:31 -07:00
Fabrice Di Meglio
47fb191841
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
...
- do not need those variables. Use what we already have in View.
- reset padding to initial values before changing it.
Change-Id: Ib396b3dca6e98a94d83a538a9b594b5eb426c453
2012-09-30 11:00:02 -07:00
Fabrice Di Meglio
93cea34a7f
am f2e5cf48: Merge "Fix bug #6427629 Clean up layout direction APIs" into jb-mr1-dev
...
* commit 'f2e5cf487e9bda4da1b902cb5c816ba48c9b7004':
Fix bug #6427629 Clean up layout direction APIs
2012-09-30 10:55:18 -07:00
Fabrice Di Meglio
f2e5cf487e
Merge "Fix bug #6427629 Clean up layout direction APIs" into jb-mr1-dev
2012-09-30 10:53:26 -07:00
Fabrice Di Meglio
343e11345e
Fix bug #6427629 Clean up layout direction APIs
...
- remove onPaddingChanged(int) and fold it into onRtlPropertiesChanged(int)
Change-Id: I1d7f02d2b4538c6c991bd4285501bbc73e6aa5c3
2012-09-28 18:26:07 -07:00
Adam Powell
7fb07337f8
am 4984ec72: Merge "Fix adjustViewBounds handling for ImageView" into jb-mr1-dev
...
* commit '4984ec7222d86a9b507a9961363bf50d2b72df1b':
Fix adjustViewBounds handling for ImageView
2012-09-28 17:09:51 -07:00
Fabrice Di Meglio
d35b2dc7cc
am be290dd8: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit 'be290dd850c8e2c31830e2a87205499586f55353':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-09-28 17:09:45 -07:00
Adam Powell
686d8e73ac
am 2e35df06: am 4984ec72: Merge "Fix adjustViewBounds handling for ImageView" into jb-mr1-dev
...
* commit '2e35df06e795e89af66850a9e12d9b1c53f9a53d':
Fix adjustViewBounds handling for ImageView
2012-09-28 16:22:35 -07:00
Fabrice Di Meglio
aab9914d0f
am 59294a26: am be290dd8: Merge "Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings" into jb-mr1-dev
...
* commit '59294a26b42dc56f71bd7d979a413dfdc3405f9c':
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
2012-09-28 16:19:53 -07:00
Adam Powell
4984ec7222
Merge "Fix adjustViewBounds handling for ImageView" into jb-mr1-dev
2012-09-28 16:15:36 -07:00
Adam Powell
d5edc77217
Fix adjustViewBounds handling for ImageView
...
When computing the adjusted view bounds, don't constrain the
dimensions by the original estimate if the opposite dimension has a
fixed size. This can result in the view never getting properly
enlarged.
Also fix a long-standing bug in MeasureSpec.makeMeasureSpec where
oversized or negative values could result in broken packed values.
Bug 7240251
Change-Id: I359d108ff52b6f3b5c4bf393d2271d28999c0127
2012-09-28 15:52:36 -07:00
Adam Powell
8b397d880f
am 2c8fb236: am 29dcd656: Merge "Track offset of center child view in Gallery for later layouts" into jb-mr1-dev
...
* commit '2c8fb236896ddfa626e14623d0ad55e72c34b79c':
Track offset of center child view in Gallery for later layouts
2012-09-28 15:52:04 -07:00
Svetoslav Ganov
149dc7137e
am 52cf248b: am 07ddb460: Merge "NumberPicker should adjust min and max when displayed values are set." into jb-mr1-dev
...
* commit '52cf248b32b50623b611b86ee41e67d07dc86efa':
NumberPicker should adjust min and max when displayed values are set.
2012-09-28 15:51:51 -07:00
Fabrice Di Meglio
15bbde41da
Fix bug #7199562 UI mirroring for RTL locales (Arabic, Hebrew, Farsi): Play settings
...
- fix padding issue. Need to update padding if layout direction change
Change-Id: I2924c1b94c7ef054dd9bd670de4c5c206f52e412
2012-09-28 15:49:38 -07:00
Adam Powell
04fc799196
am 29dcd656: Merge "Track offset of center child view in Gallery for later layouts" into jb-mr1-dev
...
* commit '29dcd656dfa4c22855b12fb6ee7d6e2e4c4844c1':
Track offset of center child view in Gallery for later layouts
2012-09-28 14:17:00 -07:00
Adam Powell
29dcd656df
Merge "Track offset of center child view in Gallery for later layouts" into jb-mr1-dev
2012-09-28 14:15:20 -07:00
Svetoslav Ganov
347a0d6c87
am 07ddb460: Merge "NumberPicker should adjust min and max when displayed values are set." into jb-mr1-dev
...
* commit '07ddb460afca09640e18b28bfedcaecfe5b2a838':
NumberPicker should adjust min and max when displayed values are set.
2012-09-28 14:11:29 -07:00
Adam Powell
4e8510b23f
Track offset of center child view in Gallery for later layouts
...
When apps request layouts while scrolling is in progress, Gallery
children can get offset in strange ways. Compensate for this by
tracking the last known offset and applying it during layout.
Bug 7245853
Change-Id: I9d746ae6bb06918e2d920c58052f72e749a7ffbf
2012-09-28 14:07:35 -07:00
Svetoslav Ganov
a1410e6789
NumberPicker should adjust min and max when displayed values are set.
...
1. The BumberPicker exposes APIs for settings displayed values for the
selected numbers. If the min and max value of the picker are less then
the length of the new displayed values array, i.e. they are out of
bounds, the NumberPicker crashes.
bug:7254000
Change-Id: I182e30216ef28c98d6541f9c985b43c8179dec76
2012-09-28 12:40:42 -07:00
Adam Powell
613479391b
am d3d5b033: am ae268392: Merge "Revert "Fix adjustViewBounds handling for ImageView"" into jb-mr1-dev
...
* commit 'd3d5b03362a4cb44c389eee7dc787a907b583109':
Revert "Fix adjustViewBounds handling for ImageView"
2012-09-28 00:37:22 -07:00
Adam Cohen
a2ba6f9202
am 080ee3ef: am 580ee8b0: Merge "Fixing AppWidgetService / AppWidgetHost to work in system process" into jb-mr1-dev
...
* commit '080ee3ef55ec32bc6a3254814f9fd717767dfa7e':
Fixing AppWidgetService / AppWidgetHost to work in system process
2012-09-28 00:33:42 -07:00
Adam Cohen
dd37f93b6c
am 21b5acc8: am 62d2d621: Merge "Fixing Keyguard widget click handling (issue 7179972)" into jb-mr1-dev
...
* commit '21b5acc8ab7e706286205639e2f4685d9bf4e551':
Fixing Keyguard widget click handling (issue 7179972)
2012-09-28 00:33:30 -07:00
Adam Powell
7a5f7ec2ad
am ae268392: Merge "Revert "Fix adjustViewBounds handling for ImageView"" into jb-mr1-dev
...
* commit 'ae26839257906e0c578b2a13479a8c0a8007bbbe':
Revert "Fix adjustViewBounds handling for ImageView"
2012-09-27 21:16:59 -07:00
Adam Powell
ae26839257
Merge "Revert "Fix adjustViewBounds handling for ImageView"" into jb-mr1-dev
2012-09-27 21:14:46 -07:00
Adam Powell
68f3eb3b56
Revert "Fix adjustViewBounds handling for ImageView"
...
This reverts commit b1271ac183
Revert this for now pending further investigation of bug 7248600
Change-Id: Ieb0a279fa2208f2aa575759dd6dd94476b471b8d
2012-09-27 21:05:17 -07:00
Philip Milne
ad365cc217
Optical bounds support for LinearLayout, TableLayout and TableRow.
...
The generic support for optical bounds provided in:
https://googleplex-android-review.googlesource.com/#/c/228269/
did not work correctly for nested LinearLayouts. With this fix
all the layouts in the APIdemos now seem to layout correctly
when the optical bounds mode is enabled.
(There's currently no, user level, way to do this. Instead, the
optical bounds layout mode has to be enabled on a per view basis.)
Change-Id: Id3d1d84445a8a2df277ddfe679c42f2d6cf775f4
2012-09-27 14:46:36 -07:00
Adam Cohen
d086ee036e
am 580ee8b0: Merge "Fixing AppWidgetService / AppWidgetHost to work in system process" into jb-mr1-dev
...
* commit '580ee8b0c6e1aea1e2e1d60499b603b9168b44f0':
Fixing AppWidgetService / AppWidgetHost to work in system process
2012-09-27 11:19:28 -07:00
Adam Cohen
580ee8b0c6
Merge "Fixing AppWidgetService / AppWidgetHost to work in system process" into jb-mr1-dev
2012-09-27 11:17:20 -07:00
Adam Cohen
672144f86d
am 62d2d621: Merge "Fixing Keyguard widget click handling (issue 7179972)" into jb-mr1-dev
...
* commit '62d2d62158e5be280e69e7620b8fb8a43a3cc26e':
Fixing Keyguard widget click handling (issue 7179972)
2012-09-27 11:14:47 -07:00