Commit Graph

181 Commits

Author SHA1 Message Date
Satish Sampath
b596dd0769 am aba34d96: Fix display of the selection background for search results.
Merge commit 'aba34d96fda75cbaaae19ce6296266feb24ce365'

* commit 'aba34d96fda75cbaaae19ce6296266feb24ce365':
  Fix display of the selection background for search results.
2009-06-11 07:57:27 -07:00
Satish Sampath
aba34d96fd Fix display of the selection background for search results.
I've used a simple approach of not drawing the solid background color for the selected item, thereby letting the default selection background to show through properly. This works by using the item's 'pressed' state and redraw code which are used by the listview during the tapping operation.
2009-06-11 10:24:26 +01:00
Android (Google) Code Review
4ceb232e19 am a05487dd: Merge change 3800 into donut
Merge commit 'a05487dd856222bacf57a41f2dfe1194d3776f05'

* commit 'a05487dd856222bacf57a41f2dfe1194d3776f05':
  Add SUGGEST_SPINNER_WHILE_REFRESHING column constant to the SearchManager
2009-06-11 01:03:05 -07:00
Mike LeBeau
ce0959df5c Add SUGGEST_SPINNER_WHILE_REFRESHING column constant to the SearchManager
for use in implementing Google suggestion refreshing in global search.
2009-06-11 00:41:55 +01:00
Android (Google) Code Review
64266658b6 am 09ea1e9c: Merge change 3715 into donut
Merge commit '09ea1e9cce29435282eb4c671cf6cebe26414e41'

* commit '09ea1e9cce29435282eb4c671cf6cebe26414e41':
  Show progress spinner while waiting for results in in app search.
2009-06-10 07:46:08 -07:00
Karl Rosaen
048d1a4821 Show progress spinner while waiting for results in in app search. 2009-06-10 14:17:21 +01:00
Android (Google) Code Review
7c2cfd50a2 am 9d19fdb2: Merge change 3576 into donut
Merge commit '9d19fdb231592904b6f8940355d89745719a1ea1'

* commit '9d19fdb231592904b6f8940355d89745719a1ea1':
  Track clicks that occur after pivoting into an app from global search.
2009-06-09 15:38:51 -07:00
Karl Rosaen
d4c98c4c45 Track clicks that occur after pivoting into an app from global search.
(framework portion).

Global search has a write-only content provider for reporting clicks that SearchDialog
makes use of.

update: addressed code review feedback
2009-06-09 18:51:05 +01:00
Satish Sampath
8762e0ac78 am 1c5fa0f3: Adds UI support for custom search widget item backgrounds.
Merge commit '1c5fa0f31009502c539c65de99010b63cb617aac'

* commit '1c5fa0f31009502c539c65de99010b63cb617aac':
  Adds UI support for custom search widget item backgrounds.
2009-06-09 08:03:06 -07:00
Satish Sampath
1c5fa0f310 Adds UI support for custom search widget item backgrounds.
- A new column was added to SearchManager cursors to specify background color (optional)
- Two new colour references added to the theme for normal and search widget corpus items (we need both to be opaque for the items to render properly)
- SuggestionAdapter was updated to choose the right theme colour for each item
2009-06-09 14:02:36 +01:00
Satish Sampath
5e23cbc660 am f9acde27: Include web search providers in Searchables.
Merge commit 'f9acde27486bcc6eea1092073f7b47c31749efd6'

* commit 'f9acde27486bcc6eea1092073f7b47c31749efd6':
  Include web search providers in Searchables.
2009-06-05 09:42:40 -07:00
Satish Sampath
f9acde2748 Include web search providers in Searchables.
- Along with ACTION_SEARCH we now enumate ACTION_WEB_SEARCH as well so web search providers are covered in the searchables list. This fixes a broken unit test.
- Moved get/setPreferredWebSearchActivity and get-all-web-search-providers implementation to this module when the searchables list gets updated, so that it happens on boot and on package add/remove events and remains up to date. The duplicate code in WebSearchProvider will be removed in a separate change.
- Also made Searchables broadcast an intent when the searchables list got rebuilt, so components such as GlobalSearch/SuggestionSources no longer need to do this on their own.
2009-06-05 10:34:53 +01:00
Android (Google) Code Review
9c4125e268 am 54de9063: Merge change 3243 into donut
Merge commit '54de90635e1d0628c396d65e6c948bf4a1529229'

* commit '54de90635e1d0628c396d65e6c948bf4a1529229':
  Fix backup agent unbind
2009-06-05 00:29:36 -07:00
Karl Rosaen
d0c3a61b07 am 320b2eee: SearchDialog should only do DialogCursorProtocol stuff when in global search mode.
Merge commit '320b2eeeea426dc06f7bb7f37c3d795babeb6adb'

* commit '320b2eeeea426dc06f7bb7f37c3d795babeb6adb':
  SearchDialog should only do DialogCursorProtocol stuff when in global search mode.
2009-06-04 22:41:22 -07:00
Christopher Tate
1885b37913 Fix backup agent unbind
The handwritten binder transaction passing wasn't propagating the agent-destroy
transaction to the client side.  Oops.

Also, remove obsolete run-one-agent code from the backup manager service.
2009-06-04 15:02:37 -07:00
Karl Rosaen
320b2eeeea SearchDialog should only do DialogCursorProtocol stuff when in global search mode. 2009-06-04 17:59:44 +01:00
Karl Rosaen
ebb03a78ce Detect impressions, and cleanup the SearchDialog / SuggestionCursor communication.
(framework portion)

There are now 4 times the search dialog will check with the cursor:
- after data set changed
- when an item is clicked
- when the cursor is about to be closed
- when an item at a particular position is detected as showing

these are now the points where we can add data in either direction, which we use to accomplish:
- finding out whether there are any pending results
- find out if there is a position at which to notify when it is displayed (the "more results" triggering)
- toggling the "more results" button
- sending the max position that was displayed when the cursor is done

the new behavior (in addition to the refactoring) is improved detection of "more results" to trigger the additional sources
(it is now precise), and detection of which items were displayed to the user.
2009-06-04 09:57:18 -07:00
Bjorn Bringert
c2c0bc6a90 Remove support for bitmap icons in search suggestions.
This is no longer needed, since content providers can now return
AssetFileDescriptors for in-memory data.
Bitmaps in the suggestion cursor was resopnsible for lots of
unnecessary copying, since all rows are copied out of the database
regardless of how many are displayed in the UI.
2009-06-04 09:57:18 -07:00
Mike LeBeau
20cd73ea54 Add INTENT_ACTION_WEB_SEARCH_SETTINGS (thereby fixing the build too :)). 2009-06-04 09:57:18 -07:00
Karl Rosaen
1c54cf0903 Detect impressions, and cleanup the SearchDialog / SuggestionCursor communication.
(framework portion)

There are now 4 times the search dialog will check with the cursor:
- after data set changed
- when an item is clicked
- when the cursor is about to be closed
- when an item at a particular position is detected as showing

these are now the points where we can add data in either direction, which we use to accomplish:
- finding out whether there are any pending results
- find out if there is a position at which to notify when it is displayed (the "more results" triggering)
- toggling the "more results" button
- sending the max position that was displayed when the cursor is done

the new behavior (in addition to the refactoring) is improved detection of "more results" to trigger the additional sources
(it is now precise), and detection of which items were displayed to the user.
2009-06-04 16:11:47 +01:00
Bjorn Bringert
3250fa7371 Remove support for bitmap icons in search suggestions.
This is no longer needed, since content providers can now return
AssetFileDescriptors for in-memory data.
Bitmaps in the suggestion cursor was resopnsible for lots of
unnecessary copying, since all rows are copied out of the database
regardless of how many are displayed in the UI.
2009-06-04 15:04:38 +01:00
Android (Google) Code Review
f762589d1f Merge change 3145 into donut
* changes:
  Add INTENT_ACTION_WEB_SEARCH_SETTINGS (thereby fixing the build too :)).
2009-06-04 06:10:37 -07:00
Mike LeBeau
3a27803b29 Add INTENT_ACTION_WEB_SEARCH_SETTINGS (thereby fixing the build too :)). 2009-06-04 14:09:42 +01:00
Mitsuru Oshima
342d59d319 am 9189cabb: * Moved supports-density tag under manifest * Refactored Compatibility code * Added CompatibilityInfo class * Removed getApplicationScale from Context * Added Resources#getCompatibilityInfo so that RootView can get the compatibility info w/o going through Context * Expandable support * Added expandable tag under manifest * Old application w/o expandable is given the default screen size ([320, 480] x density). * The non-expandable window is centered.
Merge commit '9189cabb0b6c6c28232fe6f412b7ba7a37352a6a'

* commit '9189cabb0b6c6c28232fe6f412b7ba7a37352a6a':
  * Moved supports-density tag under manifest
2009-06-03 16:34:47 -07:00
Mitsuru Oshima
9189cabb0b * Moved supports-density tag under manifest
* Refactored Compatibility code
  * Added CompatibilityInfo class
  * Removed getApplicationScale from Context
  * Added Resources#getCompatibilityInfo so that RootView can get the compatibility info w/o going through Context
* Expandable support
  * Added expandable tag under manifest
  * Old application w/o expandable is given the default screen size  ([320, 480] x density).
  * The non-expandable window is centered.
2009-06-03 16:28:10 -07:00
Bjorn Bringert
868443a947 am 33a22dc9: Close icon input stream in SuggestionsAdapter.
Merge commit '33a22dc9c84ef12006b0c12f6d169d2a74c15284'

* commit '33a22dc9c84ef12006b0c12f6d169d2a74c15284':
  Close icon input stream in SuggestionsAdapter.
2009-06-03 05:04:09 -07:00
Bjorn Bringert
33a22dc9c8 Close icon input stream in SuggestionsAdapter.
Before, SuggestionsAdapter would not close input streams after
reading icons from them. This leaks file descriptors and,
in the case of MemoryFiles, virtual address space.
2009-06-03 13:01:24 +01:00
Satish Sampath
ae8c5b868f am 8dbe612d: Adding internal method replacePreferredActivity.
Merge commit '8dbe612dc60526d635e57257b58627b33a099678'

* commit '8dbe612dc60526d635e57257b58627b33a099678':
  Adding internal method replacePreferredActivity.
2009-06-03 00:05:36 -07:00
Satish Sampath
8dbe612dc6 Adding internal method replacePreferredActivity.
This was required because we need a way to set the preferred activity for a
particular intent filter based on user selection (in our case the
ACTION_WEB_SEARCH intent filter for selecting the preferred search engine from
the list of available search engines providers). The current
addPreferredActivity call was not sufficient since it leaves the existing
preferred activities in the list and does not remove them, which this call
does.
2009-06-03 07:54:42 +01:00
Karl Rosaen
ba90ed49e5 am a058f02b: progress towards impression and click stats on all sources, plus some internal cleanup
Merge commit 'a058f02b591d971a829cb1e28d48a992e46ad85e'

* commit 'a058f02b591d971a829cb1e28d48a992e46ad85e':
  progress towards impression and click stats on all sources, plus some internal cleanup
2009-06-02 07:04:31 -07:00
Karl Rosaen
a058f02b59 progress towards impression and click stats on all sources, plus some internal cleanup
(framework portion)

suggestionCursor has new callbacks for impressions and clicks
- impressions now used to trigger "more" UI, cleanup apis around that

search dialog reports which position was clicked on via cursor#respond
- can now detect when sources under "more results" are clicked
- also used to simplify existing stuff:
  - can detect when "more results" entry is clicked and toggle base on that (no longer need INTENT_ACTION_CURSOR_RESPOND one off)
  - use response from click reporting to instruct which position should be selected
2009-06-02 15:00:37 +01:00
Android (Google) Code Review
8eff842066 am b3c3778e: Merge change 2844 into donut
Merge commit 'b3c3778edbc26affed9dc694f80412a85fe58d7b'

* commit 'b3c3778edbc26affed9dc694f80412a85fe58d7b':
  Added some icon debug logging to SuggestionsAdapter.
2009-06-02 01:32:34 -07:00
Bjorn Bringert
b791f34474 Added some icon debug logging to SuggestionsAdapter.
Good for checking that lazy contact photos works.
2009-06-02 09:29:34 +01:00
Android (Google) Code Review
93a7fb0753 am f5df8303: Merge change 2879 into donut
Merge commit 'f5df83035a45173f9ecdeaef03b68abc8a940ace'

* commit 'f5df83035a45173f9ecdeaef03b68abc8a940ace':
  Add backup side of new FullBackupAgent class
2009-06-02 00:36:44 -07:00
Android (Google) Code Review
f5df83035a Merge change 2879 into donut
* changes:
  Add backup side of new FullBackupAgent class
2009-06-01 19:30:54 -07:00
Christopher Tate
93e7e22ec9 Add backup side of new FullBackupAgent class
This class backs up an app's entire data directory tree.  Intended for use
by the backup-through-adb full mirroring facility, etc.  @hide because
it's not really something end apps will need to use.
2009-06-01 16:49:50 -07:00
Android (Google) Code Review
4dad4a3c3c am c17f16e3: Merge change 2851 into donut
Merge commit 'c17f16e33a0fca7efa10e758a526cd8d5d3a31f3'

* commit 'c17f16e33a0fca7efa10e758a526cd8d5d3a31f3':
  Change comment for SUGGEST_COLUMN_INTENT_EXTRA_DATA to clarify that
2009-06-01 14:51:43 -07:00
Android (Google) Code Review
c17f16e33a Merge change 2851 into donut
* changes:
  Change comment for SUGGEST_COLUMN_INTENT_EXTRA_DATA to clarify that this column is for use by global search only.
2009-06-01 14:50:26 -07:00
Mike LeBeau
21fd5f144a Change comment for SUGGEST_COLUMN_INTENT_EXTRA_DATA to clarify that
this column is for use by global search only.
2009-06-01 22:30:56 +01:00
Android (Google) Code Review
1f4c2951f1 am b249890b: Merge change 2835 into donut
Merge commit 'b249890bc6740531898d94aaecac34d5736106bc'

* commit 'b249890bc6740531898d94aaecac34d5736106bc':
  Add framework support for scrolling to the "More results..." list item
2009-06-01 14:23:46 -07:00
Android (Google) Code Review
b249890bc6 Merge change 2835 into donut
* changes:
  Add framework support for scrolling to the "More results..." list item when it is clicked.
2009-06-01 14:21:54 -07:00
Mike LeBeau
ae9760b62c Add framework support for scrolling to the "More results..." list item
when it is clicked.
2009-06-01 21:53:09 +01:00
Christopher Tate
ad6042aa23 am 181fafaf: Retool the backup process to use a new \'BackupAgent\' class
Merge commit '181fafaf48208978b8ba2022683ffa78aaeddde1'

* commit '181fafaf48208978b8ba2022683ffa78aaeddde1':
  Retool the backup process to use a new 'BackupAgent' class
2009-05-31 19:44:35 -07:00
Christopher Tate
181fafaf48 Retool the backup process to use a new 'BackupAgent' class
Backups will be handled by launching the application in a special
mode under which no activities or services will be started, only
the BackupAgent subclass named in the app's android:backupAgent
manifest property.  This takes the place of the BackupService class
used earlier during development.

In the cases of *full* backup or restore, an application that does
not supply its own BackupAgent will be launched in a restricted
manner; in particular, it will be using the default Application
class rather than any manifest-declared one.  This ensures that the
app is not running any code that may try to manipulate its data
while the backup system reads/writes its data set.
2009-05-31 13:10:03 -07:00
Android (Google) Code Review
0098ab97d6 am f0e7e4a9: Merge change 2520 into donut
Merge commit 'f0e7e4a9461ab3daf57ecfec3d25be583380d0d2'

* commit 'f0e7e4a9461ab3daf57ecfec3d25be583380d0d2':
  Cause the icon drawables to animate automatically by calling setVisible
2009-05-27 09:16:01 -07:00
Android (Google) Code Review
f0e7e4a946 Merge change 2520 into donut
* changes:
  Cause the icon drawables to animate automatically by calling setVisible false and then true on the drawables. For an AnimationDrawable, this will trigger the desired behavior of 'automatically' starting the animation, which should have been working to begin with according to the intended design of AnimationDrawable (see http://b/1878430 for my description of my correspondence with Romain). For Donut we'll just do this to work around it, but for a later release we need to decide a better story.
2009-05-27 09:13:15 -07:00
Android (Google) Code Review
b53bfd25f5 am ed6e0b92: Merge change 2522 into donut
Merge commit 'ed6e0b92dd8a42a67d0ffd5cb62d69a65dfcd051'

* commit 'ed6e0b92dd8a42a67d0ffd5cb62d69a65dfcd051':
  This function should be public
2009-05-27 05:54:13 -07:00
Jacek Surazski
fd0bdcc344 This function should be public 2009-05-27 14:45:48 +02:00
Android (Google) Code Review
c563beac06 am 298784cd: Merge change 2420 into donut
Merge commit '298784cd8a7ed77923bdb51de38c15e4c246a037'

* commit '298784cd8a7ed77923bdb51de38c15e4c246a037':
  This just makes it easier to derive from ApplicationErrorReport.
2009-05-27 02:19:21 -07:00
Android (Google) Code Review
298784cd8a Merge change 2420 into donut
* changes:
  This just makes it easier to derive from ApplicationErrorReport.
2009-05-27 02:17:21 -07:00