This is mostly a matter of flipping the flag, except for the case of
SystemWindows. While external SurfaceControlViewHost clients use the
leash provided by the SurfaceControlViewHost rather than the internal
ViewRootImpl surface, SystemWindows clients will use the actual
ViewRootImpl surface. This can conflict with the BLAST adapter setting
crop/frame/etc on this Surface. We modify SystemWindows to put
each layer inside a leash, and hand this out to other parts of SysUI
instead of the ViewRootImpl surface.
Test: Existing tests pass
Bug: 168505645
Change-Id: Ie621f89166f00ce385d450f1f1cea4d4abd1b805
This reverts commit cb98114abd.
Reason for revert: Not needed once ag/13507782 is merged
Bug: 169372603
Change-Id: I52d4344f6f2f3fb973f3f20e7d6f1ec2844d7567
Test: manually enter PiP
Atest cannot override include-annotation and exclude-annotation from the Android.xml, only append new ones.
Ideally we should have a single test configuration for all flicker tests (presubmit/postsubmit/flaky) and adjust the arguments according to the type of test we intend to run.
Presubmit:
atest FlickerTests -- --module-arg FlickerTests:include-annotation:android.platform.test.annotations.Presubmit --module-arg FlickerTests:exclude-annotation:androidx.test.filters.FlakyTest
Postsubmit:
atest FlickerTests -- --module-arg FlickerTests:include-annotation:android.platform.test.annotations.Postsubmit --module-arg FlickerTests:exclude-annotation:androidx.test.filters.FlakyTest
Flaky:
atest FlickerTests -- --module-arg FlickerTests:include-annotation:androidx.test.filters.FlakyTest
To run WMShellFlickerTests, just replace FlickerTests for WMShellFlickerTests in the commands above.
Bug: 170490377
Test: atest FlickerTests WMShellFlickerTests
Change-Id: Ic252f27065714e9039e3c0f33659b98eb288aa6f
We don't need to persist this because any bubble created
from persisted bubbles in the overflow wouldn't have a
notification to match with it anyways.
Test: atest BubblesTest
Bug: 178620678
Change-Id: I005704cce0e7205e254e71578d40f931c496e8f5
Those tests are right now flaky on flame and cannot be used in presubmit
Bug: 175687842
Bug: 179116910
Test: atest WMShellFlickerTests
Change-Id: I5e1b3075a63695fed006b2fb134b826447cb8d0c
The algorithm's icon arrangement logic was previously ran in
onBoundsChange, which could cause the icons to be misaligned
the very first time the menu is shown after being created.
This change ensures that the algorithm does an initial run
when the menu is first created.
Bug: 178708863
Test: manual - open YT PIP, tap to see menu, see the gear
icon is aligned to the top-start corner
Change-Id: I2cb53578db897af62be7ebd3ed40946e16606568
This adds the proper hook for framework to request PiP transition from
Shell and run the animation as needed. Currently only Enter using
3-finger navigation is supported, along with a KI that the PiP bounds
are not finalized at the end of the animation.
Bug: 165793917
Test: Enter PiP with ENABLE_SHELL_TRANSITIONS flag on
Change-Id: I0b992840ddcf8ddfcec9759a5cb06b630f1899a8
Some more details about how local and remote transitions
are dispatched.
Bug: 172695387
Test: enable shell transitions and look at logs
Change-Id: I9edff6e43287514557b10b558a94c3300d835157
This CL moves computeWindowBounds to the client side. The client can use
it to compute the frame hint on its own.
This can be a step to make client compute its window frame locally.
Bug: 161810301
BUg: 175858823
Test: atest WindowAddRemovePerfTest ActivityRecordTests
DisplayPolicyLayoutTests TaskSnapshotSurfaceTest
Change-Id: Ia5af1919b8e0e973646a63d1a4c3bf7ea7e2d1f6
- The actions container viewgroup should only be visible
when the menu state is FULL
- Update the PipMenuView mMenuState before updating the
action views so that the views reflect the actual new
state of the pip menu.
Bug: 179046413
Test: Enter PiP from Youtube, tap on where the pause
icon would be if the menu was visible, verify it doesn't
pause the video.
Change-Id: I97c55fc12b8eca21a4aa2a94d7890330ca543fc1
Refactor SizeCompatModeActivityController to WM Shell. The old one will
be removed in separate cl as there are some dependencies in other
packages.
This cl is mainly for refactor. Major change will come after.
Besides refactor, also changed the mActiveButtons key to TaskId, because
launcher Task will also trigger onTaskInfoChanged, but should not remove
the restart button on the same display.
Bug: 176061101
Bug: 178327644
Test: manually verify that the size compat restart button works as usual
Test: atest WMShellUnitTests:SizeCompatUIControllerTest
Test: atest WmTests:SizeCompatTests
Change-Id: I9143e079a1a945b76c3c56596976dd6ad2802897
Add interface for SizeCompatUIController in WM shell to use
when refactoring SizeCompatModeActivityController from system UI.
Bug: 176061101
Bug: 178327644
Test: atest WMShellUnitTests:ShellTaskOrganizerTests
Change-Id: I37f72396e1769b7773722be6575506fc430b2739
Enable tests ot be in presubmit, postsubmit or marked as flaky
Do not require flicker DSL changes
Bug: 162923992
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I74fdadaf5f6f08d96973683682297200eec6658d
These tests are flaky on both crosshatch and flame
Disable them from presubmit
Bug: 175687842
Bug: 179108356
Test: atest WMShellFlickerTests
Change-Id: I51e85238064e806106e68b47460836fd278cab3d
This is a work around for b/169372603 where PiP menu defaults the focus
on expand button when being attached to system window.
There is another inconsistency observed regarding of touch feedback
which may not be related to b/169372603 but worth mentioning
- when entering PiP and close button is shown, tap on PiP window shows
visual touch feedback
- when PiP menu in closed state, eg. nothing is shown in menu, tap on
PiP window shows no visual touch feedback
Video: http://rcll/aaaaaabFQoRHlzixHdtY/cLwTz7ad7P9nrrqk1uPiRP
Bug: 169372603
Test: Enter PiP from YT, see video
Change-Id: Ief8976fac28a65ac35724adcad7f25e11f1876a5
1) Integrate companion object inheritance and the default test runner
2) Move launch activity to setup: avoid noise of splash screen
3) Move setRotate() to setup: avoid noise of system windows
(LetterBox, NavBar, StatusBar...) visibility changes
4) Reducing test time of each test case: remove redundant transition
5) Remve redundant val for readibility
6) Remove navBarLayerIsAlwaysVisible assertion from split test
the rotation flow of enter split screen :
Overview(land) -> enter split(portrait) -> split mode(land)
7) Partially enable ROTATION_90 tests
8) Bypass visibleLayersShownMoreThanOneConsecutiveEntry assertion
for flaky reasons(Splash Screen, LetterBox, BackGestureSurface)
Test: atest WMShellFlickerTests
Bug: 176134495
Bug: 178685668
Bug: 178447631
Change-Id: I1d6153b987e5913a5d9a1fa5b72b9341b40db6fc
