Commit Graph

1344 Commits

Author SHA1 Message Date
Leon Scroggins
86e1fa647f Remove nativeCursorMatchesFocus, which is no longer necessary.
Bug:3335014

Requires a change in external/webkit.

Change-Id: I1dbaa73e86f312c6142c915e8cb252cf238f09c3
2011-01-10 17:28:02 -08:00
Huahui Wu
0904c0dcfb b/3302354 Always pass multi-touch events into WebKit, then handle them in WebView if preventDefault is not set.
WebViewCore.java: add a MotionEvent field into TouchEventData for multi-touch so the extra data such as pressure, size can be preserved.
WebView.java:
  1. Extracted the common code for multi-touch and single touch to a new private function: handleTouchEventCommon()
  2. Extracted the multi-touch code, including zooming and panning, to a new private function: handleMultiTouchInWebView()
  3. In onTouchEvent(), single touch events keep the code path, but multi-touch events are always passed to Webkit first.
  4. In Privatehandler.handleMessage(), if WebKit didn't consume the multi-touch event, the private handler calls the handleMultiTouchInWebView() to zoom and pan.

Change-Id: I3eba8812bd7cf6a298ff12e0b66223dae6725060
2011-01-10 15:22:03 -08:00
Leon Scroggins
19abf2d7a5 Do not store the find callback until action mode starts.
Bug:3331652

Prevents a bug where showFindDialog was apparently
called twice.

Change-Id: Ida473ef1b9b1b8b641fa3432b55d7a92eb7d0808
2011-01-10 15:29:01 -05:00
Leon Scroggins
9cac3c31d2 Remove the option to use shift to start selection mode.
Bug:3329956

Also ensure that keys dispatched while the WebTextView
is attached get sent to the WebTextView.

Change-Id: Icd9125a85929089a6f376b71c1cb40e885264168
2011-01-10 13:57:38 -05:00
Cary Clark
b74e32cc7d Merge "add more alt key acceleration in webview" into honeycomb 2011-01-10 09:55:54 -08:00
John Reck
36fd7a39ca Tweak user agent building to avoid multiple spaces
Bug: 3211038
 The building of the user agent could previously have multiple sequential
 spaces. This was causing the CTS test to fail.

Change-Id: I13fc76ba6b97ee84dd44461b4d03b6ca70b48cdf
2011-01-10 09:48:13 -08:00
Cary Clark
a3ee56f4ae add more alt key acceleration in webview
Make key accceleration exact; if alt is required,
allow only alt, and so on.

Also, set the touch point when nav'ing with the arrows
or trackball so that context menus have a point to
work with.

bug:3301564
bug:3241968
Change-Id: I574ce145941e84ac0934efd323d9db71eec11663
2011-01-10 11:20:56 -05:00
Leon Scroggins
aa6b9f55d6 Do not show autofill++ or saved form data in incognito mode.
Bug:2968399

Also do not save the form data in incognito mode.

Change-Id: Ice6a1cb3620b5cf272b6b361ce11f8abef269a89
2011-01-10 11:02:00 -05:00
Cary Clark
b9aaa776a6 scroll selected text in scrollable layers
Compute whether the initial tap point is in
a scrollable layer or not. If it is, get
the bounds of the scrollable layer and use them,
clipped to the view, to determine when the
select anchor is dragged close to the layer's
edge, to invoke autoscrolling.

Fix some bugs around stopping the autoscrolling
when there is nothing to do, and when a motion
up event is sent.

requires companion change in external/webkit

bug:3191699
Change-Id: Ic9229b063a8102ec93d0cd5bcaba774cc170c106
2011-01-10 09:10:25 -05:00
Svetoslav Ganov
c93fb656dc bug:3325039 Making the cursor ring movement send accessibility events.
1. Added a mechanism to select the cursor ring content if accessibility is
   enabled - This is achieved by sending an event to the WebCore thread
   (if accessibility is enabled) to select the content of the cursor when
   the latter moves. Added code in WebViewCore to select the given node
   and notify the UI thread for the selection markup which is delivered
   of the accessibility injector which manages sending accessibility
   events. This is relevant for adding accessibility to WebView if
   JavaScript is not enabled. (If JS is enabled we inject a screenreader
   written in JS).

2. Fixed the event delegation to the accessibility injector since it
   should be able to consume key events of interest and perform some
   action which leads to sending appropriate accessibility event.
   In the previous implementation it was possible that the injector
   consumes the event but the latter was bubbled up.

3. Added function to scroll the selection into view while moving it
   around based on user commands.

Note: This is a part of two project commmit.

Change-Id: Ibb81d0468726efbe3bf6e3add1b19c69e3206638
2011-01-07 14:04:22 -08:00
Leon Scroggins
2358623917 Merge "Do not update matches string when there are no matches." into honeycomb 2011-01-07 13:17:19 -08:00
Leon Scroggins
73254be0dd Do not update matches string when there are no matches.
Bug:2927451
Change-Id: I6374ffcc9d0710d69206d2f1f31a908b010a75bf
2011-01-07 15:51:43 -05:00
Steve Block
808751fe7a Avoid superfluous calls to CacheManager with the Chromium HTTP stack
When using the Chromium HTTP stack, most of the calls to CacheManager
methods are not required, as we're not using its cache. These methods
are now marked with asserts to make this clear.

Also avoid creating the cache database in WebViewDatabase.

This will avoid creating the database databases/webviewCache.db and
the directory cache/webviewCache.

Bug: 3270236
Change-Id: I68f94dde16830ed817454d5e1af961f41b71d018
2011-01-07 16:50:09 +00:00
Steve Block
5f6bcc17e9 Merge "Remove some superfluous null-checks when constructing a CacheResult" into honeycomb 2011-01-07 06:12:08 -08:00
Shimeng (Simon) Wang
e85ffea862 Make sure the reading level scale is within min/max limits.
This potentially helps the following issue.  But anyway, this change
is good to have.

issue: 3292648
Change-Id: I0ad74b802d7ce2c3d66de8115187638f1d5e72ff
2011-01-06 15:01:58 -08:00
Cary Clark
b83a4b98de Merge "pass enter key to webkit more often" into honeycomb 2011-01-06 11:29:33 -08:00
Cary Clark
ddbda005ad pass enter key to webkit more often
If the cursor is active and on a node that doesn't want
key events, treat the enter key as a click.

Otherwise, pass key down and key up to webkit.

A companion change in external/webkit adds frames
as nodes that wants key events.

bug:3325093
Change-Id: I134d2999505925ee1e571841759cb295103b5a30
2011-01-06 13:42:11 -05:00
Steve Block
7a1121511d Remove some superfluous null-checks when constructing a CacheResult
Change-Id: I57f0283872b788f84fef1667f79c37f4d92a5868
2011-01-06 17:20:21 +00:00
Steve Block
67ba204aa2 Tidy up CacheManager comments and documentation
Change-Id: I3a7d3836a51ef3092652ade87f29bc84af69ee7d
2011-01-06 17:20:21 +00:00
Steve Block
e7fc1d26c5 Remove an unused non-public CacheManager method
Change-Id: Ia0bef0a66167ce948802701e1dd85e82b937dbdf
2011-01-06 17:19:58 +00:00
Shimeng (Simon) Wang
22c5dfcaed Merge "Refactor zoom overview width calculation." 2011-01-05 13:05:29 -08:00
Leon Scroggins
67a08dda34 Merge "Show the keyboard when opening Find from the menu." 2011-01-05 12:57:37 -08:00
Leon Scroggins
ae0238cae5 Do not show past entries if autocomplete=off.
Bug:3300365

Requires a change in external/webkit.

Change-Id: I2f15d9dfce1002d0bf7a77a14605769fd654aa51
2011-01-05 15:42:20 -05:00
Leon Scroggins
eb492a02fd Merge "Do not open the keyboard when opening Find from CAB." 2011-01-05 11:14:58 -08:00
Shimeng (Simon) Wang
2c782e3d53 Refactor zoom overview width calculation.
Refactor zoom overview width calculation in FirstLayout and NewPicture;
also taking care of the case when wide viewport is not enabled.

This fixes the setInitialScale Cts test case, which is broken by some
scale related changed for fixed viewport browser.

issue: 3242034
Change-Id: Ie54d089763ee38029ef25e6029884a17c2135f97
2011-01-05 11:04:23 -08:00
Leon Scroggins
18cf9a7828 Show the keyboard when opening Find from the menu.
Bug:3324846
Change-Id: Ia8b1eea096660b3c01bc0ee3906ecc86ec1c20f3
2011-01-05 13:47:57 -05:00
Patrick Scott
624051aabf Use the app context to avoid a memory leak.
Bug: 3288583
Change-Id: Id259a0148c06f6e98b94c07e5d2e2296c6aef65a
2011-01-05 13:36:00 -05:00
Leon Scroggins
571354fd29 Do not open the keyboard when opening Find from CAB.
Bug:3312049

Do not start Find on page if the action mode fails to
start.  Clean up showFindDialog.

Requires a change to packages/apps/Browser

Change-Id: I204315665d3bf9f3ac78e78c4059c5a6f24695db
2011-01-05 13:31:02 -05:00
Cary Clark
2cdee23312 make select all, copy text public but hidden
For keyboard accelerators, add public interfaces
to copy text and select all.

bug:3270434
Change-Id: I4a38b95a373dcf73575f66fe13b082205d2423ce
2011-01-05 08:02:29 -05:00
Derek Sollenberger
1451862b0a Merge "Add full-screen support for OpenGL based plugins." 2011-01-04 13:42:41 -08:00
Derek Sollenberger
36a4f232c6 Add full-screen support for OpenGL based plugins.
bug: 3321891
Change-Id: Ief8ef6d3c4b9ea535054b80b84df080567b9b163
2011-01-04 16:05:43 -05:00
Svetoslav Ganov
12bed78d23 Fixing bugs 3315632 3235958, performing a clean up of the WebView accessibility feature. Updated event hadndling to deliver all key events to javaScript if a screen reader is injected since the latter is responsible for the full set of navigation and exploration actions.
Change-Id: Id1639828559161e0850dee04baa0a7afb2576ea8
2011-01-03 21:30:07 -08:00
Cary Clark
122da932e0 defer accelerator keys to hosting application
Allow the hosting application to do what they want if the
control key is pressed. In particular, let our Browser
map Ctrl-arrow to back and forward.

bug:3270434
Change-Id: I2dfa648edbf5a0e48b674df5023182b4a70985f6
2010-12-28 16:11:35 -05:00
Cary Clark
aa86ac82bc map keyboard for webview
Treat the numeric keypad enter as the regular enter for the
purposes of completing a text entry or activating the currently
selected link.

Add a little keyboard-related debugging.

Don't call select text to extend the selection if the tap
point hasn't moved.

A separate change to the Browser app adds more keyboard
accelerators.

bug:3270434
bug:3191699
Change-Id: I8a38b26196e93e344dc2a4b39a6968fe0c158d47
2010-12-28 11:36:09 -05:00
Kristian Monsen
9437d916f4 Only register one ProxyReceiver
Change-Id: I0a86a0149fd944faca775cca4360774d9cba250d
2010-12-24 11:59:09 +00:00
Kristian Monsen
6b91b45e31 Only store Application context
Context from an Activity are not meant to be store past the
lifetime of the Activity.

Fix for bug 3306898

Change-Id: Ib2f12cbdc3ec8aa0a6adf4770e6be4569fa6402c
2010-12-23 12:47:39 +00:00
Kristian Monsen
41e7e6f933 Retrying sending proxy changes to webkit
Now checking if the ProxyProperties object is null, and if the
string returned by getHost() is null.

Change-Id: I727e26c2a41fe057501c3b610ba6fa221d16da45
2010-12-21 14:32:35 +00:00
Huahui Wu
77788f8153 Revert "Merge "Send proxy changes on the webcore thread to WebKit""
This reverts commit ea8f4e0d66, reversing
changes made to fd4dda8d77.
2010-12-20 14:43:10 -08:00
Kristian Monsen
64a2f6bd06 Send proxy changes on the webcore thread to WebKit
Change-Id: I16995b4595e931715b064702ae570c387cf453f3
2010-12-20 17:46:20 +00:00
Kristian Monsen
c4d251bbe1 Merge "Remove WebView leak" 2010-12-20 06:04:51 -08:00
Kristian Monsen
4190aab1c9 Remove WebView leak
We were leaking the first WebView created since we kept a reference
in a static variable. Using the new way of sending messages in a
static method to avoid this.

Change-Id: Ibb665e32c22c16c17176cd69bf8f7e83fd94894f
2010-12-20 12:26:00 +00:00
Iain Merrick
c96235deb9 Deprecate CacheManager.
This class gives fairly low-level access to the HTTP cache, which
as far as we can tell was only exposed for the benefit of Gears.

BUG=3270236

Change-Id: Ibce10ecf8b524d3f472affa2a37fe4de15efd2ed
2010-12-17 16:43:01 +00:00
Kristian Monsen
1c602b3ee1 Merge "Add methods to send messages to the WebViewCore whithout having a reference" 2010-12-17 08:11:14 -08:00
Leon Scroggins
8a4fd2f8e7 Do not allow text selection if there is no ActionBar.
Bug:3276538
Change-Id: I060f14471e26e4bc1bf9773b847e0dbac9228426
2010-12-17 11:04:14 -05:00
Iain Merrick
b67529b905 Add setContentLength method to CacheResult.
This is needed to construct a cachable CacheResult object.
Currently only WebViewWorker is able to do this, by updating
the fields directly.

Bug: 3270236

Change-Id: I50148697dcee4d329e1436a2ce4c15224cb5ae30
2010-12-17 15:44:00 +00:00
Kristian Monsen
d4819a722b Add methods to send messages to the WebViewCore whithout having a reference
Change-Id: I8543e862e7a93651c3e3fa9bcefc8ea5f857a152
2010-12-16 18:14:46 +00:00
Iain Merrick
6a4d0a6af2 Merge "*Don't* disable CacheManager when using Chromium HTTP stack." 2010-12-16 08:52:14 -08:00
Iain Merrick
811665e905 *Don't* disable CacheManager when using Chromium HTTP stack.
This reverts CL https://android-git.corp.google.com/g/84508

After lengthy discussion we have decided that disabling CacheManager
is too risky for third-party apps, and that enough functionality is
still available for it to be useful.

WebView.loadUrl() will not add pages to the cache, but it is still
possible to add them manually via CacheManager.saveCacheFile().

Change-Id: I6cfd9f93bb8d685450f048375adad9d17fa4eeba
2010-12-16 16:31:44 +00:00
Kristian Monsen
d085e1c34f Merge "Fix for crash in third-party app" 2010-12-16 08:23:45 -08:00
Leon Scroggins
633567468a Do not remove WebTextView when focus size changed.
Bug:3244237
Change-Id: I3302a4c0544a19f0f96bce833010889c4742a3a0
2010-12-16 11:16:03 -05:00