Commit Graph

3347 Commits

Author SHA1 Message Date
Neil Fuller
71fbb81b14 Fix @code escapes
The body of {@code} must not be HTML escaped. This is one of
several changes that fix the source in conjunction with a
doclava fix.

Bug: 25757239
Change-Id: Ib38a0fa2dd2a3d68e467f78a812071e763d7e881
2015-12-02 14:24:11 +00:00
Yohei Yukawa
777ef95ebf Use Context.getSystemService(Class<T>) for InputMethodManager.
This is a mechanical replacement of Context.getSystemService(String)
with Context.getSystemService(Class<T>) when retrieving
InputMethodManager.  Note those are bundled code.  Hence we don't need
to make sure Build.VERSION.SDK_INT >= 23.

Change-Id: Icc64942ad8f11e44bf84f8d4fe476b2fdd1257f3
2015-11-26 00:02:05 -08:00
Tao Bai
dd337646a9 Using addAssetPathAsSharedLibrary to load asset.
This will alllow framework to overrdie the resource id even the
package resource is app.

Change-Id: I176166e7c51ceb5e84101deb3f467a826f484251
2015-11-06 14:43:12 -08:00
Gustav Sennton
8966460103 Merge "Load WebView from one out of a list of packages, reland." 2015-11-03 17:50:07 +00:00
Mikhail Naganov
9daceaf609 Small update to WebResourceRequest.isRedirect
Specify that 'isRedirect' is only true for server-side redirects.

Bug: 22346196
Change-Id: I9a8c31476c796265f554327dfff46778c5f84399
2015-11-02 15:38:29 -08:00
Mikhail Naganov
b851929c32 Add new version of WebViewClient.shouldOverrideUrlLoading callback
The new version provides more information about the origin of
the load, which helps making more secure decision on how to proceed
with it.

Bug: 22346196
Change-Id: I27f591bf5e846bde14335a2c929758a2b48d0763
2015-10-28 16:05:41 -07:00
Gustav Sennton
6ce92c9362 Load WebView from one out of a list of packages, reland.
Use a priority list of WebView packages instead of a single package to
determine which package to load WebView from.
This to allow Chrome to provide the WebView implementation.

Change-Id: I71813825cd977a72ff4535a39a97a12565ec8a09
2015-10-27 18:47:21 +00:00
Hui Shu
227a8c1df2 Add the APIs for customizing WebView action mode menu actions
We will allow apps to disable Share, Web Search, and text
processing related menu actions.

The default actions like cut, copy, paste cannot be disabled.

BUG: 22772178
Change-Id: I8429454f71f74a99298f412862cd32d8fba93784
2015-10-22 15:35:59 -07:00
Hui Shu
fb78ae50b5 Merge "Format the Javadoc using <p>" 2015-10-08 22:23:03 +00:00
Hui Shu
86ea9c1479 Format the Javadoc using <p>
Change-Id: I3c1ecf2f381e227cd413d6f3760a105ec521f807
2015-10-08 10:23:08 -07:00
Hui Shu
f119c5208f Allow WebView to startActivity and receive results
This CL makes webview override View#onActivityResult and gives webview
itnernals the access to View#startActivityForResult.

BUG: 24416313
Change-Id: Ia49db1348a1f5ee0c648a8b16551d9becc7caddd
2015-10-08 10:20:15 -07:00
Mikhail Naganov
b29e0f6960 WebView: add a note to the doc of WebView.loadDataWithBaseURL
Add a note that the base URL can be sent to servers in
the 'Referer' HTTP header.

Bug: crbug.com/506592
Change-Id: Idf77e898645fe130ad569bd266b61257c4f0e3b3
2015-09-16 13:05:53 -07:00
Torne (Richard Coles)
c0ae136be9 am 447da857: am e869b398: am 20272bec: am c207c943: am c5283927: Close ZipFiles correctly in WebViewFactory.
* commit '447da857463a80c83ae60857ddfaf61497db1ee1':
  Close ZipFiles correctly in WebViewFactory.
2015-08-10 16:27:05 +00:00
Torne (Richard Coles)
447da85746 am e869b398: am 20272bec: am c207c943: am c5283927: Close ZipFiles correctly in WebViewFactory.
* commit 'e869b3981506537dabbd1011df94f1e69ce84495':
  Close ZipFiles correctly in WebViewFactory.
2015-08-10 16:21:56 +00:00
Torne (Richard Coles)
c52839277b Close ZipFiles correctly in WebViewFactory.
We weren't closing the ZipFiles created in WebViewFactory to check
inside APKs - use try-with-resources to get them closed automatically.

Bug: 23072621
Change-Id: I11c6b77e960a7d240d19d22240cac177b6ba27b2
2015-08-10 16:40:50 +01:00
Selim Gurun
922cb58b65 Update onPause documentation
onPause() method documentation wrongly claims it stops JS. This could
have been true for very early implementations of Webview which does
not use V8 (pre-honeycomb) however it is not the case anymore
since V8 does not provide a way to stop JS safely for a particular Webview.

Change-Id: I6363dc2ef47c463da6baa417832da750225f5cf2
2015-07-31 14:02:57 -07:00
Tim Volodine
765fed146c am cd183953: am 15a4320e: am 2f6d6742: am 91b31b53: Merge "Revert "Invoke geolocation permissions callback with denied state by default."" into mnc-dev
* commit 'cd1839538f83b371716579b895bfadb1fda43dc9':
  Revert "Invoke geolocation permissions callback with denied state by default."
2015-07-27 18:19:02 +00:00
Tim Volodine
4961105a7d Revert "Invoke geolocation permissions callback with denied state by default."
This reverts commit 954d1333c4.

The revert is due to apps calling super.onGeolocationPermissionsShowPrompt see b/22685046

Bug: 22685046
Change-Id: I2a9f42b432a010828a0cafaee064480bb0f91cbe
(cherry picked from commit 0bb7d2e467)
2015-07-27 16:20:29 +00:00
Tim Volodine
08a38b68e9 Merge "Revert "Invoke geolocation permissions callback with denied state by default."" 2015-07-23 17:27:27 +00:00
Tim Volodine
0bb7d2e467 Revert "Invoke geolocation permissions callback with denied state by default."
This reverts commit 954d1333c4.

The revert is due to apps calling super.onGeolocationPermissionsShowPrompt see b/22685046

Change-Id: I2a9f42b432a010828a0cafaee064480bb0f91cbe
2015-07-23 17:16:16 +00:00
Mikhail Naganov
c39fb7e7a2 am 64a57dc1: am 4204ed96: am fa85a888: am abb8dc97: Merge "Enhance documentation of WebSettings.WebSettings method" into mnc-dev
* commit '64a57dc1b3caffc0fedbb670f0e93b3a6ef58176':
  Enhance documentation of WebSettings.WebSettings method
2015-07-09 17:59:37 +00:00
Mikhail Naganov
550f621aaf Enhance documentation of WebSettings.WebSettings method
Add a note about WebView reloading the page if the UA string is change
during loading. See crbug.com/315891.

Bug: 22325430

Change-Id: I04f5ab703fd2dcedf0709e4aa1d17b1204df355b
2015-07-07 13:39:48 -07:00
Richard Coles
4683bea8b6 am 2ec1f9d5: am 604e0cc7: am 2bb68288: am fad2e49c: Merge "Add WebView permission MIDI sysex" into mnc-dev
* commit '2ec1f9d594f0c5f95db08cbf04830b854e6c701c':
  Add WebView permission MIDI sysex
2015-07-07 17:34:17 +00:00
Richard Coles
fad2e49c42 Merge "Add WebView permission MIDI sysex" into mnc-dev 2015-07-07 10:15:17 +00:00
Narayan Kamath
c279a835d5 am 37c68894: am a78c0e0b: Merge "Fixed Javadoc typos"
* commit '37c688948d4464d636cd64c537b98697cb4b795d':
  Fixed Javadoc typos
2015-06-25 10:02:08 +00:00
Philipp Hasper
802aa0f8a2 Fixed Javadoc typos
Simple single character typos

Change-Id: I17660dbb3b7ee6597637e8d76770f434ebf202ea
2015-06-25 08:09:43 +00:00
Tao Bai
8965377b69 Add WebView permission MIDI sysex
Change-Id: I0d27e8ca48ee35b02dddc5d85ecfebfdaa3ec8cb
2015-06-23 11:05:59 -07:00
Selim Gurun
a679ac59a1 Clarify handling client certificates
Bug: 21910771

Clarify handling client certificates when using a webview. This is a
documentation change only.

Change-Id: Ida78bd89aa8867c99b4b9e4433e342767e9bac0d
2015-06-22 10:04:01 -07:00
Gustav Sennton
d973018221 Revert "Load WebView from one out of a list of packages."
This was not a clean revert!

This reverts commit 2ed6fee15c.
We essentially only revert the functionality for going through a list of
WebView package names and picking the first compatible one.
Except for that functionality we also fetched the name of the shared
library from a flag in WebView and made some minor refactoring in the
initial commit, these changes have been left alone in this revert.

Bug: 21893371
Change-Id: Idb2539dc33cc5f9e2894ecd665c23573c6cba9f3
2015-06-19 11:38:56 +01:00
Simon Baldwin
519919b0d4 Make apk entry separator compliant with jar url format
Bug: http://b/21726698
Bug: http://b/8076853
Change-Id: I4106dd82aeb5d7d66c9988be6e8c8726c78ae08c
2015-06-11 17:09:49 +01:00
Paul Miller
c8694a082a Deprecate WebView scrollbar overlay API
Deprecate setHorizontalScrollbarOverlay, setVerticalScrollbarOverlay,
overlayHorizontalScrollbar, and overlayVerticalScrollbar. They've been
no-ops for years, ever since WebViewChromium.

BUG:21642246
Change-Id: Ia1062c53fdbaa7a0d282ba79da733a6f3b9ac84f
2015-06-09 11:48:01 -07:00
Selim Gurun
50b26a5c27 Remove ViewAssistStructure and use the frameworks data structure
As part of the API rename from ViewAssistStructure to ViewStructure,
we added a temporary workaround to prevent build breakage. Remove
the temporary workaround since the current unbundled webview package
implements the updated  onProvideVirtualStructure API.

Change-Id: I13a5b8dee3e856eb585de53a0750bd52c7a909a7
2015-06-01 23:41:12 +00:00
James Cook
5cfaae4aae assist: Fix reported colors/styles for TextView/Switch
Changes to the data provided to AssistStructure:
* Text foreground color is correct even if the view has not yet been
painted.
* Text background color is now always 1 (TEXT_COLOR_UNDEFINED) for a
TextView, as it has no separate concept of background color.
* Switch now reports the text size/color/style of the label text
(usually user visible) rather than the on/off text on the button
itself (usually hidden in Material, and not usually revelant when
visible).

Bug: 21080375
Change-Id: I7e15f68d89510a76cab76031c2c8ca6ca3f32435
2015-05-28 15:52:44 -07:00
Selim Gurun
98fe09cba0 Clean remaining API related issues.
Bug:21063767
Change-Id: Ifb6936699367b4cc1641b74c890856c0b51978d2
2015-05-21 17:56:58 -07:00
Dianne Hackborn
2d9c6015b3 Merge "Fix issue #20679383: Add text style to assist.ViewNode..." into mnc-dev 2015-05-19 18:26:28 +00:00
Dianne Hackborn
02beb41c97 Fix issue #20679383: Add text style to assist.ViewNode...
...from text nodes in WebView

Add a new explicit API for setting the text style information associated
with a view structure.

Also, how about some documentation!

Change-Id: Ia948b2d66382b973d0d00a67172a281ad55ce592
2015-05-19 11:18:16 -07:00
Yohei Yukawa
c2cc6fff1b Merge "Keep IMM#mCurRootView synchronized with the actual window focus." into mnc-dev 2015-05-19 16:52:26 +00:00
Simon Baldwin
128b3c86c6 Merge "Handle load from APK correctly for shared relro" into mnc-dev 2015-05-18 14:57:22 +00:00
Simon Baldwin
b98082dcfb Handle load from APK correctly for shared relro
Update WebViewFactory's shared relro handling so that it operates
correctly where libraries are loaded directly from APK files.

Bug: http://b/20810492
Bug: http://b/8076853
Change-Id: I7887c7c0f235388d6a40c366693563b4876de992
2015-05-18 15:56:27 +01:00
Selim Gurun
26de90aa2e Rename PostMessageToMainFrame to PostWebMessage
Bug: 20557074

There is no need to keep the name PostMessageToMainFrame since
we may choose to not implement the special condition to posting
to a named subframe. And if we want, we can do this by overloading
the function.

Change-Id: I9896ad479e1c30cda500352cfdb1b7d336383568
2015-05-15 11:02:45 -07:00
Yohei Yukawa
5f05965f54 Keep IMM#mCurRootView synchronized with the actual window focus.
Currently IMM#mCurRootView is always cleared every time when
IMM#finishInputLocked() is called.  We have been doing this since
Iad09cf5dbb7f6f156fd39ed243431432e00f8945 so as not to hold the
strong reference to a DecorView so long time (Bug 6413553).

Strictly speaking, the attached window may continue holding
input focus even after IMM#finishInputLocked() is called.
In this state IMM#focusIn() might have unexpectedly rejected
focus-in event but presumably this might not be obvious, or might
not occur at all because in some situations IMM#finishInputLocked()
has never been called even when the attached view loses input
focus.

In order to fix Issue 20820914, however, we need to call
IMM#finishInputLocked() exactly when the attached view loses
input focus.  To make it easier to diagnose any unexpected
regressions, this CL only changes the handling of
IMM#mCurRootView, while the next CL Id6afc8fc64512225578c62557b96
plumbs IMM#focusOut() to IMM#finishInputLocked().

Manually tested following scenarios.
- Repro steps in Bug 6413553.  Made sure that IMM#mCurRootView
  is cleared after switching back from the current application to
  the previous application with back key.
- Test application that calls WebView#showFindDialog(). Made sure
  that LatinIME works fine when switching text fields.  This is
  non-trivial because android.webkit.FindActionModeCallback is
  changed in this CL.
- Repro steps in Bug 21144633.  Made sure that we can enter
  recipient's name in the messaging app.

Bug: 20820914
Change-Id: I219394178e4172bc47864297f1418e677dba25e5
2015-05-15 10:22:23 -07:00
Mikhail Naganov
6162eafe7a Tiny fix after updating the error reporting API
Temporarily make WebResourceError.getDescription() non-abstract
so the current version of WebView doesn't crash on it.

Bug: 20064008, 21063767
Change-Id: I15a1abb5df76263006d14eb589fe0076d5aac582
2015-05-14 13:30:13 -07:00
Wale Ogunwale
159c3d8a8b Revert "Update IME focus when the active view is losing the focus."
This reverts commit 97c3813042.

This causes issue with the right IME window getting focus.

Bug: 21144633
Change-Id: I4c75b6e7dd87c10f008444d2059164b52a8f4335
2015-05-14 12:25:24 -07:00
Mikhail Naganov
8d4f07f8d3 Update the new error reporting API in android.webkit
- minor changes in WebResourceError;
 - prepare to remove WebResourceResponseBase;
 - add immutable mode to WebResourceResponse.

Bug: 21063767

Change-Id: Iaf5f92e3850732c7a888453468e108809b3b782a
2015-05-13 18:40:20 -07:00
Selim Gurun
af9d60af0d Merge "Address API feedback for PostMessage" into mnc-dev 2015-05-13 22:37:02 +00:00
Yohei Yukawa
5ad7fe4930 Merge "Update IME focus when the active view is losing the focus." into mnc-dev 2015-05-13 22:10:37 +00:00
Selim Gurun
0a814b61e3 Address API feedback for PostMessage
Bug: 21043955

Add anchor tags, and hide the constructor for WebMessagePort.

Change-Id: Ibd2e15581c06be9015a3cd7c7741edf6657d4552
2015-05-13 14:14:14 -07:00
Hui Shu
d377c0f6ca Address API council feedback for setOffscreenPreRaster.
BUG: 21043955
Change-Id: I6481f5f84c9e00c16caeb2d9e175aa869600c715
2015-05-13 12:01:42 -07:00
Tobias Sargeant
ebc456691e Merge "Improve documentation and rename insertVisualStateCallback to postVisualStateCallback." into mnc-dev 2015-05-13 11:33:18 +00:00
Tobias Sargeant
b365604977 Improve documentation and rename insertVisualStateCallback to postVisualStateCallback.
Bug: 21043955
Change-Id: I077cad68fb519581387d1b474f27d43222f68e3b
2015-05-13 11:23:57 +01:00