Commit Graph

671 Commits

Author SHA1 Message Date
Sasha Kuznetsov
db44f628cd Merge "Revert^2 "Add GnssAntennaInfo framework APIs" + added fixes" 2020-02-11 22:29:33 +00:00
Soonil Nagarkar
77a9227b19 Fix work profile handling across location
There were a couple problems with work profile state in location. First,
we assumed that notifications sent to parent users would also be sent to
profiles but this is not true. Second we had assumed location status in
profiles was always identical to the parent user, but work profiles may
have user restrictions applied which are not present on the parent user.
The easiest way to handle these issues seems to be to expand LMS user
handling to deal with all users, rather than making various assumptions
which may or may not be true.

This also means we need to store last locations on a per profile basis.
Since we're refactoring how last location works completely, we also
removed the special NO_GPS handling for last locations. With the new
permission strings we now no longer have to exclude gnss based location
from coarsening. This lets us:

1) deprecate and remove various constants and methods use for storing
coarse locations tied to fine locations
2) substantially simplify code that calculated coarse location

This also exposed numerous bugs in the location service where we were
using the current user's state instead of the calling user's state,
which could have exposed the current user's location to other users
inappropriately.

Bug: 148798374
Bug: 146071833
Test: presubmits + manual
Change-Id: I2d3216a9fb58b73d0124d563b05de8870b70b716
2020-02-11 14:04:39 -08:00
TreeHugger Robot
e8759cc707 Merge "Deprecate Gps* APIs" 2020-02-11 21:31:50 +00:00
Sasha Kuznetsov
a68a7a3d23 Revert^2 "Add GnssAntennaInfo framework APIs" + added fixes
fef9247572

Test: End to end test: run "atest GnssAntennaInfoRegistrationTest" on cuttlefish and watch "adb logcat | grep -i GnssAntennaInfo". Other tests:  atest GnssAntennaInfoTest, atest GnssAntennaInfoProviderTest, atest GnssManagerServiceTest, atest VtsHalGnssV2_1TargetTest, atest LocationManagerFineTest.
Bug: 124556515
Change-Id: Ie1a8a60b9d7b9b95335bc84118639e33e0784ca1
2020-02-11 07:52:56 +00:00
Yu-Han Yang
eb1ae5b6bc Merge "Revert "Add GnssAntennaInfo framework APIs"" 2020-02-11 04:16:46 +00:00
Yu-Han Yang
fef9247572 Revert "Add GnssAntennaInfo framework APIs"
Revert "Add GnssAntennaInfo tests"

Revert submission 10111057-pco_pcv

Reason for revert: Build breakage
Reverted Changes:
I70e4014dd:Add GnssAntennaInfo framework APIs
I072958ecb:Add GnssAntennaInfo tests
Ia63a1f502:Add GnssAntennaInfo to HAL

Change-Id: I1934b1061737b417bb903f592c8f51cc65523747
2020-02-11 04:02:18 +00:00
Sasha Kuznetsov
1f11233375 Merge "Add GnssAntennaInfo framework APIs" 2020-02-11 02:54:40 +00:00
TreeHugger Robot
6757132332 Merge "LocationManager: move impl of setLocationEnabledForUser to server" 2020-02-11 00:06:26 +00:00
Sasha Kuznetsov
dcbeb75fc1 Add GnssAntennaInfo framework APIs
Test: End to end test: run "atest GnssAntennaInfoRegistrationTest" on cuttlefish and watch "adb logcat | grep -i GnssAntennaInfo". Other tests:  atest GnssAntennaInfoTest, atest GnssAntennaInfoProviderTest, atest GnssManagerServiceTest, atest VtsHalGnssV2_1TargetTest, atest LocationManagerFineTest.
Bug:124556515
Change-Id: I70e4014dd3959b0570c35bd2aa8bb839ef167d70
2020-02-10 12:29:19 -08:00
Yu-Han Yang
519694b50a Add fullTracking to registerGnssMeasurementsCallback (implementation)
- Currently enableFullTracking has a toggle in Developer Option.
This change adds a system API for the same functionality.
- If at least one of <enableFullTracking in Developer Option> and
<enableFullTracking from the system API> is true, full tracking is
enabled when registering a GnssMeasurement callback.
- For multiple GnssMeasurement callbacks, full tracking is enabled
if *at least* one callback has fullTracking enabled. Removing a callback
might trigger restarting the measurement collection if the aggregated
requirement has changed.

Bug: 147387008

Test: atest GnssMeasurementsProviderTest
      atest GnssManagerServiceTest
      atest GnssMeasurementRegistrationTest

Change-Id: Iedf03edd7053aa0089cfea0d5c0357322f68d9c4
2020-02-10 11:44:20 -08:00
TreeHugger Robot
b146099bc5 Merge "Add enableFullTracking to registerGnssMeasurementsCallback" 2020-02-08 00:44:36 +00:00
Yu-Han Yang
19e74855bb Deprecate Gps* APIs
- should use Gnss* APIs instead

Bug: 149111893

Test: annotation only and builds.
Change-Id: Ida2c61a746731cf0aae84fb69718943fd82e4d51
2020-02-07 14:39:33 -08:00
Yu-Han Yang
f5365989ff Add enableFullTracking to registerGnssMeasurementsCallback
- Internal implementation is in ag/10109000.

Bug: 148284818
Bug: 147387008

Test: builds and existing tests pass.
Change-Id: Ic276dcc8170a24d132770703b33bfc9762bf6b4f
2020-02-07 10:28:49 -08:00
Soonil Nagarkar
41a3654b00 Use compat framework for API behavior
Check compat API behavior using new compat APIs, also use
ActivityManager APIs to properly support user paramters on
APIs.

Bug: 145742912
Test: none
Change-Id: Ic86052b59764ad79404b78ba148aaf3220b3c1e5
2020-02-06 10:19:37 -08:00
Tim Murray
270296da83 LocationManager: move impl of setLocationEnabledForUser to server
Makes caching significantly easier.

Test: boots, works, gets location
Bug: 140788621

Change-Id: Ief39b3a985deea93e0e5f126863a3df383be5fd4
2020-02-05 16:12:17 -08:00
Muhammad Qureshi
e2b2432bc6 Use FrameworkStatsLog instead of StatsLog
As part of statsd becoming a Mainline module in R, autogenerated
StatsLog.write() calls are going away and replaced by
*StatsLog.java
that is autogenerated for each module.
This CL replaces some usages of StatsLog with
FrameworkStatsLog.

Bug: 145952197
Test: m
Change-Id: Iaa2db34a7be4c3215f62cc36661ba8ac81656baa
2020-02-03 09:17:40 -08:00
TreeHugger Robot
98bfaaf496 Merge "Remove setLocationExtra per API feedback" 2020-02-01 09:37:01 +00:00
Soonil Nagarkar
b6375a4f7f Create AppForegroundHelper
Create a new helper to deal with application foreground state changes.

1) Rename various Helpers.
2) Move GnssManagerService into location dir.
3) Use new AppForegroundHelper everywhere.
4) Move sendNiRequest to internal API
5) Some refactoring of NetInitiatedActivity

Test: atest AppForegroundHelperTest
Change-Id: Ifffe0e6a34452a18d017c6b190547b904d77b430
2020-01-29 15:23:06 -08:00
Sasha Kuznetsov
424ad90712 Merge "Update jni with measurement_corrections 1.1" 2020-01-25 23:31:42 +00:00
Soonil Nagarkar
56a2a44537 Remove setLocationExtra per API feedback
Bug: 142828735
Test: atest LocationManagerFineTest
Change-Id: I73193dc2484a2b8051c5cff42cd3fcec9a44a015
2020-01-24 13:32:26 -08:00
Soonil Nagarkar
980ce6a741 Add DPM API to request location provider enable
DPM can currently control the master location toggle, but cannot
influence the behavior of individual providers. This adds an API for
DPM (or other privileged entities) to request a provider to turn itself
on.

Practically, this is necessary to allow DPM to control network location,
which may be gated by additional consents. This change also renames some
internal location code to make clearer the distinction between provider
enabled and provider allowed: enabled = location on && allowed

Bug: 136219903
Test: CTS tests to be added
Change-Id: I05f03c976428f0f5a8a2cf627a84dc9e2baf3e67
2020-01-23 18:06:31 -08:00
Yu-Han Yang
c622cdf66c Merge "Add inter-signal bias fields to GnssMeasurement and GnssClock" 2020-01-23 20:35:28 +00:00
TreeHugger Robot
2b13f4e55f Merge "Add IRNSS svid range" 2020-01-23 18:41:40 +00:00
Sasha Kuznetsov
1ebf6158cf Update jni with measurement_corrections 1.1
Test: manually injected dummy measurement corrections in
GnssLocationProvider and verified that cuttlefish implementation
properly recieved them below the HAL
Bug: 145963440
Change-Id: Id659b0fdddd7852012da1bab07d0f26a3abb29af
2020-01-22 21:27:40 -08:00
TreeHugger Robot
34a0bef15b Merge "Fix parceling bug in ProviderRequest" 2020-01-23 01:13:14 +00:00
Yu-Han Yang
ad03c47369 Add inter-signal bias fields to GnssMeasurement and GnssClock
Bug: 147500886

Test: atest GnssMeasurementTest
      atest GnssClockTest

Change-Id: I8adaf1c1b0f6478695ca9b4768568af0ebfb11d4
2020-01-22 16:42:19 -08:00
Soonil Nagarkar
c3107caf22 Fix parceling bug in ProviderRequest
Forgot to add worksource write in addition to worksource read.

Bug: 148129736
Test: manual
Change-Id: Idac06b9191ada54bed0c79e9c799d8cd1ab0ebac
2020-01-22 14:58:16 -08:00
TreeHugger Robot
c9282b35de Merge "Support SBAS, QZSS and NAVIC navigation messages" 2020-01-22 21:31:08 +00:00
Yu-Han Yang
f81885b06a Support SBAS, QZSS and NAVIC navigation messages
Bug: 147768625

Test: atest GnssNavigationMessageTest
Change-Id: Icc788bd6762d3d8d75d7f92d3b233c05f329a104
2020-01-22 11:43:08 -08:00
TreeHugger Robot
1992ebada9 Merge "Make cN0Db and basebandCn0Db ranges consistent with HAL" 2020-01-22 18:04:30 +00:00
Soonil Nagarkar
4c0b85ba06 Overhaul FusedLocationProvider
Fix some minor bugs and ensure fused location provider correctly
supports location bypass. This is especially important for when
location bypass is invoked in direct boot.

The added UPDATE_DEVICE_STATS permission is necessary for FusedLocation
to correctly update WorkSources. FusedLocation receives work from LMS and
then further delegates that work to other location providers. The other
location providers should be informed of the correct applications for
battery blame, and should not be blaming the FusedLocation package.
1) This is the minimally scoped permission necessary to battery blame
correctly.
2) There is no way to attribute battery blame without this permission.
3) This is the correct permission - as required by LocationManager, and
this permission will likely never be removed (FusedLocation will always
need to battery blame).

Test: atest FusedLocationTests
Change-Id: If7126fffaae5577ddf8e366a0b5c17b3e5286582
2020-01-22 17:22:54 +00:00
Blake Kragten
439408699d Merge "Revert "GPS Atoms Addition"" 2020-01-16 17:18:11 +00:00
Blake Kragten
c7bdb71cc7 Revert "GPS Atoms Addition"
Revert "CTS GPS test"

Revert submission 9726785-1574459091307-c480d999

Reason for revert: Pushed atoms will be integrated into the new pulled atom.
Reverted Changes:
I9cbc8e41e: CTS GPS test
If8aed8f47: GPS Atoms Addition

Change-Id: I8d0a0b73d870a8d9fb02975df70f662de4fd1690
2020-01-15 18:57:33 -08:00
Yu-Han Yang
489465a687 Add IRNSS svid range
Bug: 147675678

Test: doc only and it builds.
Change-Id: I1c88475fd1673e173b3c62524b51ba566c08e85a
2020-01-14 10:55:01 -08:00
Soonil Nagarkar
8df02f452c Refactor providers/managers
Refactor how providers/managers are implemented in LMS, substantially
simplifying code, and opening up further simplification around
permissions in the next change.

Also, limit the number of additional packages providers can have, and
merge WorkSource into ProviderRequest so that providers can pass just
ProviderRequests around, not both.

Test: presubmits
Change-Id: Ic6fab46883cf53eb26368b54a824feac39c57a32
2020-01-09 14:52:50 -08:00
Yu-Han Yang
cb162534b6 Make cN0Db and basebandCn0Db ranges consistent with HAL
Bug: 136136192
Test: existing tests passing
Change-Id: I7ffc40f7f00e3d5e141d10025de6fe7886c61ba7
2020-01-08 12:19:34 -08:00
TreeHugger Robot
8cb0e1cfb7 Merge "Provide defaults and annotations for LocationListener" 2019-12-19 22:15:02 +00:00
Artur Satayev
53fe96661b Use new UnsupportedAppUsage annotation.
Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.

Bug: 145132366
Test: m && diff unsupportedappusage_index.csv
Change-Id: I4bc8c9482e4bb1af21363f951affff7ee3fefeab
2019-12-18 15:42:06 +00:00
Soonil Nagarkar
13cde9694d Provide defaults and annotations for LocationListener
Providing defaults allows lambdas to be used with LocationListener.

Bug: 146355527
Test: presubmits
Change-Id: Ic7b9575c2788b7fcfef91293aa2371a32621f761
2019-12-16 11:47:59 -08:00
Soonil Nagarkar
45cc8691a6 Merge "Remove logspam" 2019-12-10 23:28:33 +00:00
Soonil Nagarkar
76b1d81bfe Remove logspam
Remove upgrade message for getGpsStatus() which is called at a much
greater frequency than register/unregister.

Bug: 146003205
Test: n/a
Change-Id: I32adde8a8cffa649d373fb394b06ef294481c6cf
2019-12-10 13:42:18 -08:00
Wei Wang
c3fabdcad3 Merge "Expose FUSED_PROVIDER to test API." 2019-12-10 21:03:03 +00:00
Blake Kragten
0ce12c26c4 Merge "L5 metrics are not getting reset" 2019-12-06 22:40:37 +00:00
Blake Kragten
ccb7ad664d L5 metrics are not getting reset
Bug: 145769788
Test: On Device
Change-Id: If12dba3a75176ccb4c2bc25bbbbd003b19d92fb1
2019-12-06 09:47:31 -08:00
Soonil Nagarkar
06e37f67de Update location broadcast behavior
Updates location broadcast behavior in preparation for future changes
that will remove writes to LOCATION_PROVIDERS_ALLOWED. These changes
ensure that clients can properly listen for changes to provider enabled
status without being reliant on the deprecated
LOCATION_PROVIDERS_ALLOWED.

Bug: 145752928
Test: presubmits
Change-Id: I073749a895a6a206023290d83ea815a361353460
2019-12-05 12:22:57 -08:00
TreeHugger Robot
2e955bcb7d Merge "Add basebandCn0Dbhz to GnssMeasurement" 2019-12-04 00:54:05 +00:00
TreeHugger Robot
deaecab703 Merge "Add basebandCn0DbHz to GnssStatus" 2019-11-28 01:06:25 +00:00
Wei Wang
621e4cf504 Expose FUSED_PROVIDER to test API.
Test: it compiles
Bug:136079152
Change-Id: I921ae9ed75f2f4d44fda892be4a70bf23f40845c
2019-11-27 14:01:09 -08:00
Yu-Han Yang
9fe06ddab8 Add basebandCn0Dbhz to GnssMeasurement
The new basebandCn0DbHz is the carrier-to-noise density measured at the
baseband. The old Cn0DbHz is measured at the attenna port. Adding
the new field so that ecosystem will report both and avoid reporting
inconsistent signal strengths in one field. See go/r-gnss-hal for
detailed design.

Bug: 136136192
Test: atest GnssMeasurementTest
Change-Id: Ia8d3711e7422db5cae05d66138a3fae61bec0ae1
2019-11-26 14:29:07 -08:00
Yu-Han Yang
15e4303a5b Add basebandCn0DbHz to GnssStatus
The new basebandCn0DbHz is the carrier-to-noise density measured at the
baseband. The old Cn0DbHz is measured at the attenna port. Adding
the new field so that ecosystem will report both and avoid reporting
inconsistent signal strengths in one field. See go/r-gnss-hal for
detailed design.

Bug: 136136192

Test: atest GnssStatusTest
Change-Id: Idbfb611c6cb1c8d00c1f3bb719e422177a5ff7f2
2019-11-26 16:37:16 +00:00