Commit Graph

9381 Commits

Author SHA1 Message Date
Tim Murray
395ebcc9e2 Merge "RemoteViews: make bitmaps immutable" into tm-dev am: e9a0acdfda am: 5a06b288ea
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17803201

Change-Id: If65d33b0ce7d9918e73f11ff3599aac0d7d9ecec
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 19:05:19 +00:00
Tim Murray
e9a0acdfda Merge "RemoteViews: make bitmaps immutable" into tm-dev 2022-04-21 18:32:21 +00:00
TYM Tsai
8a938b948d Merge "Auto append password hint for TextView" into tm-dev am: 2ab23eed06 am: c1a483379b
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17750671

Change-Id: I806e9b7127a8f76f230302e8bb14932c66a975af
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-21 09:40:34 +00:00
TYM Tsai
2ab23eed06 Merge "Auto append password hint for TextView" into tm-dev 2022-04-21 08:13:10 +00:00
TYM Tsai
1f5c147eb5 Auto append password hint for TextView
Some TextViews are made as password via input type but does not
contain autofill password hint. This change auto append a hint
for autofill to identify.

Bug: 219844915
Test: atest android.autofillservice.cts.dialog.LoginActivityTest
Change-Id: Ifd18c56ffe788a601821d178ace41413f9e0454e
2022-04-20 03:55:33 +08:00
Tim Murray
21a8baaeb1 RemoteViews: make bitmaps immutable
Because mutability is propagated across Parcel and Binder, any mutable
Bitmaps passed to RemoteViews will end up mutable on the other side
even though those Bitmaps can't be modified from the RemoteViews
recipient.

Make all Bitmaps passed to RemoteViews immutable in order to ensure
that they can be sent without additional copies instead of the one
ashmem object.

Test: TH, RemoteViews work for widgets
Bug: 227920378

Change-Id: I477e7132f9ff78333c1eda56b9d0fc6ac520abd0
2022-04-18 18:36:02 +00:00
Vadim Caen
0b1c7631f3 Merge "Migrate PopupWindow to use OnBackInvokedDispatcher" into tm-dev am: 0ba48fea68 am: db68b7db77
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17105464

Change-Id: Ib7520afafe9e3b8fabb824cf2ed3c00fba374f6b
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-11 18:48:39 +00:00
Vadim Caen
a2173652a0 Migrate PopupWindow to use OnBackInvokedDispatcher
Bug: 219968356
Test: In BackTestApp, show popup window and swipe back to close it.
Test: CTS: android.widget.cts.BackInvokedOnWidgetsTest#popupWindowDismissedOnBackGesture
Change-Id: Ic22c12e2ed9f1c961f6e0abfdaf3d2a9a7bd2934
2022-04-04 16:02:38 +02:00
Vadim Caen
49c0dc04c5 Merge "Split animation methods out of OnBackInvokedCallback" into tm-dev am: d0923a2197 am: ce4cdf7989
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17523886

Change-Id: I13b53084f418b286b60ceffb3ab35a83bd44fa0c
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-01 20:28:11 +00:00
Vadim Caen
d0923a2197 Merge "Split animation methods out of OnBackInvokedCallback" into tm-dev 2022-04-01 20:13:30 +00:00
Vadim Caen
c627777dda Split animation methods out of OnBackInvokedCallback
This makes OnBackInvokedCallback SAM compatible

Bug: 227789359
Test: atest \
        CtsWindowManagerDeviceTestCases:android.server.wm.BackNavigationLegacyTest \
        CtsWindowManagerDeviceTestCases:android.server.wm.BackNavigationTests \
        WmTests:com.android.server.wm.BackNavigationControllerTests \
        FrameworksCoreTests:android.window.BackNavigationTest \
        FrameworksCoreTests:android.window.WindowOnBackInvokedDispatcherTest \
        CtsViewTestCases:android.view.cts.OnBackInvokedDispatcherTest
Change-Id: Iab86b0488f1b3048eb02042191acaeb6a645a0bc
2022-04-01 20:09:26 +00:00
Sally Yuen
8157012a66 Merge "Revert "Fixes for a11y selection". Reverts hiding some selection UI" into tm-dev am: b9d928eae3 am: cc2975c503
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17510341

Change-Id: I6775cdef5a4ebb926ba7db1dfced4f489ecb9da8
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-04-01 18:30:46 +00:00
Sally Yuen
b9d928eae3 Merge "Revert "Fixes for a11y selection". Reverts hiding some selection UI" into tm-dev 2022-04-01 18:14:37 +00:00
TYM Tsai
b0e4d5d743 Merge "Make TextView do not show IME when fill dialog popup" into tm-dev am: e6ae224102
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16984943

Change-Id: I3b892e4a120719e572908df4569d655addab38f2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-03-31 14:14:21 +00:00
TYM Tsai
e6ae224102 Merge "Make TextView do not show IME when fill dialog popup" into tm-dev 2022-03-31 14:09:17 +00:00
Sally Yuen
8021a8fb09 Revert "Fixes for a11y selection". Reverts hiding some selection UI
This reverts commit 55022a5880.

Reason for revert: b/226418848
Test: builds

Change-Id: Id709d131754e14a67805ee981bc5ad0bc759121f
2022-03-30 22:12:57 +00:00
Shan Huang
9d4a7ed133 Merge "Migrate MediaController to use OnBackInvokedDispatcher" into tm-dev am: 116b6300d0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17344424

Change-Id: I9919101df820a276588194f6a3d2e2c83cfc6cda
2022-03-24 18:37:47 +00:00
Shan Huang
116b6300d0 Merge "Migrate MediaController to use OnBackInvokedDispatcher" into tm-dev 2022-03-24 18:14:27 +00:00
Joanne Chung
af1fff3994 Merge "Fix the translation not work if the animation is off" into tm-dev am: 8121a43efd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17240423

Change-Id: I99c3e48c94e6dc27cd3da3d996643c83ba9f405b
2022-03-24 13:24:42 +00:00
Joanne Chung
8121a43efd Merge "Fix the translation not work if the animation is off" into tm-dev 2022-03-24 13:15:40 +00:00
Shan Huang
9a12be2b47 Merge "Migrate TextView to use OnBackInvokedDispatcher." into tm-dev am: 1506886e06
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17070232

Change-Id: Iafff83962cfdccecbd49f86ce54c9aabf019f778
2022-03-24 07:55:43 +00:00
Shan Huang
1506886e06 Merge "Migrate TextView to use OnBackInvokedDispatcher." into tm-dev 2022-03-24 07:41:49 +00:00
Joanne Chung
fe6fddb4f0 Fix the translation not work if the animation is off
The system will show translation after the animation is done but it
doesn't work if the animation is off. To fix the issue, we will
check the animation status before showing translation.

Bug: 215386127
Test: atest testUiTranslationWithoutAnimation

Change-Id: Id0d02c422100effcf842209971052f4d6e9b0bd2
2022-03-24 14:55:15 +08:00
Shan Huang
76561c0ce8 Migrate TextView to use OnBackInvokedDispatcher.
The OnBackInvokedCallback will be called when an app is requesting the new back dispatch behavior. Otherwise we keep dispatching KEYCODE_BACK to TextViews.

Test: Use backTestApp WidgetTestsActivity. Try selecting texts and
dimisss selection by swiping back. Both on TextView and EditText and
AutoCompleteTextView.

Change-Id: I9422f28ab650c5d77c75394fe6dcf2a3981f79c7
2022-03-23 22:37:40 +00:00
Shan Huang
18eec9cf40 Migrate MediaController to use OnBackInvokedDispatcher
The OnBackInvokedCallback will be called when an app is requesting the new back dispatch behavior. Otherwise we keep dispatching KEYCODE_BACK to MediaController.

Test: In BackTestApp, try dismissing media controller by swiping back, both in new and legacy back dispatch.

Change-Id: I9ad3c199277838639c875c78a3a8dfb0963b3ca4
2022-03-23 22:33:36 +00:00
TYM Tsai
8f502801e1 Make TextView do not show IME when fill dialog popup
Make to show fill dialog only if IME is not showing. And if the field
will show fill dialog, ignore to show ime when clicks on the field.

Bug: 210926084
Test: Manual
  launch sample and click on password field -> show fill dialog
  click on username field (no fill dialog) -> show fill UI and IME
  IME is showing and click on password field -> show fill UI
Test: atest android.autofillservice.cts.dialog.LoginActivityTest
Test: atest android.widget.cts.EditTextTest
Change-Id: I6080510d87c50969d85fd9ed746ceba7e3c1c685
2022-03-23 15:02:12 +08:00
Sally Yuen
91b35e23ed Merge "Fixes for a11y selection" into tm-dev am: 8c3314f7aa
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17198946

Change-Id: I3792d41a856095cfadf37aa3b17eb2189a4bc6c7
2022-03-22 20:22:21 +00:00
Sally Yuen
8c3314f7aa Merge "Fixes for a11y selection" into tm-dev 2022-03-22 20:15:13 +00:00
Allen Su
508818fc58 Merge "Text Wrapping automation" 2022-03-22 05:44:23 +00:00
allenwtsu
f70429088a Text Wrapping automation
Bug: 220836284
Test: atest StaticLayoutTest
Change-Id: I2aead872b0b472b3c625e075348e46da768ff3be
2022-03-22 11:16:57 +08:00
Haoyu Zhang
b297b94fb1 Merge "Scribe in View: disable cursor drag when handwriting is enabled" into tm-dev am: b3c1d1984e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17199134

Change-Id: Iefae63d41b1cdfaa44c95cbf46dfdf3779ecfde8
2022-03-21 20:21:09 +00:00
Haoyu Zhang
b989691d71 Scribe in View: disable cursor drag when handwriting is enabled
Bug: 224587325
Test: manually tested
Change-Id: I607c0d9b71cb6cfd69704d850a2d3e00745c3fb4
2022-03-16 23:02:09 +00:00
Sally
55022a5880 Fixes for a11y selection
- TextView should request focus before performing selection on
  non-editable text, since selection requires focus. On the a11y
  service side, input focus should not matter when selecting
  non-editable text.
- Remove clickable and long-clickable states, since these are present
  due to TextView#setTextIsSelectable.
- Make UI controller changes consistent between SET_SiELECTION and
  SET_TEXT. Using SET_SELECTION means the action mode menu won't pop up
  and the left/right selection handles won't appear. Interactions
  between multiple EditTexts were previously inconsistent

- Delete some obsolete javadoc

Bug: 218357385
Test: builds and install: highlighting is consistent between SET
actions. highlighting works when selecting text in TalkBack, without
the service needing to purposely put input focus,
atest AccessibilityTextTraverssalText

Change-Id: I67986020aa112d45bd670f77b2b415617226c094
2022-03-16 22:01:19 +00:00
TreeHugger Robot
e8acb4a612 Merge "Update the text wrapping API." into tm-dev 2022-03-14 23:09:41 +00:00
Taran Singh
88af2f0b91 Merge "Use local coordinates in CAI#EditorBoundsInfo" into tm-dev am: a28f53b00d am: 90b0d74d60
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17049973

Change-Id: I8baa4cbeed48f03025bc6ce29c0812f4280d9c32
2022-03-10 20:03:52 +00:00
James.cf Lin
396c789426 Update the text wrapping API.
1) Update the LineBreakConfig class to be immutable.
2) Do not return null in the PrecomputedText.Params#getLineBreaiConfig API

Bug: 216638444
Test: atest TextViewTest; atest MeasuredTextTest; atest PrecomputedTextTest; atest TextViewPrecomputedTextTest; atest StaticLayoutLineBreakingVariantsTest
Merged-In: I93bcb6ebc35344e34e9bb8a24df375aa7b3a8d81
Merged-In: I07766137ff6639c7d4acaad07dbcf11a2841cdb0
Change-Id: I07766137ff6639c7d4acaad07dbcf11a2841cdb0
2022-03-10 09:58:40 +00:00
Taran Singh
a28f53b00d Merge "Use local coordinates in CAI#EditorBoundsInfo" into tm-dev 2022-03-10 08:06:26 +00:00
yingleiw
a3a06ac231 Rename ACTION_SHOW_SUGGESTSIONS TO ACTION_SHOW_TEXT_SUGGESTIONS
Fix: 217730256

Bug: 222537368

Test: Added test in EditTextTest (will merge later when reviewed).

Merged-In: I78354a0f1d955c5b7c1ead044ea49086b3479841
Change-Id: I78354a0f1d955c5b7c1ead044ea49086b3479841
(cherry picked from commit e1f392d171)
2022-03-04 16:42:54 -08:00
Julia Tuttle
1c472e50c9 RemoteViews: don't crash on null display in getLaunchOptions
While we investigate the root cause of this bug, turn the crash into a
warning.

Bug: 218409359
Test: none; we don't have repro steps for the bug yet
Change-Id: I6d699ea839726adc634a200a0057e316d59ecaa9
(cherry picked from commit 827d967199)
2022-03-04 19:45:27 +00:00
Chavi Weingarten
8a93d1378a Merge "SurfaceView: Synchronize all surface view changes with VRI draw" into tm-dev am: 5dcd46d356
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17051013

Change-Id: I8081b90e365829921634576d05b770ea5d572898
2022-03-03 18:25:15 +00:00
Chavi Weingarten
5dcd46d356 Merge "SurfaceView: Synchronize all surface view changes with VRI draw" into tm-dev 2022-03-03 17:57:05 +00:00
Taran Singh
25854407be Use local coordinates in CAI#EditorBoundsInfo
EditorBoundsInfo uses local coordiantes, it was mistakenly set with
screen coordinates

Test: atest InputMethodServiceTest
Bug: 217957587

Change-Id: Iadeaa793d1331b6208e4b19036c45120b0185f64
2022-03-03 17:47:01 +00:00
Vishnu Nair
797aa0066c SurfaceView: Synchronize all surface view changes with VRI draw
Re landing with the following changes:
We initially cloned the SurfaceControl handle to avoid locking when
accessing the SurfaceControl from the position listener callbacks
running from RT workers. But this meant the last reference to the
layer handle would only be released by GC. If SurfaceViews are
created and destroyed rapidly, we would be at the mercy of GC to
release buffers.

Original change:

There are three transaction queues that can submit SurfaceView
changes.

1. Buffer updates via BBQ apply token
2. SCC apply token
3. ViewRootImpl BBQ apply token

It makes sense for most SurfaceView changes to be synchronized with
ViewRootImpl draws since the caller can optionally synchronize the
change with main window content.

This change eliminates the tmp transaction that is applied directly
via the SCC apply token and instead applies them with the ViewRootImpl
draw transaction.

Also take the opportunity to scope down mSurfaceControlLock usage.

Test: atest SurfaceViewSyncTest
Test: go/wm-smoke
Test: run mem tests via forrest
Bug: b/217973491, b/221631942
Change-Id: Idba712d146e62d7346920dc4f060cba92d47fada
2022-03-03 16:07:15 +00:00
TreeHugger Robot
dc71c6ebf3 Merge "Incorporate API feedback: CAI requestCursorUpdates()" into tm-dev am: 33a2b4bacd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/16977626

Change-Id: I29837bf7a2474d1e1f8e4562a54ecc94d50f027b
2022-03-03 13:38:47 +00:00
TreeHugger Robot
33a2b4bacd Merge "Incorporate API feedback: CAI requestCursorUpdates()" into tm-dev 2022-03-03 13:27:04 +00:00
TreeHugger Robot
97eae7e16c Merge "Revert "SurfaceView: Synchronize all surface view changes with V..."" into tm-dev am: 1f014a4a51
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/17048246

Change-Id: I1a66c41dd432f1077bf397c347566ed9d4ce43d7
2022-03-01 23:52:51 +00:00
TreeHugger Robot
1f014a4a51 Merge "Revert "SurfaceView: Synchronize all surface view changes with V..."" into tm-dev 2022-03-01 23:50:49 +00:00
TreeHugger Robot
148fc78a9d Merge "RemoteViews: don't crash on null display in getLaunchOptions" 2022-03-01 21:19:31 +00:00
Taran Singh
472e5c3825 Incorporate API feedback: CAI requestCursorUpdates()
1. Use intDef for CurosrUpdateFilter
2. overload requestCursorUpdates(mode, filter)
3. additional details in javadoc

Fix: 218314883
Bug: 210039666
Test: atest CtsInputMethodTestCases

Change-Id: I1dc5acac4f968b2a2d1780f2ee6c0145c7dcbbaa
2022-03-01 19:05:50 +00:00
Vishnu Nair
8dfd38ad76 Revert "SurfaceView: Synchronize all surface view changes with V..."
Revert "SurfaceView:  Avoid destination frame updates on multipl..."

Revert submission 16944940-sv-changes-tm-dev

Reason for revert: b/221631942
Reverted Changes:
I0d214e3f7:SurfaceView:  Avoid destination frame updates on m...
I0b5741b37:SurfaceView: Synchronize all surface view changes ...
I5226c304b:SurfaceView: Avoid destination frame updates on mu...

Change-Id: I35b7c1be7202ebe89a5309284a9401c8084e9d79
2022-03-01 18:55:13 +00:00