Commit Graph

2260 Commits

Author SHA1 Message Date
Luca Zanolin
535698c57d Remove the mic from the keyboard in SearchView
Bug: 5357750
Change-Id: I20c87a25e95222772c6b5154d09dd681b966fd9a
2011-10-06 13:36:15 +01:00
Fabrice Di Meglio
764041d213 Fixbug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)
- make VERY_WIDE bigger ... 64 times actually

Change-Id: I1a177ef5821d9341abb77ea69a50e05a5bfc97b5
2011-10-05 16:28:18 -07:00
Fabrice Di Meglio
e921572bda Merge "Revert "Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)"" 2011-10-04 17:24:37 -07:00
Fabrice Di Meglio
ad0b051b13 Revert "Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)"
This reverts commit a130e5f59d
2011-10-04 17:21:26 -07:00
Gilles Debunne
8c60235b55 Merge "5402566: Copy/cut icons do not appear if the text is Japanese only" 2011-10-04 10:51:13 -07:00
Gilles Debunne
a13a322e09 Merge "Optimisations and bugs in SpellChecker" 2011-10-04 10:50:54 -07:00
Gilles Debunne
8f3105ff9b 5402566: Copy/cut icons do not appear if the text is Japanese only
When the word iterator return an empty range, select an arbitrary
character so that cut/copy icons are available.

Change-Id: I16e5a3c7f10886db967d870706da7f2d690af013
2011-10-03 18:34:28 -07:00
Svetoslav Ganov
2588a07730 Merge "The logic for not populating text to some accessibility events is scattered." 2011-10-03 18:33:32 -07:00
Svetoslav Ganov
0058f724eb Merge "Accessibility services cannot obtain the source of an event coming from a root namespace descendant." 2011-10-03 17:43:39 -07:00
Gilles Debunne
e1fc4f6c3c Optimisations and bugs in SpellChecker
A bug was introduced in a recent refactoring: correct words didn't have their
SpellCheckSpan removed, leaving a lot of useless spans.

SPAN_EXCLUSIVE_EXCLUSIVE should never have a 0-length. With Japanese characters
wordStart could be equal to wordEnd when parsing the text: skip these.

Using toString().substring(...) instead of subSequence(...).toString() which
is more efficient.

Change-Id: I670870a34565939b676400091f4852152a7f7124
2011-10-03 17:03:57 -07:00
Svetoslav Ganov
2cdedffcfa Accessibility services cannot obtain the source of an event coming from a root namespace descendant.
1. The user can touch the screen at an arbitrary location potentially crossing the root namespace
   bounday which will send an accessibility event to accessibility services and they should be able
   to obtain the event source. Also accessibility ids are guaranteed to be unique in the window.
   Added a package scoped findViewByAccessibilityId method that dives into nested root namespaces.

2. Added accessibility support to the AnalogClock.

bug:5405934

Change-Id: I84edcb554bae41aafcbbc2723c5e62c1ef8a6ddf
2011-10-03 15:07:44 -07:00
Adam Powell
d2b58940f7 Don't obtain attributes for the whole theme when looking for selection
mode drawables.

Change-Id: I82d327e8fcf67baa557245982b2b5ba76ffa9fec
2011-10-03 13:42:41 -07:00
Gilles Debunne
f00b4decc3 Merge "Bug 5327547: re-check word after it (may) have been added to user dictionary." 2011-10-03 12:58:52 -07:00
Gilles Debunne
6771c7fdbe Merge "Bug 5384674: When only one suggestion is returned, it is displayed twice" 2011-10-03 12:58:42 -07:00
Gilles Debunne
d3871c53cf Merge "New underline color for the Voice recognized suggestions" 2011-10-03 12:58:34 -07:00
Svetoslav Ganov
70853772bd Adding accessibility support to the share UI.
Added content description to the overflow button and default
action target as well as content description for the popup
list with share targets.

bug:5398787

Change-Id: Iea1e9d85893899f7d161986cb958595083c79b93
2011-10-03 11:16:40 -07:00
Svetoslav Ganov
82e236d72a The logic for not populating text to some accessibility events is scattered.
1. Some accessibility evenents should not and were not dispatched for
   text population but there was no centralized location for enforcing
   this - rather the system was firing them in a specific way or there
   were conditions in a few places enforcing that. Now this is centralized
   and clean.

2. Updated the documentation with some new event types the were lacking.

3. Explicitly stated in the documentaition which events are dispatched to
   the sub-tree of the source for text populatation.

bug:5394527

Change-Id: I86e383807d777019ac98b970c7d9d02a2f7afac6
2011-09-30 19:55:27 -07:00
Gilles Debunne
845d9c7f7e Bug 5327547: re-check word after it (may) have been added to user dictionary.
Change-Id: Id4f32477c3368a140883dd34c97578aab46b04db
2011-09-30 11:24:53 -07:00
Gilles Debunne
176cd0d3b4 Bug 5384674: When only one suggestion is returned, it is displayed twice
Two separate issues here:
- The results of the spell checker may be identical to the one set by the IME. Since
we merge the spans, the entries are duplicated. Filter spell checker results to avoid
these duplicates.

- When the text is saved on rotation, the spans are saved and restored. Since we start
a new spell check when the window is attached, it also doubles the size.

Change-Id: I21e1a5ae1b264bc97f44d762e4589bf520c6c19c
2011-09-30 11:19:02 -07:00
Gilles Debunne
eba3d92341 Merge "Bug 5384675: Color in add to dictionary" 2011-09-30 10:58:30 -07:00
Gilles Debunne
9fb46925d3 Merge "Bug 5384535: Underline for typo even if there are no suggestions" 2011-09-30 10:58:10 -07:00
Gilles Debunne
5b92a451c0 Merge "Bug 5254884: suggestions are no logner copied in the clipboard" 2011-09-30 10:58:01 -07:00
Gilles Debunne
67ed574cdb Merge "Bug 5250788: EditText gets slower has the entered text gets longer" 2011-09-30 10:57:51 -07:00
Gilles Debunne
c2deadc9f3 New underline color for the Voice recognized suggestions
Change-Id: Icb863942e7c11caca7384deca5c59866d4668256
2011-09-30 10:43:43 -07:00
satok
594cb47654 Merge "Use user's settings for the spell check language instead of the system locale" 2011-09-30 01:52:40 -07:00
satok
70deff4c10 Use user's settings for the spell check language instead of the system locale
Bug: 5390462
Change-Id: Ia2a3981cb93f451646debe5ee6b037313825cf9f
2011-09-30 17:49:40 +09:00
Luca Zanolin
af43add388 Merge "The x and y position of the pop-up where not calculated correctly when the text view had internal scrolling." 2011-09-30 01:01:35 -07:00
Svetoslav Ganov
2783b4fa43 Merge "ActivityChooserView shows "see all" improperly." 2011-09-29 17:54:22 -07:00
Fabrice Di Meglio
46c78b4de1 Merge "Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)" 2011-09-29 17:53:09 -07:00
Svetoslav Ganov
1c07e22c36 ActivityChooserView shows "see all" improperly.
1. The cooser was presenting the "Show all" option if the number
   of available activities was more than the initial max count of activities
   to be shown. Since the show all option is added to the drop down
   the latter becomes effectively one longer than the initial max activity
   count which may make the drop down taller than client expectats. Also
   this leads to the case where if the activities are one more than the
   initial activity count pressing the show all button will just replace
   the show all item with the activity that did not fit - this is somehow
   annoying to the user.

bug:5379282

Change-Id: I2693214cb0b66edb2a3bdffc01ed29139341111c
2011-09-29 16:51:04 -07:00
Philip Milne
a15cb2cda7 Merge "Fix for 5393156" 2011-09-29 15:01:27 -07:00
Philip Milne
4a145d7262 Fix for 5393156
. Fix for the above.
. Make instances of Space invisible by default.
. Correctly accomodate parental constraints when row/col order is undefined.

This fix allows GridLayout to accomodate simple dependencies between
its axes. In the example given in bug 5393156, the presence of a
multi-line TextView means that GridLayout can only compute its height
after it has computed its width. This fix adds a second measurement pass
to GridLayout that passes infomation betwen the axes, using the GridLayout's
orientation property to indicate which axis should be examined first.

Change-Id: I90761c6fcfe8edc7ef6d9a89076fd5cda3adc0a4
2011-09-29 14:48:44 -07:00
Fabrice Di Meglio
a130e5f59d Fix bug #5387832 [UI/Visual] Address of the website is not displayed properly(second line of the address is partly shown)
- make DynamicLayout honor max lines
- make StaticLayout.generate() take maxLines as a parameter instead of using the field mMaximumVisibleLineCount

Change-Id: I9eafb1be4b8bb2aa881514955a6903f559cb6a1e
2011-09-29 12:44:16 -07:00
Gilles Debunne
1dd7e534e7 Bug 5384535: Underline for typo even if there are no suggestions
Change-Id: I63f78227a3a80c5fdb97b1d5d8d6c595a70e1990
2011-09-29 10:59:59 -07:00
Gilles Debunne
cf68fee06d Bug 5254884: suggestions are no logner copied in the clipboard
Change-Id: I621c5b4da4252876b0f424e895a4e19e2a4dda50
2011-09-29 10:56:18 -07:00
Gilles Debunne
e670101db8 Bug 5384675: Color in add to dictionary
Change-Id: Ibb89265a90d6b598927dec2bcf45a8c02388b5f0
2011-09-29 10:33:19 -07:00
Gilles Debunne
404c8e5764 Merge "Bug 5278473 & 5278471: delete option in suggestion popup menu" 2011-09-29 10:21:18 -07:00
Gilles Debunne
f4314dffbd Merge "Too many SpellCheckSpans are created." 2011-09-29 10:20:46 -07:00
Chet Haase
253f694981 Merge "Fixed ProgressBar logic for AnimationDrawables" 2011-09-29 07:47:16 -07:00
Luca Zanolin
83e8ced91a Merge "Change the width of the suggestion item to match the one of the suggestion pop-up" 2011-09-29 01:09:47 -07:00
Adam Powell
636da63854 Merge "Fix bug 5385274 - tabs in browser can't be scrolled" 2011-09-28 23:51:50 -07:00
Adam Powell
f6a6c97062 Fix bug 5385274 - tabs in browser can't be scrolled
Fix a regression related to optimizing invalidation in scrolling
views.

Change-Id: I6a39075dc830d78436a274935a904a32084defac
2011-09-28 23:48:10 -07:00
Adam Powell
8f84765385 Merge "Fix bug 5386915 - Action mode is intercepting touches it shouldn't be" 2011-09-28 22:47:08 -07:00
Adam Powell
e0b6cd14ac Fix bug 5386915 - Action mode is intercepting touches it shouldn't be
Standalone action mode windows should not be touch modal.

Change-Id: Ia3bab69b3ac344837093a17c4b58451bcc3471bf
2011-09-28 22:06:39 -07:00
Chih-Chung Chang
02dd17da36 Fix 5389072: NPE in MediaController.updateFloatingWindowLayout().
There was another constructor which we didn't add the call to
initialize the layout.

Change-Id: I1519c9afd7d6333736fe19d256f55a2f4cdc60c3
2011-09-29 12:49:04 +08:00
Svetoslav Ganov
a53d19dc6d Merge "Revamping of the NumberPicker widget for improved usablility." 2011-09-28 19:43:55 -07:00
Gilles Debunne
d5ea0a1bc2 Bug 5250788: EditText gets slower has the entered text gets longer
Profiling showed that the bottle neck was in the word iterator.
Now initializing the word iteerator to only a window around the region
of interest to reduce the text analysis.

Change-Id: Ibfa4952cbf52a1b36726f965143ac7a6dc63673e
2011-09-28 19:04:30 -07:00
Chet Haase
a79803c092 Fixed ProgressBar logic for AnimationDrawables
There are problems in ICS using custom ProgressBar indeterminate drawables when
those drawables are AnimationDrawables. Code that determines appropriate aspect-ratio
sizing should not kick in for this case; the animation drawables know what size
they should be.

Change-Id: I7c35e0dc0f2719f698551f197c688e6156a3f5bd
2011-09-28 17:51:53 -07:00
Svetoslav Ganov
b80a3fcad1 Revamping of the NumberPicker widget for improved usablility.
1. Now if the widget is not interacted with shows a smaller selector
   wheel with the increment and decrement arrows at the top and bottom
   respectively.

2. Tapping an arrow button now animates the widget to the new value. i.e.
   rotates the selector whell to the next value.

3. Fixed a bug that double tapping on the input shows the IME but then
   after pressing an arrow button the IME is not hidden.

4. Fixed a bug that was exposed via late changes in the framework or the
   graphics and was manifested of the selector wheel not having fading
   edges.

bug:5251980
bug:5383502

Change-Id: I4a089dc69b07a3b28a514017cddf786cb9f4af16
2011-09-28 16:58:05 -07:00
Luca Zanolin
a403cb7e72 The x and y position of the pop-up where not calculated correctly when the text view had internal scrolling.
This method is invoked only when the pop-up is currently displayed and the text scrolles.

This is scenario is reproducible only with Voice IME (I think), as the text is inserted without
touching the screen.

Bug: 5290463

Change-Id: I0b842732cc1f115de06e992fbe28cb64eac49b22
2011-09-28 11:43:22 +01:00