Commit Graph

21384 Commits

Author SHA1 Message Date
TreeHugger Robot
f032d43007 Merge "Consolidate 3 phone icons into one." 2019-01-30 02:11:42 +00:00
TreeHugger Robot
b7c7d89155 Merge "Reduced down slop and added action for expanding notifications (1/2)" 2019-01-30 00:36:59 +00:00
TreeHugger Robot
1931fa5033 Merge "Fixes an issue where users could be stuck with heads up notifications" 2019-01-30 00:21:20 +00:00
Amin Shaikh
f3a942751a Consolidate 3 phone icons into one.
ic_bt_cellphone, ic_volume_voice, ic_phone_24dp -> ic_phone

Bug: 122263617
Test: make
Change-Id: Id3a518209e78d1f51b3cc1945bcbeba1bdcb2e23
2019-01-29 18:23:55 -05:00
TreeHugger Robot
e2c6ce4b0b Merge "Log notification location and assistant-generated when smart reply sent" 2019-01-29 22:46:44 +00:00
Josh Tsuji
9b53de5736 Merge "Adds shadows and a default background color to Bubbles." 2019-01-29 22:20:16 +00:00
TreeHugger Robot
3a0a5e9e9a Merge "Protect against null channel" 2019-01-29 21:48:51 +00:00
TreeHugger Robot
06dc2c3c1e Merge "Remove unused systemui resources." 2019-01-29 21:23:06 +00:00
TreeHugger Robot
8a5c213cf7 Merge "Add experiment flag for maximum number of smart actions per notification" 2019-01-29 21:07:04 +00:00
Mady Mellor
c18ba96b3f Protect against null channel
Add a test with notif with no channel..

Test: atest BubbleControllerTest
Bug: 123540415
Change-Id: I7617d314bff340b58bab199c9e69e084591933c0
2019-01-29 11:42:47 -08:00
Selim Cinek
bd5590968f Fixes an issue where users could be stuck with heads up notifications
In a previous refactor, the notification would not be removed as soon
as possible anymore when its lifetime was extended, leading to issues
where a notification would never time out and therefore never be removed.
Additionally would we also extend the lifetime while the panel is
expanded, which is wrong.

Change-Id: If51ae9ab77ad4eb10166c71db3b902c6ac32fd06
Fixes: 122885133
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/AlertingNotificationManagerTest.java
2019-01-29 11:31:12 -08:00
Joshua Tsuji
580c0bf2ae Adds shadows and a default background color to Bubbles.
This makes the aliasing issues with clip path more apparent, but not inherently worse. We'll fix those issues in a subsequent CL, I just want to add this change now because transparent bubbles with no shadows are complicating stack-position debugging!

Test: manual
Bug: 123521453
Change-Id: I06a925ba6db64e92640146b9642396303b098f99
2019-01-29 13:14:53 -05:00
Gustav Sennton
4bf5ff5859 Add experiment flag for maximum number of smart actions per notification
We here add an experiment flag to limit the number of smart actions
shown per notification (including turning all small actions off) from
the System UI.

Bug: 122506860
Test: atest SystemUITests
Test: call "adb shell settings put global
    smart_replies_in_notifications_flags enabled=true,max_num_actions=X" for
    different values of X and ensure the behaviour is correct.
Change-Id: I2759f4bc297386d20f3a6d1cb2975165e5c87c38
2019-01-29 16:31:15 +00:00
Gustav Sennton
13edb4977d Log notification location and assistant-generated when smart reply sent
When logging that a smart reply was sent, now also log where the
notification (containing the reply) is shown, and whether the smart
reply was generated by the assistant (or provided by the application
itself).

Bug: 120767764
Test: click smart reply from notification shade and from heads-up to
ensure correct location is logged.
Test: click smart reply with system-generated replies vs. app-generated
replies to ensure we log generatedByAsssistant correctly.
Change-Id: I43e1f5a07732d578d7890a6f059432c6d6e5038c
2019-01-29 15:23:49 +00:00
Amin Shaikh
d20df8ea81 Remove unused systemui resources.
Bug: 122263617
Test: mp sysuig
Change-Id: If4681826ebe87ab193f96d90720b174a32efadca
2019-01-29 09:32:10 -05:00
Eyal Posener
aea29ed39a [Blocking Helper logs] Modify blocking helper to category
Remove MetricsEvent.NOTIFICATION_ITEM from log category,
and use the NOTIFICATION_BLOCKING_HELPER constant as the log
category.

Bug: 112482290
Test: atest SystemUITests and manual testing.

Change-Id: I8a119f625c81df2bbdd30fc9f3e4d3a2ad478ac2
2019-01-29 09:17:13 -05:00
TreeHugger Robot
c6a4af096e Merge "Keep bubbles behind a flag" 2019-01-29 00:40:45 +00:00
TreeHugger Robot
eacd0d7ff6 Merge "Move SettingsLib icons to android." 2019-01-28 22:49:36 +00:00
TreeHugger Robot
48518f4345 Merge "Update big clock when theme (overlay) changes." 2019-01-28 22:14:57 +00:00
Mady Mellor
9bad224fd0 Keep bubbles behind a flag
Alter tests to ignore the flags so they don't fail.

Test: manual - make sure no bubbles show up
      atest BubbleControllerTest
Bug: 111236845
Change-Id: Ieed38165a3699415686ef299cd54da69d7a37cea
2019-01-28 14:08:15 -08:00
TreeHugger Robot
1625a464eb Merge "Fix use of deprecated SoundPool API in Keyguard" 2019-01-28 21:05:56 +00:00
Jean-Michel Trivi
0616db4746 Fix use of deprecated SoundPool API in Keyguard
Don't use stream types for operations other than volume
  control.

Bug: 122901916
Test: verify logcat doesn't show warnings, see bug
Change-Id: I46143e53978226f6f660c92e85e7b0b1b0a37622
2019-01-28 11:00:33 -08:00
TreeHugger Robot
5887049c6f Merge "Fix expansion change is not reported if the notification is updated" 2019-01-28 18:02:04 +00:00
Gustav Sennton
d6a69968b3 Merge "Update smart reply/action sizes to follow mocks." 2019-01-28 17:56:52 +00:00
Fabian Kozynski
0d03da3723 Added tap behavior to rows in OngoingPrivacyDialog
The rows now direct to Permission Hub information for that app.

Test: manual
Test: previous Unit tests passing
Change-Id: I09e1205ee2340f5095c9c59414ddd9db440915b7
Fixes: 123415277
2019-01-28 10:48:26 -05:00
Tony Mak
96b3f1bde4 Fix expansion change is not reported if the notification is updated
When the notification is updated(reinflated), we should report the
expansion is visibly expanded again even it the notification of
the same key was already reported.

Test: atest ExpansionStateLoggerTest.java
Test: Manual. Send a message to myself. Observe
onNotificationExpansionChange is called. Send another message to update
the notification and go to see the notification. Observe that
onNotificationExpansionChange is called again.

Change-Id: Ie1f245c3954eafade0d81794b4722de6dfbec9dc
2019-01-28 15:02:07 +00:00
Charles Chen
3dedec3272 Notify SystemUI when ActivityDisplay is ready
Bug: 120748674
Test: atest ActivityManagerMultiDisplayTests#testNavBarNotShowingOnDisplayWithoutDecor * 100
Test: atest ActivityManagerMultiDisplayTests#testNavBarShowingOnDisplayWithDecor * 100
Test: atest ActivityManagerMultiDisplayTests#testNavBarNotShowingOnPrivateDisplay * 100
Test: atest SystemUITests
Change-Id: I302a35b9b860ab881b60c6407edabb2da16b75f8
2019-01-28 14:39:34 +08:00
Matthew Ng
f886946acd Reduced down slop and added action for expanding notifications (1/2)
Added an option to select expanding notifications to execute after a
gesture. Exploring swipe down by reducing the touch slope to a smaller
value to execute more. Since it is swiping towards the edge, less events
will be received and typically hard to trigger when swiping other
directions.

Bug: 112934365
Test: manual
Change-Id: I6a854043183d85b43d32633c5fbe88262f473012
2019-01-25 14:42:23 -08:00
Joshua Tsuji
0fee768a61 Ensure the cutout is not null before trying to use it.
Test: manual
Change-Id: I59cf13aed53a5d8a61e5dc65500764ecdddc9c39
2019-01-25 15:52:05 -05:00
Amin Shaikh
10f363bb18 Move SettingsLib icons to android.
Bug: 122263617
Test: make
Change-Id: I11ce02f3f65f429fd4375a5522c060c8080f4813
2019-01-25 15:26:41 -05:00
Josh Tsuji
3e6de26e7a Merge "Adds DynamicAnimation-based movement to the bubbles." 2019-01-25 16:04:51 +00:00
Aaron Heuckroth
5d1f0e0058 Merge "Creates a new grid-based global actions menu on power button hold." 2019-01-25 15:19:07 +00:00
Mark Renouf
82296cfea2 Merge "Only call ActivityView.startActivity once per bubble" 2019-01-25 14:07:10 +00:00
TreeHugger Robot
1d4c240ae6 Merge "Always show battery percentage on AOD" 2019-01-25 05:19:33 +00:00
Lucas Dupin
47904eeaad Merge "Invert custom views in dark mode" 2019-01-25 04:00:05 +00:00
Lucas Dupin
c97d88f90f Always show battery percentage on AOD
Fixes: 123362085
Test: visual
Change-Id: Ib94efbb9b84bad75ba0a485fff827acb397a8b5f
2019-01-24 19:06:47 -08:00
TreeHugger Robot
a93cbcb6ae Merge "QSFooterImpl shows multiple carriers" 2019-01-25 02:30:51 +00:00
Lucas Dupin
e1bb998611 Invert custom views in dark mode
Invert custom view colors (in Y'UV space) if its background isn't dark,
we're in dark mode, and app doesn't target Q.

Change-Id: I74f557315c5e7e91ee7ec01d1535dac40f921524
Fixes: 112767229
Test: send custom notification from pre Q app with black background
Test: send custom notification from pre Q app with white background
Test: send custom notification from pre Q app with green background
Test: send custom notification from Q app with white background
2019-01-24 18:30:26 -08:00
Joshua Tsuji
b1a796b155 Adds DynamicAnimation-based movement to the bubbles.
See go/bubble-stack-design for a high level overview of these changes. This is a large CL, but required in order to allow continued development and team testing without breaking functionality over the course of multiple CL submissions.

To integrate the new animations, the following changes have been made to existing code:
* (BubbleStackView) The bubble container (and thus, the stack view) are MATCH_PARENT to allow the bubbles to independently translate anywhere on the screen.
* (BubbleStackView) Start position is set by the stack controller, not BubbleStackView.
* (BubbleStackView) Expand positon is set by the expansion controller, not BubbleStackView.
* (BubbleStackView/BubbleTouchHandler) Added the methods onDragStart/onDragged/onDragFinish, and onBubbleDragStart/onBubbleDragged/onBubbleDragFinish, for cleaner dispatch of touch events to the appropriate animation controller.
* (BubbleStackView/BubbleController) The stack view's getBoundsOnScreen returns the first bubble's bounds, if the stack is not expanded.
* (BubbleStackView) applyCurrentState no longer manages translation of bubbles, or the expanded view, these are controlled by animation.
* (BubbleMovementHelper) Deleted, no longer needed.
* (Everywhere) Changed uses of Point to PointF, since translation values are floats anyway.

Known issues to be fixed in subsequent, far smaller CLs:
* (b/123022862) Bubble dragging out/dismissing is not animated, and the bubbles can be deposited anywhere. Tap outside the stack to collapse them back to normal.
* (b/123023502) New bubbles added while the stack is expanded are not positioned properly.
* (b/123022982) Expanded view arrow is sometimes in the wrong position.
* (b/123023410) If the stack is expanded while animating, it collapses to its original position even if not along the edge of the screen.
* (b/123023904) The expanded view doesn't animate out, it disappears instantly.
* (b/123026584) Bounds in landscape are a bit wonky.

Bug: 111236845
Test: atest SystemUITests
Test: physics-animation-testing.md
Change-Id: Icaca09e5db89c635c9bb7ca82d7d2714362e344e
2019-01-24 19:23:17 -05:00
TreeHugger Robot
7e5d596e89 Merge "Convert PrivacyItemController to Dependency" 2019-01-24 23:47:33 +00:00
Fabian Kozynski
1823f11ddf QSFooterImpl shows multiple carriers
QSFooter now shows up to two subscriptions with corresponding signal
rate graphic.

Modified CarrierTextCallback to pass an info struct.

Pending design guidelines.

Test: manual using DSDS
Bug: 113343186
Change-Id: Ic98d52ae59139132533a86fcc279a4f64c98c91e
2019-01-24 17:13:55 -05:00
TreeHugger Robot
db0b01e6a2 Merge "Fixes a crash when logging" 2019-01-24 21:46:31 +00:00
Fabian Kozynski
bcc927a19f Merge "Refactor logic out of CarrierText" 2019-01-24 21:32:43 +00:00
Mark Renouf
8eafa2244c Only call ActivityView.startActivity once per bubble
This change fixes behavior when used with bubble intents which always create
a new task, using documentLaunchMode="always".

Test: manual
Bug: 111236845
Change-Id: Ic58639ff6e55fde8ca2e35c1be4632a2358e30a2
2019-01-24 21:27:38 +00:00
TreeHugger Robot
77bf8692e6 Merge "Fixes NotificationInfo for demoted notifications." 2019-01-24 21:26:44 +00:00
TreeHugger Robot
f973b04f98 Merge "Only toggle launcher stability flag when prototype is enabled" 2019-01-24 21:26:34 +00:00
Fabian Kozynski
04f83eb5f0 Convert PrivacyItemController to Dependency
This makes sure that PIC is a Singleton and prevents memory leak.

Bug: 121388507
Test: atest PrivacyItemControllerTest

Change-Id: Ib5c2a8790157034e1937c8037650ac047478d005
2019-01-24 16:24:40 -05:00
TreeHugger Robot
0b7dff0e16 Merge "Adds setting for direction of dismiss gesture." 2019-01-24 21:20:30 +00:00
Aaron Heuckroth
166392ff24 Creates a new grid-based global actions menu on power button hold.
Test: Automated tests should pass. Menu should render at correct size, shape, and position for 0-9 action items.

Bug: 121385065

Change-Id: I3448e7e333ea8fdaeb09a241249ce7521920169e
2019-01-24 20:06:54 +00:00
Selim Cinek
0b054d161b Fixes a crash when logging
Change-Id: Ie5207ad22a580b88f50b117f3247a045b2dd31b8
Fixes: 123327642
2019-01-24 11:58:23 -08:00