Commit Graph

1989 Commits

Author SHA1 Message Date
Vadim Caen
39b397de9f Merge "Release the SurfacePackageViewHost on splash screen removed" into sc-dev am: dc07d29bd0 am: e65475b1c6
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14775423

Change-Id: I675fd44270a6a59863a2490e3723f0f53379b3c5
2021-06-16 12:42:44 +00:00
Vadim Caen
e65475b1c6 Merge "Release the SurfacePackageViewHost on splash screen removed" into sc-dev am: dc07d29bd0
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14775423

Change-Id: I49cf9037240aeffebff7b6109ea0abe3942c0fc9
2021-06-16 12:42:29 +00:00
Vadim Caen
dc07d29bd0 Merge "Release the SurfacePackageViewHost on splash screen removed" into sc-dev 2021-06-16 12:27:47 +00:00
Ben Lin
d6d31dd817 Merge "PiP: Divide up the magnetic percent by 2." into sc-dev am: dd44345c6a am: e8b4a8ab7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14940431

Change-Id: I5ae59481504a9dc80ee1ee96627fcbd327466330
2021-06-15 19:14:55 +00:00
Ben Lin
e8b4a8ab7a Merge "PiP: Divide up the magnetic percent by 2." into sc-dev am: dd44345c6a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14940431

Change-Id: I5fea0df9e9e23084cf41dd93e9b5d02fc484eecc
2021-06-15 19:13:28 +00:00
Ben Lin
dd44345c6a Merge "PiP: Divide up the magnetic percent by 2." into sc-dev 2021-06-15 19:06:17 +00:00
Mady Mellor
a587c7aeea Merge "Fix dismiss ciricle being behind expanded view" into sc-dev am: 563e1b4856 am: a652e22417 am: 6f8b73939f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14970151

Change-Id: I242e61f13b83d2eee0cf5889ae1d536c210983da
2021-06-15 16:26:38 +00:00
Mady Mellor
6f8b73939f Merge "Fix dismiss ciricle being behind expanded view" into sc-dev am: 563e1b4856 am: a652e22417
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14970151

Change-Id: I99f42491ccd11f8d7617dada7272cb130284bc59
2021-06-15 16:22:04 +00:00
Mady Mellor
f25ecf8dfc Merge "Fix dismiss ciricle being behind expanded view" into sc-dev am: 563e1b4856
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14970151

Change-Id: If3794aeb4235008b7e09104e4e34b853c7d7f361
2021-06-15 16:21:40 +00:00
Mady Mellor
a652e22417 Merge "Fix dismiss ciricle being behind expanded view" into sc-dev am: 563e1b4856
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14970151

Change-Id: Id5efca28bb74c11167094143ca0a1a7c286fe54d
2021-06-15 16:12:28 +00:00
Mady Mellor
563e1b4856 Merge "Fix dismiss ciricle being behind expanded view" into sc-dev 2021-06-15 16:09:56 +00:00
Mady Mellor
dcc41f099d Merge "Fix launching bubbles from widgets" into sc-dev am: faee2e6b03 am: 500a18e02a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14940550

Change-Id: I74566baa9a82aa8ed508a8c50322532142f54496
2021-06-15 16:09:32 +00:00
Mady Mellor
f5753d3eee Merge "Fix launching bubbles from widgets" into sc-dev am: faee2e6b03 am: 116a6e0493
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14940550

Change-Id: I19fe960e792ae5c2f05a582ce93e246ba275b8c9
2021-06-15 16:09:21 +00:00
Mady Mellor
500a18e02a Merge "Fix launching bubbles from widgets" into sc-dev am: faee2e6b03
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14940550

Change-Id: I69f23eae9d361d25d4aa22dd47ce56268361e7a3
2021-06-15 16:09:09 +00:00
Mady Mellor
116a6e0493 Merge "Fix launching bubbles from widgets" into sc-dev am: faee2e6b03
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14940550

Change-Id: Ib0a1d09296d050e400e0f61f14f08f0724e908e3
2021-06-15 16:09:04 +00:00
Mady Mellor
faee2e6b03 Merge "Fix launching bubbles from widgets" into sc-dev 2021-06-15 16:08:52 +00:00
Vadim Caen
a46ff113be Release the SurfacePackageViewHost on splash screen removed
The SurfacePackageViewHost was never release, leading to a leak of its
surfaces.

This CL ensure it is released:
  - Directly in the shell if the SplashScreenView was not copied
  - From the client, through the window manger and then to the shell if
  the splash screen was copied in the client process

Test: Manually tested with app setting by checking if the surfaces
are actually removed (winscope + logs) in the following scenarios:
    - When the application registers an OnExitAnimationListener
      and calls remove(),
    - When the application registers an OnExitAnimationListener
      and dies without calling remove()
    - When the applicaiton does not register an OnExitAnimationListener
    and the shell removes the splash screen
Bug: 189759180

Change-Id: Ib68bfffad6720911368739d7dd87d8a03034c589
2021-06-15 15:39:09 +02:00
Tony Huang
afaf49b6cf Merge "Using rotate split layout while split active" into sc-dev am: e59e08b8f2 am: ab4130735c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14909655

Change-Id: I17aa0960f9c825599ec3e5634c60cc9fab0a0cda
2021-06-15 07:08:52 +00:00
Tony Huang
ab4130735c Merge "Using rotate split layout while split active" into sc-dev am: e59e08b8f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14909655

Change-Id: If2ac1372047684bd0b6be3af3e2789ce2cd3879b
2021-06-15 06:59:05 +00:00
Tony Huang
2903a84488 Merge "Using rotate split layout while split active" into sc-dev am: e59e08b8f2 am: 751c068b24
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14909655

Change-Id: Ic490d29d5188df55fbdc18b483941236c82e307a
2021-06-15 06:58:33 +00:00
Tony Huang
751c068b24 Merge "Using rotate split layout while split active" into sc-dev am: e59e08b8f2
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14909655

Change-Id: If2177bc4f6c21d38efd5b647c57098a8a21443b2
2021-06-15 06:58:12 +00:00
Tony Huang
e59e08b8f2 Merge "Using rotate split layout while split active" into sc-dev 2021-06-15 06:50:54 +00:00
TreeHugger Robot
8c42d2e682 Merge "Import translations. DO NOT MERGE ANYWHERE" 2021-06-15 05:03:38 +00:00
TreeHugger Robot
4403e96123 Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-dev 2021-06-15 04:39:23 +00:00
TreeHugger Robot
38e2f0e24a Merge "Import translations. DO NOT MERGE ANYWHERE" into sc-v2-dev 2021-06-15 04:19:43 +00:00
Bill Yi
6e42108257 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I766baecdbecccd89b0a1b0b0dfc5ad71aee83736
2021-06-15 02:39:50 +00:00
Bill Yi
1729ea4c88 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: Iab4b9ceaa274a0914f294e71d8fc56f99bd6c87d
2021-06-15 02:38:26 +00:00
Bill Yi
575886adff Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I02b4ba5d59e656eeaad58df19e22df03bae22de3
2021-06-15 02:36:33 +00:00
TreeHugger Robot
8c9484cb95 Merge "Settings Switch animation jank while enabled One-handed mode" into sc-dev am: e796dc88bd am: fe162aa552
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14947950

Change-Id: Ic5d75d99db8899b6c78b470604de1c325a5a376c
2021-06-15 02:08:21 +00:00
TreeHugger Robot
d5b17d4953 Merge "Settings Switch animation jank while enabled One-handed mode" into sc-dev am: e796dc88bd am: bd1142c3a3
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14947950

Change-Id: I5480ce930a3fb6bafad8c176fa950070a6eb1674
2021-06-15 02:08:00 +00:00
TreeHugger Robot
fe162aa552 Merge "Settings Switch animation jank while enabled One-handed mode" into sc-dev am: e796dc88bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14947950

Change-Id: Ic86a5baf33d7e029bb837e73a21deb9059b11321
2021-06-15 01:54:46 +00:00
TreeHugger Robot
bd1142c3a3 Merge "Settings Switch animation jank while enabled One-handed mode" into sc-dev am: e796dc88bd
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14947950

Change-Id: I6d1e56857d683f81aa05891cbd5853465cd8946f
2021-06-15 01:54:03 +00:00
TreeHugger Robot
e796dc88bd Merge "Settings Switch animation jank while enabled One-handed mode" into sc-dev 2021-06-15 01:37:34 +00:00
Mady Mellor
e57920820e Fix launching bubbles from widgets
There were a couple of issues:
1) onActivityRestart wasn't checking for bubbles in the overflow
   so there were cases where we could open a bubble but weren't
2) delay opening the bubble until after the transitions have
   happened when launching from a widget, the transition could
   alter the placement of the bubble's surface resulting in
   weird UI.

Test: atest LaunchConversationActivityTest
Test: manual 1) have a bubble & convo widget for it
             2) tap on the widget => bubble opens normally, close
                the bubble & repeat that a bunch

             1) have an unopened bubble & convo widget for it
             2) get enough bubbles to push it out of the stack &
                out of the overflow
             3) tap on the widget => bubble opens

             1) have a bubble & convo widget for it, dismiss bubble
             2) tap on the widget => bubble opens normally
Bug: 188306336

Change-Id: Id68ccbfbfc6fc6949cfc257df4706b470fb78569
2021-06-14 18:25:25 -07:00
Mady Mellor
be613e6a98 Fix dismiss ciricle being behind expanded view
- Need to give it an elevation
- Need to make sure to bring the bubble container
  in front of it so that they appear on top

Test: manual - have at least 2 bubbles, expand the stack, drag
               the bubble that is not expanded to the dismiss view
             => observe that the dismiss view is above the expanded
                view & below the bubble
Bug: 190478161
Change-Id: Ifbce49211b2342c3e197168af38f4c2ca9a1904b
2021-06-14 15:18:12 -07:00
Bill Lin
61766a732c Settings Switch animation jank while enabled One-handed mode
Switch is CompoundButton(View) and animating position when user
tap on it. Unfortunatly when set overlay pakcage enabled, Switch
componet will invoke onLayout() and cancelPositionAnimator(),
that result the UX feel jank.

We add a delay(250ms) before execute runtime resouce overlay
to ensure the widget animation finished first.

Test: Manual Settings > Gesture > One Handed Mode > Tap Switch
Bug: 190584055
Change-Id: Ia42fdf3ed699afd51c154cb0a53581ef67959c71
2021-06-15 05:15:44 +08:00
Jorge Gil
6c3fd83afa Merge "Remove duplicate call to update PIP bounds on PIP expand" into sc-dev am: d3cc960edf am: b1d7465e29
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14681779

Change-Id: I1165c45d7fe6cb68f362a978916317adaac530cc
2021-06-14 15:25:00 +00:00
Jorge Gil
997bb95062 Merge "Remove duplicate call to update PIP bounds on PIP expand" into sc-dev am: d3cc960edf am: 101b82657f
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14681779

Change-Id: I50f5bb0e3ef516d855450ec469e74de63c288e50
2021-06-14 15:24:49 +00:00
Jorge Gil
b1d7465e29 Merge "Remove duplicate call to update PIP bounds on PIP expand" into sc-dev am: d3cc960edf
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14681779

Change-Id: I15d962b0c0c292cc72ec4ba3cf8dce79893ee3be
2021-06-14 15:10:29 +00:00
Jorge Gil
101b82657f Merge "Remove duplicate call to update PIP bounds on PIP expand" into sc-dev am: d3cc960edf
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14681779

Change-Id: I242ee2211975d8566069a56dead9656d2ff74e3e
2021-06-14 15:09:59 +00:00
Jorge Gil
d3cc960edf Merge "Remove duplicate call to update PIP bounds on PIP expand" into sc-dev 2021-06-14 14:58:33 +00:00
Selim Cinek
bcee98b3b3 Merge "Always do the app reveal animation when dismissing the splash screen" into sc-dev am: bfa0487b7a am: b77c0a3d8a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14934416

Change-Id: I8d3c9409f66d28e749f41bd7852816836c3d44a7
2021-06-14 08:33:03 +00:00
Selim Cinek
f7930d1946 Merge "Always do the app reveal animation when dismissing the splash screen" into sc-dev am: bfa0487b7a am: 3e62cd77b5
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14934416

Change-Id: Ibbc4766f3f1de0d557df131baede066b1bbad5f7
2021-06-14 08:32:13 +00:00
Selim Cinek
b77c0a3d8a Merge "Always do the app reveal animation when dismissing the splash screen" into sc-dev am: bfa0487b7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14934416

Change-Id: Id5d4519dd0c96ee044a31c5ecac97cfd644d5cc5
2021-06-14 08:19:26 +00:00
Selim Cinek
3e62cd77b5 Merge "Always do the app reveal animation when dismissing the splash screen" into sc-dev am: bfa0487b7a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14934416

Change-Id: I4858516d5c5b9a1cb849fd34437666ed5a7392f4
2021-06-14 08:18:53 +00:00
Selim Cinek
bfa0487b7a Merge "Always do the app reveal animation when dismissing the splash screen" into sc-dev 2021-06-14 08:02:08 +00:00
TreeHugger Robot
a9e3cdd20a Merge "Skip onMovementBoundsChanged when waiting for fixed rotation" into sc-dev am: fe8d6de401 am: ba69e6175a
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14939513

Change-Id: I778a9e832b32131dd54e20eef9f5cb4926c70a8b
2021-06-12 18:50:55 +00:00
TreeHugger Robot
846d138903 Merge "Skip onMovementBoundsChanged when waiting for fixed rotation" into sc-dev am: fe8d6de401 am: 783bb77e60
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14939513

Change-Id: I9fb285a92c2efe4d4732ce4119676f68f1b60a6f
2021-06-12 18:50:32 +00:00
TreeHugger Robot
ba69e6175a Merge "Skip onMovementBoundsChanged when waiting for fixed rotation" into sc-dev am: fe8d6de401
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14939513

Change-Id: I4e0179afae3cee599f69e5d9c122bbe4223ebb9e
2021-06-12 18:34:45 +00:00
TreeHugger Robot
783bb77e60 Merge "Skip onMovementBoundsChanged when waiting for fixed rotation" into sc-dev am: fe8d6de401
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/14939513

Change-Id: Idcb8b6d58087d435f68e43130c7355ac7b88c33b
2021-06-12 18:34:11 +00:00