Commit Graph

2792 Commits

Author SHA1 Message Date
alanv
ac6e50a671 Catch badly formed URLs in WebView accessibility injector.
Bug: 7206684
Change-Id: I13e8f29043314430ea3fcfa8ab59040136d06e57
2012-10-19 12:57:41 -07:00
Charles Chen
4c38e24afb Merge "Don't alter accessibility JS APIs unless a page is about to load." into jb-mr1-dev 2012-10-12 13:46:09 -07:00
alanv
03e636f33d Don't alter accessibility JS APIs unless a page is about to load.
Previously we were adding and removing the APIs on window attach and
detach, but a page's life cycle is not related to attach/detach. This
patch also ensures that ChromeVox is not null before calling. Includes
formatting fixes and extra comments in the waitForResultTimedLocked
method to improve readability. Fixes parsing of integer resultId, which
was being parsed using Long.

Bug: 7328348
Change-Id: I6b81a8e4d8209f8e99419da9b8250abe57e25048
2012-10-12 11:42:37 -07:00
John Reck
b746febca2 Merge "Center text selection point to avoid rounding glitches" into jb-mr1-dev 2012-10-11 18:25:55 -07:00
John Reck
9fcef3d023 Center text selection point to avoid rounding glitches
Bug: 7313424

Change-Id: I5356bec61e3d1244b506486300f059aa0bba6d9e
2012-10-11 18:08:03 -07:00
Svetoslav Ganov
3003bada60 Merge "Check whether ChromeVox is ready before attempting to call it." into jb-mr1-dev 2012-10-11 17:14:34 -07:00
Svetoslav Ganov
87c6f9a528 Merge "This is wrong since it fixed the symptom not the problem. Alan is uploading a correct patch." into jb-mr1-dev 2012-10-11 17:12:07 -07:00
alanv
d8faf74662 Check whether ChromeVox is ready before attempting to call it.
Calls to performAction will immediately return false if ChromeVox is not
loaded. Also adds additional debugging output.

Bug: 7328657
Change-Id: I5bd7c69ccc9500cebaa4a8c1bf023794f4eebe2e
2012-10-11 16:48:32 -07:00
Svetoslav Ganov
d1821cc06f This is wrong since it fixed the symptom not the problem. Alan is uploading a correct patch.
Revert "Reducing WebView navigation timeout for accessibility."

This reverts commit 2203cf3f72

Change-Id: I5b2d999851af98acb953529ebfcda608ce27799d
2012-10-11 16:46:33 -07:00
clchen
4574df0c15 Merge "Reducing WebView navigation timeout for accessibility." into jb-mr1-dev 2012-10-11 16:16:56 -07:00
clchen
2203cf3f72 Reducing WebView navigation timeout for accessibility.
Reducing the amount of time that WebView will wait before treating
a navigation attempt as failed. This is needed to recover from
cases where the user is attempting to linearly navigate a WebView
that is immediately switched out right as it starts to read.
A good example of this problem is AdMob's WebViews which are
continuously being swapped.

Change-Id: Ib9b4a9b99a35d42920e34e0acbe8ab45e1d47871
2012-10-11 16:13:00 -07:00
Jonathan Dixon
96a1b3cf67 Unhide setPictureListener
The replacement isn't available yet, so we need to leave this in for now.

BUG: 7332831
Change-Id: I311c44c45ef71461572afbe4060d134cdaefd3ae
2012-10-11 14:00:50 -07:00
alanv
df313699ba Fix WebView accessibility scripts.
Ensures A11y APIs are added to WebView before page loads. Prevents calls
to TTS before init and after shutdown. Ensures calls to TTS are thread-
safe. Activates and deactivates feedback from AndroidVox when view is
attached and detached. Adds a flag for logging debug output, as well as
a lot of debug output.

Bug: 7326781
Change-Id: I5d4ab7f9fb1669f98ef05ae207e897565d3086c9
2012-10-10 17:09:11 -07:00
John Reck
3f5a59accc Fix perf regression from scale/density mismatch
Bug: 7242941

Change-Id: I8a45e8ae589cecc6215566b995003b9eefb7827e
2012-09-27 17:10:49 -07:00
Jeff Brown
bf6f6f9de7 Update references to migrated global settings.
Fixed one setting that was migrated but not marked deprecated.

Removed a hidden setting that is no longer used by the new
power manager service.

Bug: 7231172
Change-Id: I332f020f876a18d519a1a20598a172f1c98036f7
2012-09-25 15:27:51 -07:00
Kristian Monsen
d0b90d30d8 Hiding a method for JB-MR1
This one got left out in the last round of method hiding.

This got lost in the last round of method hiding.

Change-Id: I3c6aa234dd29933cb32d0cd91830d47289e7e639
2012-09-24 19:11:30 -04:00
Victoria Lease
37563c5249 Get your own cursor Drawables, WebViewClassic!
These are shared resources! You can't just animate *everyone's*
cursors!

This is a hand-merge of Icdc86af4fba427a352019cd3e2017f97a3b9fdba
from jb-dev branch. I'm not sure why it wouldn't automerge, as it
seemed pretty straightforward...

Bug: 7110290
Change-Id: I131a611b9e16699a51d3769658f079c2ae4cf262
2012-09-21 09:31:11 -07:00
John Reck
9f9d34552f Use less static synchronized
Bug: 6482144

Change-Id: I86161e3298101c10a112add406615001561e649e
2012-09-20 15:25:16 -07:00
John Reck
b6610d8289 Merge "Fix DPI scaling on TVDPI" into jb-mr1-dev 2012-09-20 10:21:41 -07:00
John Reck
6013d8c25b Fix DPI scaling on TVDPI
Bug: 6891214
 tvdpi has a density of 1.3312501 which we fail on as we assume
 you can take density and multiply by 100, cast to an int, and
 divide by 100f to get back to the original density. Force this
 assumption to be true by truncating density

Change-Id: I0caeb7768ee002f935b41c77a5579ffeed491f82
2012-09-19 18:33:38 -07:00
John Reck
55bc7efaf9 Revert "Test aggressive throttling"
Bug: 7182109
This reverts commit c7c85b34da.

Change-Id: Ibc8837b97450ec6e77a0e9dd509280ff780bb22b
2012-09-19 14:26:48 -07:00
Elliott Hughes
c3ff72f5bd Use icu4c for CLDR "yesterday", "today", and "tomorrow" strings.
(cherry-pick of 47a0539ecaf7d7a15008704bd89f748aebf85d47.)

Conflicts:

	core/res/res/values/public.xml

Bug: 6811501
Change-Id: Ifb2e030a9fda85a7f664feac812b63e67780e68f
2012-09-14 20:22:17 -07:00
Kristian Monsen
4cb846b8de Merge "Hiding some of the deprecated android.webkit API's" into jb-mr1-dev 2012-09-14 14:01:37 -07:00
Selim Gurun
b4c02e6ffd Minor update to addjavascriptinterface documentation
Change-Id: I67525673e3d061e00fbe8989c08050ad84e78920
2012-09-12 13:36:21 -07:00
Selim Gurun
4f8da32ffa Merge "Make JavascriptInterface annotation public." into jb-mr1-dev 2012-09-12 12:48:32 -07:00
Brian Carlstrom
0efca17105 Tracking upgrade to bouncycastle 1.47
Change-Id: I4a3c508c5e65dd46a2df22935b5351092550fad5
2012-09-12 10:01:00 -07:00
Kristian Monsen
bd0fe87834 Merge "Deprecating methods (and a constant) for JB MR1" into jb-mr1-dev 2012-09-12 09:34:37 -07:00
Selim Gurun
e91d5bee24 Make JavascriptInterface annotation public.
Bug: 7073422

This change makes @JavascriptInterface public and it requires
using this annotation to allow javascript access to public java
methods for API level JELLY_BEAN_MR1 and above. The behavior
does not change for API levels JELLY_BEAN and below.

Change-Id: I4108b17cf71b9ac273d7b61b1c8f7f5581e922ee
2012-09-12 08:04:26 -07:00
Selim Gurun
79ccb1e8a9 Merge "Deleting the defunct SearchBox interface." into jb-mr1-dev 2012-09-11 15:01:21 -07:00
Selim Gurun
a7094734ae Deleting the defunct SearchBox interface.
Change-Id: Iecb698dbe942d3c9680ad1135ba0d604aa211856
2012-09-11 13:27:08 -07:00
Selim Gurun
faed98a161 Merge "Added annotations for injected accessibility objects" into jb-mr1-dev 2012-09-11 13:23:45 -07:00
Selim Gurun
2fa10c675b Fix build break
Change-Id: Ib5415bbebb849de23b3ff8533a7c1a98f6ae38f4
2012-09-11 11:32:44 -07:00
Selim Gurun
0e9292b94a Remove defunct searchbox implementation from webview.
The search box implementation has not been in use since ICS. This
removes dead code from webview.

Change-Id: I8a28eeeec556619abc4a902a3abec2ac52bad319
2012-09-11 10:40:28 -07:00
Selim Gurun
b743a23fc5 Added annotations for injected accessibility objects
Bug: 7073422

Provided @JavascriptInterface to methods that are accessible from
js.

Change-Id: If3bf8f5aa2b6ff38fe5358aad534ea31f6f546ae
2012-09-11 10:24:44 -07:00
Selim Gurun
94740e6c33 Control access to inherited methods of jsinterface objects
Bug: 7073422

Create the plumbing to use an annotation to allow access to
inherited methods of jsinterface objects. The default webview
behavior has not changed yet. However internally an a flag is
introduced to restrict javascript access to methods that have an annotation.

Change-Id: I41927248e6bc4b09d17c0707c60fe5e6ab681e66
2012-09-10 16:43:35 -07:00
John Reck
095e8aa02b Fix some destroy bugs
Bug: 6961494
 Don't call clearHelpers in destroy(). It is already called
 in onDetach, which is where it needs to be. It can't be
 called by the finalizer

 Switch onCancel listener to onDismiss listener. Fixes an issue
 where destroying can live the webcore thread hung because onCancel
 won't be called, but onDismiss is

Change-Id: I669c389c8c9a81d92c27f88d83bcb711c6c0a5ee
2012-09-10 16:07:04 -07:00
Kristian Monsen
f4912580e6 Hiding some of the deprecated android.webkit API's
Change-Id: I1775a2ff615d1633fe9a20a5af49623222d3d27b
2012-09-07 15:34:20 -04:00
Kristian Monsen
5cc2351ded Deprecating methods (and a constant) for JB MR1
Change-Id: I3eb0eaff5ea5d8984ad143f801efa19e25bd0685
2012-09-07 15:34:13 -04:00
Teng-Hui Zhu
4db5d23dea Merge "Back key to dismiss full screen video" into jb-mr1-dev 2012-09-07 11:49:54 -07:00
Teng-Hui Zhu
5558eacfbf Back key to dismiss full screen video
Also cleanup some warnings.

bug:6722752

Change-Id: Ib612cf79e9546d40a048c5f09a1be6ca37ce51f8
2012-09-06 16:20:14 -07:00
Selim Gurun
18e8768067 Merge "remove defunct javascript interface" into jb-mr1-dev 2012-09-05 15:04:07 -07:00
Selim Gurun
d773ca8ff2 remove defunct javascript interface
Bug: 7073422

The feature that is using search box implementation was removed from
browser after Honeycomb. This is to remove the js interface that
is added for this feature.

Change-Id: I9441d461caf189467e4ad45de958c13b81f4ff17
2012-09-05 11:53:44 -07:00
Adam Powell
1027ed2aca Make WebView track focal points more accurately
Change-Id: I6683edee6933b1dd026453935d72119320ab3c81
2012-09-04 14:42:11 -07:00
John Reck
fef288b01c am 8f58dfa9: am da5cd308: am ae03afda: Merge "onSavePassword dialog can leak when WebViewClassic is destroyed."
* commit '8f58dfa975d01c5c50de513848a6aa8a4460d32c':
  onSavePassword dialog can leak when WebViewClassic is destroyed.
2012-08-30 11:45:47 -07:00
John Reck
da5cd30802 am ae03afda: Merge "onSavePassword dialog can leak when WebViewClassic is destroyed."
* commit 'ae03afda41ace0721e48ed15ce35345bfa033116':
  onSavePassword dialog can leak when WebViewClassic is destroyed.
2012-08-30 11:41:38 -07:00
Johan Redestig
8655e9085c onSavePassword dialog can leak when WebViewClassic is destroyed.
The AlertDialog creates in onSavePassword method leaks if
WebViewClassic is destroyed when the dialog is shown.

Change-Id: I81f20e1dd138467a6413766c0a081b389b334ae0
2012-08-30 10:13:41 +02:00
Selim Gurun
8506ce1a3f Merge "Provide referer to browser on download request." into jb-mr1-dev 2012-08-29 15:39:11 -07:00
Selim Gurun
a36dcfdfe0 Provide referer to browser on download request.
Bug: 6662557

Provide a private API to provide referer to browser for download
requests.

Change-Id: I6ff393caa43e16db12fb5dab38f1f26cd76bf232
2012-08-29 11:50:55 -07:00
John Reck
25b86b6bf0 Remove dead code
Change-Id: Ice4bf3a94743019a8fc8ab04ee3de19f27a9e2c3
2012-08-28 16:24:28 -07:00
John Reck
f920271828 Merge "Protect against focus changes after .destroy()" into jb-mr1-dev 2012-08-27 16:54:18 -07:00