Commit Graph

1129 Commits

Author SHA1 Message Date
TreeHugger Robot
11866a4242 Merge "Hide activities when AOD comes in" into pi-dev 2018-03-28 01:11:42 +00:00
Makoto Onuki
452ae34af5 Merge "Add auto battery saver suggestion notification/dialog" into pi-dev 2018-03-27 21:20:13 +00:00
Lucas Dupin
47a65c79c9 Hide activities when AOD comes in
Display timeout does not lock the keyguard, which means that
activities won't immediatelly disappear.

We need to factor AOD into to equation to make sure that
the user won't see phantom activities under the status bar
window when the display times out.

Fixes: 73120928
Test: open Settings, wait for display timeout
Test: Wait for display timeout, press power, see launcher
Test: Launch maps, start navigation (FLAG_SHOW_WHEN_LOCKED)
Test: Go to AOD, press power button: activity is occluding keyguard
Test: Press home: bouncer shows up
Test: Unlock: maps goes into pip mode
Test: Go to AOD and back to lock screen: keyguard visible
Test: Expand maps, go to AOD, back to lock screen: maps is occluding keyguard
Change-Id: I9b7512313af2f851d8788ec53de7880bce3bed2c
2018-03-27 12:12:14 -07:00
Makoto Onuki
52c6295e22 Add auto battery saver suggestion notification/dialog
Spec: go/ebs-low-battery-mode-flow

- Basically when the user manually enables battery saver 4 times,
we show this notification to suggest turning on "scheduled"
(i.e. auto) battery saver.

- We show it through 8th time. If the user hits "no thanks",
or if auto-saver is enabled already, we will not show it.

- Introduced a new notification channel "HINTS" with
IMPORTANCE_DEFAULT.

Bug: 74120126
Test: Manual test with ll development/scripts/battery_simulator.py

Change-Id: I713abc59dc7caee6882ba848c3e3aabaf778c2bd
2018-03-27 10:42:05 -07:00
Rohan Shah
524cf7b68d [Notif] Add Blocking helper to swipe
Implemented blocking helper UI as part of guts - the
ExpandableNotificationRow that's swiped away is effectively detached
from the notification logic but kept in as a view in the layout (it'll
still show up when looping through the normal view hierarchy). We
purposefully open up NotificationInfo with the intent of showing it as
the blocking helper.

It's animated away/closed when the user interacts with any other content
or swipes away, as with guts (Can be changed in the future if we want it
to stick around for longer).

KIs, that will be tracked in bugs once CL is in:
- Swiping a notification if it's partially hidden by the shelf does not
bring it up into focus
- If only one notification is showing, the shade auto-closes as if it
didn't have any notifications (which it technically doesn't)
- Animation on multiple blocking helper shows cuts too early and doesn't
allow the notification to transition out
- Long press on notification dismisses (it should probably ignore it)
- Metrics are still missing
- Accessibility needs a runthrough

Bug: 63095540,73783854
Test: Visually & Ran all tests
Change-Id: Iaa5e3d5537bbb72c946fdd7ee35b155e22ca2b05
2018-03-27 10:14:47 -07:00
Rohan Shah
620da5249f Merge "[Notif] Disable long click listener after dismiss" into pi-dev 2018-03-27 17:06:51 +00:00
TreeHugger Robot
b429012907 Merge "Add link to notification app listing in shade" into pi-dev 2018-03-27 14:09:18 +00:00
TreeHugger Robot
a691b71e99 Merge "Show status labels in wifi QS tile." into pi-dev 2018-03-27 13:10:24 +00:00
TreeHugger Robot
fddbae9c78 Merge "Fix issue where bouncer would go away" into pi-dev 2018-03-27 02:37:35 +00:00
Amin Shaikh
e74dbdd364 Show status labels in wifi QS tile.
- Request a score for the current network upon network state change
- Track the status label (either sign in / no internet / wifi speed
label) in WifiStatusTracker/WifiSignalController

Bug: 74075761
Test: runtest systemui && visual

Change-Id: I0794b246683df769f6db79f2baf70a9226d8f0f1
2018-03-26 18:00:28 -04:00
Julia Reynolds
ed1c9af653 Add link to notification app listing in shade
Test: atest SystemUITests
Bug: 74318867
Change-Id: Ic309dfb08be0d41b7d524adc1b5910ab61b2d9fb
2018-03-26 17:14:48 -04:00
Lucas Dupin
6f0d71fbb4 Fix issue where bouncer would go away
Activities with the flag FLAG_DISMISS_KEYGUARD_ACTIVITY will try to
dismiss the keyguard. In this case we should show the occluded bouncer.

Ideally we should not show the lock screen, but at this point,
ActivityManager still doesn't know if the keyguard should be dismissed
or not.

Test: manual, edit emergency information on EmercencyDialer
Test: runtest -x cts/tests/framework/base/activitymanager/src/android/server/am/ActivityManagerDisplayLockedKeyguardTests.java
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardBouncerTest.java
Test: atest packages/SystemUI/tests/src/com/android/keyguard/KeyguardHostViewTest.java
Change-Id: I65b40ae47319c522c13ed3dc9420bc15cb472430
Fixes: 74726131
Fixes: 74779270
2018-03-26 13:51:45 -07:00
Lucas Dupin
0791d97e11 Fix flickering when switching display power modes
So far we've been Waiting for the next frame but it doesn't
mean that it will be visible on the screen.

We're usually rendering with 2 buffers and it's possible that
we'll switch the display power mode before anything has hit
the display.

Increased the timeout for now until we have a better alternative.

Change-Id: I63afc8a9139a4ccbba4f16f5569717e22217da9a
Fixes: 72527083
Test: manual
Test: packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
2018-03-26 13:32:16 -07:00
Rohan Shah
c6990a019f [Notif] Disable long click listener after dismiss
Fix for blocking helper - disable long click after the main notification
has been dismissed, in preparation for the blocking helper (which can't
be long pressed)

Test: Visually
Change-Id: I78795df4e77cb8d51382c1103bfa4ce02c1a11f3
Fixes: 76227576
2018-03-26 12:25:28 -07:00
TreeHugger Robot
525b182864 Merge "Add flag to control blocking Smart Replies for apps targeting an Android version below P." into pi-dev 2018-03-23 22:07:15 +00:00
Richard Ledley
4069f7a167 Add flag to control blocking Smart Replies for apps targeting an Android version below P.
Bug: 73802997

Test: atest SmartReplyConstantsTest

Change-Id: Id340cba09da7931ff6a4689802b3a5f594852a72
(cherry picked from commit 28944cbdcf)
2018-03-23 21:14:27 +00:00
Amin Shaikh
c5b1bc80bc Ensure TileQueryHelper#mTiles is thread safe.
- Ensure TileQueryHelper#mTiles is only modified on the background
thread and a send a copy to listeners.
- Do not call onTilesChanged until all stock tiles are loaded (as
opposed to after each tile) to reduce tile spec recalculation.
- Remove completion callback and instead maintain query state in
TileQueryHelper

Bug: 75415415
Test: manually
Change-Id: I2a20bd916dae0ee9f4c422ec4e2ac3f2d47da3dc
2018-03-23 15:23:08 -04:00
TreeHugger Robot
afc61792cb Merge "Have the status bar listen to all macro-users VPN changes." into pi-dev 2018-03-23 09:26:46 +00:00
TreeHugger Robot
194cca21b1 Merge "Fixed an issue where the heads-up icon location was wrong" into pi-dev 2018-03-23 03:39:29 +00:00
TreeHugger Robot
4cfd9f242c Merge changes I2d09a84e,I111aab35 into pi-dev
* changes:
  Do not show bouncer when fading away
  KeyguardBouncer#isShowing fix
2018-03-23 03:23:27 +00:00
TreeHugger Robot
65cb06cfc5 Merge "Fixed an issue where the roundness of a notification could be wrong" into pi-dev 2018-03-22 23:55:10 +00:00
Selim Cinek
60ffea6400 Fixed an issue where the heads-up icon location was wrong
Because of configuration changes, old listeners would still
be influencing the icon location, even after they were detached.

Test: runtest systemui
Test: change density, get heads-ups, observe correct position
Change-Id: I35f4c905ab8a6025476c582dcbc7e85a5eff23f5
Fixes: 76084585
2018-03-22 16:36:33 -07:00
Lucas Dupin
28dc9d7dfd Do not show bouncer when fading away
Change-Id: I2d09a84ec7cda04dab3095f16f3c6e3acd425c76
Fixes: 76035580
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardBouncerTest.java
Test: double tap on notification, dismiss bouncer
Test: swipe up, dismiss bouncer
Test: go to emergency dialer, hit back
Test: fp from lock screen
Test: fp from AOD
2018-03-22 23:20:19 +00:00
Lucas Dupin
3d565fa8dd KeyguardBouncer#isShowing fix
KeyguardBouncer.isShowing should not return
true when the view is hidden.

Change-Id: I111aab356f6fc2367816b2ac132c0c4b140864c3
Fixes: 74583436
Fixes: 76151115
Test: packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardBouncerTest.java
Test: Swipe up on lock screen
Test: Unlock with fp from AOD, keyguard or bouncer
Test: Unlock from occluded bouncer
2018-03-22 23:19:31 +00:00
Selim Cinek
8875de1d08 Fixed an issue where the roundness of a notification could be wrong
When animating away a heads-up, there was no listener in place and
if the view in question wasn't the first notification, it's
roundness could be wrong.

Change-Id: I0676ee18c9fb0c52b190b82b8b9adfa63d584262
Fixes: 76147670
Test: runtest systemUI
2018-03-22 15:19:36 -07:00
Chalard Jean
616ede0964 Have the status bar listen to all macro-users VPN changes.
Bug: 73217368
Test: manual
      Using Datally on work profile. Before this, enabling the VPN
      does not show the key icon. After this it does.

Change-Id: I454eb8f3881a48af1b0187c2b14a2a399d3c2445
2018-03-22 13:25:52 +09:00
TreeHugger Robot
f2e00697a5 Merge "add car volume dialog" into pi-dev 2018-03-21 20:07:41 +00:00
TreeHugger Robot
6e7e028b62 Merge "Screen off animation" into pi-dev 2018-03-21 02:57:19 +00:00
Selim Cinek
db0e4f1d73 Merge changes from topic "heads_up_redesign" into pi-dev
* changes:
  Added new appear and disappear animations for heads up
  Polished the heads up experience
  Removed the heads up scrim and replaced it with more elevation
  Insetting heads up notifications
  Ensured that the heads-up notifications are always rounded
2018-03-21 00:53:50 +00:00
Lucas Dupin
16cfe45dec Screen off animation
SysUI can now control the screen off animation as long as
config_dozeAfterScreenOff is set to false.

The current implementation collapses the notification shade and moves
the clock whenever the use is on the lock screen, or will fade the
scrims and show the clock when the keyguard is occluded.

Display state change (on, doze, doze_suspended) is delayed to let the
animations occur at 60Hz.

Test: atest packages/SystemUI/tests/src/com/android/systemui/doze/DozeUiTest.java
Test: atest packages/SystemUI/tests/src/com/android/systemui/doze/DozeWallpaperStateTest.java
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Test: atest tests/src/com/android/systemui/statusbar/phone/DozeScrimControllerTest.java
Test: atest tests/src/com/android/systemui/statusbar/phone/DozeParametersTest.java
Test: atest packages/SystemUI/tests/src/com/android/systemui/keyguard/WakefulnessLifecycleTest.java
Fixes: 73178121
Change-Id: Id5d964452f342d4e97bedf1084efa808604e602c
2018-03-20 15:59:51 -07:00
Selim Cinek
99e9adf519 Removed the heads up scrim and replaced it with more elevation
Fixes: 72748440
Test: runtest systemui
Change-Id: Id1eb413a2a44589727d212c0fefe3a1b742bb25e
2018-03-20 15:36:21 -07:00
Selim Cinek
aa9db1f34f Insetting heads up notifications
Heads up notifications are now corretly respecting insets.
instead of overlapping with any possible notches, we're
insetting heads up notifications and splitting the main
content from the header.

Fixes: 72748440
Test: runtest systemui
Change-Id: Ie53ea31fef4e468239c4346f9d1f192bcb26e11d
2018-03-20 15:36:17 -07:00
Selim Cinek
29aab967ba Ensured that the heads-up notifications are always rounded
Previously they would have a random rounding. We're now introducing
a roundness manager that isolates this from the notification list.

Bug: 72748440
Test: runtest systemui
Change-Id: I5e9e7528a55536c802b5262168664e47fbec310e
2018-03-20 15:33:53 -07:00
Beverly
5a20a5ed2f Ability to hide/unhide suspended app notifications
Test: NotificationListenerVerifierActivity.java
Test: atest NotificationDataTest NotificationListenerServiceTest NotificationManagerServiceTest
Bug: 73965645
Change-Id: I49a02e9fd84dfaa1891437a5d8fc52109a43cded
2018-03-20 17:40:36 -04:00
Lucas Dupin
b5438ce105 Merge changes I09f58bdc,Iaf6cee33 into pi-dev
* changes:
  Hide SHOW_WHEN_LOCKED activity under scrim
  Temporarily show wallpaper when pulsing
2018-03-20 18:16:02 +00:00
Amin Shaikh
c7593b1e1a Do not display <unknown ssid>.
Fixes: 73853121
Test: runtest systemui
Change-Id: Ib16a63cb9edfbd287724500adf515287f12c0d07
2018-03-20 11:43:16 +00:00
TreeHugger Robot
31d58db7c3 Merge "@ignore flaky test" into pi-dev 2018-03-20 07:47:54 +00:00
Lujiang Xue
e53f749995 add car volume dialog
Bug: 73134851

Test: manually tested

Change-Id: Ia95a8aa48789652d6af67a542f62353a7bf13607
(cherry picked from commit 4d2a3ef6e9)
2018-03-19 22:38:17 +00:00
Lucas Dupin
d51073055e Hide SHOW_WHEN_LOCKED activity under scrim
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Test: atest packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/StatusBarTest.java
Test: visual
Bug: 72660912
Change-Id: I09f58bdc3712aec7d601c5318b34fea9088d7ae5
2018-03-19 15:35:42 -07:00
Alison Cichowlas
ffe3a21317 @ignore flaky test
Bug: 75303426
Test: this is it
Change-Id: Iad3a571131d6acce232cc8000a1e01b7d6eeba98
2018-03-19 13:22:58 -04:00
Amin Shaikh
329c828f18 Update mobile data off dialog.
Show the mobile data turn off dialog until the user taps the turn off
button. All subsequent toggles will immediately toggle data on/off. Also
update the message copy.

Fixes: 74072757
Test: runtest systemui && manual
Change-Id: I489d5c3c19d52a6f531b1b925b3210019412243b
2018-03-19 10:53:21 -04:00
TreeHugger Robot
0487601e57 Merge "Disable scrim focus on AOD" into pi-dev 2018-03-19 05:03:50 +00:00
Lucas Dupin
f5d216cc7c Merge changes Ia438f4a2,I356c2d57 into pi-dev
* changes:
  Bouncer notification and QS scrim
  Fix bouncer not showing on top of QS or notif
2018-03-19 03:11:51 +00:00
Andreas Gampe
66745e929c SystemUI: Temporarily disable test
Bug: 75329085
Test: none
Exempt-From-Owner-Approval: Let TH pass while investigating
Change-Id: I4c007e5162502f0064b65a89408882e4c348e0db
2018-03-18 15:50:30 -07:00
Lucas Dupin
05726cd4b6 Bouncer notification and QS scrim
Show front scrim when the notification panel is expanded,
otherwise pin would be overlayed on top of notifications.

Change-Id: Ia438f4a2794eb9510ec05ad86cc8c19e2e716358
Fixes: 74550013
Test: double tap on notification when locked
Test: tap on QS edit button when locked
Test: unlock by swipping up
Test: fling quickly on keyguard
2018-03-18 09:10:09 -07:00
Lucas Dupin
38962d7821 Disable scrim focus on AOD
Test: tests/src/com/android/systemui/statusbar/phone/ScrimControllerTest.java
Change-Id: I5ca941454fe7d0d058970323838b1f3e94fa5f33
Fixes: 74726963
2018-03-16 12:30:44 -07:00
Lucas Dupin
0df9b7a893 Fix bouncer not showing on top of QS or notif
Bug: 74726131
Test: packages/SystemUI/tests/src/com/android/systemui/statusbar/phone/KeyguardBouncerTest.java
Test: unlock with fp
Test: unlock with pattern
Test: edit QS - look at bouncer
Test: tap on notification when locked
Change-Id: I356c2d5700531cc9bb9b4179f12d4fd65f8bfc41
2018-03-16 10:52:50 -07:00
Alan Viverette
259dd151f4 Merge "Restore "Update packages for 1.0.0-beta1"" into pi-dev 2018-03-16 13:53:46 +00:00
Alan Viverette
e893588f19 Restore "Update packages for 1.0.0-beta1"
This reverts commit f980f54a75.

Bug: 74950017
Test: manual
Change-Id: I793ec0f6c2ba6a141481f8d03e85b791dd8a73d1
2018-03-15 21:21:54 +00:00
Alan Viverette
5b07f94a95 Merge "Revert "Update packages for 1.0.0-beta1"" into pi-dev 2018-03-15 20:04:22 +00:00