Commit Graph

1352 Commits

Author SHA1 Message Date
Felipe Leme
ec150609e4 Fixed AutofillServiceHelper.assertValid() so it throws the right exception.
Test: atest FillResponseTest SaveInfoTest
Bug: 76097200

Change-Id: Id643007e2d038cc6948cdb8d66c5454048d5f632
2018-03-23 14:09:02 -07:00
Felipe Leme
63df4e248a Merge "Improved autofill logging and dumping." into pi-dev 2018-03-23 05:48:26 +00:00
Felipe Leme
0cdac33f8f Merge "Always set FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE on SaveInfo when on compat mode." into pi-dev 2018-03-23 01:05:29 +00:00
Felipe Leme
da9ea34c02 Improved autofill logging and dumping.
Bug: 76027553
Test: adb shell dumpsys autofill

Change-Id: I19ef88c71334c62292ed982e43d7a7e89b35f10e
2018-03-22 16:43:28 -07:00
TreeHugger Robot
3a31f6c5cc Merge "Removed urlBarResourceId." into pi-dev 2018-03-22 22:22:30 +00:00
Felipe Leme
4f74a018c8 Always set FLAG_SAVE_ON_ALL_VIEWS_INVISIBLE on SaveInfo when on compat mode.
Test: atest CtsAutoFillServiceTestCases:VirtualContainerActivityCompatModeTest

Bug: 76027553

Change-Id: I432b4321801ca90a55a24e5e896578d5b2d63014
2018-03-22 13:30:59 -07:00
Felipe Leme
88b745cce3 Removed urlBarResourceId.
It will be removed before the final P build.

Test: atest FrameworksServicesTests:AutofillManagerServiceTest CtsAutoFillServiceTestCases
Fixes: 74445943

Change-Id: I9bc243a3c1ae78f2c385dbb907d362d8ab16b34c
2018-03-22 11:44:06 -07:00
Felipe Leme
de6dfd93e5 Merge "Don't allow null ids on FillResponse.Builder.setAuthentication()" into pi-dev 2018-03-22 17:36:18 +00:00
Felipe Leme
df0b0d380d Fixed autofill service metadata name on javadoc sample.
Bug: 72811034
Test: nope

Change-Id: I0367fa6ad1fa21c51dadb9706830bc50c3139cab
2018-03-22 08:40:52 -07:00
Felipe Leme
2596089146 Don't allow null ids on FillResponse.Builder.setAuthentication()
It would crash the system when save is invoked.

The issue was reproduced by passing a null id on
AuthenticationTest#testFillResponseAuthServiceHasNoDataButCanSave , but that
change was not committed because with the fix the builder would throw an
exception.

Test: atest CtsAutoFillServiceTestCases:FillResponseTest

Fixes: 76097200

Change-Id: Ifa8105ee1451ba7107082a94a538a8f84f50df18
2018-03-21 14:13:17 -07:00
TreeHugger Robot
6c0f42b3b5 Merge "Ability to hide/unhide suspended app notifications" into pi-dev 2018-03-20 23:38:36 +00:00
TreeHugger Robot
764f123b97 Merge "Check if the given user is unlocked when unlock by token" into pi-dev 2018-03-20 23:36:37 +00:00
Beverly
5a20a5ed2f Ability to hide/unhide suspended app notifications
Test: NotificationListenerVerifierActivity.java
Test: atest NotificationDataTest NotificationListenerServiceTest NotificationManagerServiceTest
Bug: 73965645
Change-Id: I49a02e9fd84dfaa1891437a5d8fc52109a43cded
2018-03-20 17:40:36 -04:00
Hongwei Wang
bab773d23f Check if the given user is unlocked when unlock by token
Bug: 76010226
Test: None

Change-Id: I2ceea0f185c5e54a9c2a529a9cf8db78587c4072
2018-03-20 09:55:31 -07:00
TreeHugger Robot
8cf1ae4928 Merge "Auto zen rules reset for some upgrading users" into pi-dev 2018-03-20 16:51:10 +00:00
Beverly
4e2f76c3ef Auto zen rules reset for some upgrading users
Automatic zen rules will be set to the undeletable,
default rules for for fresh P devices and for upgrading users
who didn't have any zen automatic rules enabled on upgrade

Bug: 74381638
Test: atest ZenModeHelperTest
Change-Id: Icfa7dfe6c99cb9d67821df0034d5e9a3457b2ef4
2018-03-20 09:31:29 -04:00
Felipe Leme
4cd1ae0cb1 Cosmetic changes on Field Classification TODOs and docs.
Test: in TreeHugger we trust!
Bug: 73648631

Change-Id: I9390fb570e18e9636da2de27e2bc6186d5958e41
2018-03-15 16:00:26 -07:00
TreeHugger Robot
197ea9e3a5 Merge "TextClassifierService.onSelectionEvent" into pi-dev 2018-03-12 21:35:25 +00:00
Abodunrinwa Toki
ad52f4b97c TextClassifierService.onSelectionEvent
Bug: 74466564
Bug: 67609167
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit FrameworksCoreTests:android.view.textclassifier.logging.SelectionEventTest
Merged-In: Ib5af1ec80a38432d1201fbc913acdc3597d6ba82
Change-Id: Ib5af1ec80a38432d1201fbc913acdc3597d6ba82
2018-03-12 19:32:51 +00:00
TreeHugger Robot
9e56800b6e Merge "Moved urlBarResourceId from autofill service manifest to whitelist settings." into pi-dev 2018-03-12 18:53:10 +00:00
Abodunrinwa Toki
e6d974a567 Allow TextClassifierServices to get a hold of a local TextClassifer.
Test: builds
Bug: 74466564
Bug: 72747726
Merged-In: Idb108f2b3d95393a051f9f19b0c04fc4e3ed2b33
Change-Id: Idb108f2b3d95393a051f9f19b0c04fc4e3ed2b33
2018-03-12 18:04:24 +00:00
Felipe Leme
1c7eb0c8eb Moved urlBarResourceId from autofill service manifest to whitelist settings.
The manifest attribute is still public as it might have been used by autofill
services deployed against P DP1; it will be removed after the next developer
previs is branched out. We also need to assumie a default value for the buttons
if not specified by settings, but that will be done in a separate change so it
can be easily reverted.

Also implemented support for multiple buttons, and added unit tests.

Test: atest CtsAutoFillServiceTestCases:VirtualContainerActivityCompatModeTest \
CtsAutoFillServiceTestCases:VirtualContainerActivityTest \
FrameworksServicesTests:AutofillManagerServiceTest

Bug: 74445943
Bug: 72811561
Fixes: 73786629

Change-Id: I066ecf40fde2c5318dd8633a659fca8b7af8aecd
2018-03-12 10:11:20 -07:00
Julia Reynolds
ccc6ae64ff Expand the visual effects that DND can suppress.
Additionally default to disabling all visual effects when DND is on,
to gather dogfood feedback.

The 'dnd has changed' notification will be reposted after this
CL and has updated text.

Test: runtest systemui-notification
Bug: 74075050
Change-Id: I5bec8ccc6456d98112907b0264ecd52734983984
2018-03-08 09:48:16 -05:00
Adrian Roos
b8d853732c Merge "Window: Provide frame size hint to ViewRootImpl" into pi-dev 2018-03-07 22:58:34 +00:00
TreeHugger Robot
5a169cf2f6 Merge "System sounds get its own dnd toggle" into pi-dev 2018-03-07 16:39:40 +00:00
Adrian Roos
9e370f2912 Window: Provide frame size hint to ViewRootImpl
Provides a better estimate to the ViewRootImpl about the likely
window frame size than it can get from the configuration, which
allows it to avoid unneccessary measure passes.

Bug: 73813813
Test: atest PhoneWindowManagerLayoutTest
Change-Id: Ia4de6509416d90eed61929ce1646904c31afdd8d
2018-03-07 16:53:54 +01:00
Holly Jiuyu Sun
435c213e9d Remove toString() for CarrierIdentifier.
We may get NPE if mCarrierIdentifier is null. + should convert it to
string by itself.

Test: test on phone
Merged-In: Ibd352d6d2a9b0cb33a494d108eb0d3a7c1dbc61b
Change-Id: Ibd352d6d2a9b0cb33a494d108eb0d3a7c1dbc61b
2018-03-06 16:40:27 -08:00
Beverly
d696476fb3 System sounds get its own dnd toggle
- Added logic for streams to be muted by dnd (unassociated with ringer)

Test: runtest -x frameworks/base/services/tests/uiservicestests/src/com/android/server/notification/ZenModeHelperTest.java
Bug: 73362490
Change-Id: I1101e67282f7331497e91eb510d2bf4f1ea6b4b1
2018-03-06 09:08:29 -05:00
TreeHugger Robot
964f01b328 Merge "Fixed issues with legacy usages of notification people" 2018-02-27 23:16:56 +00:00
Benjamin Miller
604843bda6 Docs: added a note about about notification listeners and work profiles.
Stated that NotificationListenerService is ignored when running in the work profile.
A NotificationListenerService might not see notifications from the work profile if an IT admin blocks personal apps.
Staged at:
  http://go/dac-stage/reference/android/service/notification/NotificationListenerService.html

Test: Run make ds-docs and review
Bug: 67907973
Change-Id: Ie37cf8f576dc228e6c8ba074f389595fdebcdf9c
2018-02-27 11:33:52 +00:00
Selim Cinek
5390e7d7ac Fixed issues with legacy usages of notification people
Change-Id: Iac0caf2c97532913a7072a18af91791d2888bfd8
Fixes: 72110655
Test: runtest -x tests/app/src/android/app/cts/NotificationTest.java
2018-02-26 18:22:55 -08:00
Erik Wolsheimer
5fb1070b1f Guard against updateDoze after detach
Bug: 68815183
Change-Id: I147f04af4ea1af59f95757a14de3c34021e048a5
2018-02-23 17:57:30 +00:00
Eugene Susla
e2e3b77aad Merge "Use PooledLambda in autofill code" 2018-02-21 21:32:42 +00:00
Eugene Susla
9f1921f9ff Use PooledLambda in autofill code
This replaces the usage of handler message types with PooledLambda

Bug: 73648631
Test: atest CtsAutoFillTestCases
Change-Id: I3be0870116489c0c831353fe4ab9abed3cac3a93
2018-02-21 19:47:18 +00:00
Makoto Onuki
700feef8a6 Shortcut permissions for default text classifier
- Add two shortcut related permissions as SystemAPI for the default
text classifier.

- The default text classifier package name still comes from the
system resource.

Bug: 73083596
Bug: 71555985
Test: atest CtsPermission2TestCases
Test: Manual test with a test package, with the following in config.xml
<string name="config_defaultTextClassifierPackage" translatable="false">com.example.android.pm.shortcutlauncherdemo</string>

Change-Id: I19081d9d6ba0b33eb25d19aa55b4fe2f26a75897
2018-02-20 12:14:18 -08:00
TreeHugger Robot
e9aa338817 Merge "Autofill Field Classification improvements." 2018-02-15 08:06:45 +00:00
TreeHugger Robot
d1da52edb9 Merge "Uses ICU DateFormat on new Autofill APIs." 2018-02-15 06:03:38 +00:00
Felipe Leme
febb733c1b Autofill Field Classification improvements.
* Changed the remoteId -> userValue API to userValue -> categoryId so the
  category could map to multiple values (for example,
  "email" -> "email1", "email2")
* Added method and settings for maximum number of category ids.
* Tuned the default value of some settings.

Bug: 70407264

Test: atest CtsAutoFillServiceTestCases:UserDataTest \
            CtsAutoFillServiceTestCases:FieldsClassificationTest \
	    SettingsBackupTest

Change-Id: I27f348c500077937c0f4bf65db6a899fa3c41cf6
2018-02-14 20:27:55 -08:00
Svetoslav Ganov
a6ebff0f0b Don't hold the autofill lock when looking up fill compat packages
Test: cts-tradefed run cts-dev -m CtsAutoFillServiceTestCases

Bug:73072565

Change-Id: I773e1e2f4ceedbe45c9389a065dc7f6fb0ab65b1
2018-02-14 18:18:41 -08:00
Felipe Leme
27206d7940 Uses ICU DateFormat on new Autofill APIs.
Test: atest CtsAutoFillServiceTestCases:DateTransformationTest \
            CtsAutoFillServiceTestCases:DateValueSanitizerTest
Fixes: 73392044
Fixes: 73392214

Change-Id: I26d20691d8fd68c4c2837f27cc0eee939bb9bf0b
2018-02-14 18:18:22 -08:00
TreeHugger Robot
4963ce8efc Merge "Add support for url_bar sanitization on autofill compat mode." 2018-02-14 20:22:31 +00:00
Felipe Leme
185de72695 Add support for url_bar sanitization on autofill compat mode.
Browsers typically use a standard class (like EditView) to hold the URL of the
page being loaded, and the content of that view is sanitized in the initial
autofill request. So, when running in compat mode, we need a mechanism to let
services tell which view contains the URL, so we can convert its contents to
a sanitized webScheme + webDomain pair or properties.

Test: manual verification
Fixes: 72994424

Change-Id: I8be5f3533d6c31f81f28036dc51d5de10a528079
2018-02-14 09:43:21 -08:00
Beverly
3bae4e5d86 Zen upgrade notification
Test: runtest --path /extra/master/frameworks/base/services/tests/uiservicestests/src/com/android/server/notification/ZenModeHelperTest.java
Change-Id: Ia31f89af74d9bcee40e050bd6cc13f1e6a9a15d9
Fixes: 73000503
Fixes: 72876890
Fixes: 73110052
2018-02-13 17:29:59 -05:00
Qingxi Li
ceb94979e3 Merge "Public EuiccManager APIs." 2018-02-12 22:09:53 +00:00
TreeHugger Robot
40279e5407 Merge changes I6993325b,Icb5114fe
* changes:
  Frameworks: Annotate trivial @GuardedBy in services/core
  Frameworks: Annotate trivial @GuardedBy in core/java
2018-02-08 23:32:03 +00:00
Holly Jiuyu Sun
4f73b9c09a Public EuiccManager APIs.
Public EuiccManager and other related necessary files.
Mark EuiccCardManager and other related necessary files as @SystemApi.
Solve lint errors and warnings.

Bug: 35851809
Test: test on phone
Change-Id: I68853e134e1e31fa9b91a83af6c491a2a8cca971
2018-02-08 11:12:30 -08:00
Jiuyu Sun
d3bb4aed78 Revert "Public EuiccManager APIs."
This reverts commit af6a5fffdc.

Reason for revert: <INSERT REASONING HERE>

Change-Id: Id3296a91e5c3ad624a6a03f6532b859524a518bf
2018-02-08 16:38:26 +00:00
Andreas Gampe
3f24e69dbe Frameworks: Annotate trivial @GuardedBy in core/java
Add @GuardedBy for simple functions that require a single lock
and are named XYZLocked.

Bug: 73000847
Test: m
Test: m javac-check-framework RUN_ERROR_PRONE=true
Change-Id: Icb5114fea2ff2385e1cc7511121026099e05c0ee
2018-02-08 02:19:42 -08:00
Holly Jiuyu Sun
af6a5fffdc Public EuiccManager APIs.
Public EuiccManager and other related necessary files.
Mark EuiccCardManager and other related necessary files as @SystemApi.
Solve lint errors and warnings.

Bug: 35851809
Test: test on phone
Change-Id: Id7895f9b35ce9d4fb6fae42ba89ca9b29dbfa74c
2018-02-07 11:09:27 -08:00
felipeal
d1d0e4ae1a Dump autofill compat packages.
Test: manual verification
Bug:72811034

Change-Id: Iee815a84e4ff9fa1ace9301b5da7c883d4e753b8
2018-02-05 15:51:17 +01:00