Commit Graph

28 Commits

Author SHA1 Message Date
Jeff Sharkey
fab0ab3c9c Improve OWNERS coverage across frameworks/base/.
As general background, OWNERS files expedite code reviews by helping
code authors quickly find relevant reviewers, and they also ensure
that stakeholders are involved in code changes in their areas.

Some teams under frameworks/base/ have been using OWNERS files
successfully for many years, and we're ready to expand them to cover
more areas.  Here's the historical coverage statistics for the last
two years of changes before these new OWNERS changes land:

-- 56% of changes are fully covered by OWNERS
-- 17% of changes are partially covered by OWNERS
-- 25% of changes have no OWNERS coverage

Working closely with team leads, we've now identified clear OWNERS on
a per-package basis, and we're using "include" directives whenever
possible to to simplify future maintenance.  With this extensive
effort, we've now improved our coverage as follows:

-- 98% of changes are fully covered by OWNERS
-- 1% of changes are partially covered by OWNERS
-- 1% of changes have no OWNERS coverage

This specific change is automatically generated by a script from
detailed ownership information confirmed by team leads.

Bug: 174932174
Test: manual
Exempt-From-Owner-Approval: refactoring with team leads buy-in
Merged-In: I9789c97c1de8e5d962b48c29c57d82fe83729eba
Change-Id: I9789c97c1de8e5d962b48c29c57d82fe83729eba
2020-12-08 08:36:27 -07:00
Mathew Inwood
5d123b6775 Add maxTargetSdk restriction to unused APIs.
These are APIs that have @UnsupportedAppUsage but for which we don't
have any evidence of them currently being used, so should be safe to
remove from the unsupported list.

Bug: 170729553
Test: Treehugger
Merged-In: I626caf7c1fe46c5ab1f39c2895b42a34319f771a
Change-Id: I54e5ecd11e76ca1de3c5893e3a98b0108e735413
2020-11-04 09:45:53 +00:00
Peter Wang
4c7b55f086 Merge "Add a null check for EuiccProfileInfo access rules at creation" am: 65f6068c8a am: 098fb8606a
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/1364082

Change-Id: Icca17231fe6b7386e18b9c44a22eebdca2336f24
2020-07-16 09:34:33 +00:00
Peter Wang
548f34b47d Add a null check for EuiccProfileInfo access rules at creation
Bug: 158780604
Fix: 158780604
Test: Build
Change-Id: I6432499309115c7ca29f4704e0f5cfc871eb4d00
Merged-In: I6432499309115c7ca29f4704e0f5cfc871eb4d00
2020-07-15 17:34:27 -07:00
Svet Ganov
d459a8da1e Revert an API breaking changes
bug:150281259

Test: N/A

Exempt-From-Owner-Approval: porting upstream

Change-Id: Ie30286456af15dd7b81bceb0547ffe8bfac422d2
Merged-In: Ie30286456af15dd7b81bceb0547ffe8bfac422d2
2020-05-03 05:38:43 +00:00
Hunter Knepshield
dcd87bf35c Forward IBinder#dump to CarrierService#dump
This will allow CarrierConfigLoader to dump packages' bound carrier
services as part of bug reports when appropriate.

Bug: 146521742
Test: manual with modified CarrierConfigLoader + dumpsys carrier_config
Change-Id: Ie3aef4216e7a42e5e4cc5ba4a3978b9c4dda50dd
Merged-In: Ie3aef4216e7a42e5e4cc5ba4a3978b9c4dda50dd
(cherry picked from commit 05a57b6f5e)
2020-03-23 11:01:35 -07:00
Alex Lin
20faafc483 Update EuiccService encodeSmdxSubjectAndReasonCode am: 2c3cc82819 am: 1fb2e3e4fc
Change-Id: I54d7779e0def1eda1b96edb2ae07d4f131e10871
2020-03-17 23:43:27 +00:00
Alex Lin
2c3cc82819 Update EuiccService encodeSmdxSubjectAndReasonCode
Update the method signature of encoding subject code and reasoncode
Bug: 149216056
Test: atest EuiccService

Change-Id: Ifb9c1a11f48e191f7d49384946f9fd78d81b84dc
Merged-In: Ifb9c1a11f48e191f7d49384946f9fd78d81b84dc
2020-03-13 18:32:52 -07:00
Alex Lin
e61b636a61 Add public error codes to Euicc public API
Adding public error codes to euicc public API, this will allows the user
to get an general idea of what went wrong when calling the Euicc APIs
Bug: 143107744
Test: atest EuiccService, atest EuiccManager

Change-Id: I427f17e8f28fa4a646a63299a1f63c4c5970a5a0
Merged-In: I427f17e8f28fa4a646a63299a1f63c4c5970a5a0
2020-03-13 18:25:14 -07:00
Amit Mahajan
f035fd91aa Move euicc related file to telephony.
All other files were moved earlier. This is a newly added file
that was added in the old location.

Test: basic sanity
Bug: 140908357
Merged-in: I756b5834ddb1031627168a17dc49ce93b5af8219
Change-Id: I756b5834ddb1031627168a17dc49ce93b5af8219
(cherry picked from commit 235289719b)
2020-02-24 17:59:17 -08:00
Hunter Knepshield
05a57b6f5e Forward IBinder#dump to CarrierService#dump
This will allow CarrierConfigLoader to dump packages' bound carrier
services as part of bug reports when appropriate.

Bug: 146521742
Test: manual with modified CarrierConfigLoader + dumpsys carrier_config
Change-Id: Ie3aef4216e7a42e5e4cc5ba4a3978b9c4dda50dd
2020-02-14 13:33:04 -08:00
Alex Lin
d0c492f00f Add public API for EuiccService log dump
Add public APi to EuiccService which allows the connected LPA to dump
out the logs when a bug report is triggered.
Bug: 62881779
Test: manually tested by extracting bug report to see if the logs are
present and atest EuiccServiceTest

Change-Id: I0869b95d12ab87a5e2a255015549191040d9daa7
Merged-In: I0869b95d12ab87a5e2a255015549191040d9daa7
2020-01-31 14:05:58 -08:00
Meng Wang
e3387ef9c4 Fix import of Rlog - generated by formatting tool
Test: make
Merged-In: Ibe36c6d0fe8bfb6277d7b9034af8dbf45ce2f716
Change-Id: Ibe36c6d0fe8bfb6277d7b9034af8dbf45ce2f716
2020-01-30 12:38:32 -08:00
Meng Wang
1dbea2f840 Fix import of Rlog - generated by formatting tool
Test: make
Change-Id: Ibe36c6d0fe8bfb6277d7b9034af8dbf45ce2f716
2020-01-30 12:25:08 -08:00
Amit Mahajan
235289719b Move euicc related file to telephony.
All other files were moved earlier. This is a newly added file
that was added in the old location.

Test: basic sanity
Bug: 140908357
Change-Id: I756b5834ddb1031627168a17dc49ce93b5af8219
2020-01-23 18:14:46 -08:00
Alex Lin
aac0588d15 Add public error codes to Euicc public API
Adding public error codes to euicc public API, this will allows the user
to get an general idea of what went wrong when calling the Euicc APIs
Bug: 143107744
Test: atest EuiccService, atest EuiccManager

Change-Id: I427f17e8f28fa4a646a63299a1f63c4c5970a5a0
2020-01-22 13:20:04 -08:00
Alex Lin
2fb59151dc Add public API for EuiccService log dump
Add public APi to EuiccService which allows the connected LPA to dump
out the logs when a bug report is triggered.
Bug: 62881779
Test: manually tested by extracting bug report to see if the logs are
present and atest EuiccServiceTest

Change-Id: I0869b95d12ab87a5e2a255015549191040d9daa7
2020-01-17 13:59:16 -08:00
Treehugger Robot
c764cb634d Merge "Use new UnsupportedAppUsage annotation." 2020-01-15 13:29:02 +00:00
Artur Satayev
53ada2ab28 Use new UnsupportedAppUsage annotation.
Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.

Bug: 145132366
Test: m && diff unsupportedappusage_index.csv \
      git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'
Merged-In: I853372f3c6fef905553bb31be4f1bb48df735f7a
Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
2020-01-14 15:54:55 +00:00
Meng Wang
6d3e821058 Use com.android.telephony.Rlog for mainline module.
Bug: 144374158
Test: make
Merged-In: I86a479affb8e0fa8e48734324a6a05c68230d910
Change-Id: I86a479affb8e0fa8e48734324a6a05c68230d910
2020-01-13 10:32:55 -08:00
Meng Wang
cb1aa8d29c Merge "Use com.android.telephony.Rlog for mainline module." 2020-01-10 01:11:38 +00:00
Meng Wang
b8ffe81593 Use com.android.telephony.Rlog for mainline module.
Bug: 144374158
Test: make
Change-Id: I86a479affb8e0fa8e48734324a6a05c68230d910
2020-01-09 04:42:58 +00:00
Artur Satayev
2ebb31c00c Use new UnsupportedAppUsage annotation.
Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.

Bug: 145132366
Test: m && diff unsupportedappusage_index.csv \
      git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'

Change-Id: I853372f3c6fef905553bb31be4f1bb48df735f7a
2020-01-08 16:06:00 +00:00
Austin Wang
a63a2c0130 Revert "Use new UnsupportedAppUsage annotation."
This reverts commit a5264903e2.

Reason for revert: Droidcop-triggered revert due to breakage https://android-build.googleplex.com/builds/quarterdeck?branch=git_master&target=sdk_phone_armv7-sdk&lkgb=6083299&lkbb=6085371&fkbb=6083313, bug b/146533269

Change-Id: Ie5b031d7b277cf0e09b0a9776b26bf74f5f69e70
2019-12-19 06:38:19 +00:00
Artur Satayev
a5264903e2 Use new UnsupportedAppUsage annotation.
Existing annotations in libcore/ and frameworks/ will deleted after the migration. This also means that any java library that compiles @UnsupportedAppUsage requires a direct dependency on "unsupportedappusage" java_library.

Bug: 145132366
Test: m && diff unsupportedappusage_index.csv \
      git diff HEAD^ HEAD | grep '^[+-][^+-]' | grep -v '.import'
Change-Id: I087bb1cecbe59f1cf0c2e770c735d7a433722c6f
2019-12-18 12:07:36 +00:00
Meng Wang
4d1971e880 Merge "Move android.service.euicc.* into telephony" 2019-11-27 21:23:59 +00:00
Meng Wang
2b8d61158d Move android.service.euicc.* into telephony
Bug: 145232482
Test: make
Change-Id: I9dc5c904761f688e7abecea47647da29f6cec512
2019-11-27 19:15:55 +00:00
Meng Wang
a9ed606636 Move CarrierIdentifier/CarrierService to telephony
Bug: 145232482
Test: make
Change-Id: I9ba0618bb6f95f5caadc3ac9ac75e97efa5573c6
2019-11-27 19:15:37 +00:00