Commit Graph

27509 Commits

Author SHA1 Message Date
Will Brockman
9eda5f5e32 Merge "Notification statsd logs: Notification panel." into rvc-dev 2020-03-01 17:51:04 +00:00
Lucas Dupin
7f1c80da68 Merge "Ignore falsing manager for UiAutomator tests" into rvc-dev 2020-02-29 21:12:59 +00:00
Lucas Dupin
13b8cec66f Ignore falsing manager for UiAutomator tests
Device performance and dropped frames on cloud devices makes it very
likely that touches will be misinterpreted, increasing flakiness of
the tests.

Bug: 149828540
Test: atest --test-mapping frameworks/base/packages/SystemUI:platinum-postsubmit
Change-Id: Ia9b4152b2662fa5a7442cacfd1a87064b037ea0c
2020-02-28 17:29:57 -08:00
Fabian Kozynski
4e618138a9 Merge "Iterate over a copy in QSTileHost#changeTiles" into rvc-dev 2020-02-28 22:26:20 +00:00
Bernardo Rufino
0a7ced1dd3 Show toasts from system/sysUI to all users
The package name test is safe:
* If it's used by Toast class in an app, apps have access to layout
  params anyway via getWindowParams() and applied flag is already
  protected by INTERNAL_SYSTEM_WINDOW permission.
* If it's used by ToastUI class in sys UI on behalf of another app,
  sys UI is trusted domain and can't be messed up by another app. It
  also has INTERNAL_SYSTEM_WINDOW permission.

Bug: 149408635
Test: atest ToastUITest android.widget.cts.ToastTest
      android.widget.cts29.ToastTest android.server.wm.ToastTest
Test: Change phone to vibration/silent in secondary user and observe
      toast is displayed.

Change-Id: I227e9f74166300fcb3ba8f3871b464afe6ec6a28
Merged-In: I227e9f74166300fcb3ba8f3871b464afe6ec6a28
(cherry picked from commit caef507aa9)
2020-02-28 21:42:36 +00:00
Bernardo Rufino
9b256a210d Merge "Unify toast presentation code" into rvc-dev 2020-02-28 21:09:36 +00:00
Fabian Kozynski
f482c100db Merge "Use the correct user context in CustomTile" into rvc-dev 2020-02-28 19:05:17 +00:00
TreeHugger Robot
c8bb1b3286 Merge "Prevent NPE in CustomTile" into rvc-dev 2020-02-28 18:01:02 +00:00
Heemin Seog
dfb1fe98af Merge "Generalize AutoHideController to be shared" into rvc-dev 2020-02-28 16:55:28 +00:00
Hongwei Wang
bfdc669666 Merge "Updates destination bounds upon rotation change" into rvc-dev 2020-02-28 16:47:07 +00:00
Hongwei Wang
1a7d51051e Merge "Fixed the GMM PiP window size" into rvc-dev 2020-02-28 16:46:51 +00:00
Bernardo Rufino
dee28c91a3 Unify toast presentation code
Extract window layout construction and view inflation from Toast and
ToastUI into common @hide class ToastPresenter. This is desirable by
itself but also in preparation for making system toasts visible to all
users.

Bug: 149408635
Test: atest ToastUITest android.widget.cts.ToastTest
      android.widget.cts29.ToastTest android.server.wm.ToastTest

Change-Id: Ifdd7ee37687da2e4c7abed61569cf342f95b2611
Merged-In: Ifdd7ee37687da2e4c7abed61569cf342f95b2611
(cherry picked from commit aea2c50cd8)
2020-02-28 16:18:42 +00:00
Miranda Kephart
aef754d253 Merge "Fix bug where screenshot jumped to the left" into rvc-dev 2020-02-28 15:31:55 +00:00
Will Brockman
626f043a30 Notification statsd logs: Notification panel.
Experimenting with moving this logging to the SysUI side to be able to
log the complete panel, including any lifetime-extended items.

Test: atest NotificiationLoggerTest SystemUITests
Test: statsd_testdrive 245
Test: adb shell cmd stats print-logs && adb logcat -s statsd:I | grep ' (245)'

Bug: 146488473
Change-Id: I0a1a1ddd8838c002807e7137477175f0acceba98
2020-02-28 09:56:42 -05:00
TreeHugger Robot
2523db7c3f Merge "Do not go home when status bar collapse is requested." into rvc-dev 2020-02-28 12:03:58 +00:00
Julia Reynolds
66db87d0c0 Merge "Show snoozed conversations in conversation header" into rvc-dev 2020-02-28 11:46:33 +00:00
TreeHugger Robot
8f034348ca Merge "Update section header placement logic" into rvc-dev 2020-02-28 11:46:28 +00:00
Robin Lee
eff035d996 Do not go home when status bar collapse is requested.
This is only invoked from CTS and related tests. Some of these tests
attempt to launch an activity and then close the status bar in the
setup step. This exits the activity and is not desired.

Test: atest GtsIncidentManagerTestCases
Test: atest CtsAutoFillServiceTestCases
Bug: 150404191
Change-Id: Ic988c537dfbb72b6eac2dc3885bb832848f8df17
2020-02-28 09:52:48 +00:00
Hongwei Wang
ea2ae858d0 Updates destination bounds upon rotation change
This would be a bug for any PiP-enabled application if the preferred
fullscreen is in a different screen rotation than in PiP mode.

Bug: 150360003
Test: atest PinnedStackTests
Test: manually enter/exit PiP w/ Play movies app
Change-Id: Ibb56d907b9968eaf90171315faa6181a7e72b146
2020-02-27 22:41:59 -08:00
TreeHugger Robot
837f5ea60a Merge "Fix bouncer race condition" into rvc-dev 2020-02-28 03:19:35 +00:00
Julia Reynolds
138111fca3 Show snoozed conversations in conversation header
- And allow them to be unsnoozed with a tap.
- Also use the conversation's shortcut icon and name if available.
- And ignore the setting to turn off the strips since it now requires
explicit user action to make the strip visible

Note 1: unsnoozing a notification causes it to make sound again - we
probably want to change that for manually unsnoozed things
Note 2: the entries in the header don't yet persist across a reboot

Test: atest, manual
Bug: 149486431
Change-Id: Id661c25a49bc982e39deab977eb912f51eaf6757
2020-02-28 02:48:07 +00:00
TreeHugger Robot
5688bc3e4c Merge "Bubbles user education for stack & manage" into rvc-dev 2020-02-28 02:11:46 +00:00
TreeHugger Robot
141b5e79c3 Merge "Fix crash when opening bubble overflow" into rvc-dev 2020-02-28 02:04:09 +00:00
Lucas Dupin
8833d1eb4c Fix bouncer race condition
Bouncer would get stuck if authentication method changed after view
inflation.

Bug: 149773776
Bug: 149828540
Test: atest PlatformScenarioTests:android.platform.test.scenario.sysui.lockscreen.LockscreenWithInvalidPIN
Change-Id: I39ee2ec2e2ba9b6cf7dfba6b8141efc8b380b48e
2020-02-28 01:45:35 +00:00
Xiangyu/Malcolm Chen
806e50963c Merge "Smoother signal bar transition during CBRS data switching" into rvc-dev 2020-02-28 00:40:28 +00:00
Daniel Sandler
06907ad5ee Merge "Add importance indicator to conversation icons." into rvc-dev 2020-02-28 00:26:10 +00:00
Mady Mellor
5a3e94b702 Bubbles user education for stack & manage
Two types of education
1) highlighting the bubble when it first appears on screen (after user tap)
2) highlighting manage button when a bubble is expanded

* Both of these are added in BubbleStackView & respond to theme changes
* Prefs to save whether user has seen either education
* Simple animations in / out; we can tune them later
* Adjusts the starting position of the stack to work with user education
  positioning
* Adds a secure setting string to force user education to show for demo
  purposes.

Test: manual:

1) get bubble for first time
2) tap on flyout => flyout disappears & user education shows
3) get another update to that bubble => note that it doesn't show bc
   user education is displaying

1) get bubble for first time
2) tap on bubble => flyout disappears & user education shows
3) tap outside of the user education => user education hides

1) get bubble for first time
2) wait => after flyout disappears, user education shows
3) tap  on the bubble => user education hides & bubble expands, after
   expansion "manage" user education appears
4a) interact with content in the activity view
4b) collapse the stack (via back or tapping outside)
4c) tap on the manage button
4d) select a different bubble
=> each of 4x) should dismiss the manage button user education

Check that switching themes (and dark mode) gets the right colour for user
education backgrounds & text.

Bug: 148105621
Change-Id: I8e6401573c1ac21dfe636aa1132461fe04ce67ac
Merged-In: I8e6401573c1ac21dfe636aa1132461fe04ce67ac
2020-02-27 22:57:14 +00:00
Mady Mellor
0122cc904f Fix crash when opening bubble overflow
BubbleExpandedView needs a BubbleStackView reference, without that
there could be an NPE in various locations.

Also uses the correct parent view to setup the overflow.

Test: manual - tap on the overflow, observe no crash
Fixes: 150394526
Change-Id: Ib1ae9353a0dfd60ac8b6eb4f94b5b0cc5bc47811
2020-02-27 12:26:59 -08:00
Miranda Kephart
5fc0317753 Fix bug where screenshot jumped to the left
s/height/width/ when setting the X position :)

Bug: 150389556
Test: manual
Change-Id: I48b4b3e2b3eb0f1db6165ca5d68d889362858153
2020-02-27 14:34:47 -05:00
TreeHugger Robot
9a979fb217 Merge changes I41959627,Iba316772 into rvc-dev
* changes:
  Bind/unbind notif children content dynamically
  Support freeing contracted/expanded view
2020-02-27 18:17:01 +00:00
TreeHugger Robot
8f24e99754 Merge "Enable overflow" into rvc-dev 2020-02-27 08:41:20 +00:00
Shawn Lin
9a02e30990 Merge "Fixed listeners were unexpectedly unregistered when device rotated" into rvc-dev 2020-02-27 03:10:26 +00:00
TreeHugger Robot
abe2fed8b0 Merge "Ensures display rotation triggers PiP re-position" into rvc-dev 2020-02-27 02:39:05 +00:00
TreeHugger Robot
ee47af6207 Merge "Turn on QS media player by default" into rvc-dev 2020-02-27 01:56:48 +00:00
Beverly Tai
0a71d6063d Merge changes I8ad04753,I59aa77f3 into rvc-dev
* changes:
  Use a BgExecutor in SecurityControllerImpl
  Inject DeviceConfig into SystemUI classes
2020-02-27 01:54:47 +00:00
Hongwei Wang
610d2284fe Fixed the GMM PiP window size
This is a regression caused by ag/9645603 and it happens when the
requested aspect ratio is lesser than 1.

Added additional test cases to PipBoundsHandlerTest

Bug: 146162554
Test: Put GMM into PiP window and comparing the bounds
Test: atest PipBoundsHandlerTest
Change-Id: I356caf79bf122921b1d227d9744a40369feafa6e
2020-02-26 17:53:17 -08:00
Heemin Seog
e67cefea27 Generalize AutoHideController to be shared
Bug: 147427386
Test: atest SystemUITests for sdk_gphone_x86 and atest
CarNavigationBarControllerTest HvacControllerTest for hawk-userdebug

Change-Id: I9d0ee8135c1a53abaeb64f4b7b2aebd9208c0160
2020-02-26 16:54:14 -08:00
TreeHugger Robot
4ad907d3d0 Merge "Set recording duration and file size limits" into rvc-dev 2020-02-26 23:53:25 +00:00
Kevin Han
3cb379c551 Bind/unbind notif children content dynamically
Unbind notificiation children content when they won't be visible anyway
in order to save memory. Bind again lazily if we ever do actually need
it.

This is going into the old pipeline so we can start testing it out
early, but ultimately, we also plan to put this in the new pipeline
(though in a form where we try to unbind the row entirely).

Bug: 145748993
Test: Post group on Notify APK. Clear notifs and confirm no weird UX
Test: atest DynamicChildBindControllerTest
Change-Id: I41959627a55fa7041629ce52af5539b3f0c3cecc
2020-02-26 15:08:59 -08:00
Miranda Kephart
91ae0d0d8d Merge "Fix screenshot scaling bug" into rvc-dev 2020-02-26 22:54:17 +00:00
Dave Mankoff
6b0bccc9c2 Merge "Ensure that FalsingManager is not active when phone unlocked." into rvc-dev 2020-02-26 21:48:14 +00:00
Evan Rosky
3abea008b1 Merge "Use hierarchy focusability to pause the minimized tile" into rvc-dev 2020-02-26 21:47:57 +00:00
Hongwei Wang
bede2c1049 Ensures display rotation triggers PiP re-position
Fixed in this CL, upon rotation change
- Updates display bounds in PipTaskOrganizer
- Issues PiP offset from PipTouchHandler (-> PipMotionHelper)

Bug: 150300422
Bug: 150275283
Test: manually rotating screen
Change-Id: I4262df6ddc306732693150f27ca0da6e294df5ab
2020-02-26 13:35:17 -08:00
Fabian Kozynski
4ba3f9aa86 Use the correct user context in CustomTile
CustomTile was using the SystemUI context (in user 0) to retrieve
service information and resources. This failed in 3rd party tiles that
could be installed just for a particular user but were not installed in
user 0.

Additionally, having observed cases where the sysui_qs_tiles setting has
"work,work,work,....", this CL cleans that up and prevents it happening
in the future by not allowing repeats in the specs list.

Fixes some leaks in CustomTile:
* destroy CustomTile that changes user
* remove Change listerner from TileLifecycleManager

Test: atest QSTileHostTest CustomTileTest
Test: manual
Test: hprof
Fixes: 141904434
Change-Id: I92b26294dec63477943d28e2000fe3e0c16f8aa3
Merged-In: I92b26294dec63477943d28e2000fe3e0c16f8aa3
(cherry picked from commit a6862914da)
2020-02-26 21:33:26 +00:00
Beth Thibodeau
679609721c Turn on QS media player by default
Test: manual; atest NotificationMediaTemplateViewWrapperTest
Bug: 150285848

Change-Id: I1d692360f4f18b60ef34f2f18c9514a52ec88ea2
2020-02-26 16:01:55 -05:00
Fabian Kozynski
2648a2a99a Prevent NPE in CustomTile
The icon is passed by the TileService, so it could null when retrieving
the drawable. Check for null before doing operations on it.

Test: atest CustomTileTest
Fixes: 140479361
Change-Id: I0ee11806c0047e0e524f5201d369bee51beba451
Merged-In: I0ee11806c0047e0e524f5201d369bee51beba451
(cherry picked from commit cfdd8d4093)
2020-02-26 20:23:35 +00:00
Fabian Kozynski
d37dcf856b Merge "Changed management to just show all controls" into rvc-dev 2020-02-26 20:20:07 +00:00
Dave Mankoff
9cfce017d7 Merge "Use alternative prox sensor when specified." into rvc-dev 2020-02-26 20:07:35 +00:00
Malcolm Chen
0c63c4daff Smoother signal bar transition during CBRS data switching
Upon CBRS switch or any data switch between a group, assume the target
sub validated up to 2 seconds if the previous data sub was validated.

Bug: 131776846
Test: manual - switch data between primary and CBRS and observe signal
bar transitions.

Change-Id: I45d2558510bcd1b86b001f723bbd3dd8dc3a3914
2020-02-26 19:48:45 +00:00
TreeHugger Robot
6d2586f03f Merge "Don't use main handler in ImageWallpaperTest" into rvc-dev 2020-02-26 19:47:23 +00:00