Commit Graph

2320 Commits

Author SHA1 Message Date
Gilles Debunne
e9c98bdf99 Merge "Potential thread concurrency issue with WordIterators." 2011-10-27 14:04:03 -07:00
Svetoslav Ganov
872d11cbc4 am 8c807076: Merge "NumberPicker does not not fit on Crespo in landscape." into ics-mr1
* commit '8c8070763971b72aa012e23585fe844b4b956282':
  NumberPicker does not not fit on Crespo in landscape.
2011-10-26 22:35:22 +00:00
Svetoslav Ganov
e0c8ab5aaa NumberPicker does not not fit on Crespo in landscape.
1. Now the NumberPicker has a max height and width for which is looks
   good but can still shrink if there is not enough available space.

bug:5512787

Change-Id: Ieea88cafa8408e1d4160bab4bfe2b771bd79f7f8
2011-10-26 14:06:26 -07:00
Philip Milne
fec2aa51d6 Merge " Update to fix for bug 5393156" 2011-10-26 10:18:30 -07:00
Gilles Debunne
dc37203c95 Merge "Text handles do not handle scroll correctly" 2011-10-25 15:54:51 -07:00
Philip Milne
ecab117864 Update to fix for bug 5393156
Tweak to the logic to take account of margins when gravity = FILL is used and
    there is a measurement dependency between the axes (as in mulit-line text).

Change-Id: I91b9143c2d5db41cb67dd641d5c7ea0b56cae7ff
2011-10-25 15:07:19 -07:00
Adam Cohen
bd12e41ba5 am e3bb0ecb: Merge "Removing fades on last item in StackView for major FPS improvement on Prime" into ics-mr0
* commit 'e3bb0ecb2b36964cb3b02bc0d575e9366818ee00':
  Removing fades on last item in StackView for major FPS improvement on Prime
2011-10-21 14:38:41 -07:00
Gilles Debunne
fec22c6be6 Text handles do not handle scroll correctly
A recent patch taking scroll into account was applied at the wrong
level. isVisible() expects positions that already take scroll into
account. isOffsetVisible() is where the initial bug was.

Change-Id: If2a5349555ec9e86e4295e819d5d9086f0adcdbd
2011-10-21 13:48:20 -07:00
Adam Cohen
c798b6688a Removing fades on last item in StackView for major FPS improvement on Prime
Change-Id: I479eb129e80a6087ab55d1de7eed0222d6dacdf6
2011-10-21 12:44:13 -07:00
Gilles Debunne
d224c88c48 Potential thread concurrency issue with WordIterators.
parse() is called from the UI thread when text is changed, and in
that case it is safe to re-use the TextView's WordIterator.

It can also be called from the SpellCheckSession thread though
onGetSuggestions: use a local WordIterator in that case.

Change-Id: I596bff15cc8f997b9dc49598724450ac5c582101
2011-10-20 16:57:11 -07:00
Gilles Debunne
592ddaa34f Bug 5428541: Check that span is still in text before deleting
This is a cherry-pick in MR0 of CL 141388 from master.

Bug 5488537

In case the span has been removed from the text since the popup
was showed, the delete action is a no-op.

Change-Id: Iec2aeaf03becd82ad44715d5c08bfaa8f62aa3fe
2011-10-20 16:03:04 -07:00
Gilles Debunne
c5d6fe0152 Merge "Renaming of a hidden API: ShowSoftInputOnFocus" 2011-10-20 15:35:34 -07:00
Svetoslav Ganov
c8c2e17ecd Merge "Add content description setter to RemoteViews" 2011-10-20 14:29:18 -07:00
Svetoslav Ganov
c397df7754 am 5dc30a77: Merge "DatePicker crashes when going from 2036 to 2035 via ▼" into ics-mr0
* commit '5dc30a770ab1b4f07ff10502f9de9ec39daac41d':
  DatePicker crashes when going from 2036 to 2035 via ▼
2011-10-19 21:17:14 -07:00
Svetoslav Ganov
5dc30a770a Merge "DatePicker crashes when going from 2036 to 2035 via ▼" into ics-mr0 2011-10-19 21:15:30 -07:00
Svetoslav Ganov
6304b0d58e DatePicker crashes when going from 2036 to 2035 via ▼
1. Some obsolte logic was placing invalid index in the array of
   scroll wheel items which was resulting in failure to look its
   string representation from the cache causing a NPE.

2. While editing the current value via the IME the middle item
   of the scroll wheel was partially visible i.e. the user was
   able to see a dimmed version of the old value intermixed with
   the new one.

3. The logic for hiding the IME while poking a button i.e. starting
   to use another way of changing the current value, was incorrect.

bug:5480205

Change-Id: I1c2c96402bd38bac1dec64ccc6b550410332b9d7
2011-10-19 20:43:35 -07:00
Svetoslav Ganov
4a41cb3147 am 018cb119: Merge "AdapterView does not check for null adapter when initializing accessibility event." into ics-mr0
* commit '018cb119bca7a3a08dd59843e1fec9a3027a8133':
  AdapterView does not check for null adapter when initializing accessibility event.
2011-10-19 15:53:28 -07:00
Svetoslav Ganov
0e6fa8b60d AdapterView does not check for null adapter when initializing accessibility event.
The code that initializes accessibility events was assuming the AdapterView
always has an adapter and this caused NPE. Now the right method of the view
is called to get the item count.

bug:5474162

Change-Id: I6c330dc2894477df9447a4ecfddc7bd62c575d59
2011-10-19 12:38:08 -07:00
Gilles Debunne
0f4109e4ef Renaming of a hidden API: ShowSoftInputOnFocus
Change-Id: Ib0384815f5ed677547a42d456ee190d5ac2ef7bd
2011-10-19 11:26:21 -07:00
Svetoslav Ganov
e261e283ea Add content description setter to RemoteViews
bug:5480389

Change-Id: I66616f379a244ba7f3552d766f3aaa77f207550a
2011-10-18 18:01:47 -07:00
Chet Haase
5b2dfbde53 am 1aad3b5e: Merge "Issue 5432115: Speed up notification scrolling" into ics-mr0
* commit '1aad3b5e336a04ed612c091d8002569f959e1722':
  Issue 5432115: Speed up notification scrolling
2011-10-17 11:32:45 -07:00
Chet Haase
ba1fe8e3cf Issue 5432115: Speed up notification scrolling
The NotificationPanel was using views that had non-1 alpha
values set on them (permanently). This is costly in the GL
implementation and caused more rendering overhead, and worse
performance, than simple opaque views would.

The fix is to set the text color and ImageView drawable alpha
directly, without setting the View alpha property.

Change-Id: I381e0bd45bf45784b8e364a27a339e6583189a43
2011-10-17 08:54:53 -07:00
satok
69db986cf0 am e6fee18d: Merge "Invalidate SuggestionSpan with FLAG_AUTO_CORRECTION when it\'s removed." into ics-mr0
* commit 'e6fee18d16a86c266afef48f7705268435a99111':
  Invalidate SuggestionSpan with FLAG_AUTO_CORRECTION when it's removed.
2011-10-14 11:16:57 -07:00
satok
e6fee18d16 Merge "Invalidate SuggestionSpan with FLAG_AUTO_CORRECTION when it's removed." into ics-mr0 2011-10-14 11:15:05 -07:00
Gilles Debunne
ae245d59b3 Merge "Bug 5420741: exception when rotating device while suggestion popup is visible" 2011-10-14 11:09:59 -07:00
Gilles Debunne
b9e78d96b7 Merge "Spell checher's language synced with keyboard." 2011-10-14 11:09:44 -07:00
Joe Fernandez
5a401ddbc8 am 471fa9d1: Merge "docs: add developer guide cross-references, Project ACRE, Round 2" into ics-mr0
* commit '471fa9d10b4fa4da070c0ffb5fa5ea1354c8e6b8':
  docs: add developer guide cross-references, Project ACRE, Round 2
2011-10-14 10:54:29 -07:00
Joe Fernandez
471fa9d10b Merge "docs: add developer guide cross-references, Project ACRE, Round 2" into ics-mr0 2011-10-14 10:52:33 -07:00
Joe Fernandez
558459fe85 docs: add developer guide cross-references, Project ACRE, Round 2
Change-Id: I39a534ae3a2a34b4dabc333a09961012ef911d3e
2011-10-14 10:18:33 -07:00
satok
75e126f2df Invalidate SuggestionSpan with FLAG_AUTO_CORRECTION when it's removed.
Bug: 5460262

Change-Id: I4ca71020a6d4b7057f60ca99944c479775cca8b7
2011-10-15 01:24:44 +09:00
Gilles Debunne
19f4b66ddc Merge "Bug 5228934: added a flag to disable the display of the soft input on focus" 2011-10-13 16:54:23 -07:00
Gilles Debunne
9d8d3f1539 Spell checher's language synced with keyboard.
Bug 5379440. The spell check is now using the IME's language to
do the spell checking. Changing the input language triggers a
new spell check of the entire text.

Optimizations: ArrowKeyMovementMethod re-uses the TextView's
wordIterator, already set to the correct language.

One wordIterator shared by all SpellParsers in SpellChecker.
Cannot re-use TextView's because of concurrency issues.

With the current implementation, one has to type a new character
to see the new spell checking take place.

Change-Id: I0e460c0a6777548f89d03d6b68f3deea6606c17f
2011-10-13 16:52:42 -07:00
Gilles Debunne
cbdd245793 Merge "Bug 5428541: Check that span is still in text before deleting" 2011-10-13 14:23:37 -07:00
Adam Powell
9e45b78c4e am aa79a5d5: Merge "Fix bug 5455676 - seek bars without thumbs" into ics-mr0
* commit 'aa79a5d5a3b06b5b4e40a1ab0ccc6697627b1a8d':
  Fix bug 5455676 - seek bars without thumbs
2011-10-13 13:12:42 -07:00
Adam Powell
2c5b8cc71b Fix bug 5455676 - seek bars without thumbs
Change-Id: I9a4257b91a89cceeca7d5acf9358a8254446c784
2011-10-13 11:44:38 -07:00
Gilles Debunne
26c8b3ae7f Bug 5420741: exception when rotating device while suggestion popup is visible
The suggestion popup window was not dismissed on orientation change.
This is triggered by onDetachedFromWindow.
However, this method is also called when the suggestion popup window
pops up. A new flag detects that case to dismiss the popup unless it
has expressly been asked to show up.

Still errors in the log after that change, I assume related to the window manager.

Change-Id: Ia515fc576ddf2127b2f9863cc2652aeb619fff6e
2011-10-12 16:43:24 -07:00
Fabrice Di Meglio
cee057ed2d am 87228cd7: Merge "Fix bug #5446966 Changing Gravity on a TextView does not change how the text is aligned" into ics-mr0
* commit '87228cd7bb9a39e2bb33a767d214c8d834f840df':
  Fix bug #5446966 Changing Gravity on a TextView does not change how the text is aligned
2011-10-12 12:42:12 -07:00
Gilles Debunne
550efbfbf7 Bug 5228934: added a flag to disable the display of the soft input on focus
This will be used by the contact app for the dial screen text input.
https://android-git.corp.google.com/g/#/c/141088/

New upload to trigger a new android-build-police build.
Error 137 on buld server, builds fine locally even after a make clean.

Change-Id: I9288f3cab5c3330d693e08f88611acdd03526a41
2011-10-12 11:53:25 -07:00
Fabrice Di Meglio
9f51384720 Fix bug #5446966 Changing Gravity on a TextView does not change how the text is aligned
- this was a regression introduced when dealing with getLayoutAlignment()

Change-Id: I9571a7976789b768c7cb41560d88b35d67ae3895
2011-10-12 11:43:27 -07:00
Gilles Debunne
b10d396f2e Merge "Bug 5385279: IOOB in createMisspelledSuggestionSpan" 2011-10-12 09:51:17 -07:00
Gilles Debunne
ba25c01335 Merge "Bug 5237623: word no longer underlined after replacement" 2011-10-12 09:50:45 -07:00
Adam Powell
af5280cc71 Fix bug 5173029 - make fast scroller aware of scrolling containers
When a ListView with a FastScroller is located in a scrolling
container, defer the start of the drag operation for a short time or
until a touch slop is crossed. This allows these lists to be placed in
containers like ViewPagers without immediately stealing touch events.

Change-Id: I9b10b6993b24113c5e95c485bf57206747c73a84
2011-10-11 19:06:13 -07:00
Gilles Debunne
c08ec615d2 Bug 5385279: IOOB in createMisspelledSuggestionSpan
Race condition: when spell check result come back, the spell check span may no longer
be in the text, although it should have been removed by removeSpellCheckSpan.

This is possible because onGetSuggestions is called from an other thread
and it can see the text in an inconsistent state where the span may have been removed
from the text, but the listener that calls removeSpellCheckSpan has not yet been called.
As a result, onGetSuggestions still lists the span but getSpanStart returns -1.

Change-Id: Ia40f7ed2b46fc94888fce5a6b209fb0d0d529bbe
2011-10-11 16:12:23 -07:00
Gilles Debunne
28ef904077 Bug 5428541: Check that span is still in text before deleting
In case the span has been removed from the text since the popup
was showed, the delete action is a no-op.

Change-Id: I6478e0953cab132a984174b596d1f813909cdc2d
2011-10-11 16:01:25 -07:00
Adam Powell
aa4f5c95c3 Fix bug 5434403 - invalidation problem with seek bars at edges
Explicitly invalidate the seek bar thumb area when we change drawable
states for touch down. This prevents the thumb from only being
half-invalidated at the edges since it extends into the view's padding
region.

Change-Id: Icc4e608aca044b2d05f3a9378eced839c03947e6
2011-10-11 15:38:30 -07:00
Gilles Debunne
5915c885de Bug 5237623: word no longer underlined after replacement
When replacing a word, we need to remove *all* misspelled
suggestion spans, not just the one which triggered that popup.

Change-Id: I7be17ac626b26123b029f5e10c1e2eaa5f94d67c
2011-10-11 14:54:26 -07:00
Svetoslav Ganov
a72a80632b Merge "DO NOT MERGE AdapterView does not set setCurrentItemIndex in accessibility event." into ics-mr0 2011-10-11 13:54:28 -07:00
Svetoslav Ganov
eb0c52e491 DO NOT MERGE AdapterView does not set setCurrentItemIndex in accessibility event.
Cherry picking since branching caught us in the middle of review.

bug:5439637

Change-Id: I67d080abb4c14cad88b952e2f91d65e181b2029b
2011-10-11 11:58:13 -07:00
Svetoslav Ganov
98348517fd DO NOT MERGE AdapterView#isScrollableForAccessibility does not handle null adapter.
Cherry picking since branching caught us in the middle of review.

1. If an AdapterView has no adapter and the view tries to fire an
   accessibility event we get a null pointer exception.

bug:5439321

Change-Id: Ia3d7a5ad852ef42422d10d8a62c4d3af6792313b
2011-10-11 11:54:22 -07:00
Svetoslav Ganov
0c9698aca5 Merge changes I67d080ab,Ia3d7a5ad
* changes:
  AdapterView does not set setCurrentItemIndex in accessibility event.
  AdapterView#isScrollableForAccessibility does not handle null adapter.
2011-10-11 11:30:45 -07:00