Fixes a bug where the camera icon could become
visible in AOD even though it should not.
Fixes: 62038727
Test: Trigger ambient display, uninstall button provider plugin, observe camera button does not show
Change-Id: Ie97085dff58b6ecd0157126e30b86138f585d454
- Don't show when collapsed, show divider instead
- Don't show when no notifications
- Animate between states while expanding/collapsing
- Other visual cleanup
Test: visual
Change-Id: I923c963fa70d63601b6a181299b04c5fc49922bb
Fixes: 38199857
Fixes: 38483355
Fixes: 38409326
Fixes: 38417776
It also fixes an issue where the reinflation wasn't
working properly.
Test: runtest -x packages/SystemUI/tests/src/com/android/systemui/statusbar/ExpandableNotificationRowTest.java
Merged-In: If359256a3ac0c574260b5ff5af3fc2042e1dce9a
Change-Id: If359256a3ac0c574260b5ff5af3fc2042e1dce9a
Fixes: 36469584
Manually apply some specific tinting to override what UserIcons
provides.
Test: visual
Change-Id: Icdae51b3037dc046ccad7a374282cd1ef6fc0206
Fixes: 38052832
Switch from support library to internal implementation of cast
dialog.
Test: send menu event to dialog
Change-Id: If9c8bf0f544e712f3835977dd45a5adeeaac0c77
Fixes: 37216170
This fixes the regression caused by the previous commit
bad26692d0 Set notification TAG and style in TV PIP notification
Bug: 37249867
Test: Manual test (PIP notification UI was dismissed after closing th
PIP by notification UI, or PIP controller dialog. Also checked that
the notification UI was dismissed after the the PIPed activity
becomes fullscreen.)
Change-Id: I4dc6d1ee8035f89583a5fb49aa6c8fdc40bb49a0
Fixes an issue with the group expansion animation
by reverting a change introduced in I9dd91b85432e3d4309e0eb78a7b03ada87c3554e
Change-Id: Ia1e118a14ca2e420d0b0a23723676cf65d72f85b
Merged-In: Ia1e118a14ca2e420d0b0a23723676cf65d72f85b
Fixes: 38355658
Test: add notification group, test that clicking on the expansion icon shows a smooth animation
Change-Id: Ia5d999f1756050a972f986357d563703abce7172
Fixes: 37878458
Test: Double-tap to trigger Ambient Display, use fingerprint to unlock. Verify transition is Buttery Smooth
Huns could become clipped and their actions hidden
after they were posted the first time.
They are now only pushed in if they are above the shelf
Test: manual, add huns, observe correct clipping
Change-Id: I3277da30397e7424c000098b822e571620dd1e08
Fixes: 38017936
- When the device rotates due to a test that requests a specific
orientation, the TV PiP logic was resizing the state back to
mDefaultPipBounds, which doesn't change depending on orientation change,
clobbering the bounds in the new orientation that were calculated in WM.
Since TV does not really care about the rotation case, we can just
ignore the configuration changes due to orientation changes for the sake
of passing the common CTS tests across handhelds and TV.
Bug: 38246863
Test: android.server.cts.ActivityManagerPinnedStackTests
Change-Id: Id7988a0b02f14f67908d3202cdd73b186d9fea16
Because we are aborting animations when the screen turns off
we also have to finish the expansion in that case, otherwise
it can be stuck in that state and the padding would never
update anymore.
Test: runtest systemui
Change-Id: Ia8f901fad06ef8d972a24b696e94940f64cc1957
Fixes: 38308213
Test: Manual - have a notification, schedule an update to it, show the
menu, wait for the update, note that the menu is still visible
Bug: 38334364
Change-Id: Idcd49e4ffa4b422653a7090ae6365b8f404ec7b3
- Change the enter animation animated event to a normal event (no
animations were being choreographed on the event animation trigger
anyways)
- Remove the code in RecentsActivity, which poorly tried to schedule
the animation after the first layout. Instead, properly defer the
start animation until both the first layout _after stack reload_
and enter animation callback happens (regardless of which one comes
first).
Bug: 38391395
Test: Launch Chrome, dock, and ensure there are tasks visible
Change-Id: I4c2823fe25adbd3c200a0f786c478155541ccf26
Added code to restore docked stack to the position before minimized
state when no animation duration is specified. Battery mode skips
animations and therefore it provides no animation duration.
Change-Id: Ica4e4497b90d6b99c9c2c78b5e27365fe35b37ce
Test: manual
Fixes: 36768431
- Changes in the CommandQueue callbacks resulted in the default
implementation of preloadRecentApps() to be called instead of the
actual implementation in the Recents component.
- Removing extraneous methods in the interface called from other parts of
SystemUI.
Bug: 38390446
Test: Launch Recents, ensure that preloading is hit first on touch down on
the button
Change-Id: I28f7ac47eafa76a53343505f3352760e6510c213
- Also ensuring that we don't do additional work for non-current users when
the task stack changes.
Bug: 38390446
Test: Launch Recents in multiple users, ensure that it works and does not
make a binder call to get the current user id
Change-Id: If075675edc3874d809bad30d0aa564a8e59771d3
The interpolator we chose had a very slow easy out where it
generated out frame with mExpandedHeight=0.3 pixels. We add a
check there and stop the animation immediately if this happens.
Furthermore, we just use a simple post when closing the panel
to not add to much latency. The frame will be shown in any case
since we are already in animation/input callback, such that a post
will be executed after the frame has been sent to RT.
Test: Capture trace, unlock phone, make sure no delays
Change-Id: I9fc45f4b081bd6143da1ba99e9bc652a9f64e4a7
Fixes: 38294347
- If a user taps the PiP quickly multiple times, you can hit a case where
you expand the PIP, which triggers the re-registration of the
InputConsumer, but doesn't disable touches until the pinned stack
animation starts. If the user taps in between that time, it can trigger
a resizing of the stack what aborts the expand animation
- Also adding additional debugging logs
Bug: 37657050
Test: Quickly tap the PiP
Change-Id: Ib0088a3aa8e917aca3214c289a0787bdf7e66199
Otherwise all unlocks will result in onDismissCancelled.
Also fixes a race condition bug where we call
reportKeyguardShowingChanged but we don't wait until the state is
updated. Then, we called onDismissSucceeded such that
KeyguardManager.isDeviceLocked would still return true. Fix this
by waiting for the message to be processed.
Note that delays shouldn't be a problem here as we are soon
calling reportKeyguardShowingChanged from the UiOffloadThread.
Test: KeyguardLockedTests
Change-Id: I0b312a5f02be3a3d1028d8bf0cd1b8e6a33476ce
Fixes: 38219395
Latency when unlocking the phone regressed a bit for two reasons:
- For lockscreen -> app we now have to create a full starting
window containing the snapshot, while previously this was just
showing a surface.
- For lockscreen -> home, we can't use the saved surface anymore
because currently we don't support snapshotting translucent
activities. However, in the long term, we want home screen to be
more involved into transitions anyways, so we'll have to wait for
the first frame draw anyways.
However, crystal ball trainee developer Jorim added some
artificial latency in this transition 3 years ago, because he knew
that it is going to be an issue at some point so we have some
headroom to improve! Genius! On a more serious note, it was because
he didn't understand how to read systraces with binders involved (to
be fair, there was also no binder tracing).
Now, we can completely fix the introduces latencies above by
removing this latency of 100ms, and we are 30-70ms better than
before! However, this requires a lot of discipline in SystemUI.
Currently, the callback to dismiss Keyguard takes around 30ms. By
moving all non-essential binder calls of the main thread or to the
next frame, we bring this down to 5ms, such that window animation
and Keyguard animation starts about at the same time.
Test: Take systrace, unlock phone...profit!
Fixes: 38294347
Change-Id: I481fe4ecf358ed09f7142dd9e7ecd290b53c500c
Merged-In: I3ea672bc2eca47221bc6c9f3d7c56b6899df207d
Test: Open bouncer, click emergency call
Test: Open Camera, click on the lock icon on the bottom right,
click emergency call.
Change-Id: Id03ee738ddadd52f689a8531539dc3e9abe345b3
Fixes: 37195733
