Commit Graph

2496 Commits

Author SHA1 Message Date
John Reck
e666b10dff Drain any pending touch events immediately if possible
Bug: 6317798

Change-Id: Id343801cf80817f587414224cc67c13d34efed04
2012-05-04 15:30:42 -07:00
John Reck
84fa241f6c Fix tap highlight annoyingness
Bug: 6108346
 Highlight now correctly doesn't show up unless it is a click, and
 no longer has any weirdness with sticking around unusually long

Change-Id: I06f6eae45d970085232466f17cbbd9ebaefc4d69
2012-05-03 16:08:55 -07:00
John Reck
eaca069aff Merge "Fix clicking on a fake element (address, phone number, etc..)" into jb-dev 2012-05-03 09:59:46 -07:00
John Reck
9155cbac78 Fix clicking on a fake element (address, phone number, etc..)
Bug: 6426909

Change-Id: Ic45deea2423dbeb2bcb4ecbcaac32ec194f7511e
2012-05-03 09:51:32 -07:00
George Mount
aac5066dbf Merge "Add intercept path for UI touch handling." into jb-dev 2012-05-03 09:37:18 -07:00
John Reck
d4796461ee Fix accessibility drawing
Bug: 6407623
 If script injection is disabled, the accessibility injector works
 by modifying the text selection. However, this would cause WebView
 to go into text selection mode, showing the CAB and such, which
 we don't want. Add a flag saying WHY text selection is being changed
 so that we can respond accordingly in WebViewClassic.

Change-Id: Ia509def3fcdb022b93fbbc7ed89bc9558663afd3
2012-05-03 09:07:11 -07:00
George Mount
7a33acf123 Add intercept path for UI touch handling.
Bug 6410164

Change-Id: Ia3907a9a57321d0f25763c88fd0c0a7617d5da48
2012-05-03 09:02:14 -07:00
Chris Craik
3421f9fd68 Merge "Add temporary functor lifetime logging" into jb-dev 2012-05-02 17:26:57 -07:00
Chris Craik
2fe99801e8 Add temporary functor lifetime logging
bug:6405861

Note: revert once the above bug is verified fixed

Change-Id: Iae04ec6ffa73a2711f96e128d60011bcb5864b5c
2012-05-02 16:37:24 -07:00
John Reck
9a793c91b6 Merge "Add missing null check" into jb-dev 2012-05-02 16:15:51 -07:00
John Reck
2f612bdfbd Merge "Rewrite PictureSet" into jb-dev 2012-05-02 16:11:17 -07:00
John Reck
33b019b183 Rewrite PictureSet
Removes no longer supported splitPicture
Removes unnused code

Bulk of the change is in webkit CL: https://android-git.corp.google.com/g/#/c/185850/

Change-Id: I4eca363ba3cb4a6d6fccc82bf5ea8588df780a4b
2012-05-01 17:24:38 -07:00
John Reck
273b8c2e7f Add missing null check
Change-Id: I05e288762c00d80f4c0842584daa88c205196b6f
2012-05-01 17:22:25 -07:00
Chris Craik
ad759f958a Merge "fix monkey scrolling crash" into jb-dev 2012-05-01 16:01:58 -07:00
Chris Craik
5f3c08a411 fix monkey scrolling crash
bug:6336994

Depends on external/webkit change: https://android-git.corp.google.com/g/#/c/186186/

Change-Id: Ib019ca68f6e57f98e30b022949c624bab4695294
2012-05-01 15:53:06 -07:00
George Mount
8072976d7a Fix flicker while selecting text.
Bug 6413113

Change-Id: I5c8d2cda1eae9d5670c757711c49ccc9e47b4127
2012-05-01 08:56:24 -07:00
Chris Craik
1266692b30 never attach null functor
bug:6412902

Change-Id: I26a5f80ae13cc19df3daa4d4e7e5401778f76dbb
2012-04-30 13:15:55 -07:00
John Reck
3ea8761974 Merge "Fix crash in setNewPicture" into jb-dev 2012-04-30 11:31:27 -07:00
Chris Craik
a59558f476 check for null ViewRootImpl
bug:6412902
Change-Id: I36b5ee48fb94ed0f8222f9ec41ee9fc3730ceed0
2012-04-30 11:06:46 -07:00
John Reck
579f4e93fb Fix crash in setNewPicture
Bug: 6412902

Change-Id: I65d8f65839c6e84440cb9d0393c35a8c488c9781
2012-04-30 10:50:04 -07:00
John Reck
7658e53073 Revert "add null check on ViewRootImpl"
This reverts commit 67a1c8e3d5
2012-04-27 18:04:14 -07:00
Chris Craik
67a1c8e3d5 add null check on ViewRootImpl
bug:6412902
Change-Id: I688a54731ed34283bc039a7967f472af131f458d
2012-04-27 15:50:17 -07:00
Steve Block
7e279bc91a Merge "Tweak JavaDoc for WebSettings.setAllowUniversalAccessFromFileURLs() and setAllowFileAccessFromFileURLs()" into jb-dev 2012-04-27 03:19:04 -07:00
Ben Murdoch
c6911d47d1 Merge "Create WebViewDatabaseClassic from WebViewDatabase." into jb-dev 2012-04-27 01:39:59 -07:00
Steve Block
ef16315080 Tweak JavaDoc for WebSettings.setAllowUniversalAccessFromFileURLs() and setAllowFileAccessFromFileURLs()
Bug: 6212665
Change-Id: Ifc5c83cfee7cf63edbe2c65c55617eb01ea9eced
2012-04-26 23:25:29 +01:00
John Reck
a75fbc3c76 Merge "On new content, attach functor directly" into jb-dev 2012-04-26 12:27:56 -07:00
Teng-Hui Zhu
85973212e9 Merge "DO NOT MERGE:The visiblerect calculation should take view's scaling into consideration" into jb-dev 2012-04-26 11:28:17 -07:00
Steve Block
ff35000ce1 Merge "Fix JavaDoc style for several WebView classes" into jb-dev 2012-04-26 11:02:32 -07:00
Ben Murdoch
99c12e8d5f Create WebViewDatabaseClassic from WebViewDatabase.
WebViewDatabase has a getInstance() method, so similarly
to WebStorage, WebIconDatabase etc we refactor it into a
proxy class, and move the current implementation into
WebViewDatabaseClassic.

Also clean up some JavaDoc in touched files.

Bug: 6234236
Change-Id: I71cbd8f78e60f396e96e8546073ad634797cce15
2012-04-26 19:02:15 +01:00
Michael Kolb
13d7c03eb8 Fix NPE in isPrivateBrowsingEnabled()
Bug: 6393286

Change-Id: I1fd9c57b7bd68a9c495cbb0df45a406f83b22b5f
2012-04-26 10:43:08 -07:00
Steve Block
4e584df4ce Fix JavaDoc style for several WebView classes
This fixes the JavaDoc style for the following classes ...
- CacheManager.java
- CookieManager.java
- GeolocationPermissions.java
- WebResourceResponse.java
- WebSettings.java
- WebStorage.java
- WebView.java

In particular, this applies the guidelines at
https://wiki.corp.google.com/twiki/bin/view/Main/APIDocumentation

This should help to ensure that future JavaDoc comments use correct style,
rather than using incorrect style for consistency.

Note that this change does not attempt to improve the content of the JavaDoc
comments. This will be done in later changes.

Bug: 5461416
Change-Id: I79e9b15a8cf3597195d58e154a7eb1bcc462944c
2012-04-26 13:59:52 +01:00
Chris Craik
c2c9543c13 On new content, attach functor directly
bug:6323847

depends on external/webkit change: https://android-git.corp.google.com/g/#/c/184314/

Change-Id: Ibdf997f3ee4f5c5c1ea5a320556813f175fea93f
2012-04-25 15:42:59 -07:00
Teng-Hui Zhu
9d28157866 DO NOT MERGE:The visiblerect calculation should take view's scaling into consideration
bug:5684832
Change-Id: I9d29b1f32b19ad73aeae6a5c0873ec04722ff1ac

cherry-pick from master:
https://android-git.corp.google.com/g/#/c/183798/
2012-04-25 13:02:21 -07:00
Chris Craik
912507928c Merge "Support picture listener correctly in HW webviews" 2012-04-24 14:49:51 -07:00
John Reck
4961295d19 Merge "Use the right timeout" 2012-04-24 14:18:17 -07:00
John Reck
d7156d3f47 Use the right timeout
oops

Change-Id: I667b849af4c5d4fece42e9bcbc5b6b9951b955bb
2012-04-24 14:14:47 -07:00
Steve Block
3aa800b9f9 Add tests for reflection and improve JavaDoc for Java Bridge
Bug: 5461416
Change-Id: Ic339b97a9424d8848f8afd47ba00cbbee4d60c9d
2012-04-24 21:34:42 +01:00
Steve Block
f03f64d810 Merge "Update WebViewClassic JavaDoc to refer to WebView" 2012-04-24 03:22:27 -07:00
Steve Block
406aeb2a9d Update WebViewClassic JavaDoc to refer to WebView
Change-Id: I5152ce82111dc661e5dc723d5c3402f2765b7312
2012-04-24 11:20:29 +01:00
Jonathan Dixon
26ed99f3f5 Merge "static methods in CookieManger call via instance" 2012-04-24 03:01:55 -07:00
Jonathan Dixon
be58c40646 static methods in CookieManger call via instance
This allows CookieManager subclasses to correctly override all behvaior
in the base class.

Bug: 6379925
Change-Id: Ife02db24bc192bc1eabf09e0d64668716786d237
2012-04-24 09:48:28 +01:00
Romain Guy
d4caee0e50 I broke the build after all... here's a fix.
Change-Id: I970715fcff5a74a0ce272654c2ea79e4ab3684bf
2012-04-23 20:44:04 -07:00
Romain Guy
ba6be8a62d Prevent WebView from crashing when detached from the window
Bug #6365056

WebView enqueues a functor in the hardware renderer to handle
animations and this functor is called at a later time by the
hardware renderer. However, the functor was not removed from
the queue when WebView was removed from the window. This could
cause the hardware renderer to attempt to execute an invalid
functor and lead to a crash.

Change-Id: I9d38e80f3fdc5e29d4d0cdfa1e893c251a954508
2012-04-23 20:29:31 -07:00
Jonathan Dixon
003952ba33 Merge "Fix dumprendertree crash" 2012-04-23 10:56:21 -07:00
Jonathan Dixon
03b433c031 Fix dumprendertree crash
This is a quick workaround to get tests running again, will follow up with full fix tomorrow.

Bug: 6379925
Change-Id: I96d6e27bfb8f8cd41ec08845ab0fb1e584dbc9da
2012-04-23 18:51:28 +01:00
Steve Block
b838aef488 Fix use of API level in android.webkit JavaDoc
Bug: 5461416
Change-Id: Id17b10fec6bebc46260db6abe6df5f7d44a711ae
2012-04-23 18:24:29 +01:00
Ben Murdoch
1579a67ee9 Merge "Pause the WebCore thread watchdog at the right time." 2012-04-23 05:52:05 -07:00
Ben Murdoch
cba778dc21 Pause the WebCore thread watchdog at the right time.
There are times when we deliberately put the WebCore thread
to sleep (i.e. waiting for a user to complete a JS prompt or
dismiss an alert). In this case, we don't want the WebCore thread
watchdog to fire. Pause the watchdog before we put the WebCore thread
to sleep and resume it again when the thread wakes up.

Factor out the repeated send/pause/wait/resume code into it's own
function.

Bug: 6366520
Change-Id: I17ecf9d466ce21b25a9e5cb8ff4cb0e5fab7605b
2012-04-23 13:50:03 +01:00
Jonathan Dixon
d3101b1d30 Seperate interface and implementation of 4 WebView classes
GeolocationPermissionsClassic
CookieManagerClassic
WebIconDatabaseClassic
WebStorageClassic

Also creats a WebViewFactory top level class - this remains hidden
for now, as it's currently only used implicitly by the other
public WebView classes to create the provider instances.

Bug: 5626244

Change-Id: Id0ca1c16d8058f31a86414bbc0e8a55db4b907ba
2012-04-23 12:43:02 +01:00
Chris Craik
9e5936bc53 Support picture listener correctly in HW webviews
Change-Id: I0e2c5d8cdf788b3a409efa9ced5d37abb1d169c0
2012-04-20 17:41:04 -07:00