Commit Graph

11175 Commits

Author SHA1 Message Date
Rob Carr
1ca9c3b5ac Merge "Forward Activity stop signal to attached windows." into pi-dev am: d1366f604a
am: 6b3d3cc048

Change-Id: Ia2842bb15ffbe40d7f3a36cdaf6a7eefdd639c1f
2018-04-05 13:09:25 -07:00
Richard Ledley
dd02f9fb0c Merge "Add null check for Nullable argument." into pi-dev am: 335b0d36da
am: 54094b3bd1

Change-Id: I6f318e0ed2a9d927c127e810dc6274509cc18dae
2018-04-05 12:37:16 -07:00
Rob Carr
d1366f604a Merge "Forward Activity stop signal to attached windows." into pi-dev 2018-04-05 19:03:29 +00:00
Richard Ledley
5f77b6a35a Add null check for Nullable argument.
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest FrameworksCoreTests:android.view.textclassifier.TextLinksTest

Bug: 77624093
Change-Id: I527c4e7f6758c699d4d4e7258cf8474f833040c7
2018-04-05 17:30:24 +01:00
Richard Ledley
0c73a2848a Merge "Use Collection instead of List for entity list" into pi-dev am: 7b7e87eeb5
am: d4381891c3

Change-Id: Ifc4875458cbd9b72acade667aa1335efa5ec304e
2018-04-04 23:14:37 -07:00
Richard Ledley
7b7e87eeb5 Merge "Use Collection instead of List for entity list" into pi-dev 2018-04-05 05:46:53 +00:00
Dake Gu
fdb7ef65f1 Merge "autofill: fix window location in splitwindow and dialog" into pi-dev am: 2b26f83f12
am: c3bb24d64b

Change-Id: Ib07a77e0e4a2041497ef1485910e13cfa65f5545
2018-04-04 16:16:31 -07:00
TreeHugger Robot
2b26f83f12 Merge "autofill: fix window location in splitwindow and dialog" into pi-dev 2018-04-04 22:06:49 +00:00
Abodunrinwa Toki
15b037367c Merge "Fix TCS crash due to API changes." into pi-dev am: d6997b05e0
am: b3f39bfd55

Change-Id: I3d365ffe5efed4b0d7133fe0e03fd326dbf25b64
2018-04-04 14:41:55 -07:00
TreeHugger Robot
dcbb3bfb87 Merge "Avoid sending content changed a11y events from wrong views" 2018-04-04 21:11:39 +00:00
Dake Gu
640e9b9bf4 autofill: fix window location in splitwindow and dialog
autofill should use relative location to app window as PopupWindow
is based on relative location.

The fixed reverted changes made in compatibility mode CL that made
autofill window TYPE_SYSTEM_DIALOG.

Changing PopupWindow to use absolute screen location is another fix
choice, but it does not allow autofill window to be automatically
moved when app window changes location (e.g. adjust split window
separator or bring up IME)

The autofill window switches to TYPE_APPLICATION_ABOVE_SUB_PANEL with
IME disabled. So it still appears above IME and most other app
windows, unless app window is TYPE_APPLICATION_ABOVE_SUB_PANEL too.

Fixes: 73555917
Bug: 77587135
Test: manually tested compability mode with chrome amazon login
      manually tested splitted window
      atest CtsAutoFillServiceTestCases

Change-Id: I6b8ecf3fe7a91cebea1f7a868f4b15fbed8b0051
2018-04-04 11:36:40 -07:00
Richard Ledley
ab669a01a7 Use Collection instead of List for entity list
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest FrameworksCoreTests:android.view.textclassifier.TextLinksTest

Bug: 76448224

Change-Id: I354fa05f14b22075c2172624925f5b953956f3a4
2018-04-04 17:42:07 +01:00
Abodunrinwa Toki
ae82e7ad28 Fix TCS crash due to API changes.
- Brings by old deleted APIs and hides them
- Except parceling and hidden APIs that won't have been called anyway
- Option holds a reference to the Request object so we don't have to
  rebuild it

Bug: 77523413
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextSelectionTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextLinksTest
Change-Id: I4277c48a950c3334439649373885ed7fe54f898e
2018-04-04 14:10:51 +02:00
Evan Rosky
4ce7ea5e63 Merge "Use client-side version of inTouchMode" into pi-dev am: 3ec4b8ccfd
am: bdc641a6d5

Change-Id: Ib27e46386c015acdd060de8e566b0b82c0a12943
2018-04-03 20:07:16 -07:00
Winson Chung
7e756be722 Allow recents animation to override divider minimized state am: f557c3b565
am: ea0adfdb10

Change-Id: I8d56a170214c5592e6b44781ab01eca6e94103f8
2018-04-03 17:51:51 -07:00
Winson Chung
ea0adfdb10 Allow recents animation to override divider minimized state
am: f557c3b565

Change-Id: Iff052805a63517f8cd1bd72172f4caecc955991b
2018-04-03 16:53:49 -07:00
TreeHugger Robot
3ec4b8ccfd Merge "Use client-side version of inTouchMode" into pi-dev 2018-04-03 23:25:34 +00:00
Robert Carr
3f7bd97df9 Forward Activity stop signal to attached windows.
Simply put there is nothing ensuring PopupWindow's stop using
the Surface before the app is stopped. Since PopupWindow's are
detached from the main View Hierarchy teardown of the main window
provides no such guarantee. It seems enough to forward the "WindowStopped"
signal from ViewRoot to other ViewRoot's using the token of that ViewRoot.

Bug: 62536731
Test: Manual
Change-Id: Ib431f49be7e06a6397a40c11ec7e842a8bc5caf9
2018-04-03 15:53:01 -07:00
TreeHugger Robot
5fa07c0986 Merge changes from topic "fw_quickstep_update" into pi-dev
* changes:
  Reparent recents animation task leash to app animation layer
  Allow recents animation to override divider minimized state
  Prevent unnecessary reordering of the home stack
2018-04-03 22:31:57 +00:00
Evan Rosky
2888404df8 Use client-side version of inTouchMode
Was bindering into WM service pretty often due to this which was
causing some jank

Bug: 72236832
Test: Related touchmode/focus CTS tests still pass
Change-Id: Ia0f89429b67464beea07c702d8fe2d8b813f8d38
2018-04-03 13:21:55 -07:00
Derek Sollenberger
1aefca09eb Merge "Merge "Restore saveLayer APIs back into the public API." into pi-dev am: ffe1c2a266" into pi-dev-plus-aosp
am: c13bf77769

Change-Id: I1d93eb9fadc99f578e7162a6aae82d6eb612a3b8
2018-04-02 23:19:26 +00:00
Abodunrinwa Toki
dd5bc6f127 Merge "Merge "TextClassifier API updates." into pi-dev am: bf9dfb16be" into pi-dev-plus-aosp
am: 008a5d01af

Change-Id: I4efb43ab74ac98244c6f4145855a75480e2c85b0
2018-04-02 22:20:45 +00:00
TreeHugger Robot
ffe1c2a266 Merge "Restore saveLayer APIs back into the public API." into pi-dev 2018-04-02 14:28:48 +00:00
TreeHugger Robot
bf9dfb16be Merge "TextClassifier API updates." into pi-dev 2018-04-02 09:08:52 +00:00
Abodunrinwa Toki
080c8542b6 TextClassifier API updates.
1. Wraps TC queries in Request objects
2. Adds create/destroyTextClassificationSession system APIs
3. Adds the session Ids to system API calls
4. Change setSignature() to setId() on result objects
5. Plumbing to make the API updates work as things currently work
6. Hide Linkify.addLinksAsync APIs

Bug: 74461129

Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationManagerTest
Test: bit CtsViewTestCases:android.view.textclassifier.cts.TextClassificationManagerTest
Test: bit CtsWidgetTestCases:android.widget.cts.TextViewTest
Test: bit FrameworksCoreTests:android.widget.TextViewActivityTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextClassificationTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextSelectionTest
Test: bit FrameworksCoreTests:android.view.textclassifier.TextLinksTest

Change-Id: I933ada8b37ef9893331a265e3b4fc08e043f1029
2018-04-01 20:04:47 +01:00
Evan Rosky
88836ce65d Merge "Renamed KeyFallbackEvent to UnhandledKeyEvent and exposed dispatch" into pi-dev am: e1059d9f5e
am: 1334492e2b

Change-Id: Ic2eb0d1c4ea9d7b7ff4c31ff97523225de128aa3
2018-03-31 18:15:20 +00:00
TreeHugger Robot
e1059d9f5e Merge "Renamed KeyFallbackEvent to UnhandledKeyEvent and exposed dispatch" into pi-dev 2018-03-31 17:39:18 +00:00
Evan Rosky
3a98b0971b Merge "Restored focusableViewAvailable logic on visibility change" into pi-dev am: 4d0a5fd7e7
am: 759d87a01f

Change-Id: I33ab28d6a89966b8ea59ddc1b3031e0bb6b9311c
2018-03-31 03:06:38 +00:00
Evan Rosky
4d0a5fd7e7 Merge "Restored focusableViewAvailable logic on visibility change" into pi-dev 2018-03-30 21:23:32 +00:00
Evan Rosky
4807ae257b Renamed KeyFallbackEvent to UnhandledKeyEvent and exposed dispatch
This new naming clashes less with the existing notion of FLAG_FALLBACK
in KeyEvents.

Bug: 72562800
Test: ViewTest#testUnhandledKeys
Change-Id: Ibd713860601e62d955443fe6811fd974b5bb0092
2018-03-30 19:52:58 +00:00
Derek Sollenberger
2d4f01ba7f Restore saveLayer APIs back into the public API.
The saveLayer APIs are restored from @removed but will treat input
as ALL_SAVE_FLAGS and generate exceptions on newer API levels.

We internally used these calls in one situation that now use a
different @hide API to support the previous behavior until we
refactor that code.

Partial revert of "Remove deprecated android.graphics.Canvas APIs"
This reverts commit 7b837616ae.

Bug: 77276963
Bug: 73777445
Test: CtsGraphicsTestCases
Change-Id: I7acd4ffd5ac41a58d2be8b48cf50119c2b896708
2018-03-30 14:40:04 -04:00
Winson Chung
f557c3b565 Allow recents animation to override divider minimized state
- When swiping up while in split-screen, the animation should be able to
  adjust the docked divider minimized state so that we don't wait until
  launcher is repositioned to the front in order for the divider to
  update.

Bug: 73118672
Test: Enter split screen, swipe up and ensure the dock divider moves
      (Note, there are still unrelated clipping issues)

Change-Id: Id71f91eaf2f06b3c33628a2199cc94c82e235471
2018-03-30 10:25:16 -07:00
Jeff Sharkey
fc1dd8789c Merge "Switch reference time to ZonedDateTime" into pi-dev am: 50ac4d2c60
am: 69258db6ed

Change-Id: I217365cefe9ce1283d122e8688b479112c5ac605
2018-03-29 20:55:42 +00:00
Eugene Susla
3fb3c59040 Avoid sending content changed a11y events from wrong views
The root cause of both attached bugs was the tree-merging algorithm in
ViewRootImpl.SendWindowContentChangedAccessibilityEvent converging on a
common predecessor that is marked not View#isImportantForAccessibility.

As a result, such unlucky content changed events were discarded.

Fixes: 72378611, 72950579
Test: ensure attached bugs are fixed
Change-Id: I3c3c66151b6cd4773de4eadd417709e9a61a7cf2
2018-03-29 12:59:30 -07:00
Jan Althaus
a1652cfcce Switch reference time to ZonedDateTime
Bug: 74838195
Test: atest FrameworksCoreTests:TextClassificationManagerTest
Test: atest FrameworksCoreTests:TextClassificationTest
Test: atest CtsViewTestCases:TextClassificationManagerTest
Test: atest CtsViewTestCases:TextClassifierValueObjectsTest
Change-Id: I0df9dddf415fa558435553336a8a0a15621e9b05
2018-03-29 18:41:32 +02:00
Abodunrinwa Toki
5e4879c4c2 Merge "Implement Stateful TextClassifier APIs." into pi-dev am: 119d10deb9
am: 12dea84530

Change-Id: I248b3ffff26747f3cb95b6caf44bfcbe8dae10a3
2018-03-29 00:10:10 +00:00
Abodunrinwa Toki
119d10deb9 Merge "Implement Stateful TextClassifier APIs." into pi-dev 2018-03-28 20:58:47 +00:00
Jorim Jaggi
66f7ea24c4 Merge "Add different animation for transitions with translucent apps" into pi-dev am: 13c4b14e92
am: 162b5e89ec

Change-Id: Id1eded5e514f0444f697fe52730e39af593aaba4
2018-03-28 20:03:21 +00:00
Jorim Jaggi
13c4b14e92 Merge "Add different animation for transitions with translucent apps" into pi-dev 2018-03-28 19:09:08 +00:00
Jan Althaus
bd626aa9cb Merge "Change TextClassification to use RemoteActions" into pi-dev am: 08a75e0ee7
am: 39441a9d85

Change-Id: Ib9f44a89c0943eeff54f60f68e1aeb5d83ef3994
2018-03-28 17:35:32 +00:00
Jan Althaus
08a75e0ee7 Merge "Change TextClassification to use RemoteActions" into pi-dev 2018-03-28 17:04:58 +00:00
Yohei Yukawa
ac8d445ec3 Merge "Improve the JavaDoc for SOFT_INPUT_STATE_UNSPECIFIED" into pi-dev am: 59ecb96da9
am: 45cce268a0

Change-Id: I483b805079891e303081508fae767952bdac6ec4
2018-03-28 16:50:40 +00:00
TreeHugger Robot
59ecb96da9 Merge "Improve the JavaDoc for SOFT_INPUT_STATE_UNSPECIFIED" into pi-dev 2018-03-28 16:29:56 +00:00
Adrian Roos
a38538d2d6 Merge "DisplayCutout: Add clarifying images to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES" into pi-dev am: 95712fe0cb
am: b038415e98

Change-Id: If06875a89cdf08eb04aeaeada403e5de8551e326
2018-03-28 15:21:53 +00:00
Adrian Roos
95712fe0cb Merge "DisplayCutout: Add clarifying images to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES" into pi-dev 2018-03-28 14:56:19 +00:00
Adrian Roos
1a2ee998b7 Merge "DisplayCutout: Fix attrs.xml javadoc" into pi-dev am: 813a4bee76
am: f71a29c976

Change-Id: I9cc8503daa68cbc45f288bf61afa54d3ad4045f2
2018-03-28 14:54:06 +00:00
Jorim Jaggi
98a9d206be Add different animation for transitions with translucent apps
None of the existing animation really work with transitions in
which a translucent app is appearing/disappearing. Add a separate
animation for that and change all existing transitions to these
new transition types in case we detect that only translucent
activities are appearing/disappearing.

Test: Sharesheet animations
Test: go/wm-smoke
Change-Id: Iffe57b7664dddf647d723c91d115ade60c12ad33
Fixes: 37953606
Fixes: 70730519
Fixes: 72649981
Fixes: 72686618
2018-03-28 16:46:41 +02:00
Adrian Roos
813a4bee76 Merge "DisplayCutout: Fix attrs.xml javadoc" into pi-dev 2018-03-28 14:29:08 +00:00
Adrian Roos
ad1da31764 DisplayCutout: Add clarifying images to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
Fixes: 76462084
Test: make doc-comment-check-docs, open $ANDROID_BUILD_TOP/out/target/common/docs/doc-comment-check/reference/android/view/WindowManager.LayoutParams.html, navigate to LAYOUT_IN_DISPLAY_CUTOUT_MODE_SHORT_EDGES
Change-Id: I8a9df979cbb062896fa874a163414a4f8a095b21
2018-03-28 15:00:45 +02:00
Jan Althaus
20d346eafe Change TextClassification to use RemoteActions
Behavioural changes:
- Every action now as an icon, and instead hints via RemoteAction whether
  the icon should be shown or not.
- Icons are now taken from the app default, not the activity.
  (That way, we can construct a lightweight resource backed Icon)
- Legacy intents are no longer parceled for security reasons.
  (TextClassificatio wasn't parcelable in O)
- TextClassifications built with the new API will always return null for
  getIntent, but provide a getOnClickListener.
- Accessibility descriptions are now provided for action mode items.

Testing changes:
- Removed URI checks from TCM test because PendingIntent hides this info.

Bug: 73950205
Test: atest FrameworksCoreTests:TextClassificationManagerTest
Test: atest FrameworksCoreTests:TextClassificationTest
Test: atest CtsViewTestCases:TextClassificationManagerTest
Test: atest CtsViewTestCases:TextClassifierValueObjectsTest
Test: atest CtsWidgetTestCases:TextViewTest
Test: atest CtsWidgetTestCases:EditTextTest
Change-Id: I6706d2c342a8bbb9de0146a48c8b8aac9d9c7d83
2018-03-28 11:41:39 +02:00