Commit Graph

892 Commits

Author SHA1 Message Date
Hugo Benichi
c9d24d203d Merge "Network Service Discovery test: properly release resources" 2017-09-04 11:50:58 +00:00
Erik Kline
3204e5fc63 Merge "Record even more stats even more often"
am: 72a708d623

Change-Id: I6a662cce3cf5394d392f7ff816f5eb6a71131484
2017-09-04 02:25:48 +00:00
Erik Kline
aabdaa9710 Record even more stats even more often
Like kale, one can never have enough stats.  =)

Test: as follows
    - built
    - flashed
    - booted
    - runtest frameworks-net passes
Bug: 29337859
Bug: 32163131
Merged-In: I5d40eae488cab685be6a44849181c0286fe28fdb
Merged-In: I759e97f9a72d15a84036c3a56451b872143539c6
Change-Id: Ieb47c3beed50f21c2c858fe57438afd48cfdc662
(cherry picked from commit 1199a352fc)
2017-09-04 09:37:12 +09:00
Erik Kline
84f37b8481 Record even more stats even more often am: 1199a352fc
am: 65b541488c

Change-Id: I759e97f9a72d15a84036c3a56451b872143539c6
2017-09-03 22:58:31 +00:00
Erik Kline
65b541488c Record even more stats even more often
am: 1199a352fc

Change-Id: I5d40eae488cab685be6a44849181c0286fe28fdb
2017-09-03 22:44:54 +00:00
Erik Kline
1199a352fc Record even more stats even more often
Like kale, one can never have enough stats.  =)

Test: as follows
    - built
    - flashed
    - booted
    - runtest frameworks-net passes
Bug: 29337859
Bug: 32163131
Change-Id: Ieb47c3beed50f21c2c858fe57438afd48cfdc662
2017-09-03 18:54:48 +09:00
Hugo Benichi
e062ae07f9 Network Service Discovery test: properly release resources
Bug: 32561414
Bug: 62918393
Bug: 62044295
Test: runtest frameworks-net
Change-Id: If23993b5e391947ecbdc01677f0a643144794b2b
2017-09-02 14:54:29 +09:00
Jeff Sharkey
6d902da970 Merge "Gracefully handle integer overflows." into oc-mr1-dev am: 4d2a8d7203
am: 19f40da9fa

Change-Id: I6a4cec507d8d4eaad65a691e37171359f7fc87c3
2017-09-02 02:24:56 +00:00
Jeff Sharkey
19f40da9fa Merge "Gracefully handle integer overflows." into oc-mr1-dev
am: 4d2a8d7203

Change-Id: I6ed70a40ad3e6df55e7669fedfe5b34faf95bd9f
2017-09-02 02:07:25 +00:00
Jeff Sharkey
d405d0555c Gracefully handle integer overflows.
Try sticking with integer-based math as much as possible for speed,
but switch to double-based math if we detect that we'd end up
causing an overflow.

New tests to verify.

Test: bit FrameworksNetTests:com.android.server.net.NetworkStatsCollectionTest
Bug: 65257769
Change-Id: I1ae35599be134f81850c0a3d86928b057fba1eff
2017-09-01 17:13:01 -06:00
Ahmed ElArabawy
7b1a11c6a4 Merge "Add APF black list for ether-type" am: c6b2e356b6 am: b7cabe7b59
am: 1c1d81493e

Change-Id: I6302b93b8fcd40f6689f5cfe2faf580776a669d6
2017-09-01 07:15:05 +00:00
Ahmed ElArabawy
b7cabe7b59 Merge "Add APF black list for ether-type"
am: c6b2e356b6

Change-Id: I2aca562191119dc26eb7bc5293956061e5f44827
2017-09-01 06:28:51 +00:00
Ahmed ElArabawy
fd424169a1 Add APF black list for ether-type
Add a configurable black for protocols which packets are to be dropped
by APF. This enales an OEM to configure the APF to filter out un-needed
packets from reaching the host

Bug: 62415182
Test: runtest frameworks-net

Merged-In: I86335a0f854d5e83a2b2767978cd69b2cc25c2f8

Signed-off-by: Ahmed ElArabawy <arabawy@google.com>

(cherry picked from commit caffbe1277)

Change-Id: I15a758d18464d73d24ba8364a867904bb3cd3b34
2017-09-01 14:03:58 +09:00
Jeff Sharkey
595987e619 Merge "Augment network stats based on SubscriptionPlan." into oc-mr1-dev am: f31cf45e82
am: 8ab5f7f324

Change-Id: Ica24924ff8e5c95bd14114fb0a1d82c21a7d30d4
2017-08-30 19:27:49 +00:00
Jeff Sharkey
8ab5f7f324 Merge "Augment network stats based on SubscriptionPlan." into oc-mr1-dev
am: f31cf45e82

Change-Id: Ia6c6d5893d841f21d181363dc01f77efa6579a8f
2017-08-30 19:14:21 +00:00
Jeff Sharkey
f4de294297 Augment network stats based on SubscriptionPlan.
When a carrier provides an "anchor" of data usage at a specific
moment in time, augment the network statistics used by warning/limit
thresholds and Settings UI.  For example, if the OS measured 500MB
of usage, but the carrier says only 400MB has been used, we "squish"
down the OS measured usage to match that anchor.

Callers using the hidden API will have their data augmented by
default, and the public API offers a way to opt-into augmentation.

Thorough testing to verify behavior.

Test: bit FrameworksNetTests:android.net.,com.android.server.net.
Test: cts-tradefed run commandAndExit cts-dev -m CtsUsageStatsTestCases -t android.app.usage.cts.NetworkUsageStatsTest
Bug: 64534190
Change-Id: Id3d4d7625bbf04f57643e51dbf376e3fa0ea8eca
2017-08-30 10:01:10 -06:00
Colin Cross
46a435a378 Fix errorprone build
Fixes:
frameworks/base/tests/net/java/com/android/server/connectivity/tethering/OffloadControllerTest.java:149: error: [JUnit4TestNotRun] Test method will not be run; please add @Test annotation
    public void testNoSettingsValueDefaultDisabledDoesNotStart() throws Exception {
                ^
    (see http://errorprone.info/bugpattern/JUnit4TestNotRun)
  Did you mean '@Test'?
frameworks/base/tests/net/java/com/android/server/connectivity/tethering/OffloadControllerTest.java:170: error: [JUnit4TestNotRun] Test method will not be run; please add @Test annotation
    public void testNoSettingsValueDefaultEnabledDoesStart() throws Exception {
                ^
    (see http://errorprone.info/bugpattern/JUnit4TestNotRun)
  Did you mean '@Test'?

Bug: 64489631
Test: m -j RUN_ERROR_PRONE=true javac-check
Merged-In: Ib32489d07778465134bca52c589baddbd78ab129
Change-Id: I41dfdf87529e532df385617fa05c7006a7a14c86
2017-08-29 12:54:11 -07:00
Lorenzo Colitti
3dd0137ee5 Merge "Trivial change to test expectations."
am: c0d8300b32

Change-Id: I58155e3edb424ea6918a3d2bb8e284e61346765f
2017-08-28 12:49:29 +00:00
Lorenzo Colitti
f612b609db Trivial change to test expectations.
(cherry picked from commit 0fee732ca5)

Bug: 32163131
Test: runtest frameworks-net
Change-Id: Iec8af5191b4da495e47ef97d70a03a5d2e75cfe2
2017-08-28 18:58:13 +09:00
Lorenzo Colitti
349667d173 Merge "Trivial change to test expectations." into oc-mr1-dev am: 9487f80cc5
am: 06e3e912b2

Change-Id: I335fdb5f3053569036608300f8a324a840517cde
2017-08-24 11:17:28 +00:00
Lorenzo Colitti
06e3e912b2 Merge "Trivial change to test expectations." into oc-mr1-dev
am: 9487f80cc5

Change-Id: Iad2aad7163aea9b1b92ed3f46be7ce36cd0578c6
2017-08-24 11:03:38 +00:00
Erik Kline
df2a880775 Merge changes from topic "offload_cherrypick"
am: b09cf3fbf1

Change-Id: Icb4332b34bc8b940a2c30beab143f7136e0178de
2017-08-24 05:33:44 +00:00
Treehugger Robot
b09cf3fbf1 Merge changes from topic "offload_cherrypick"
* changes:
  Send add/removeDownstream info to offload HAL
  Don't completely stop offload if setting data limit fails.
2017-08-24 05:18:23 +00:00
Hugo Benichi
a585b612ff Merge "Make NetworkManagementServiceTest pass again." am: 29b1826ff2 am: d3d6ddea94 am: c933ef6c54
am: dceef06841

Change-Id: I5ec6a8cc3422c1baf107c814f7a60b28fcc71cd5
2017-08-24 04:21:14 +00:00
Hugo Benichi
dceef06841 Merge "Make NetworkManagementServiceTest pass again." am: 29b1826ff2 am: d3d6ddea94
am: c933ef6c54

Change-Id: Ic39262b1f650695cc6903c3a9e2ddb592d47b365
2017-08-24 04:09:14 +00:00
Erik Kline
b3bb26eaa7 Send add/removeDownstream info to offload HAL
Test: as follows
    - built
    - flashed
    - booted
    - "runtest frameworks-net" passed
Bug: 29337859
Bug: 32163131

Merged-In: I0cb81ac054fc2bf6c8b8bfe658e9404a15091d7a
Merged-In: I7abcdcc2d7d967179c47081a6db2b417164891f3
Change-Id: I6c59aa7cb80b54f376f294b24c1409710c553d74
(cherry picked from commit ed962a8412)
2017-08-23 20:55:47 -07:00
Lorenzo Colitti
ddce7ee20f Don't completely stop offload if setting data limit fails.
Currently, if setting a data limit fails, we completely stop
offload in order to avoid data overages. However, the next thing
we do is try to fetch the stats and crash, because once offload
is stopped all our local state is cleared.

Fix this by fetching stats before we stop offload.

Bug: 29337859
Bug: 32163131
Bug: 64867836
Test: OffloadControllerTest passes
Test: no crash when disabling wifi tethering with BT tethering active
Merged-In: I7fc47e60b2da5f39c26fb22c1325618f9948dd38
Merged-In: I464dd2a6d1996b1cfb8bbf82b6ee453fd0747569
Change-Id: I260f5450f8b67f055983af68fb23a5f3cfc0bc69
(cherry picked from commit d743601a00)
2017-08-23 20:51:35 -07:00
Hugo Benichi
d3d6ddea94 Merge "Make NetworkManagementServiceTest pass again."
am: 29b1826ff2

Change-Id: If7fafa0922fdbc499c0c911a3f88ede9c8a26c1d
2017-08-24 03:46:07 +00:00
Lorenzo Colitti
0fee732ca5 Trivial change to test expectations.
Bug: 32163131
Test: runtest frameworks-net
Change-Id: Iea41c2b50502797f559afd09ded8cedf50dd7c05
2017-08-24 12:43:38 +09:00
Hugo Benichi
29b1826ff2 Merge "Make NetworkManagementServiceTest pass again." 2017-08-24 03:36:20 +00:00
Hugo Benichi
bbadcfd315 Merge "Tethering offload stats updates are eventually consistent"
am: ff12ba9376

Change-Id: I3a8ddc928b60c666faab2991defe8fb7afd0801e
2017-08-24 02:52:42 +00:00
Erik Kline
7c5c7cc570 Merge "Send add/removeDownstream info to offload HAL" into oc-mr1-dev am: 568cd41216
am: 7559e2d2b2

Change-Id: I7abcdcc2d7d967179c47081a6db2b417164891f3
2017-08-24 01:44:31 +00:00
Erik Kline
7559e2d2b2 Merge "Send add/removeDownstream info to offload HAL" into oc-mr1-dev
am: 568cd41216

Change-Id: I0cb81ac054fc2bf6c8b8bfe658e9404a15091d7a
2017-08-24 01:27:46 +00:00
Erik Kline
ed962a8412 Send add/removeDownstream info to offload HAL
Test: as follows
    - built
    - flashed
    - booted
    - "runtest frameworks-net" passed
Bug: 29337859
Bug: 32163131

Change-Id: I6c59aa7cb80b54f376f294b24c1409710c553d74
2017-08-23 15:18:37 -07:00
Lorenzo Colitti
c7a8394ab1 Merge "Don't completely stop offload if setting data limit fails." into oc-mr1-dev am: 9b601f2066
am: 331f8a98df

Change-Id: I464dd2a6d1996b1cfb8bbf82b6ee453fd0747569
2017-08-23 06:05:09 +00:00
Lorenzo Colitti
331f8a98df Merge "Don't completely stop offload if setting data limit fails." into oc-mr1-dev
am: 9b601f2066

Change-Id: I7fc47e60b2da5f39c26fb22c1325618f9948dd38
2017-08-23 05:53:33 +00:00
Lorenzo Colitti
9b601f2066 Merge "Don't completely stop offload if setting data limit fails." into oc-mr1-dev 2017-08-23 05:46:34 +00:00
Hugo Benichi
752c1287bd Tethering offload stats updates are eventually consistent
This patch removes the call to runWithScissors() in
OffloadController#getTetherStats() that was causing a deadlock when
NetworkStatsService would be polled for stats in certain threading
contexts.

Instead of trying to query the tethering offload HAL synchronously all
the time, this patch:
 - changes getTetherStats() to only call into the offload HAL when it
   detects that it is called on the same thread as the Tethering handler
   thread.
 - changes the map of interface to accumulated tethering forwarded stats
   to be concurrent.

This makes stats reading from getTetherStats() eventually consistent.
From the point of view of getTetherStats(), it preserves the guarantees
that tethering stats are monotonically increasing, and also guarantees
no tearing between rx bytes and tx bytes.

Bug: 29337859
Bug: 32163131
Bug: 64771555
Test: runtest frameworks-net
Merged-In: Ibcd351ad0225ef146b00a807833f76d2a886f6c1
Merged-In: I61786d61fe1422e429c0dd9eadaff6f02eb850e7
Merged-In: I999d1d1bf72e7ab02c5d17f37aad00bc711d3fc5

(cherry pick from commit eb5e465edd)

Change-Id: I28646b962cee8c8a6efd66059f84873c02ac5810
2017-08-23 09:58:09 +09:00
Lorenzo Colitti
a086800e04 Make NetworkManagementServiceTest pass again.
1. Mock the service manager so that NMS can fetch mock versions
   of INetd and IBatteryStats.
2. Call LocalServices.removeServiceForTest to avoid a duplicate
   service registration error. // check this
3. Change the timeout from 100ms to 200ms, as otherwise the tests
   that check for IfaceClass fail.
4. Convert NetworkManagementServiceTest to JUnit 4.
5. Move NetworkManagementServiceTest to tests/net

Bug: 29337859
Bug: 32163131
Bug: 32561414
Bug: 62918393
Test: runtest frameworks-net
Change-Id: Ic7371b427b35809ccd446addf35c9d8ae99ccfd3
2017-08-23 09:49:05 +09:00
Lorenzo Colitti
96ae2a0694 Merge "Tethering offload stats updates are eventually consistent" into oc-mr1-dev am: 45fb339d83
am: e3aeae68f3

Change-Id: I999d1d1bf72e7ab02c5d17f37aad00bc711d3fc5
2017-08-22 22:38:06 +00:00
Lorenzo Colitti
e3aeae68f3 Merge "Tethering offload stats updates are eventually consistent" into oc-mr1-dev
am: 45fb339d83

Change-Id: I61786d61fe1422e429c0dd9eadaff6f02eb850e7
2017-08-22 22:19:36 +00:00
Lorenzo Colitti
45fb339d83 Merge "Tethering offload stats updates are eventually consistent" into oc-mr1-dev 2017-08-22 22:06:46 +00:00
Hugo Benichi
eb5e465edd Tethering offload stats updates are eventually consistent
This patch removes the call to runWithScissors() in
OffloadController#getTetherStats() that was causing a deadlock when
NetworkStatsService would be polled for stats in certain threading
contexts.

Instead of trying to query the tethering offload HAL synchronously all
the time, this patch:
 - changes getTetherStats() to only call into the offload HAL when it
   detects that it is called on the same thread as the Tethering handler
   thread.
 - changes the map of interface to accumulated tethering forwarded stats
   to be concurrent.

This makes stats reading from getTetherStats() eventually consistent.
From the point of view of getTetherStats(), it preserves the guarantees
that tethering stats are monotonically increasing, and also guarantees
no tearing between rx bytes and tx bytes.

Bug: 29337859
Bug: 32163131
Bug: 64771555
Test: runtest frameworks-net
Change-Id: Ibcd351ad0225ef146b00a807833f76d2a886f6c1
2017-08-22 19:31:31 +09:00
Lorenzo Colitti
d743601a00 Don't completely stop offload if setting data limit fails.
Currently, if setting a data limit fails, we completely stop
offload in order to avoid data overages. However, the next thing
we do is try to fetch the stats and crash, because once offload
is stopped all our local state is cleared.

Fix this by fetching stats before we stop offload.

Bug: 29337859
Bug: 32163131
Bug: 64867836
Test: OffloadControllerTest passes
Test: no crash when disabling wifi tethering with BT tethering active
Change-Id: I260f5450f8b67f055983af68fb23a5f3cfc0bc69
2017-08-22 18:09:02 +09:00
Hugo Benichi
f525708438 Merge "IpManager: use InitialConfiguration for provisioning" am: 5b218bdc8e am: c6a9b5564a am: e869136a54 am: f7c02563ee
am: 4b884096a5

Change-Id: Iceab8f4f6b438564f444410487f8f4ace84181fd
2017-08-21 12:57:26 +00:00
Hugo Benichi
4b884096a5 Merge "IpManager: use InitialConfiguration for provisioning" am: 5b218bdc8e am: c6a9b5564a am: e869136a54
am: f7c02563ee

Change-Id: I80439f92cad469ac77c11430727e5207e75cf432
2017-08-21 12:41:28 +00:00
Hugo Benichi
386f3aee13 IpManager: use InitialConfiguration for provisioning
This patch changes IpManager to take into account static provisioning
information specified in the InitialConfiguration for IPv6 static
configuration.

When a valid InitialConfiguration with IPv6 content is specified,
IpManager will do the following things:

- at start(), it will push the IPv6 addresses in the config to netd
- it will observe all addresses be notified via Netlink
- when all addresses are there, it will patch in the associated IPv6
  routes in the config, so that they get passed to ConnectivityService
  through the usual mechanism

The logic triggering onProvisioningSuccess is also changed to take into
account InitialConfiguration: when all addresses and all routes in the
config are seen the provisioning is successful.

Bug: 62988545
Test: runtest frameworks-net, with newly added tests
Merged-In: I77ed7c576c4b198de7a4726be70c78b74689e98b
Merged-In: I131589680b68222e4fda4e9165ac2f50894ee28e
Merged-In: I6e42d26ae430c213f65e466a2c556760ff0e14eb
Merged-In: I8e9c6de63697b8c3f41480d69309360763119838
Merged-In: I80439f92cad469ac77c11430727e5207e75cf432

(cherry picked from commit d00ddf5672)

Change-Id: I7b1ced13361f49a92b10174486de9a1f70dd68d1
2017-08-21 21:37:29 +09:00
Hugo Benichi
f7c02563ee Merge "IpManager: use InitialConfiguration for provisioning" am: 5b218bdc8e am: c6a9b5564a
am: e869136a54

Change-Id: I8e9c6de63697b8c3f41480d69309360763119838
2017-08-21 12:29:53 +00:00
Hugo Benichi
e869136a54 Merge "IpManager: use InitialConfiguration for provisioning" am: 5b218bdc8e
am: c6a9b5564a

Change-Id: I6e42d26ae430c213f65e466a2c556760ff0e14eb
2017-08-21 12:19:08 +00:00
Hugo Benichi
c6a9b5564a Merge "IpManager: use InitialConfiguration for provisioning"
am: 5b218bdc8e

Change-Id: I131589680b68222e4fda4e9165ac2f50894ee28e
2017-08-21 12:08:28 +00:00