Commit Graph

16651 Commits

Author SHA1 Message Date
TreeHugger Robot
cc0987b12a Merge "Soft remove deprecated translation apis." into sc-dev 2021-05-21 08:39:35 +00:00
Adam He
6ebd5b236d Soft remove deprecated translation apis.
Bug: 186475868
Test: atest CtsTranslationTestCases
Change-Id: I87395052e9e5574f4ba11652c484cedec95c0cfb
2021-05-20 18:14:56 -07:00
Yohei Yukawa
ebd27c999b Merge "Fix IME be dismissed abruptly" into sc-dev 2021-05-20 17:19:45 +00:00
Jeff DeCew
fc0a05e3e4 Merge "Remove padding logic designed for old position of the expand button" into sc-dev 2021-05-20 16:22:41 +00:00
Joanne Chung
86d3f3deae Merge "Translate TextView content description if exist" into sc-dev 2021-05-20 06:00:56 +00:00
Wilson Wu
e525c01439 Fix IME be dismissed abruptly
CL[1] used to fix some IME animation issue.
And simplified the check focused view logic.

But when window focus changed, the focused view
may still be null. So ImeFocusdController use the
DecorView to start an new Input and hide keyboard.

Use the focused view after focus change callbacks
when we call onPostWindowFocus as before.

[1]: Ib140801f1ce03b5566e756914f96dacba3ad8892

Bug: 186331446
Test: Manual test with the bug steps
Test: atest FocusHandlingTest#testRequestFocusOnWindowFocusChanged
Change-Id: I2f8fde0b6575db17955ff8b8804b61378f9d6dad
2021-05-20 10:26:47 +08:00
TreeHugger Robot
214e26eced Merge changes from topic "revert-13738532-client_suggestions_fillrequest-sc-dev-EQZRQWLQUO" into sc-dev
* changes:
  [DO NOT MERGE] Remove the Client Suggestions APIs
  [DO NOT MERGE] Remove Client suggestions implementations
2021-05-20 01:23:24 +00:00
Jeff DeCew
970a13aea0 Remove padding logic designed for old position of the expand button
Fixes: 188095319
Test: Manual testing of minimized notifications.
Change-Id: I92ba63ec0266089a4af630afb202b279dbe294ed
2021-05-19 13:37:24 -04:00
Tiger Huang
a254d7fd43 Merge "Force showing navigation bar while IME is visible" into sc-dev 2021-05-19 15:25:17 +00:00
TYM Tsai
94a825887b [DO NOT MERGE] Remove the Client Suggestions APIs
Bug: 188618287
Test: atest CtsAutoFillServiceTestCases
Change-Id: I178e0443278383120d9e6e3321ec96be8e5705c1
2021-05-19 23:24:32 +08:00
Adam He
c1b7cc6ab5 Merge "Change dictionary results to use a bundle instead since it is a structured result." into sc-dev 2021-05-18 18:49:03 +00:00
TreeHugger Robot
0b9af71d1e Merge "Quick change to add default to deprecated callback method so implementors can move to new api." into sc-dev 2021-05-18 18:46:31 +00:00
Galia Peycheva
551a988b60 Merge "Add windowIsFloating to window blur documentation" into sc-dev 2021-05-18 12:47:10 +00:00
Vadim Caen
eacda76449 Merge "Draw splashscreen edge to edge" into sc-dev 2021-05-18 11:22:54 +00:00
Siarhei Vishniakou
234adf7cb2 Merge "Check mInputEventReceiver before sending timeline -- 2" into sc-dev 2021-05-17 17:35:24 +00:00
Galia Peycheva
fa9ca5f9bf Add windowIsFloating to window blur documentation
Bug: 182567575
Test: m doc-comment-check-docs
Change-Id: I3ee71c82416e359d077750ae7d0ba8b1b7fbfb29
2021-05-17 18:10:45 +02:00
Joanne Chung
9753899a97 Translate TextView content description if exist
Screen reader(Talkback) will read content description first if the
developers set. We only translate TextView text, this may cause the
screen reader will not read the translated text if the developers set
content description.

To fix the issue, we also send the content description to translate.
When the translated text is shown, we also set content description
with translated content description and reset to original content
description if show original text.

Bug: 187134784
Test: atest CtsTranslationTestCases
Change-Id: I6986384260627a0539780b7293d47666c442d852
2021-05-17 14:05:52 +08:00
Tiger Huang
a39967f4bc Force showing navigation bar while IME is visible
This CL revokes navigation bar control to make navigation bar visible
while IME is showing, so the button to dismiss IME would be available.

This CL also lets IME receive visible navigation bar insets, regardless
of the navigation bar visibility.

Fix: 167971834
Fix: 186789472
Test: atest WindowStateTests WindowInsetsControllerTests
Change-Id: I2e723d4fc50d006127caa473d67c2f6af0d2cbcd
2021-05-17 11:10:26 +08:00
Jeff Sharkey
dd6dd3b1fb Apply AttributionSource during Intent delivery.
There are some Parcelables which offer to perform Binder calls, and
when these are delivered via Intent extras they fallback to
ActivityThread.currentAttributionSource(), instead of being tagged
based on the relevant app component.

This change begins using Intent.prepareToEnterProcess() as a hook to
fix-up AttributionSource when those extras finally land in the
destination process.  It uses the relevant AttributionSource based
on the Activity or Service the Intent is delivered to, which
developers have control over via AppComponentFactory.

In the case of <receiver> manifest elements, this change applies the
first android:attributionTags value to the Context used for that
BroadcastReceiver.

Bug: 187097694
Test: atest AttributionTest
Change-Id: I8f5197db7e8d7277d34f0ef2bb90bfdf1871186a
2021-05-15 09:48:14 -06:00
Adam He
9cb16d9a4a Change dictionary results to use a bundle instead since it is a
structured result.

Bug: 187219452
Test: atest CtsTranslationTestCases
Change-Id: I61f62172d8089e1401e95177150ee23b1bee8e96
2021-05-14 17:11:28 -07:00
Winson Chung
79914dfbd5 Merge "Add fallback animation for auto-enter without source rect hint" into sc-dev 2021-05-14 23:44:23 +00:00
Ahaan Ugale
9e22972568 Merge "Fix IndexOutOfBoundsException when calling dispatchProvideStructure()" into sc-dev 2021-05-14 21:15:18 +00:00
Ahaan Ugale
6bf4cb6147 Merge "Make InputMethodInfo#showInInputMethodPicker public." into sc-dev 2021-05-14 16:14:00 +00:00
Riddle Hsu
a274fd1c1a Draw splashscreen edge to edge
- Switch from PhoneWindow to FrameLayout
 - Ensure the Action bar is not shown on the splashscree
 - Do not show the contrast scrim under the system bars
 - Use the latest insets API to layout fullscreen

Test: Updated CtsWindowManagerDeviceTestCases:SplashscreenTests
Bug: 181852475
Bug: 184941669
Change-Id: Ifc04bd2227394415cc74c20d2974f4726ec9c789
2021-05-14 17:51:23 +08:00
Ahaan Ugale
76bf20fce7 Make InputMethodInfo#showInInputMethodPicker public.
Allows custom Input Method Pickers to exclude relevant IMEs, like the
system picker does now.

Fix: 184890628
Test: atest InputMethodInfoTest InputMethodManagerTest
Change-Id: I20033de2f6679ed8cd538de66e157f737792d847
2021-05-13 20:58:32 -07:00
Huihong Luo
f410f8134f Merge "Fix leakage of ASurfaceTransactionCallback" into sc-dev 2021-05-14 03:33:53 +00:00
Adam He
0a78fe6d5e Merge "Removed addValue from TranslationRequest because of potential bug in genrated builder code." into sc-dev 2021-05-13 22:03:42 +00:00
Adam He
c8421712cb Quick change to add default to deprecated callback method so
implementors can move to new api.

Bug: 186475868
Test: atest CtsTranslationTestCases
Change-Id: I3cfa2ec09bab37b7db110bf0f140754db4d2329a
2021-05-13 13:53:28 -07:00
Adam He
af6aa6ffb7 Merge "Make getText() nullable and return null." into sc-dev 2021-05-13 20:52:48 +00:00
TreeHugger Robot
0d2041dec3 Merge "Do not recreate ImeInputEventSender for the same channel" into sc-dev 2021-05-13 18:55:14 +00:00
Ady Abraham
c49b886d73 Merge changes from topic "preferredDisplayModeId60120" into sc-dev
* changes:
  Enable preferredDisplayModeId for frame rate override
  Add preferredMaxDisplayRefreshRate
2021-05-13 15:59:00 +00:00
Ahaan Ugale
cc4fa5f3b6 Merge "Pipe UiTranslationSpec through to the UiTranslationController." into sc-dev 2021-05-13 15:24:12 +00:00
Winson Chung
8aa6016bb3 Add fallback animation for auto-enter without source rect hint
- Launcher will create a new surface which is faded in over the app,
  and as it finishes the recents animation, we transfer the overlay
  from the leash to the task (as with the transform), and when the
  pip task organizer receives it, it can fade out and remove the
  surface
- Fixes flash of status bar colors when going from light status bar
  to home (dark status bar) by deferring whether a task affects the
  sysui flag until it enters pip (only for autoenter)

https://recall.googleplex.com/projects/e3f080d7-2818-43f0-a087-405000b8fdf5/sessions/971a84c8-a622-4b34-a9de-4e595595da42

Bug: 184703546
Test: Swipe up from app with auto-enter but no source hint rect

Change-Id: I0a00cdb98d0a599ef065206e0cd2cfc0e6cc72b1
2021-05-12 23:53:25 -07:00
Siarhei Vishniakou
85d8f5c669 Do not recreate ImeInputEventSender for the same channel
InputEventSender is used to send events to an InputChannel. On the other
side, InputEventReceiver receives the events and processes them.

There's no good way to synchronize InputEventSender and
InputEventReceiver today. If the InputEventSender object changes in the
middle of interaction with the InputEventReceiver, it will confuse the
receiver. Recently added strict checking of state in InputEventReceiver
causes the other side to crash.

In the IME case, there are dup'ed InputChannel being compared to each
other by object. Since the objects are different, the equality check
fails, even though they represent the same connection. This causes the
InputEventReceiver to receive a sequence of events like this:

incoming event seq = 1
incoming event seq = 2
incoming event seq = 3
incoming event seq = 1
incoming event seq = 2
...

If the InputEventReceiver is slow, it might only send finished signal
after it processed first event with seq = 2, but the sender has already
changed, and has already sent a new event with seq = 2. This would cause
the receiver to overwrite the state of the second event with the first
event, thus later causing a crash when it tries to ack the second event.

The events received by the InputEventReceiver should all have unique
seq. The pattern of re-creating InputEventSender breaks this contract.

To fix this issue, we check whether the provided InputChannel represents
the same connection. If the connection is the same, we do not re-create
the InputEventSender, and just keep using the same object. This ensures
that InputEventReceiver is always communicating with only one
InputEventSender and the state remains consistent.

In this CL, only a minimal change is made, and it is not rootcaused why
the 'setInputChannelLocked' call is being made for the same connection.

Bug: 183434055
Test: adb shell monkey 10000; run this test several times until it
crashes. No more crashes observed with "Abort message: 'Could not find consume time for seq=2'"
Test: use soft keyboard on device

Change-Id: If8317941dd1c6d5db77f1239b9a9f45d49997df9
2021-05-13 00:06:28 +00:00
Ahaan Ugale
f765882432 Pipe UiTranslationSpec through to the UiTranslationController.
And use it to conditionally enable content padding for requested views.

Fix: 179693024
Test: atest android.translation.cts.UiTranslationManagerTest
Test: adb shell dumpsys activity <ACTIVITY> --translation
Change-Id: I23fb29a60525d736f2dcf9d11b548c62332c412c
2021-05-12 11:47:15 -07:00
Jeff DeCew
9e30756592 Merge "Show minimized header text with the correct text weight" into sc-dev 2021-05-12 17:57:57 +00:00
TreeHugger Robot
3d18b83a20 Merge "Fix UiTranslationSpec#shouldPadContentForCompat javadoc." into sc-dev 2021-05-12 14:00:03 +00:00
Ahaan Ugale
4b7d0eddc5 Fix UiTranslationSpec#shouldPadContentForCompat javadoc.
Corrects the documented behaviour to reflect the implementation.

Bug: 187739356
Test: n/a
Change-Id: I6b64ebf56e32da4d4718cfa6b5501e5314a62aac
2021-05-11 20:28:18 -07:00
Joanne Chung
f13de286ff Merge "API feedback: Translation View API improvement." into sc-dev 2021-05-12 00:29:53 +00:00
Jeff DeCew
9c1f4e12c9 Show minimized header text with the correct text weight
Fixes: 184863420
Test: visual
Change-Id: Ic16f9e88e118e7ea5fe14054cf1c35318d4a6ddd
2021-05-11 17:10:34 -04:00
TreeHugger Robot
ab367ab510 Merge "AttachedSurfaceControl: Respond to API feedback." into sc-dev 2021-05-11 19:13:05 +00:00
TreeHugger Robot
d85097d1ad Merge "Add android: to text constant to prevent namespace conflicts." into sc-dev 2021-05-11 12:50:54 +00:00
Ady Abraham
26c834522b Add preferredMaxDisplayRefreshRate
Add a new private window attribute for allowing apps to specify the max
display refresh rate. This is useful for use cases such as keyguard
where the refresh rate should be limited to preserve power.

In the next CLs the preferredDiplayModeId would be enabled for
frame rate override (60-on-120) and the preferredMaxDisplayRefreshRate
would be the alternative to control the display refresh rate (as opposed
to the frame rate experienced by the app).

Test: atest RefreshRatePolicyTest
Test: atest DisplayModeDirectorTest
Test: Launch camera app and observe refresh rate
Bug: 183226498
Change-Id: I1c5e9f6047cbea4bfb581251b8dd2b9058b3e378
2021-05-10 16:37:33 -07:00
Joanne Chung
1450a8706d API feedback: Translation View API improvement.
1. Rename dispatchRequestTranslation().
2. Provide what should be done in onViewTranslationResponse().

Bug: 186578468
Bug: 186578311
Test: atest CtsTranslationTestCases
Test: manual.
CTS-Coverage-Bug: 177960696

Change-Id: Id90e7d68a92ec17ec302d7ff05ef67c8bfa6454b
2021-05-10 17:19:09 +08:00
Adam He
d5a4499faa Removed addValue from TranslationRequest because of potential bug in
genrated builder code.

* if Builder.setValues is called with an immutable list, future calls to
addValue will throw.

Fixes: 187542825
Test: atest CtsTranslationTestCases
Change-Id: Ie405975e1a0a8aa90bde7358afde15b8c60aa95a
2021-05-07 16:41:15 -07:00
Adam He
b9cdc84c87 Add android: to text constant to prevent namespace conflicts.
Fixes: 187219011
Test: atest CtsTranslationTestCases
Change-Id: I980156c8653581aa5020afaa5bcb97e909d291df
2021-05-07 15:14:30 -07:00
Rob Carr
84c2f5bf21 Merge "SyncRtSurfaceTransactionApplier: Improve thread safety" into sc-dev 2021-05-07 22:11:00 +00:00
TreeHugger Robot
14449b8794 Merge "Add NO_FOCUS_CHANGE flag to MotionEvent" into sc-dev 2021-05-07 20:54:30 +00:00
Robert Carr
e9ea91f47d SyncRtSurfaceTransactionApplier: Improve thread safety
If the calling thread releases the SurfaceControl passed
to SyncRtSurfaceTransactionApplier concurrently with the
applier preparing the transaction, this can lead to a
synchronization error and a crash. Once the state is
inside the transaction no further synchronization is required
as the native transaction will hold its own sp<SurfaceControl>
reference. By constructing the Transaction on the calling thread
and deferring application to the RenderThread we enable the calling
thread to not have any release synchronization requirements with
RenderThread.

Bug: 186391509
Change-Id: I585e1a9d3baf9ea384b00408b6253f34487d5037
2021-05-07 18:53:00 +00:00
Huihong Luo
e76f181372 Fix leakage of ASurfaceTransactionCallback
The callback needs to set to null when thread renderer is destroyed.

Bug: 187419942
Bug: 186869429
Test: blaze test --test_strategy=local --test_arg=--device_broker_type=LOCAL_ADB_SERVER //javatests/com/google/android/testing/elizabot/internal/sanity/subscriptionleak:SubscriptionLeakTest_generic_phone_google_31_x86
Change-Id: Ic80c58f102ee5f21830542030021828f6231cc37
2021-05-07 08:17:26 -07:00