Commit Graph

11270 Commits

Author SHA1 Message Date
Adrian Roos
55fe653956 Merge "DecorView: Fix status guard" into qt-dev
am: f5432f1862

Change-Id: I0f455bb3e860e089dfe31b6d5e8109a74580989d
2019-06-11 10:45:09 -07:00
Adrian Roos
f5432f1862 Merge "DecorView: Fix status guard" into qt-dev 2019-06-11 17:34:32 +00:00
Adrian Roos
27db0caaca DecorView: Fix status guard
Fixes several issues with the status guard:
- poor background color for light status bar background
- guard & action mode need insets for the navigation bar in landscape
- status guard was not properly dismissed after completion of the action mode
- uses the proper non-zero root inset when LAYOUT_HIDE_NAVIGATION is unset & in landscape

Bug: 132924796
Test: make ApiDemos, use SystemUiModes activity to trigger action mode
Change-Id: Ie9ba2b6fb2c87a1825df85f756ffb062a45d4f55
2019-06-11 17:09:12 +02:00
Christian Wailes
31e3b9cb80 Merge "Fixes two data races in USAP pool management." into qt-dev
am: 5e468cf4dd

Change-Id: I08c601277f24cf918000eb032e7d95f38e6c0c5c
2019-06-10 15:26:57 -07:00
Christian Wailes
5e468cf4dd Merge "Fixes two data races in USAP pool management." into qt-dev 2019-06-10 22:09:43 +00:00
Eugene Susla
6fef220b46 Merge "Guard against null mFunc in PooledLambdaImpl" into qt-dev
am: e64acbea8e

Change-Id: I5591cb8fc6eefae6c82e8d1dc705f422484bd3ea
2019-06-10 13:39:25 -07:00
TreeHugger Robot
e64acbea8e Merge "Guard against null mFunc in PooledLambdaImpl" into qt-dev 2019-06-10 20:28:11 +00:00
Matt Pietal
1fd7d07ddf Merge "Sharesheet - Hide direct share area for low ram devices" into qt-dev
am: fcc4d76a97

Change-Id: Ia4622b13fcb9befbf34932b86c247dc3057323a5
2019-06-10 10:33:44 -07:00
TreeHugger Robot
fcc4d76a97 Merge "Sharesheet - Hide direct share area for low ram devices" into qt-dev 2019-06-10 17:29:52 +00:00
Matt Pietal
8b19acac90 Merge "Sharesheet - Adjust timeouts and logic for direct share" into qt-dev
am: 503b489384

Change-Id: Ibbbb8947eeaae6c2f883f725de8c6dec8b25792c
2019-06-10 08:00:10 -07:00
Matt Pietal
6e88b51026 Sharesheet - Hide direct share area for low ram devices
Make sure to force the item count to 0 to make sure the direct share
area stays hidden.

Bug: 134776740
Test: Low ram device, manual
Change-Id: I598752db5747b1c845495af7ae2f591488799352
2019-06-10 10:20:15 -04:00
Matt Pietal
ab73a887ef Sharesheet - Adjust timeouts and logic for direct share
Improve direct share loading by:
1. Do not issue redundant service calls within the watchdog timeout
period
2. Set a min and max watchdog timeout period, and if all services
return early, then informt the user we are done to so that they don't
have to wait until the max timeout period.
3. Be more specific on package changes. Resolver requires any change
to trigger a refresh, but chooser only needs to know about top level
package changes.

Bug: 134416594
Test: Manual
Change-Id: I075fd5b6f64c25637fd7ba7aa6b163dca81371a8
2019-06-10 07:24:51 -04:00
Eugene Susla
f8fc474c8f Guard against null mFunc in PooledLambdaImpl
Fixes: 134594642
Test: presubmit
Change-Id: I7b65d18df1625a276986a844569a1275c09df4e4
(cherry picked from commit 1cff0828e3)
2019-06-07 21:22:33 +00:00
Chris Wailes
f59ea2cc39 Fixes two data races in USAP pool management.
The USAP pool management code contained two data races.  One could cause
a double decrement if a runtime thread executed the SIGCHLD handler
while the server was responding to a pool exit message from a USAP.  The
other data race could occur when the SIGCHLD handler executed in the
middle of a USAP pool flush.

The solution to the first race is to change the return value from a
helper function to ensure that the decrement only occurs when the entry
is invalidated through that specific invocation of the helper.

The second data race was fixed by using SIGTERM instead of SIGKILL when
flushing the USAP pool.  This allows the Zygote to clear the table
entries outside of the SIGCHLD handler, and the handler to avoid
duplicate bookkeeping cleanup when this occurs.  SIGTERM is used so that
it can be differentiated from other process termination events and so
that it can be blocked while the USAP is specializing, but hasn't yet
informed the Zygote of it's removal from the pool.  This issue and this
fix will no longer be necessary once the Zygote signal handler has been
replaced with a signalfd.

Bug: 132794985
Test: atest SignedConfigHostTest
Change-Id: Ie01637a10b356b80b5aa62291a97f2c167242827
Merged-In: Ie01637a10b356b80b5aa62291a97f2c167242827
(cherry picked from commit fb329ba7c8)
2019-06-07 13:32:38 -07:00
Benedict Wong
3e9726c69c Revert "Take all VPN underlying networks into account when migrating traffic for"
am: ac06c1022d

Change-Id: Iec81a5823e476a52c41a9853fb40aa1804d1a826
2019-06-07 02:33:30 -07:00
Benedict Wong
ac06c1022d Revert "Take all VPN underlying networks into account when migrating traffic for"
This reverts commit 917327b193.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: Ibdaad3a4cbf0d8ef1ed53cfab1e454b9b878bae9
2019-06-07 09:18:01 +00:00
Yiwei Zhang
d480e6a0f7 Merge "Decouple Game Driver from preloading graphics driver" into qt-dev
am: 1f66726d08

Change-Id: I77846d647f3f77f6af325f85a6a229d6c3c8d085
2019-06-06 16:14:39 -07:00
TreeHugger Robot
1f66726d08 Merge "Decouple Game Driver from preloading graphics driver" into qt-dev 2019-06-06 22:54:21 +00:00
Govinda Wasserman
2c594ee9b6 Merge "Improves the REMINDER_EXP mode for Assist Handle behavior" into qt-dev
am: 4335d958e4

Change-Id: I72309c3d7a2a71ac7c298a2504e0995d5135d865
2019-06-06 15:05:58 -07:00
TreeHugger Robot
4335d958e4 Merge "Improves the REMINDER_EXP mode for Assist Handle behavior" into qt-dev 2019-06-06 21:50:28 +00:00
Govinda Wasserman
48cdd68afe Improves the REMINDER_EXP mode for Assist Handle behavior
- User learning state is reset when leaving REMINDER_EXP behavior.
- Default parameters updated for easier testing and better experience
- Show and go only performed once per day when gesture has been learned
- Slightly delay handle showing when entering an apps with a longer
  delay when switching between apps rapidly.
- Adds state dump to improve debugability.
- Adds ability to suppress handle showing in specific states using
  flags.

Test: atest AssistHandleBehaviorControllerTest
Test: Tested locally
BUG:132983599
Change-Id: I7829ad55d7667f5db3633e702add709968dcd0a9
2019-06-06 16:24:35 -04:00
Fabian Kozynski
005993172f Merge "DO NOT MERGE Revert "DO NOT MERGE Remove Privacy Indicators"" into qt-r1-dev 2019-06-06 19:45:20 +00:00
Adrian Roos
e8fa8c6230 Merge "GestureNav: Fix broken split screen navbar" into qt-dev
am: 730b22c229

Change-Id: Icef93a6bf78f8a25c9ba307bfd56e17f28407a79
2019-06-06 09:28:18 -07:00
TreeHugger Robot
730b22c229 Merge "GestureNav: Fix broken split screen navbar" into qt-dev 2019-06-06 16:09:25 +00:00
Yiwei Zhang
6100c70d58 Decouple Game Driver from preloading graphics driver
Previously, when the Game Driver package name is set, graphics driver preloading
is automatically disabled. Now we'd like to decouple the relation here. So Game
Driver could still work no matter graphics driver is preloaded in Zygote or not.

Bug: 134526352
Test: build, flash and boot.
Change-Id: Id720cc11e3365423dd9b984b7d30a2dbeecb6116
2019-06-05 15:56:10 -07:00
Makoto Onuki
3c36699987 Merge "Avoid creating multiple death recipients for same observer" into qt-dev
am: a478c5f9aa

Change-Id: Id856368d4da90c4efb660ee4598b7d2ae4a75dc7
2019-06-05 09:08:36 -07:00
Makoto Onuki
a478c5f9aa Merge "Avoid creating multiple death recipients for same observer" into qt-dev 2019-06-05 15:54:05 +00:00
Lucas Dupin
7bfbb7e0a7 Merge "Fix flaky test" into qt-r1-dev 2019-06-05 15:37:29 +00:00
Matt Pietal
5e0e38c7f4 Merge "Sharesheet - Adjust button bar insets" into qt-dev
am: 83375a391c

Change-Id: I1ecd70053caef327025d628bc1e4df5725ec83f2
2019-06-05 06:18:50 -07:00
Matt Pietal
78fdbd492f Sharesheet - Adjust button bar insets
Button bar insets were set before the inset callback. Add a call to
layout the button bar during the inset callback.

Bug: 134472146
Test: Steps from defect
Change-Id: I0246f06315cd05343002071dd6d217d41e0059ca
2019-06-05 07:09:17 -04:00
Lucas Dupin
5febf7eb6b Fix flaky test
Test was registering a listener, and events could come from wallpaper
manager making it unstable.

Fixes: 134485306
Test: atest SysuiColorExtractorTests
Change-Id: Ie838cbee0887f3503ce328d5c5b5603c413d5458
2019-06-04 20:47:29 -07:00
Hui Yu
c1dceabb36 Merge "Only set mStartClockTime when device is fully charged." into qt-dev
am: 28d28a4ee5

Change-Id: I902918ae0523e9a1c57bf4d867cd4d17847b4867
2019-06-04 18:20:04 -07:00
Makoto Onuki
ad1291e749 Avoid creating multiple death recipients for same observer
Also do a WTF when the same process registers 1000 observers with the
same observer instance.

Fix: 133388082
Test: manual test: Launch leaky app and make sure WTF is raised
Test: manual test: Open contacts app, close, and make sure the
"Total number of unique observers" goes back
Test: manual test: Open contacts app, kill it, and make sure the
"Total number of unique observers" goes back
Test: manual test: Open contacts app while contacts are syncing,
and make sure the activity refreshes itself.
Test: atest cts/tests/tests/content/src/android/content/cts/ContentResolverTest.java
Test: atest FrameworksCoreTests:BinderDeathDispatcherTest
Test: atest FrameworksServicesTests:com.android.server.content.ObserverNodeTest

Change-Id: Id738ca66023c029b92db3d108d99a9fc240fe77c
2019-06-04 17:06:39 -07:00
Hui Yu
28d28a4ee5 Merge "Only set mStartClockTime when device is fully charged." into qt-dev 2019-06-04 21:59:52 +00:00
Fabian Kozynski
53ceaf677a DO NOT MERGE Revert "DO NOT MERGE Remove Privacy Indicators"
This reverts commit ec3e0ecaca.

Reason for revert: Re-enable Privacy Indicators in qt-r1-dev
Bug: 133257910

Change-Id: I7c778dd76c0aff3f483cf06f1dd96fd067145c12
2019-06-04 16:37:21 +00:00
Kevin Yao
0d2970d912 Merge "User education support on disambiguation dialog" into qt-dev
am: 327751f18f

Change-Id: I0ab37bd7b5cf4b00df4dc70d35a1387e3f348680
2019-06-03 18:40:43 -07:00
Kevin Yao
327751f18f Merge "User education support on disambiguation dialog" into qt-dev 2019-06-04 01:29:21 +00:00
Hui Yu
5104da00aa Only set mStartClockTime when device is fully charged.
The mStartClockTime represents the time device is fully charged.
Currently mStartClockTime is set again whenever the device clock
changes. Since the device clock could change many times, we lost
original mStartClockTime value, unreasonable mStartClockTime values
for example 26 days could be returned (because the device clock changes)
when getStartClockTime() is called.

A better solution is to only set mStartClockTime when device is fully
charged, the value is persisted across device reboot. When getStartClockTime()
is called, we return adjusted value according to current time.

Change-Id: I49ded1519bc31daf1a51a572325cbbe67f1abd09
Fix: 132914064
Test: Manual test, checking Settings--Battery--Last full Charge
2019-06-03 14:18:32 -07:00
Matt Pietal
02b0c0e363 Sharesheet - Fix layouts for multi-window mode
am: 3e4b56f76c

Change-Id: Iaea89d07090efc03a831955753411432142d5890
2019-06-03 10:07:07 -07:00
Kevin Yao
9176f033d9 User education support on disambiguation dialog
Support Accessibility education according to
1. Gesture Navigation is on or off
2. Screen reader feature (such as TalkBack) is enabled or not
Manual test screenshot: https://drive.google.com/open?id=1afTDRYPMcZphM5cL0krPDA_Vh9pRX-8x

Bug: 133811747
Test: Manual
Change-Id: I04ca36c9e88ff14e29103db41cfab2a9b53985d5
2019-06-03 13:59:38 +00:00
Adrian Roos
faba406212 GestureNav: Fix broken split screen navbar
With gesture navigation, it no longer makes sense to force the navigation bar
to black in split screen, instead we can show the respective navbar backgrounds of
the applications.

Fixes: 130913061
Test: enable gesture navigation, enter splitscreen, observe that navigation bar backgrounds are properly drawn, also verify the same if IME is open.
Change-Id: If1464dd9cf0c5499c7c33caab06eb430fb59cb30
2019-06-03 14:46:51 +02:00
Matt Pietal
3e4b56f76c Sharesheet - Fix layouts for multi-window mode
When using multi-mode and holding the phone in portrait, android will
report it's orientation as LANDSCAPE. Take multi-window mode into
account when determining fixed widths as well as number of items per
row.

Bug: 132828939
Test: Use multi-window mode
Change-Id: I97b722ea58c9f79aea2a3ab594c3ad7d78f8607c
2019-06-03 07:08:22 -04:00
Hui Yu
7ac56b7229 Merge "Do not create EMPTY batterystats history file." into qt-dev
am: 04c3eeeaa0

Change-Id: Ia9927f3f094767ea136a06b0a840e89f280d26c2
2019-05-31 20:22:45 -07:00
TreeHugger Robot
04c3eeeaa0 Merge "Do not create EMPTY batterystats history file." into qt-dev 2019-06-01 02:30:20 +00:00
Hui Yu
e40781ee84 Do not create EMPTY batterystats history file.
Previously when batterystats history buffer exceeds MAX_HISTORY_BUFFER
size, we create a new history file which is empty until batterystats
history buffer is written to the file. But the buffer is written to the
file every 30 minutes by default. When the file is empty, if the
system server process crashed or abrupt powered off, the file will remain
empty.

During the device bootup, batterystats reads history buffer from
the empty file and failed. The important mHistoryBaseTime variable is zero,
which causes all timestamps in subsequent history events are wrong, this
causes volta go/powerbug displays wrong, also Battery Usage in Settings
are wrong.

The fix is to not create new empty history file on disk until we actually
write history buffer to the file.

This problem can be manually reproduced by creating new empty file under
battery-history directory, then power off the device by long press power
button.

Bug: 133525277
Test: frameworks/base/core/tests/coretests/src/com/android/internal/os/BatteryStatsHistoryTest.java

Change-Id: I0c22881df6897e8832b472cc5e82fbf2727eb252
2019-05-31 23:48:47 +00:00
Fabian Kozynski
ec3e0ecaca DO NOT MERGE Remove Privacy Indicators
am: 9a560e068d

Change-Id: Ied3a51b9c47255a21e2fd29becfe4ed3400a16c7
2019-05-31 15:51:18 -07:00
Fabian Kozynski
9a560e068d DO NOT MERGE Remove Privacy Indicators
Bug: 133257910
Test: build and check that behavior is as P
Change-Id: I24bfc3806e2d12f6a1cc968d6979107e7002a3c4
2019-05-31 20:43:21 +00:00
Robert Snoeberger
33ce8f47c9 Merge "Implemented the mechanism of hiding clock face based on phenotype flag." into qt-r1-dev 2019-05-31 18:38:59 +00:00
lumark
9992e08829 Merge "Skip IME initialization when received the token that already registered" into qt-dev
am: 9bb2607703

Change-Id: I47e3521b214d5b5e057c979dfe8d96696bd42009
2019-05-30 10:44:19 -07:00
TreeHugger Robot
9bb2607703 Merge "Skip IME initialization when received the token that already registered" into qt-dev 2019-05-30 17:33:17 +00:00