Commit Graph

3687 Commits

Author SHA1 Message Date
Tony Huang
40a037b395 Merge "Fix divider animation and wrong split bounds" 2022-02-11 03:13:19 +00:00
TreeHugger Robot
4f95f02d2c Merge "PIP: pass grant focus token to focus requests" 2022-02-11 01:02:30 +00:00
Tom Natan
02d4f22709 Merge "[12/n] Letterbox Education: relayout but don't update surface position when bounds change." 2022-02-10 23:16:55 +00:00
tomnatan
3bb6ce2bc7 [12/n] Letterbox Education: relayout but don't update surface position when bounds change.
The position of the letterbox education is fixed to the top left corner (0,0) of the task (parent surface) so there is no need to set the position of the surface because this is the default position of a surface (relative to its parent).

We do however need to update the dimensions of the layout (relayout) when the task bounds change because they are dependant on them.

Finally, there is no need to relayout when View#onLayout is called because neither the surface position nor the layout's dimensions depend on changes in the layout itself.

Bug: 215314668
Test: N/A
Change-Id: I17850b4106b13809e51cf2b9b83c6d67151a9df5
2022-02-10 23:15:20 +00:00
Vishnu Nair
70190ee138 PIP: pass grant focus token to focus requests
Update remaining uses of grantEmbeddedWindowFocus
to pass in a grantFocusToken instead of the input token.

Test: steps in b/218436735
Fixes: 218436735
Change-Id: Idadbd584c06f75ea64dd18a6a002d14426de8998
2022-02-10 20:25:50 +00:00
Evan Rosky
0ef7951dee Merge "Hook up fixed-rotation logic to shell transitions" 2022-02-10 19:51:45 +00:00
Winson Chung
ab4e152e05 Merge "Allow dragging to launch multiple instances of the same activity" 2022-02-10 18:59:35 +00:00
TreeHugger Robot
af9e9264f9 Merge "Fix PIP keyboard test" 2022-02-10 16:37:46 +00:00
Shan Huang
a1c62623bf Merge "Create BackEvent interface for back navigation parameters." 2022-02-10 14:59:06 +00:00
Pablo Gamito
2c37d7a5e0 Merge "Remove fass assertions from tests" 2022-02-10 14:46:06 +00:00
Nataniel Borges
3bbed27849 Fix PIP keyboard test
Test was missing teardown block

Bug: 218604389
Test: atest WMShellFlickerTest
Change-Id: I2331a16f76b95d31b524c2b714b815a174fbcf04
2022-02-10 13:12:59 +01:00
TreeHugger Robot
d25198a25e Merge "Disable flaky tests" 2022-02-10 09:16:48 +00:00
Nataniel Borges
d86a80274a Merge "Run flicker tests 3x" 2022-02-10 07:32:47 +00:00
Shan Huang
a39fa74923 Create BackEvent interface for back navigation parameters.
Bug: b/210539672, b/195946584
Test: m -j
Change-Id: I0264d0995aed8a73563bece0d15d2a9aac0ebf06
2022-02-10 07:01:01 +00:00
Tony Huang
7d2761e465 Fix divider animation and wrong split bounds
Use a flag to prevent we should divider during luancher is
animtating the divider and set surface bounds on this transition.

Fix: 215667718
Fix: 215667829
Test: manual
Test: pass existing tests
Change-Id: I4bee717d8be314dd59ec303e73b1dd66be98c0c3
2022-02-10 06:29:46 +00:00
Evan Rosky
91a630b912 Hook up fixed-rotation logic to shell transitions
This works by separating an app launching to 2 phases
(similar to legacy fixed rotation). First it launches
the app into a different rotation. Once the animation
finishes it creates a new seamless display-rotation
transition.

Because we have displayRotation in windowconfiguration,
we can directly rotate a window's surface instead of
checking explicitly for fixedRotationState. Since the
second-phase is a transition, we don't (ab)use
seamlessRotator. Once the display lines-up, the
surfaces and configurations automatically update.

Since we still want to explore shell-transitions style
rotation (single-transition), add a system property
to turn it off and on.

Bug: 217560545
Test: existing tests and manual tests
Change-Id: I0b34b32ff5b2650a519d3c195df452de446cf515
2022-02-09 17:12:31 -08:00
Nataniel Borges
77dff60b1b Disable flaky tests
Create specific class for shell transition when whole CUJ crashes

Bug: 209843622
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I8d3d96af7303e6bd7bc4a540aa79b0f9ea3bf4a0
2022-02-09 19:02:17 +01:00
Tom Natan
d414b99dcc Merge "[7/n] Letterbox Education: add enter/exit animation to the dialog." 2022-02-09 10:37:03 +00:00
Nataniel Borges
c95bc4d69a Run flicker tests 3x
We run the flicker tests multiple times to detect CLs that intoruce flakiness early. Currently we run 5 executions of each CUJ. However, due to lab capacity and impact in presubmit times, this CL reduces the repetitions to 3

Bug: 209843622
Test: atest FlickerTests WMShellFlickerTests
Change-Id: I165937fb82953d62c028ffe96a948d0ca00dbbe2
2022-02-09 11:11:54 +01:00
Winson Chung
f4ed441e18 Allow dragging to launch multiple instances of the same activity
- When dragging to launch a new app, apply MULTIPLE_TASK to the launch
  intent to allow apps that support it to show side-by-side
- This requires the pending intent resolved from LauncherAppsService to
  be mutable (should be ok since we only use this api from SysUI)
- Also remove some unused members and duplication of getting the running
  task when dragging

Bug: 207686016
Test: atest WMShellUnitTests

Change-Id: Ib233ad754a6c6e3c4e0d0e10ed788ab8e055cccc
2022-02-09 07:21:44 +00:00
TreeHugger Robot
14da91737a Merge "Add default theme for flicker test app" 2022-02-09 06:36:41 +00:00
Ats Jenk
5f32b96cee Merge "Hide suppressed bubble" 2022-02-09 04:47:37 +00:00
tomnatan
4a463aaab8 [7/n] Letterbox Education: add enter/exit animation to the dialog.
Bug: 207010227
Test: N/A
Change-Id: Ie5f88b97c16a7bd043c6c63a8693415563b56a54
2022-02-09 00:23:19 +00:00
Tom Natan
2f6356d870 Merge "[6/n] Letterbox Education: add window manager and connect to controller." 2022-02-09 00:20:37 +00:00
Winson Chung
0c0afb3da9 Merge "Add source owners to test owners" 2022-02-08 22:28:58 +00:00
tomnatan
2d6097698d [6/n] Letterbox Education: add window manager and connect to controller.
Bug: 207010227
Test: atest WMShellUnitTests:CompatUIWindowManagerTest
Test: atest WMShellUnitTests:CompatUIControllerTest
Change-Id: I1f85245180ffa9b3abe409a0f18bf923bea3a442
2022-02-08 20:36:38 +00:00
Tom Natan
32d5e048f2 Merge "[5/n] Letterbox Education: update the dialog layout." 2022-02-08 20:32:39 +00:00
Pablo Gamito
b85d6f1ad4 Remove fass assertions from tests
Assertions are very flaky, don't provide any immediately useful information in the current state and going to be replace soon anyways

Test: atest FlickerTests
Change-Id: Id8f7649b818237bc16051d808ef46ca875669faa
2022-02-08 17:10:10 +01:00
Riddle Hsu
5a68f5cd91 Add default theme for flicker test app
Otherwise its WidowManager.LayoutParams#windowAnimations is 0, then
it won't play animation (TransitionAnimation#loadAnimationAttr
returns null) so the the surface of closing app may be updated to
invisible at random timing that causes the test flaky.

Use darker gray as window background color to make it easier to
distinguish the visual result between home, starting window (gray)
and app content (orange).

Bug: 216297992
Bug: 213852103
Test: com.android.server.wm.flicker.launch.OpenAppColdTest
Change-Id: I3bb073dfa52484a63168b3aeb6e7f5f43bd02aac
2022-02-08 14:58:55 +00:00
tomnatan
bf5b7b2dd3 [5/n] Letterbox Education: update the dialog layout.
In addition, remove the overlay layout and include it in the dialog
layout as the background of the top-level layout (renamed as dimmer).

Test: N/A
Bug: 207010227
Change-Id: I658e85378ec266c4260b520b5fcdddbfb66b35c6
2022-02-08 10:36:28 +00:00
Winson Chung
c8ae608fec Add source owners to test owners
Bug: 207582920
Test: N/a
Change-Id: Ie0c8562ad45cfd64445c40dde4e426585c75bdc0
2022-02-08 06:23:29 +00:00
TreeHugger Robot
b9d43091d6 Merge "Import translations. DO NOT MERGE ANYWHERE" 2022-02-07 20:25:55 +00:00
Winson Chung
3e6933f15a Merge "Add some protologs for recents" 2022-02-07 19:48:45 +00:00
Bill Yi
05e8640ad2 Import translations. DO NOT MERGE ANYWHERE
Auto-generated-cl: translation import
Change-Id: I663deb83b5032416072a3d922475c5c87e387bdf
2022-02-05 18:43:42 +00:00
Tom Natan
634fa51080 Merge "[4/n] Letterbox Education: Create a superclass for compat UI window managers." 2022-02-05 12:58:11 +00:00
Shan Huang
6aa1f22cae Merge "Expose IBackAnimation from Shell to Launcher." 2022-02-05 00:58:32 +00:00
Shan Huang
445c5f24a2 Expose IBackAnimation from Shell to Launcher.
Test: m -j
Bug: b/195946584
Change-Id: I26f48e78c91ef99757da9bc09d4a4f98dc50f863
2022-02-04 18:50:38 +00:00
tomnatan
6c7e886348 [4/n] Letterbox Education: Create a superclass for compat UI window managers.
This super class will hold common logic and be used for the letterbox
education window manager in a follow up cl.

Bug: 207010227
Test: atest WMShellUnitTests:CompatUILayoutTest
Test: atest WMShellUnitTests:CompatUIWindowManagerTest
Test: atest WMShellUnitTests:CompatUIControllerTest
Change-Id: If6a1a5d1325e1fd4245b138e255000fa71273472
2022-02-04 17:45:53 +00:00
Nataniel Borges
08136e8150 Merge "Run pip transition 5x" 2022-02-04 10:04:42 +00:00
Robin Lee
0e03d61fb6 Merge "Rescue Tv SystemUI from broadcast receiver changes" 2022-02-04 07:52:59 +00:00
Ats Jenk
bb4306e62a Hide suppressed bubble
When a bubble is suppressed it should be removed from the stack and
expanded view.
Previously we were updating the visibility of the suppressed bubble.
This kept it in the expanded view.
Updating the suppression logic to remove the suppressed bubble view
temporarily, while it is suppressed.
When it should be visible again, adding it back.

Bug: 214090876
Test: atest BubbleDataTest BubblesTest
Test: manual, created a single bubble, checked it is hidden when
associated activity is opened and shown again after activity closes
Test: manual, created multiple bubbles, checked bubble is hidden when
associated activity is opened and shown again after activity closes
Test: manual, checked that suppressed bubble is not shown in expanded
view

Change-Id: I591a4330ccbb4d9764100715140d8bd20d0351bf
2022-02-03 17:36:14 -08:00
Winson Chung
07113ffcfa Add some protologs for recents
Bug: 207142749
Test: adb shell wm logging enable-text WM_SHELL_RECENT_TASKS
Change-Id: I0897db2ce66f42ac21cf55bea6173392c8931d9f
2022-02-04 00:48:23 +00:00
Mady Mellor
24c3cf7519 Merge "Fix issue with bubble stack & bubble data expanded bit being out of sync" 2022-02-03 18:55:09 +00:00
Vadim Caen
8e59ca9a3a Merge "Save the OnBackInvokedCallback in WindowState" 2022-02-03 17:26:12 +00:00
Nataniel Borges
dd9373015a Run pip transition 5x
The test was previously running the transition 20 times incorrectly. This frequently led to OOM errors, since the system would store 80 instances of protos + flicker objects in memory while making assertions.

Intead run the default 5x

Bug: 216303412
Test: atest ExitPipWithSwipeDownTest
Change-Id: I20fe19239a857cfbc0818910814041323735692a
2022-02-03 15:35:20 +01:00
Nataniel Borges
cbe01b513c Merge "Fetch traces async" 2022-02-03 13:07:15 +00:00
Tom Natan
16e0b72647 Merge "Letterbox Education: Cleanup the toast layout." 2022-02-03 10:15:17 +00:00
Robin Lee
d4584a0d38 Rescue Tv SystemUI from broadcast receiver changes
Bug: 161145287
Bug: 217670016
Change-Id: I9e982cc09777ed0e3bc4bc1300cb7c4791bac10c
2022-02-03 10:13:04 +00:00
Tracy Zhou
275a1a4b80 Support launching intent and task in split screen
Bug: 216829535
Test: see the other cl in the same topic
Change-Id: Id0f58a788585e2dabeae476b8a2bd80ba85bb9fe
2022-02-02 16:19:16 -08:00
Vadim Caen
717e53a6a7 Save the OnBackInvokedCallback in WindowState
This CL enable OnBackInvokedCallback to be saved in a WindowState and
queried by the BackNavigationController to be returned when
ATM.startBackNavigation() is called.

The DecorView provides a PendingOnBackInvokedDispatcher that can receive
callback registration before being added to a ViewRootImpl.

Test: atest FrameworksCoreTests:BackNavigationTest
Bug: 131727607
Change-Id: I01528a22ea4a6583a56ade4eab69136d727855d0
2022-02-02 22:08:02 +01:00