Commit Graph

17476 Commits

Author SHA1 Message Date
TreeHugger Robot
75a81749f3 Merge "Move mobile signal indicator to QS footer." into pi-dev 2018-03-09 14:56:59 +00:00
Julia Reynolds
0b4626aa23 Merge changes from topic "jr-viseffects" into pi-dev
* changes:
  Make systemui obey new visual effect flags
  Expand the visual effects that DND can suppress.
2018-03-09 13:38:06 +00:00
Adrian Roos
802bf39664 Merge "SysUI: Fix a bunch of hacks around insets and cutouts" into pi-dev 2018-03-09 12:40:37 +00:00
Amin Shaikh
0e00331e8f Move mobile signal indicator to QS footer.
- Change mobile data tile to a static icon with mobile data indicators
- Add the status bar mobile network signal icon to QS footer
- Show SIM status in the carrier text in the QS footer only if the
status is not simply "No SIM card" since that status is shown in the
secondary text of the mobile data tile

Bug: 72540392
Test: visual && runtest systemui
Change-Id: I6fee19887decf68db5084edc8c0e2d23bb1938d1
2018-03-08 22:56:55 -05:00
TreeHugger Robot
24d888aab6 Merge "Add secondary text to mobile data tile." into pi-dev 2018-03-08 21:51:40 +00:00
TreeHugger Robot
92078d34fb Merge "[QS] Disable hotspot when data saver is enabled" into pi-dev 2018-03-08 21:43:11 +00:00
TreeHugger Robot
a24322afc6 Merge "[QS] Update Cellular/data usage tile" into pi-dev 2018-03-08 21:36:59 +00:00
Lucas Dupin
59a1bef8e9 Merge changes Ib8f43601,I61d82dca into pi-dev
* changes:
  Show battery percentage on indication field
  Revert "Show battery percentage on indication field"
2018-03-08 21:31:28 +00:00
TreeHugger Robot
b450537f8f Merge "[QS] Tweak tooltip color & shown count" into pi-dev 2018-03-08 20:14:35 +00:00
Amin Shaikh
43ad7fef06 Add secondary text to mobile data tile.
- Update data content description for the mobile data tile to include no
internet connectivity
- Update strings for telephony icons to show that they are no longer
only used for accessibility purposes

Bug: 74192657
Test: runtest systemui
Change-Id: I95f36e871dedfc9caea53326e8ee198f141fb8a8
2018-03-08 14:49:28 -05:00
Adrian Roos
edfab3b832 SysUI: Fix a bunch of hacks around insets and cutouts
PhoneStatusBarView: update correctly on rotation
VolumeUI: properly place window instead of accounting for bars and letterbox
PhoneWindowManager: remove special policy for TYPE_VOLUME_OVERLAY
GlobalActions: Adjust for removal of special policy for volume overlays

Bug: 74195186
Test: Use VolumeUI, GlobalActions, Keyguard and Status bar in all kinds of orientations and cutout configurations
Change-Id: I72281cee202fea0a69766ff0d58ea55dcb5a36e1
2018-03-08 20:37:43 +01:00
TreeHugger Robot
ce18c717c8 Merge "Cutout: Fix status bar layout" into pi-dev 2018-03-08 19:25:07 +00:00
Lucas Dupin
8d595d200f Show battery percentage on indication field
Supports two battery formats until all locales are updated

Test: visual
Test: switch language, observe.
Change-Id: Ib8f43601a85f24b8e315d7c67c8693060fc6d32b
Bug: 74386188
2018-03-08 10:36:25 -08:00
Lucas Dupin
58d1d65961 Revert "Show battery percentage on indication field"
This reverts commit 15ab369336.

Reason for revert: IllegalFormatConversionException

Fixes: 74386188
Change-Id: I61d82dca45a4b0b973c9ea572c63cbbb8125758d
2018-03-08 10:32:40 -08:00
TreeHugger Robot
62cfe60bce Merge "Remove upper left X icon on mobile signal." into pi-dev 2018-03-08 18:17:59 +00:00
Rohan Shah
53f3f15654 [QS] Update Cellular/data usage tile
Updated intent and API. We were using an explicit intent and there's
changes going on in the Settings team that change the activity name and
enabled states. Updating to an implicit event as with other parts of the
Settings app (e.g. Bluetooth).

Test: Visually
Bug: 73586207
Change-Id: Ifa5125b4770927521d9267569d487319efdb9f9f
2018-03-08 18:12:33 +00:00
Rohan Shah
b6a915c840 [QS] Tweak tooltip color & shown count
Limiting count to 2 (down from 3). Also updated the text color so it no
longer looks clickable.

Test: visually
Bug: 74075675
Change-Id: I86fbb5ae7481f6d19b7e6722832ac600595ad7ea
(cherry picked from commit a853aa7fe5)
2018-03-08 18:07:04 +00:00
Rohan Shah
815fa9821a [QS] Disable hotspot when data saver is enabled
Added new callback for data saver and used the data saver enabled state
to determine whether the tile was available (similar to how airplane
mode works).

Test: Visually (via toggling both data saver/hotspot tiles)
Bug: 33003328
Change-Id: I0b0e5e382ab2a9ee13d4412ed059c523795b68c7
(cherry picked from commit a23980f1d8)
2018-03-08 18:00:45 +00:00
Julia Reynolds
24653c3bba Make systemui obey new visual effect flags
Test: runtest systemui
Bug: 74075050
Change-Id: I46a3e762ecdab132edcb81880ef3e4f7f2e55aac
2018-03-08 11:55:33 -05:00
Amin Shaikh
af4c19394e Remove upper left X icon on mobile signal.
Use the signal drawable cutout to represent both data disabled and no
internet state. ag/3690757 displays the description of these icons ("No
internet" or "Mobile data off") in the secondary text of the mobile data
tile.

Bug: 72540392
Test: visual && runtest systemui
Change-Id: I806c41bc96420c42461c0a75b93a485f9a2186f7
2018-03-08 10:59:46 -05:00
TreeHugger Robot
4a28bbaf8f Merge "Global actions visuals - color and ordering changes." into pi-dev 2018-03-08 15:01:46 +00:00
Adrian Roos
7b54b078eb Cutout: Fix status bar layout
Fixes an issue where the status bar would not lay out under
the cutout if it was the IME target.

Change-Id: Ib5d1bbbf6311a0bcd1694a5dc69076f24b88b5e8
Fixes: 74369579
Test: Receive notification with Direct Reply, open direct reply, verify status bar stays under cutout.
2018-03-08 12:53:49 +01:00
TreeHugger Robot
7b894b3fcd Merge "Show app ops guts when tap app ops icons" into pi-dev 2018-03-08 04:00:37 +00:00
TreeHugger Robot
8b4b86981c Merge "Tapping overview button when quickstep enabled shows overview" into pi-dev 2018-03-08 03:51:17 +00:00
Matthew Ng
8a8c89ce40 Tapping overview button when quickstep enabled shows overview
This is the systemui side of showing launcher's overview when it decides
to allow users to trigger overview with the overview button in the
navigation bar when quickstep is enabled.

Test: manual - tap overview button in nav bar
Bug: 67957962
Change-Id: I0d59d60d4b4ce1df9dcf2a745f9a5efd415b8582
2018-03-07 17:49:17 -08:00
Julia Reynolds
b586745d86 Show app ops guts when tap app ops icons
Test: runtest systemui
Bug: 64085448
Change-Id: Ia51044f77311ab705ffb9dd1ae204d0131316396
2018-03-08 01:45:09 +00:00
Alison Cichowlas
3be52dbfa6 Global actions visuals - color and ordering changes.
Test: Manual, with light & dark themes
Bug: 72404596

Change-Id: I739035d8a2824af801e2a5a1bbb8541594d43267
2018-03-07 17:49:19 -05:00
Mike Digman
a42585c349 Merge "Apply prior tint to rotate icon on recreation" into pi-dev 2018-03-07 22:47:40 +00:00
Mike Digman
c821758150 Apply prior tint to rotate icon on recreation
In very rare circumstances, it's possible for the rotate icon
to be recreated but not have the dark intensity set. Fix this
by applying prior icon's intensity.

Test: manual but heisenbug so very hard to validate
Fixes: 74354524
Change-Id: I042de35e725794b04f5250fa3a2fc5a54d65d143
2018-03-07 22:47:22 +00:00
TreeHugger Robot
ed0b75df20 Merge "Fix separator color for light wallpapers" into pi-dev 2018-03-07 21:37:30 +00:00
Lucas Dupin
b21fb8020f Fix separator color for light wallpapers
Test: visual
Change-Id: I61b2161db16db264c7425431dca50f5a54fce425
Fixes: 74345301
2018-03-07 11:37:25 -08:00
Lucas Dupin
20ebb0a6d8 Merge "Disable color extraction for media" into pi-dev 2018-03-07 17:36:26 +00:00
TreeHugger Robot
5a169cf2f6 Merge "System sounds get its own dnd toggle" into pi-dev 2018-03-07 16:39:40 +00:00
TreeHugger Robot
bb9bd1215a Merge "Fix extra padding when there are no static notification dots" into pi-dev 2018-03-07 15:41:18 +00:00
Lucas Dupin
3ec5928cc2 Disable color extraction for media
Overlaying an album with wallpaper colors isn't optimal.
Using the album extracted color also isn't optimal, the color probably
won't meet accessibility guidelines and will have to be stretched
according to the current lock screen theme - which can be even worse.

Test: atest packages/SystemUI/tests/src/com/android/systemui/colorextraction/SysuiColorExtractorTests.java
Change-Id: I53d08713716bd76ee0975c2b4bba5b933201f999
2018-03-06 20:27:50 -08:00
Alison Cichowlas
f280653c43 Screenshots: delete, default for edit intent.
Revive delete action in screenshot notification; add config option
to specify default component to handle edit.

Test: Manual with Markup app & empty option.
Change-Id: If0fd90bf8eeb5667c51f3d959d3f77b28c5a33ce
2018-03-06 19:19:56 -05:00
TreeHugger Robot
b88b9640cb Merge "Hide overlay notification" into pi-dev 2018-03-06 23:33:28 +00:00
Mike Digman
4ef95e2531 Merge "Reset user rotate pref on navbar create" into pi-dev 2018-03-06 23:04:54 +00:00
Julia Reynolds
af78a797bf Hide overlay notification
If app's own foreground service notification is tagged.

Test: atest SystemUITests
Bug: 64085448
Change-Id: If10b8dda529c72ee063c9c18c932ceb6d4f92bb4
2018-03-06 20:26:28 +00:00
TreeHugger Robot
0719d0790c Merge "Fix notification padding and slice collision" into pi-dev 2018-03-06 20:13:48 +00:00
Mike Digman
ab65025833 Reset user rotate pref on navbar create
System appears in portrait after restart, however rotation
watcher callbacks don't fire leaving user rotate pref stale
from last boot. Reset in onCreate and replace override logic
with policy's natural rotation.

Test: manual
Change-Id: Ia1f1e5f637708e5c678edbb5cbf9f4125e451103
2018-03-06 11:40:03 -08:00
TreeHugger Robot
b6238ed540 Merge "Do not allow ScrimView backgrounds" into pi-dev 2018-03-06 19:28:30 +00:00
Lucas Dupin
2c5fce62f1 Fix notification padding and slice collision
Slices should completely replace notifications,
they should never be visible at the same time.

Test: send notification, look at AOD
Change-Id: I14f04db1e4541a24f7b9117659e4c9481262aeff
Fixes: 73908553
2018-03-06 10:18:19 -08:00
Evan Laird
43c09a9e92 Fix extra padding when there are no static notification dots
The logic now mimics the visual overflow logic such that when the
non-static notification icon container gets a virtual end-of-layout, but
that layout has no dots, then it adds the correct amount of padding to
handle the max number of BTW notifications

Test: add 3 min priority notifications when there is one regular
notification. Pulling the shade shouldn't collapse the regular
notification icon

Bug: 73487572
Change-Id: I77cc3821f7c93a5ba88d1419fb5594ccd9e1616d
2018-03-06 09:52:26 -05:00
Beverly
d696476fb3 System sounds get its own dnd toggle
- Added logic for streams to be muted by dnd (unassociated with ringer)

Test: runtest -x frameworks/base/services/tests/uiservicestests/src/com/android/server/notification/ZenModeHelperTest.java
Bug: 73362490
Change-Id: I1101e67282f7331497e91eb510d2bf4f1ea6b4b1
2018-03-06 09:08:29 -05:00
TreeHugger Robot
a2546208a6 Merge "Shows the correct home icon when quickstep is enabled on startup" into pi-dev 2018-03-06 04:14:27 +00:00
Lucas Dupin
cfcf1aede6 Do not allow ScrimView backgrounds
An external agent is setting the background of the ScrimView.
This causes washed out lock screen and AOD flickering.

It's not clear what's doing this so I'm adding a Log.wtf and keeping the
backbround from being set.

PS: also formatted the xml and removed an unused method

Change-Id: I65dce9ce2b097b572c78605e0524b3854f46457f
Fixes: 71527665
Fixes: 68877998
Test: manually add a ripple to packages/SystemUI/res/layout/super_status_bar.xml
(cherry picked from commit c2aa8d2a2d)
2018-03-06 02:23:44 +00:00
Matthew Ng
d0a73e7aa4 Shows the correct home icon when quickstep is enabled on startup
The wrong home icon was shown on startup because it takes sometime for
the disabled flags to set disable recents flag that determines if
overview is enabled. When it changes to be true update nav bar icons.

Test: boot phone and look at nav bar
Change-Id: Ib1c00cfa1c3eb0444ccc985dfaf1b3c74e790692
Fixes: 74071465
2018-03-06 01:14:44 +00:00
Tony Wickham
2f0d015211 Adjust recents onboarding logic
- After dismissing, don't show again until 5 app launches
- Don't count the same task id towards that 5 (or the 2 before
  showing the first time)

Test: manual, launch a couple apps and verify onboarding shows;
continues showing until I dismiss it; shows again after launching
5 apps (different activities in the same app don't count)

Bug: 73392035
Bug: 70180942
Change-Id: Icff567e3418097c3503d2f322cf829a9efc195e7
2018-03-05 22:43:32 +00:00
Mike Digman
5aeca79673 Increase rotate suggestion timeout in fullscreen
To use the rotate nav button in fullscreen the navbar must
become visible. This normally requires a user gesture which
makes it hard to hit the button given its normal timeout
duration. Make it easier to tap by effectively extending the
timeout if the suggestion is given when the navbar is
invisible.

Test: manual with fullscreen testing app
Change-Id: I54ac3dfb590df9b9a039c53984623497ca18fcb5
2018-03-05 19:37:01 +00:00