Commit Graph

9406 Commits

Author SHA1 Message Date
Jon Eckenrode
634c1751a1 Merge "Removed outdated link." am: f74a4b312b
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2280480

Change-Id: I2a34b19dd8f6cb7da46de69f36391a84028b8abf
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-11-02 23:31:54 +00:00
Jon Eckenrode
4b376be8df Removed outdated link.
Change-Id: I01db8876d591efad358957269e4e358282943e40
2022-11-02 20:36:35 +00:00
Xin Li
4b1dc6dbf6 Merge TP1A.221005.003
Merged-In: I6ffbb7510e6854f18bc427d1ae1e782918c799dc
Change-Id: I32d05cdabc6579f00bb4af0657b38539ec81a588
2022-10-03 13:38:22 -07:00
Treehugger Robot
0605a3c8b6 Merge "Reorganize text related owners" am: 5e89e54398 am: 95ea173c85 am: 38eb872609 am: a35e8a8e8d
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2226540

Change-Id: I3ecf084064583b0920becb5bd994fe43a14a7b1f
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 18:53:36 +00:00
Treehugger Robot
38eb872609 Merge "Reorganize text related owners" am: 5e89e54398 am: 95ea173c85
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2226540

Change-Id: Ib9cc543d2d3cf6f2bedd5e05f1e86e06a60d1cf0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-29 17:56:49 +00:00
Seigo Nonaka
5916f347b3 Reorganize text related owners
Update list of owners of the text team.

Bug: N/A
Test: N/A
Change-Id: Iae227284d69b1251f26f549850909f44c7639c8f
2022-09-22 16:12:23 +09:00
Steven Terrell
b2eba6b95d Merge changes from topic "cursor-bg-blink-cp" into tm-qpr-dev am: 131fb1ff89
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19955684

Change-Id: I896302084978f6f22cc52167f981d62feaedc31a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 03:15:41 +00:00
Steven Terrell
e23d904d4a Stop cursor from blinking when not visible am: 4ec6dfc389
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19758504

Change-Id: Id4fd25b59737a3095366280de62ab484bda75193
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-09-16 03:15:20 +00:00
Steven Terrell
131fb1ff89 Merge changes from topic "cursor-bg-blink-cp" into tm-qpr-dev
* changes:
  Add Ability to Check if Cursor is Blinking
  Stop cursor from blinking when not visible
2022-09-16 02:46:30 +00:00
Steven Terrell
d2acc476d0 Add Ability to Check if Cursor is Blinking
adds a method for returning whether the cursor is blinking based on the
current value of the mCancelled property in the Blink class.  This
method is only inteded to be used for testing purposes.

Bug: 228354442
Test: manual, method is called in CtsWidgetTestCases:EditTextTest#
      testSuspendAndResumeBlinkingCursor,
      testCursorBlinkingOnNewActivity_WithFocus,
      testCursorNotBlinkingOnNewActivity_WithoutFocus
Change-Id: I02849f6e105cbfe7af78dfb34ffbf1ebbb4a82ae
2022-09-15 22:42:43 +00:00
Alan Viverette
411af7b504 Merge "Fixed the reference to the compat version of the widget. Revised the class description." into tm-dev am: 96d92cfeda am: 86fec4c5ad am: 1e6efa818e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19748654

Change-Id: I1722a5c7993ac4d6a09d2b1736df83a66f2cc8ad
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 15:46:03 +00:00
Alan Viverette
1e6efa818e Merge "Fixed the reference to the compat version of the widget. Revised the class description." into tm-dev am: 96d92cfeda am: 86fec4c5ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19748654

Change-Id: I295cfcd5d4070eefef89c9dc16b38e7aaec13199
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 15:21:09 +00:00
Alan Viverette
cd62cff626 Merge "Fixed the reference to the compat version of the widget. Revised the class description." into tm-dev am: 96d92cfeda
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19748654

Change-Id: I5712f596bc91f84269943566e7ef7440a18743cb
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-29 14:52:15 +00:00
Steven Terrell
4ec6dfc389 Stop cursor from blinking when not visible
Cursor continues to blink in a text field even when the text field is
not currently visible. This change checks the visibility of the window
that houses the text field in addition to checking if the view is in
focus.

Bug: 228354442

Test: Added logging to the shouldBlink() method ran following steps:
     1: open contacts app
     2: tap add new contact, tap in an edit field
     3: move back to home screen
     4: lock screen, then unlock screen
     5: observed logs written out to logcat console when app not
        visible.
     after change logs no longer printed to console, cursor still blinks
     correctly after app is re-opened or when new field becomes in
     focus.
Test: CtsWidgetTestCases:EditTextTest#
        testCursorNotBlinkingOnNewActivity_WithoutFocus()
	testCursorBlinkingOnNewActivity_WithFocus()
	testSuspendAndResumeBlinkingCursor()
Change-Id: Iad4396e5f7fd810344c711320d65c57ea25eda70
Merged-In: Iad4396e5f7fd810344c711320d65c57ea25eda70
2022-08-26 20:31:56 +00:00
joneckenrode
6dbcd1f835 Fixed the reference to the compat version of the widget. Revised the class description.
Cherry-picked from CL 19211934 merged on master. See https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/19211934.

Test: Built API documentation
Change-Id: If74178eba609346eb7cf9e462bdb3edf40db4d81
2022-08-25 23:18:47 +00:00
Jon Eckenrode
02516202f1 Merge "docs: Edited API documentation related to line-break and line-break word styles." into tm-dev am: 1914a2f78e am: 0e9d7be16e am: 638d45938c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19669167

Change-Id: I309ce5c008792c52c581dcc19b77e63b05f55aef
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 19:42:07 +00:00
Jon Eckenrode
638d45938c Merge "docs: Edited API documentation related to line-break and line-break word styles." into tm-dev am: 1914a2f78e am: 0e9d7be16e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19669167

Change-Id: I8c7e51969b81ec6f66c6009567d9805debe48ecc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 19:24:31 +00:00
Jon Eckenrode
f63ffedb7c Merge "docs: Edited API documentation related to line-break and line-break word styles." into tm-dev am: 1914a2f78e
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19669167

Change-Id: I2ecf65274a264fc6f84dc5e5cb5ad3b8d7da5c23
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-25 19:02:56 +00:00
Alex Stetson
4ce48b4d83 Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev am: 2cd24931e3
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19295691

Change-Id: Ie1a410591ed21da53d32cb59a9c6c8427922f728
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-24 19:40:20 +00:00
Alex Stetson
2cd24931e3 Merge "Fixed divider rendering in RTL languages" into tm-qpr-dev 2022-08-24 19:32:59 +00:00
joneckenrode
bf5d4d5190 docs: Edited API documentation related to line-break and line-break word styles.
Files patched from CL 19608033, https://googleplex-android-review.git.corp.google.com/c/platform/frameworks/base/+/19608033.
Could not cherry-pick CL because LineBreakConfig.java on master contains Android U code.

Staged to:

https://android.devsite.corp.google.com/reference/android/widget/TextView

https://android.devsite.corp.google.com/reference/android/R.attr

https://android.devsite.corp.google.com/reference/kotlin/android/R.attr

Test: Built API docs
Change-Id: Ie322096ee2cc0ab3e24bb7d2ff8c398e8861726f
2022-08-23 20:55:59 +00:00
Tim Murray
22ab60b4ed RemoteViews: fix BitmapCache after immutable Bitmap switch
Test: widgets appear correctly
Bug: 237256275

Change-Id: I864ac1ba8ac771c326dc215ae4e712ceb0b6057b
(cherry picked from commit 4f359bd765)
Merged-In: I864ac1ba8ac771c326dc215ae4e712ceb0b6057b
2022-08-19 18:43:40 +00:00
Tim Murray
308b8f45aa Merge "RemoteViews: fix BitmapCache after immutable Bitmap switch" into tm-dev am: 5c7bab4ccb
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19570391

Change-Id: Ie7db45fb0802507496ac84fd1eb0c426b52a1c0a
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-17 23:35:00 +00:00
Treehugger Robot
bef30a8056 Merge "Update OWNERS for RemoteViews related files." am: 00545d0fd6 am: ea4b4e5a83 am: 4e5571fd30 am: 82812dd066
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2180621

Change-Id: I0ade83d702a47dd3ec12d08a01d5104e80085070
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-11 18:24:35 +00:00
Treehugger Robot
ea4b4e5a83 Merge "Update OWNERS for RemoteViews related files." am: 00545d0fd6
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2180621

Change-Id: I4beccbf68d0b3b841b2e629be2a5f2662fe90f42
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-11 17:07:04 +00:00
Mihir Patel
f333fa0c93 Merge "Reporting the Autofill IDs and Positions of active views in list view" into tm-qpr-dev am: 25192d7d0c
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19054708

Change-Id: I6b8ffade431d057334147ae9cd5386afbad13cbc
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 17:41:15 +00:00
Mihir Patel
25192d7d0c Merge "Reporting the Autofill IDs and Positions of active views in list view" into tm-qpr-dev 2022-08-10 16:35:13 +00:00
TreeHugger Robot
9c1576da1c Merge "RemoteViews: fix BitmapCache after immutable Bitmap switch" into tm-qpr-dev am: fe195e6f74
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19450080

Change-Id: I7ea562c9433a85dcad6cb3241954140dcb8905b2
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-10 04:34:20 +00:00
Tim Murray
4f359bd765 RemoteViews: fix BitmapCache after immutable Bitmap switch
Test: widgets appear correctly
Bug: 237256275

Change-Id: I864ac1ba8ac771c326dc215ae4e712ceb0b6057b
2022-08-10 04:25:13 +00:00
TreeHugger Robot
fe195e6f74 Merge "RemoteViews: fix BitmapCache after immutable Bitmap switch" into tm-qpr-dev 2022-08-10 04:13:07 +00:00
Pinyao Ting
8767364abf Update OWNERS for RemoteViews related files.
Change-Id: I50719c5d5b19f0d5fd542a94726221b165020860
2022-08-09 23:40:35 +00:00
Mihir Patel
a6e0f74c90 Reporting the Autofill IDs and Positions of active views in list view
Test: atest CtsContentCaptureServiceTestCases, observed events reported only once on scroll and stop as well as on fling
Bug: 211899037
Change-Id: Id67fcc360bf63fcab1d9f345c31d2bf7b9a173d6
2022-08-09 15:37:50 -07:00
Sunny Goyal
b4b25e4f9e Merge "Wrapping various apply parameters into a separate class" into tm-qpr-dev am: b4b3a8bdeb
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19531583

Change-Id: I1c24d06db68910c8a99028eca57b233c7e6c5b0d
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-08-08 16:39:36 +00:00
Sunny Goyal
6224d07127 Wrapping various apply parameters into a separate class
> This would allow us to easily extect the options
> Also passing the executor for async inflation. This will allow
  containing adapters to also be async if the parent View is using
  async inflation

Bug: 202766048
Test: Presubmit
Change-Id: I60a9b5db5f9b5f8d6e56521ee00de4be30decce6
2022-08-05 14:53:00 -07:00
Alex Stetson
0ee3b273a0 Fixed divider rendering in RTL languages
In horizontal layouts, when elements are rendered from LTR, the
definition of "before" and "after" gets flipped, causing the divider
spacing to be allocated to the wrong locations. By flipping the check in
RTL layouts, the dividers can be placed correctly.

Additionally, it is necessary to add divider measurements to all layout
width measurements to allow for dividers in right gravity to layout
properly.

Bug: 208927871
Test: atest android.widget.cts.LinearLayoutTest
Change-Id: If6e917873571484a6fb1dfc28b356289e2cc1ffa
2022-08-03 16:03:29 -07:00
Tim Murray
c930727226 RemoteViews: fix BitmapCache after immutable Bitmap switch
Test: widgets appear correctly
Bug: 237256275

Change-Id: I864ac1ba8ac771c326dc215ae4e712ceb0b6057b
2022-07-27 17:45:14 +00:00
Yi-an Chen
89e8a943d8 Merge "Add PbA branding to clipboard" into tm-qpr-dev am: 2b04393a1d
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19152769

Change-Id: I5e965626328b0d60f67ff43094f38e28304287c0
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-25 16:25:47 +00:00
Yi-an Chen
2b04393a1d Merge "Add PbA branding to clipboard" into tm-qpr-dev 2022-07-25 16:08:26 +00:00
Sean McQuillan
cd4d5991b2 Merge "Don't crash after unsetting char[] in TextView" into tm-qpr-dev am: 469768f559
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/19340644

Change-Id: Id975fe1ef50e8bab6a0ac851eab071b3f246c2ae
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-07-20 16:22:58 +00:00
Yi-an Chen
edfc44079c Add PbA branding to clipboard
Bug: 213357911

Test: Manually on Raven
Change-Id: If9944393fe64c7f94a5be139a538833d91ae98fe
2022-07-19 13:52:13 -07:00
Sean McQuillan
81cde0b584 Don't crash after unsetting char[] in TextView
TextView.setText(char[]) is from API 1 and follows a running with
scissors API style of not copying the passed array.

To avoid a leak, in TextView.setText(String), the char[] would be nulled
out. However, an internal object could have been read using .getText()
prior to this second setText would immmediatly become a
CharSequence that crashed when you called any methods on it.

After this change, the CharWrapper will stay valid if had been
previously retrieved. The general shape of the API will be maintained.

Fixes: b/227218386
Test: atest android.widget.TextViewTest
Relnote: "Calling TextView.getText() after calling TextView.setText(char[])
will now return a valid CharSequence. The char[] pointed to by this char
sequnece may still be mutated by future calls to setText(char[]), but it
will no longer allow a (char[]) null to be set, which lead to crashes
when reading CharSequence returned from getText on TextView."

Merged-In: I35a2a76d58ec1946dace2f615cacf6a6085efdeb

Change-Id: I35a2a76d58ec1946dace2f615cacf6a6085efdeb
(cherry picked from commit 166c7217f4)
2022-07-19 20:38:10 +00:00
TreeHugger Robot
3c7b2c3fe0 Merge "Explain the difference between setBreakStragegy() and setLineBreakStyle() in API doc" into tm-dev am: 2b868683ad am: 4e9b6a3839 am: e0d6f903b9
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18769766

Change-Id: I530759c97e64b8be4254b411b1e9021857db3d64
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 07:50:25 +00:00
TreeHugger Robot
6ff694f3cc Merge "Explain the difference between setBreakStragegy() and setLineBreakStyle() in API doc" into tm-dev am: 2b868683ad
Original change: https://googleplex-android-review.googlesource.com/c/platform/frameworks/base/+/18769766

Change-Id: If473607c0c66734e62805e398be3fee2a1f08558
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-09 06:21:25 +00:00
allenwtsu
289d576548 Explain the difference between setBreakStragegy() and setLineBreakStyle() in API doc
Bug: 217951279
Test: build pass
Change-Id: Ida98327a656edc4878f7ce1c7f2bc99b72cd91d6
2022-06-07 13:06:52 +08:00
Treehugger Robot
9942758628 Merge "Fix owner files in text components in the widget directory" am: 5078370e5f am: a375a95fd4
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2115546

Change-Id: I275376ed1252beb7bb26d27de6d435c5c2760407
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 23:21:20 +00:00
Treehugger Robot
a375a95fd4 Merge "Fix owner files in text components in the widget directory" am: 5078370e5f
Original change: https://android-review.googlesource.com/c/platform/frameworks/base/+/2115546

Change-Id: I10ff5646a9168fa2a4737a680fd539bf8a3b4b60
Signed-off-by: Automerger Merge Worker <android-build-automerger-merge-worker@system.gserviceaccount.com>
2022-06-06 22:53:37 +00:00
Seigo Nonaka
fa29f96603 Fix owner files in text components in the widget directory
Text team owns the text related module in widget.
The previous per-file line was not working due to extra spaces between
files list.
Fixed by removing white spaces and also change to refer the text team
OWNERS file.

Bug: 234759754
Test: N/A

Change-Id: I3302de8fd90a12e7745f15d07c8c53c900bb3a14
2022-06-03 21:16:55 +00:00
Mark Punzalan
6758b3f7e7 Translate selectable TextViews by temporarily disabling selectable.
The text is not selectable while translated. Making translated text
selectable requires many more changes.

This was tested in Nextdoor in the feed/posts activity. When there is a
"Read more" link in the post, the link doesn't work while translated,
and doesn't behave the same way after translation is paused.

Bug: 202966891
Test: atest CtsTranslationTestCases
Test: Manually - with Nextdoor on feed and chat activities
Change-Id: I6e8f532d427d85ff22df0deb248d8416a15f4821
2022-05-25 20:03:10 +00:00
Shan Huang
7caa2c1c6b Migrate AutoCompleteTextView to use OnBackInvokedDispatcher.
With ag/17952046 we now actively intercept KEYCODE_BACK before they are
sent to IME when new back flow is used. This requires us to migrate
AutoCompleteTextView#onKeyPreIme, and is also what causes the test
failure in b/231960630.

Test: atest AutoCompleteTextView test.
Test: Test back behavior of AutoCompleteTextView in BackTestApp.
Bug: 231960630
Change-Id: I1a5e01c9a4f8f0e762b493284650854a230aecd3
2022-05-18 19:08:59 +00:00
Lucas Dupin
06ac74c54f Merge "Don't trigger full relayout if DateTimeView doesn't change" into tm-dev 2022-04-22 15:21:23 +00:00