There was a deadlock when ConnectionHandler exited the loop in SocketPipeThread, and would call the onFinishedCallback, which called the synchronized method in Forwarder that would
deadlock. Changing the Forwarder class solved the issue and made it more efficient.
Change-Id: I947450a19573f2e88274b1ebc7b77d4df6afffa7
The revision number is taken from external/webkit/WEBKIT_MERGE_REVISION and is served to the java code by apache server. To be able to do that, the new alias directive had to be
added to the run_apache2.py script.
Bug: 2889572
Change-Id: Ie3d147e4d8ea9edd0144b819152121563b8bd759
Before, if a crash was detected, but the "Force quit" dialog remained on the screen, sending the intent to restart the executor would do nothing. It's fixed now with default
uncaught exception handler. Also, when we catch the uncaught exception, we can restart the executor straight away, without waiting for the time-out.
Change-Id: I2f0b4b5f2abd180ff518f1a40ad1294bed2f7f67
The call would deadlock because lines 62-67 in ConnectionHandler were in the synchronized block. The is.read() would block and therefore call to shutdown() would block too.
is.read()
would never unblock because the stream was ready to be closed, and it needs to be done so from shutdown(). Removing the synchronized block fixes it and is save, as it was not
needed here.
Change-Id: I3326098c47ee18c4eabaa8510b27ca82debce360
It creates the sockets on the device that allow DumpRenderTree2 to get tests from the server running on the remote machine. Communication happens through the adb.
Change-Id: I7f26ffc78195b6c5f4d423a57d5ee5f0f4a9c615
Renamed LayoutTestsRunner activity to TestsListActivity. It will be responsible for restrating the Executer after the crash. Now it only starts
it.
Renamed LayoutTestsRunnerThread to TestsListPreloaderThread. It only preloads tests now.
LayoutTest class is no longer needed, its functionality is in LayoutTestsExecuter.
Most of the functionality from LayoutTestsRunnerThread is now in ManagerService.
Change-Id: I08924d949ceb9f8816888bc8e795256d0542fa99
There is a new activity (LayoutTestsExecuter) added that is responsible for acutally running the tests and sending the actual results to the new
ManagerService class. This class will take over most of the functionality of the current LayoutTestsRunnerThread. At the moment
LayoutTestsRunnerThread is changed so that after computing the tests' list it sends the list to LayoutTestsExecuter. The rest of the code is
never called. It will be shifted to the service.
Current implementation of ManagerService only prints the log message on receiving the bundle with actual results from LayoutTestsExecuter.
Change-Id: I5adcbc20bb18ebf24324974bc66e4b31c4b81902
These classes are responsible for actually running the tests, checking the results, generating visual diffs, etc.
Change-Id: I9b7f554409db1c97ac086c456db3aea3b993b5c6
It preloads the tests from the given path, runs them and asks for dumps and diffs. It will also prepare summaries in the future. It delegates
most of the work of actually running the individual tests to LayoutTest class and AbstractResult (and its subclasses in the future).
Change-Id: I483bf26a380b539e4769e61b4a09fa270ab0e8e9
- A run/abort dialog on long click on directory
- A delayed progress dialog for directories that take long to load
Change-Id: I2fda245a48cb09faf8228809f7b091a7d2383589
