Add a lock over all frro iterator methods to make sure the
iterator isn't changed or removed from under the iteration
call while it's running.
+ Also introduce an ID ensuring the caller is the same for
all the acquire/next/release methods
+ a bit of moves where they were supposed to be from the start
Bug: 245727875
Test: manual + presubmits
Change-Id: Ie585b6d113ebddee491c9ee433f070bed71a57cc
Without this change there are errors when running with the new version
of clang
Bug: 247585041
Test: verified that frros used for colors still works, automated tests
Change-Id: Iebbef8aaca866c6f34c381792c1e66bd6b2121f0
This also includes the change to use the configs to decide which (if
any) frros to use at runtime
Bug: 243066074
Test: Manual, updated and created automated tests
Change-Id: I3f1d23e2958ad170799880b9f5eb5bd8ceb1fa67
Once the client requests idmap2d to release a directory iterator,
idmap2d should follow the client request to free and release
frro_iter_.
It should not only check the value of frro_iter_ but also make
frro_iter_ to be nullopt in releaseFabricatedOverlayIterator.
Fixes: 244389702
Test: adb reboot; adb wait-for-device; adb logcat -s idmap2d
Change-Id: Ida1e7e7ae89f12407d26e66ab318a91e4f861df4
Split SysTrace.h into SysTrace.cpp to avoid defining ATRACE_TAG
in the clients of SysTrace.h
This is in preparation to land aosp/2190022
Test: m
Bug: 161393989
Change-Id: I0ed94c9f66043aa83a59e8042ec9e61ee47db0f2
This enables passing them and and storing them in the .frro file but no
further.
Bug: 243066074
Test: Manual
Change-Id: I5c9723e69d175a536f9739619c6b6bf3162a5027
This includes all of the work of passing the string all the way down to
the native code but then does nothing with it. Storing and retrieving of
it will be in follow up changes.
Test: Manual
Bug: 232940948
Change-Id: Ie00cc23680a0132588744991bf829afad6ba336f
As of now it's impossible to tell what happened or is happening
to idmap2d - and that's the important thing in the bug. Adding
some logging to help investigating it if it happens again
Bug: 219393586
Test: manual
Change-Id: Ia6615f80d8a4b7ba94714f0af10e09ba9d709bb6
Add missing includes that are not transitively provided when compiling
against musl.
Bug: 190084016
Test: m USE_HOST_MUSL=true
Change-Id: If8829cebb0c62b539d7a336b75cf106755588cdd
Merged-In: If8829cebb0c62b539d7a336b75cf106755588cdd
Add missing includes that are not transitively provided when compiling
against musl.
Bug: 190084016
Test: m USE_HOST_MUSL=true
Change-Id: If8829cebb0c62b539d7a336b75cf106755588cdd
stdout and stderr are macros in musl, which causes build failures
when they are used as field names. Rename the fields to stdout_str
and stderr_str.
Test: builds
Merged-In: I04770d2d6e82ca8393308ab12a304838a80f0ae5
Change-Id: I04770d2d6e82ca8393308ab12a304838a80f0ae5
stdout and stderr are macros in musl, which causes build failures
when they are used as field names. Rename the fields to stdout_str
and stderr_str.
Test: builds
Change-Id: I04770d2d6e82ca8393308ab12a304838a80f0ae5
* If necessary, use --header-filter to select warnings
in owned header files for each module.
Change-Id: I5a2a52a4f78661b60a8375fbcc46bd5bad92ae60
Test: make with WITH_TIDY=1
If for some reason there are a lot of fabricated overlays in the
resources cache, the binder limit of the list of fabricated overlay
infos could exceed the maximum binder transaction size. Rather than
return all of the frro infos in one transactions, register an iterator
with the native idmap2d service and use multiple binder transactions
to iterate through all of the frros.
Bug: 192948522
Test: Toggle device theme colors several times and observe frro cache
Reboot device and observe old frros are deleted
Change-Id: I5e9cf3ae9d1d45eda683c24141a0cd4e4301e02f
Suppress below errors:
include/idmap2/Idmap.h:126:12: error: avoid repeating the return type
from the declaration; use a braced initializer list instead
[modernize-return-braced-init-list,-warnings-as-errors]
return StringPiece(target_path_);
^~~~~~~~~~~~ ~
{ }
gen/aidl/android/os/BnIdmap2.h:6:1: error: nested namespaces can be concatenated
[modernize-concat-nested-namespaces,-warnings-as-errors]
namespace android {
^~~~~~~~~~~~~~~~~~~
namespace android::os
Bug: 193712493
Test: build with the next compiler
Change-Id: I14297355dd92c2bbf4bd24da95cfa868b427739e
