Commit Graph

9 Commits

Author SHA1 Message Date
Tom O'Neill
17c5e79496 Keep LMP from breaking KitKat API
- Bug: 17390371

Change-Id: I25c1abebcc42ed24abd57bbe2834a40fb8ee834b
2014-09-04 15:42:36 -07:00
Tom O'Neill
248ada68cc Injected settings no longer include summaries
- Bug: 13279850

Change-Id: I0fd1e60b2a56c45776963c29bbae6f176fdf1bea
2014-03-03 10:30:36 -08:00
Tom O'Neill
cef05c28eb Incorporate new API council comments
- Split getStatus() into onGetSummary() and onGetEnabled()

- Call them on app's UI thread

- Allow runtime exceptions to propagate up

- Make a couple of more methods final to prevent subclasses from playing
around with the intent

- Remove explicit timing requirement from javadoc

- Mention that this will be restricted to system-image apps (will be
enforced by the actual settings code)

- b/10461474

Change-Id: Id22dd7a707c05de396ae4c5810e839ca734714c0
2013-09-05 09:45:03 -07:00
Tom O'Neill
546113d4c2 Improve constant names for settings injection API
- Add timing for getStatus() call to encourage implementors to be fast

- Affects b/10461474

Change-Id: I503cbae5cf27008c587a39ab4e60d8e09daedecc
2013-08-30 10:09:39 -07:00
Tom O'Neill
7f6f45723a Remove or reduce visibility of deprecated methods
- Fix additional getInt() path, restores the location settings screen
functionality.

- Should fix "unresolved link" build breakages in
git_klp-dev-plus-aosp-without-vendor, which is much more persnickety than
klp-dev for some reason.

- Add warning that we may add additional location modes in the future.

- Finish fix for b/10461763 and b/10461474

Change-Id: Id7155e3a0d7526a377d446018ef3bdb057bad3a6
2013-08-27 10:53:15 -07:00
Tom O'Neill
4a7c49c81f Address API Review for SettingInjectorService
- Escape < and > in javadoc

- Constructor does not take log tag

- Start intent rename

- Comments for Status.summary and enabled

- Bonus fixes:

  - Start renaming STATUS_KEY to SUMMARY_KEY

  - Send message back even if getting the status fails so we don't have
  to wait for the fetch to time out

  - Add comment about setting activity being invoked when disabled

- Partial fix for b/10461474

Change-Id: I025e7e0782c2873a4eda20ab4793bc6145daf8db
2013-08-26 10:08:12 -07:00
Tom O'Neill
c8211ea1cc Add a little comment about the enabled value
Change-Id: I4ac0b864f55992242b6a3b0d8ffb328f23f6b645
2013-08-22 14:28:12 -07:00
Tom O'Neill
184e75146c Warn that SettingInjectorService must be fast
- Move UPDATE_INTENT to SettingInjectorSErvice

Change-Id: I9c8f8dc0878647a051cb852721b3436e9d55b391
2013-08-19 13:13:21 -07:00
Tom O'Neill
fa2992c412 API for location settings injection
- Partial fix for b/10287745

Change-Id: Ie998ce0a7b350e4183fce5753bfac3eb51238ff4
2013-08-13 14:41:22 -07:00