Commit Graph

5400 Commits

Author SHA1 Message Date
Roshan Pius
08a61aa733 XmlUtils: Fix hex parsing in readThisByteArrayXml
hex 'a' is not correctly deserialized in readThisByteArrayXml.

Change readThisByteArrayXml & writeByteArrayXml to use HexEncoding for
hex conversions.

Bug: 138482990
Test: Was seeing parsing errors with ag/9135251.
Validated the fix with ag/9135251.

Change-Id: If9f86b5ed85a9f883130e4110f85cd2faa995439
2019-08-05 11:18:10 -07:00
Andrew Lewis
65ded6c655 Merge "Redact ISOBMFF boxes with 'free'" into qt-dev
am: f68a201ebc

Change-Id: I4755c6f884958dce01e06aa5a889f06e035f1f1c
2019-07-11 06:26:42 -07:00
Andrew Lewis
4ec5fda3d6 Redact ISOBMFF boxes with 'free'
Test: atest MediaStore_Video_MediaTest android.os.RedactingFileDescriptorTest
Bug: 135499138
Change-Id: Idaa8ad30300d5427f91bb2543be3152881018cf6
2019-07-10 19:46:48 +01:00
Louis Chang
026aacbe71 Merge "Avoid making post state to RESUMED for a PAUSING activity" into qt-dev
am: ae80cf399a

Change-Id: I4e9ee3631b0e2fd76c6af24390150d3421bbf6be
2019-07-03 16:39:36 -07:00
TreeHugger Robot
ae80cf399a Merge "Avoid making post state to RESUMED for a PAUSING activity" into qt-dev 2019-07-03 06:20:07 +00:00
Louis Chang
ea203cdbdf Avoid making post state to RESUMED for a PAUSING activity
Make sure the client post execution lifecycle state to RESUMED
only if the activity was RESUMED while delivering new intent.

Bug: 135715788
Test: making skype calls
Test: atest ActivityThreadTest

Change-Id: I1e3054e1d1611aecf6ddf6d482abf2cb3ebdf9a4
2019-07-03 09:44:12 +08:00
Dmitry Dementyev
a51df29cf5 Merge "Revert "Do not load xml metadata for unchanged packages in RegisteredServicesCache"" into qt-dev
am: 660c234e9a

Change-Id: I1142efdfe93ff9e5ac8f33af9f58e27d52f02236
2019-07-02 12:28:34 -07:00
Dmitry Dementyev
40431ae1bc Revert "Do not load xml metadata for unchanged packages in RegisteredServicesCache"
This reverts commit 8094880025.

Reason for revert: changed services order
Test: manual
Bug: 136261465

Change-Id: I2f78f0dbbace212309b87f779efad020cf255196
2019-07-02 03:59:17 +00:00
Amin Shaikh
ac1c310771 Add themed icons.
- Updating missing settings overlay icons.
- Update list of overlayed icons.
- Add IconPackOverlayTest to ensure themed icons stay in sync with the
underlying sysui icons.

Fixes: 135951717
Test: make and push overlays; atest IconPackOverlayTest
Change-Id: Ib712ad3444e1810ba899f7b9fd0b10c7814dd80c
2019-06-28 16:47:29 -04:00
Mihai Popa
53416a8c01 Merge "Fix Layout.primaryIsTrailingPreviousAllLineOffsets" into qt-dev
am: 65f73d6bb8

Change-Id: Iadad3af2dfc1b1d9e28335980e0af58440943a8d
2019-06-26 04:52:32 -07:00
Mihai Popa
7ad499d007 Fix Layout.primaryIsTrailingPreviousAllLineOffsets
The CL fixes a crash in Layout.primaryIsTrailingPreviousAllLineOffsets.
The crash was happening when the method was called for a line beginning
with an empty bidi run. This could happen, for example, for empty text -
I was unable to find any other case. The CL improves the existing test
for the method with this case, which was previously crashing.

The CL also fixes a potential crash in getLineHorizontals. However, this
bug could never happen as in the current code path clamped is always
false (and kept as parameter for parity with getHorizontal).

Bug: 135444178
Test: atest FrameworksCoreTests:android.text.LayoutTest\#testPrimaryIsTrailingPrevious
Change-Id: I47157abe1d74675884734e3810628a566e40c1b4
2019-06-25 23:09:02 +00:00
Benedict Wong
edcd5ad555 Revert "Revert "Take all VPN underlying networks into account when migrating traffic for""
This reverts commit d8220c2050.

Reason for revert: Fix available for deadlocks.

Bug: 113122541
Bug: 134244752
Merged-In: Ib65214598837289bd39dbf040b56ab7835f893ba
Change-Id: Ia90bf2c72ef686e80800d113d03548e0efcadb66
(cherry picked from commit a84d9fa572)
2019-06-21 01:09:49 +00:00
Will Brockman
e320fca53a Merge "Log usage of addPerson() and setStyle() in notifications." into qt-dev
am: 029190c1bc

Change-Id: If5b6463d6c44df9660088e14b6357321c85c095d
2019-06-18 10:48:27 -07:00
Will Brockman
c22772c36a Log usage of addPerson() and setStyle() in notifications.
Added Tron logging to StatusBarNotification.getLogMaker() so it will
be present in most logs about the notification.

Change-Id: I720706d37c663f2018bdfe2153ad180970166c90
Test: atest android.service.notification.StatusBarNotificationTest
Bug: 135180518
2019-06-14 19:10:02 +00:00
Yiwei Zhang
45a6eae80e Merge "Game Driver: Add settings global for prerelease driver opt in option" into qt-dev
am: ca354f308d

Change-Id: I62ade6ba3b577080b32165c7c03ce61a66448bb3
2019-06-12 18:13:40 -07:00
TreeHugger Robot
ca354f308d Merge "Game Driver: Add settings global for prerelease driver opt in option" into qt-dev 2019-06-13 00:31:24 +00:00
Nate Myren
8825f11b9a Merge "Added test coverage to Context.startActivityAsUser" into qt-dev
am: 471a664375

Change-Id: I1fe9849c4b5244291ab84234eabd4570da94bf0e
2019-06-12 15:23:37 -07:00
TreeHugger Robot
471a664375 Merge "Added test coverage to Context.startActivityAsUser" into qt-dev 2019-06-12 22:08:35 +00:00
Michael Groover
faf3e373db Merge "Remove settings to relax device ID access restrictions" into qt-dev
am: 692a68133b

Change-Id: I3312fae325c593aef750c80cbd4365dfd2669f6c
2019-06-12 14:20:22 -07:00
Michael Groover
692a68133b Merge "Remove settings to relax device ID access restrictions" into qt-dev 2019-06-12 20:31:16 +00:00
Nate Myren
4d006f59bb Added test coverage to Context.startActivityAsUser
Test: atest ContextTest
Fixes: 127711435
Change-Id: I7629da8d15ded1b2ac0907f2284289fdb07879ec
(cherry picked from commit 7c491a534a)
2019-06-12 16:25:31 +00:00
Yiwei Zhang
4836fb16c9 Game Driver: Add settings global for prerelease driver opt in option
Bug: 134881329
Test: build, flash and boot
Change-Id: I8c3ba687f3c85f3fe093cdf7086adf9b8109713d
2019-06-09 15:23:17 -07:00
Benedict Wong
3e9726c69c Revert "Take all VPN underlying networks into account when migrating traffic for"
am: ac06c1022d

Change-Id: Iec81a5823e476a52c41a9853fb40aa1804d1a826
2019-06-07 02:33:30 -07:00
Benedict Wong
ac06c1022d Revert "Take all VPN underlying networks into account when migrating traffic for"
This reverts commit 917327b193.

Reason for revert: This change has been implicated in 4-way deadlocks as seen in b/134244752.

Bug: 134244752
Change-Id: Ibdaad3a4cbf0d8ef1ed53cfab1e454b9b878bae9
2019-06-07 09:18:01 +00:00
Tony Mak
01ac3d3a7b Merge "Fix an issue that clicking on a smart action chip on keyguard ... failed to launch app resolver when there are more than one app handlers." into qt-dev
am: 78a48f5512

Change-Id: Ic7dd0c9f952e905c8f42001276f3def6e1797b70
2019-06-06 02:39:33 -07:00
TreeHugger Robot
78a48f5512 Merge "Fix an issue that clicking on a smart action chip on keyguard ... failed to launch app resolver when there are more than one app handlers." into qt-dev 2019-06-06 09:22:13 +00:00
Makoto Onuki
3c36699987 Merge "Avoid creating multiple death recipients for same observer" into qt-dev
am: a478c5f9aa

Change-Id: Id856368d4da90c4efb660ee4598b7d2ae4a75dc7
2019-06-05 09:08:36 -07:00
Makoto Onuki
a478c5f9aa Merge "Avoid creating multiple death recipients for same observer" into qt-dev 2019-06-05 15:54:05 +00:00
Tony Mak
82e60027f4 Fix an issue that clicking on a smart action chip on keyguard ...
failed to launch app resolver when there are more than one app handlers.

What happened:
1. TextClassifier constructs an implicit intent to fulfill a task
like opening a link, making a phone call, etc.
2. TextClassifier calls resolveActivity against the implicit intent to
resolve the intent. The resolve component name will be used to create
an explicit intent. In this case, the intent is resolved to the
app resolver activity.
3. wouldLaunchResolverActivity in SysUI returns false for an explicit
intent with component name android/ResolverActivity.
4. SysUI does not trigger the "start the activity after the keyguard
is gone" logic because wouldLaunchResolverActivity returns false.
5. When user clicks on the action on keyguard, ResolveActivity.onStop
is triggered because it is shown (and thus moved to the background)
under the keyguard. So, finish() is called in onStop, and thus the bug.

IMHO, wouldLaunchResolverActivity should not return false
for an explicit intent with component name android/ResolverActivity.
But since we are late at this point, the safest option is to not setting
component name when the intent is resolved to package "android". Note that
this is what we are doing for P, so it should be pretty safe.

Test: 1. Install two browsers. Send myself a link. Tap on the Open Link
chip on keyguard. App resolver is shown.
2. atest frameworks/base/core/tests/coretests/src/android/view/textclassifier/

BUG: 129220155

Change-Id: I6d4d67c2233a2fec950887ea274825bf1cbc1ae2
2019-06-05 12:52:22 +01:00
Michael Groover
44c92e0708 Remove settings to relax device ID access restrictions
Bug: 123937881
Test: atest TelephonyPermissionsTest
Change-Id: I6eb1920730a28d393cdbef06195f43da957338fd
2019-06-04 18:30:59 -07:00
Makoto Onuki
ad1291e749 Avoid creating multiple death recipients for same observer
Also do a WTF when the same process registers 1000 observers with the
same observer instance.

Fix: 133388082
Test: manual test: Launch leaky app and make sure WTF is raised
Test: manual test: Open contacts app, close, and make sure the
"Total number of unique observers" goes back
Test: manual test: Open contacts app, kill it, and make sure the
"Total number of unique observers" goes back
Test: manual test: Open contacts app while contacts are syncing,
and make sure the activity refreshes itself.
Test: atest cts/tests/tests/content/src/android/content/cts/ContentResolverTest.java
Test: atest FrameworksCoreTests:BinderDeathDispatcherTest
Test: atest FrameworksServicesTests:com.android.server.content.ObserverNodeTest

Change-Id: Id738ca66023c029b92db3d108d99a9fc240fe77c
2019-06-04 17:06:39 -07:00
TreeHugger Robot
a1da7a4ef5 Merge "Update themed icons." into qt-r1-dev 2019-06-04 16:30:35 +00:00
Alan Stokes
b68ff5ab78 Cleanup background activity starts for release.
am: 9e2457622a

Change-Id: I9bc0682105251e2d462859560978763032b195c2
2019-06-04 07:37:55 -07:00
Alan Stokes
9e2457622a Cleanup background activity starts for release.
This removes the parts of the feature that were only needed in beta
releases:
- Toast when a start is or would be blocked.
- Configurable whitelist of exempt apps.
- Global setting to disable.

Not to be submitted until after beta 5 is cut.

Bug: 131747138
Test: atest BackgroundActivityLaunchTest
Test: atest RootWindowContainerTests
Test: atest WmTests:ActivityStarterTests
Test: atest CtsWindowManagerDeviceTestCases:ActivityStarterTests
Test: atest CtsAppTestCases:.ServiceTest

Change-Id: I3d8b9c72c8fac86b93ac57a8a1988f4133043af8
2019-06-04 14:26:00 +00:00
Amin Shaikh
10a8b519f3 Update themed icons.
Fixes: 132808864
Fixes: 131238809
Test: mp droid; manually check icons
Change-Id: Idffc547c971c90031f14dc0b2fa1b6337586e61f
2019-06-04 08:11:51 -04:00
Qingxi Li
e06624716d Remove all eSIM Invisible Profiles during FDR
Bug: 132360644
Test: E2E
Change-Id: Ic4e58ed7c8cf5892d8f49605e268c3d131b35ea9
(cherry picked from commit 1854f47f80)
2019-06-03 20:46:58 +00:00
Riddle Hsu
9b7699939e Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev
am: 3bc96f9113

Change-Id: I8a66a0d378b13e7c2f48edf4bff01ae2799e47d5
2019-06-03 10:06:18 -07:00
TreeHugger Robot
3bc96f9113 Merge "Invoke setWindowStopped on the thread that created the view" into qt-dev 2019-06-03 10:13:18 +00:00
Hui Yu
7ac56b7229 Merge "Do not create EMPTY batterystats history file." into qt-dev
am: 04c3eeeaa0

Change-Id: Ia9927f3f094767ea136a06b0a840e89f280d26c2
2019-05-31 20:22:45 -07:00
Hui Yu
e40781ee84 Do not create EMPTY batterystats history file.
Previously when batterystats history buffer exceeds MAX_HISTORY_BUFFER
size, we create a new history file which is empty until batterystats
history buffer is written to the file. But the buffer is written to the
file every 30 minutes by default. When the file is empty, if the
system server process crashed or abrupt powered off, the file will remain
empty.

During the device bootup, batterystats reads history buffer from
the empty file and failed. The important mHistoryBaseTime variable is zero,
which causes all timestamps in subsequent history events are wrong, this
causes volta go/powerbug displays wrong, also Battery Usage in Settings
are wrong.

The fix is to not create new empty history file on disk until we actually
write history buffer to the file.

This problem can be manually reproduced by creating new empty file under
battery-history directory, then power off the device by long press power
button.

Bug: 133525277
Test: frameworks/base/core/tests/coretests/src/com/android/internal/os/BatteryStatsHistoryTest.java

Change-Id: I0c22881df6897e8832b472cc5e82fbf2727eb252
2019-05-31 23:48:47 +00:00
Varun Anand
dadc3c9da4 Merge changes from topic "vpn_data_accounting" into qt-dev
am: b33d2ca2e3

Change-Id: Ie336c7c3968dd8cbb2b303398620632681d516b6
2019-05-29 09:47:38 -07:00
Varun Anand
b33d2ca2e3 Merge changes from topic "vpn_data_accounting" into qt-dev
* changes:
  Add one more test for VPN usage stats.
  Addressing comments for http://ag/7700679.
  NetworkStatsService: Fix getDetailedUidStats to take VPNs into account.
  Take all VPN underlying networks into account when migrating traffic for VPN uid.
2019-05-29 16:34:14 +00:00
Varun Anand
917327b193 Take all VPN underlying networks into account when migrating traffic for
VPN uid.

(cherry picked from commit 95aa6d446f)

Bug: 113122541
Bug: 120145746
Test: atest FrameworksNetTests
Test: Manually verified on device that stats from VPN UID are moved
      appropriately based on its declared underlying network set.
Test: vogar --mode app_process --benchmark NetworkStatsBenchmark.java

Change-Id: I7f368c5970b2dcb969fe0daf5ef44edb1f51d09d
2019-05-29 18:15:17 +09:00
Amin Shaikh
903091fcc2 Update themed icons.
- Ensure underlying icons and overlayed icons match in size, tint and
autoMirrored
- Add a couple missing Settings icons
- Change perm_group_* icons to use colorControlNormal

Fixes: 132997623
Fixes: 131346125
Test: make; change overlays
Change-Id: I65170eb7671c425bd2c39cd2f1341f641fa810e3
2019-05-28 13:51:03 -04:00
Gavin Corkery
ef441722c8 Allow PackageManager to retrieve inactive/factory APEXs.
Add functionality to ApexManager to filter the list of all APEX
packages in order to obtain lists of inactive or factory APEXs.
Expose this information to dumpsys.

Test: adb shell dumpsys package
Test: adb shell pm list packages -a --apex-only
Test: atest PackageParserTest
Bug: 123680735
Bug: 119767311
Change-Id: Id8ffe6320b55f647cdf550abfd6703cd868565ff
2019-05-25 19:03:51 +01:00
Abodunrinwa Toki
a578ecce46 Merge "Convert TextClassifierEvent to SelectionEvent for logging in the default TC." into qt-dev 2019-05-23 19:35:24 +00:00
Abodunrinwa Toki
5258633e2d Convert TextClassifierEvent to SelectionEvent
for logging in the default TC.

TCEvents for selection and links are not currently being written to
default TC logs. This changelist writes these events as SelEvents.

Bug: 131228248
Test: atest android.view.textclassifier.TextClassifierEventTest
Change-Id: I191f2f9281eab1b8a427ef21717fff283a304a22
2019-05-23 13:37:59 +01:00
Qingqing Deng
848b984715 Merge "Update isNewEmoji to check Unicode 12." into qt-dev 2019-05-21 20:56:11 +00:00
Qingqing Deng
41f9d352cd Update isNewEmoji to check Unicode 12.
Bug: 127811703
Test: Verified on Device.
Test: atest frameworks/base/core/tests/coretests/src/android/text/EmojiTest.java
Test: atest cts/tests/tests/text/src/android/text/cts/EmojiTest.java
Change-Id: Id2409dd96243bf74ff1c717a8cc458a6ebf24deb
2019-05-20 15:19:35 -07:00
Abhijeet Kaur
3a0eed2379 Add tests for optional screenshot Fd in bugreport API
Not all bugreports need screenshots, and hence it should not be
mandatory to pass screenshotfd in parameters to startBugreport (call to
bugreport API).
Ensuring the above by passing null screenshotFd.

Bug: 123578274
Test: atest BugreportManagerTest
Change-Id: I79f4a71cc79e655a64c4cf9ac04fef0814db8ff1
2019-05-20 15:50:11 +01:00